3003 Commits

Author SHA1 Message Date
bbaetz%student.usyd.edu.au
1edd210910 Bug 110013 - templatize describecomponents.cgi
r=gerv, afranke


git-svn-id: svn://10.0.0.236/trunk@114463 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-14 01:25:25 +00:00
jake%acutex.net
1b0baad92a Update the test to use the same basic format as the handling code from globals.pl
git-svn-id: svn://10.0.0.236/trunk@114406 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 19:24:05 +00:00
justdave%syndicomm.com
0981d9555c Backing out checkin for bug 115369, it's busted on Perl 5.00503.
git-svn-id: svn://10.0.0.236/trunk@114403 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 17:25:02 +00:00
justdave%syndicomm.com
75bc7b09ce Fixing tinderbox bustage from previous checkin.
Name "main::legal_keywords" used only once


git-svn-id: svn://10.0.0.236/trunk@114397 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 15:49:06 +00:00
justdave%syndicomm.com
551166c6d8 Fix for bug 115369: Templatization of long_list.cgi
Patch by Gervase Markham <gerv@mozilla.org>
r= bbaetz, dkl


git-svn-id: svn://10.0.0.236/trunk@114395 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 15:34:36 +00:00
justdave%syndicomm.com
ae543c8a25 Adding jb2bz.py to contrib (bug 124869).
Conversion script to import bugs from Jitterbug into Bugzilla contributed by Tom Emerson <tree@basistech.com>


git-svn-id: svn://10.0.0.236/trunk@114391 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 14:59:30 +00:00
jake%acutex.net
7dbccc55a3 Bug 121105 - type="application/x-javascript" confuses IE, so we should use the new $::script_type variable added in bug 123339.
r= kiko


git-svn-id: svn://10.0.0.236/trunk@114390 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 14:19:07 +00:00
ian%hixie.ch
3c71ea2b99 Adding Stocks contributor.
git-svn-id: svn://10.0.0.236/trunk@114388 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 13:48:19 +00:00
bbaetz%student.usyd.edu.au
5bd31d7e20 Bug 97471 - The assignee and qa contact should always be able to see their
bugs
r=justdave, afranke


git-svn-id: svn://10.0.0.236/trunk@114371 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 03:05:15 +00:00
bbaetz%student.usyd.edu.au
8018723bcc Bug 100094 - use generic template handling code
r=mattyt, afranke


git-svn-id: svn://10.0.0.236/trunk@114368 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 02:27:24 +00:00
ian%hixie.ch
63124db3fa Fixing regression introduced by the CTCP patch: long lines no longer get wrapped. Also includes minor cleanup. r=kerz
git-svn-id: svn://10.0.0.236/trunk@114366 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 02:20:01 +00:00
justdave%syndicomm.com
92bd7a7a44 Fix for bug 99024: checksetup was not giving proper permissions to the contents of the template directory. This patch also
adds an .htaccess file that blocks access to the template folder by the web server.
Patch by Dave Miller <justdave@syndicomm.com>
r= zach x 2


git-svn-id: svn://10.0.0.236/trunk@114357 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 01:35:28 +00:00
ian%hixie.ch
128e046038 Added support for running mozbot on multi-homed boxes (requires Net::IRC 0.71). b=93186 r=kiko
git-svn-id: svn://10.0.0.236/trunk@114350 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 00:49:37 +00:00
ian%hixie.ch
8849568641 Inital implementation of Stock Quote module. Code/Review by both zach and Hixie. b=70874
git-svn-id: svn://10.0.0.236/trunk@114349 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 00:42:57 +00:00
gerv%gerv.net
e3bb80e737 Moving JS to beginning of file to avoid IE warnings.
git-svn-id: svn://10.0.0.236/trunk@114325 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-12 22:55:25 +00:00
jake%acutex.net
84a0813cd4 Fix for bug 123339 - More enhancements for the cvsgraph.cgi module (give it popups very similar to cvsblame.cgi).
r= kiko


git-svn-id: svn://10.0.0.236/trunk@114308 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-12 21:34:04 +00:00
timeless%mac.com
8590a615f3 Bug 124970 Who indents oddly because we aren't using LDAP
r=mcafee


git-svn-id: svn://10.0.0.236/trunk@114306 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-12 21:30:25 +00:00
ian%hixie.ch
c89869ebe2 Remove brackets around grep(). b=111831 r=timeless
git-svn-id: svn://10.0.0.236/trunk@114282 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-12 15:03:11 +00:00
ian%hixie.ch
82301ff431 * Implement !seen command
* Implement a few new greeting types (e.g. wb)
b=72943 r=timeless

* Implement CTCP Ping and Source responses
b=72956 r=timeless

* Remove brackets around grep() in Greeting.bm
b=111831 r=timeless


git-svn-id: svn://10.0.0.236/trunk@114281 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-12 14:59:29 +00:00
ian%hixie.ch
cb20d07ab8 * Implement CTCP Ping, Version and Source as BotModule Event
* Added ctcpSend(), ctcpReply() APIs
* Implemented CTCP Version in the general module
* Updated devel docs
b=117625 r=Jake

* Remove brackets around grep() in mozbot.pl
b=111831 r=Jake


git-svn-id: svn://10.0.0.236/trunk@114280 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-12 14:51:59 +00:00
kestes%walrus.com
7e504a3c7f parsing of arguments was buggy. I did not get the arguments into the script.
git-svn-id: svn://10.0.0.236/trunk@114203 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-11 23:08:44 +00:00
bbaetz%student.usyd.edu.au
76c31e4bbd Correct date on logincookies schema change.
git-svn-id: svn://10.0.0.236/trunk@114020 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-08 11:16:05 +00:00
justdave%syndicomm.com
f58b298f38 Fix for bug 97966: Changing the product in the query page would remove your component, version, and milestone selections, even if the other product used the same ones, or you were selecting an additional product without unselecting the first one.
Patch by Christian Reis <kiko@async.com.br>
r= caillon, justdave


git-svn-id: svn://10.0.0.236/trunk@113993 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-08 03:31:10 +00:00
ian%hixie.ch
be9b893e79 Fixes a copy-paste error in the help line. r=timeless; b=123708
git-svn-id: svn://10.0.0.236/trunk@113892 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-07 08:36:23 +00:00
ian%hixie.ch
085da4328c Lets the invite command accept the more natural syntax 'invite user in #channel' rather than just 'invite user channel'. r=zach; b=72949
git-svn-id: svn://10.0.0.236/trunk@113891 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-07 08:33:17 +00:00
justdave%syndicomm.com
d8baf36515 Fix for bug 122897: Comments entered on the bug form are now added to the bug before it is closed and moved when moving a bug
to another Bugzilla install.
Patch by Dave Miller <justdave@syndicomm.com>
r= timeless, bbaetz


git-svn-id: svn://10.0.0.236/trunk@113760 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 04:34:10 +00:00
justdave%syndicomm.com
c4c291a120 Fix for bug 119005: The instructions in editgroups.cgi incorrectly state that you can't use spaces in a group name. You in
fact can.
Patch by Christian Reis <kiko@async.com.br>
r= bbaetz x 2


git-svn-id: svn://10.0.0.236/trunk@113741 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 02:54:08 +00:00
justdave%syndicomm.com
686d81fb26 Fix for bug 117055: Emails were being truncated if they contained a line with nothing but a period on them. We now pass -i to
sendmail and its clones to tell it to ignore periods (since we close the pipe when we're done, rather than signalling it with
a period).  Has been tested with sendmail and postfix.
Patch by Dave Miller <justdave@syndicomm.com>
r= afranke, bugzilla@bkor.dhs.org, jake


git-svn-id: svn://10.0.0.236/trunk@113739 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 02:47:00 +00:00
bbaetz%student.usyd.edu.au
8ec543447a Bug 119715 - strictvaluechecks should always be enabled
r=justdave, gerv


git-svn-id: svn://10.0.0.236/trunk@113648 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-05 00:20:09 +00:00
bbaetz%student.usyd.edu.au
2c81615c9a Bug 122418 pt2 - obsoleting a patch from the create attachment screen gave
a taint error.


git-svn-id: svn://10.0.0.236/trunk@113647 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-05 00:11:48 +00:00
gerv%gerv.net
2a14c2e071 Remove JS strict warning.
git-svn-id: svn://10.0.0.236/trunk@113636 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 22:47:26 +00:00
bbaetz%student.usyd.edu.au
d2945c40c2 bug 122418 - setting attachment status fails taint checks. Just needed to
detaint after checking.
r=gerv,kiko


git-svn-id: svn://10.0.0.236/trunk@113632 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 22:16:18 +00:00
gerv%gerv.net
4711cd34e5 show_bug.cgi templatisation.
git-svn-id: svn://10.0.0.236/trunk@113629 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 21:17:17 +00:00
zach%zachlipton.com
137895e51f Fix for bug 87398: checksetup.pl should warn if not run as root. Patch
adds a warning if the user has webservergroup set but does not run
checksetup.pl as root.

r1=kiko, r2=justdave


git-svn-id: svn://10.0.0.236/trunk@113610 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 16:38:33 +00:00
bbaetz%student.usyd.edu.au
e20fe58870 Bug 95732 - remove logincookies.cryptpassword, and invalidate cookies from
the db when required instead.
(Also fixes bug 58242 as a side effect)

r=myk, kiko


git-svn-id: svn://10.0.0.236/trunk@113598 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 12:23:05 +00:00
justdave%syndicomm.com
40ab41ff77 Fix for bug 14461: QA contact is no longer required. You can still leave it blank in editing and creating components if you
want, even if it's enabled now.  This is consistant with the behavior of this field everywhere else in Bugzilla now.
Eventually this will be a per-product setting whether to enforce having one or not.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x 2


git-svn-id: svn://10.0.0.236/trunk@113584 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 00:41:40 +00:00
myk%mozilla.org
f89a91a9e4 Fix for bug 121747: Stops every script before it does anything else if Bugzilla is currently shut down. Also adds global template
instantiation code to globals.pl.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv,kiko


git-svn-id: svn://10.0.0.236/trunk@113573 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-03 09:28:48 +00:00
myk%mozilla.org
75dca718c9 Fix for bug 98021: Cleans up "edit attachment" interface on NS4.x by removing text of buttons that do not work in that browser.
Patch by Myk Melez <myk@mozilla.org>.
r=kiko x 2


git-svn-id: svn://10.0.0.236/trunk@113430 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 17:50:00 +00:00
jake%acutex.net
18e6a3ea4d Bug 122154 part 2 - Eliminiate the use of the "usetms" Javascript cache variable.
Patch by Christian Reis <kiko@async.com.br>
r= bbaetz, jake


git-svn-id: svn://10.0.0.236/trunk@113420 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 14:52:37 +00:00
jake%acutex.net
7efb764af7 Bug 121636 - Provide support for cvsgraph (requires the cvsgraph binary, see bug 121636 for more information).
r= kiko


git-svn-id: svn://10.0.0.236/trunk@113417 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 14:32:55 +00:00
timeless%mac.com
e73045e569 Bug 109138 platform detection not working on macintosh
r=bbaetz r=gerv
adds another regexp for MacOSX


git-svn-id: svn://10.0.0.236/trunk@113412 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 10:05:04 +00:00
ian%hixie.ch
3e9ca21d73 * Added getGroupMembers() to the User data source.
* Fixed a bug in the MySQL implementation of User data source's getGroupName() method. It treated 'row' as an array ref instead of a normal array.
* Made the MySQL User data source automatically add a group with ID 1, named 'Administrators'.
* Special-cased the group with ID 1 in the user object so that if a user is in that group, he automatically is assumed to have all rights.
* Fixed a bug with the saving of the original groups in the user object (the backup object was simply a reference to the original object, which was later changed in place, causing the backup to change too).
* Fixed the handling of rights in the user object constructor to simply set the rights in one line instead of using indirection.
* Fixed the invalidateRights() method of the user object to correctly re-set the rights (previously it was not turning the generated array into a hashref).
* Added a setup.install implementation to the login component. It now queries the user for an administration username and creates the relevant user and puts it in the magic group 1.
* Fixed a call to checkAddress() in the login component.


git-svn-id: svn://10.0.0.236/trunk@113408 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 06:48:02 +00:00
ian%hixie.ch
78a5b28737 Commented out the call to Net::SMTP's verify() method and replaced it with a generic regexp sanity check. It appears that VRFY is not correctly implemented on all servers. (I may be mistaken on this; it might just be a bug somewhere in the PLIF code that is messing something up, but I couldn't find it if so.)
git-svn-id: svn://10.0.0.236/trunk@113407 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 06:38:55 +00:00
ian%hixie.ch
bcf3696b25 Added a check that ensures that the configuration file is not readable or writable by anyone except the user running the script. This closes a potential security hole on shared machines. Changed the umask during the creation of the configuration file so that the permission bits are set that way too. Added a comment to clarify the superficially recursive nature of the configuration database and the configuration data source.
git-svn-id: svn://10.0.0.236/trunk@113405 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 06:36:27 +00:00
ian%hixie.ch
d36a91026e Another change that should be done at some point: Move PLIF/DataSource/*/MySQL.pm to PLIF/DataSource/MySQL/*.pm
git-svn-id: svn://10.0.0.236/trunk@113404 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-01 06:32:17 +00:00
bbaetz%student.usyd.edu.au
37e83dae0b Bug 122744 - charting fails taint checks
r=daa@distributed.net, gerv


git-svn-id: svn://10.0.0.236/trunk@113380 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 23:51:38 +00:00
bbaetz%student.usyd.edu.au
af02b7487d Fix up "used only once" warning from kiko's checkin.
r=kiko x 2.


git-svn-id: svn://10.0.0.236/trunk@113379 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 23:46:51 +00:00
jake%acutex.net
11e4684e5b Bug 122636 - Templatise colchange.cgi
Patch by David Lawrence <dkl@redhat.com> and Christian Reis <kiko@async.com.br>
r= kiko, jake


git-svn-id: svn://10.0.0.236/trunk@113349 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 20:12:50 +00:00
ian%hixie.ch
cd94938f2b Removed an erroneous comment, which should be the last traces of the old problem of the lack of a configuration file being a fatal error.
git-svn-id: svn://10.0.0.236/trunk@113325 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 18:30:21 +00:00
ian%hixie.ch
095dfaa67a Theoretical nit: call inherited constructor just in case at some point in the future it does something useful...
git-svn-id: svn://10.0.0.236/trunk@113324 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 17:35:52 +00:00