beng%bengoodger.com
dfde20d73e
329269 various improvements to view initialization r=annie.sullivan@gmail.com 330736 - bug in query serialization r=brettw@gmail.com
...
git-svn-id: svn://10.0.0.236/trunk@192511 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-17 02:02:36 +00:00
annie.sullivan%gmail.com
78ce903b68
Fixes several bugs with open in tabs: makes menus set selection in command events in case DOMMenuItemActive doesn't get sent, only shows Open in Tabs menuitem if there are two or more items in the menu, and respects browser.tabs.loadFolderAndReplace and browser.tabs.loadBookmarksInBackground prefs. Also moves #include of debug.js to browser.js as this was causing JavaScript errors on the mac. r=ben@mozilla.org sr=darin@meer.net bug=330130
...
git-svn-id: svn://10.0.0.236/trunk@192438 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-15 19:59:09 +00:00
gavin%gavinsharp.com
e49a4cf424
Bug 325248: Add MOZILLA_1_8_BRANCH ifdef for bug 318193, r+a181=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@192338 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-14 21:10:21 +00:00
gavin%gavinsharp.com
1b38a5281d
Bug 325248: Add MOZILLA_1_8_BRANCH ifdef for bug 23485, r+a181=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@192337 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-14 21:06:55 +00:00
gavin%gavinsharp.com
322c663b6f
Bug 325901: don't preprocess files unnecessarily, r=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@192333 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-14 20:44:37 +00:00
joe%retrovirus.com
8afe1d3f15
Moved Ben's JavaScript ASSERT function to be NS_ASSERT in
...
toolkit/content/debug.js
debug.js is now included by globalOverlay.js, but if that's not in your
scope you can just #include debug.js directly.
NS_ASSERT() shows a dialog box containing a stack trace when it's called
with a condition that isn't true. The dialog box will be suppressed in
final builds, but in nightlies and alphas, it's useful for encouraging
bug submissions. To disable the dialogs, set XUL_ASSERT_PROMPT=0 in
your environment.
bug=327349
r=darin@meer.net , gavin.sharp@gmail.com
git-svn-id: svn://10.0.0.236/trunk@192291 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-14 01:57:26 +00:00
gavin%gavinsharp.com
a0ab34a052
Bug 323761: default page style not available when preferred stylesheet's media is not screen or all, patch by Jonathan Haas <jonathan_haas@web.de>, r=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@192256 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-13 03:19:31 +00:00
beng%bengoodger.com
61e70249c5
329269 - more work on places organizer. menus, accessible sorting and grouping options, etc. still a work in progress. r=annie.sullivan@gmail.com
...
git-svn-id: svn://10.0.0.236/trunk@192184 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-10 23:48:40 +00:00
joe%retrovirus.com
b5ef892f4b
Changes to bookmark properties dialog:
...
* Customized bookmark properties dialog for add vs. edit cases
* Added support for changing URI of bookmark (annotations not carried over yet)
* Add support for viewing properties of history entries
* Changed from tag-style control to folder tree for folder selection,
yielding layout and accessibility improvements
* Switched to using standard dialog buttons
bug=329272
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com
git-svn-id: svn://10.0.0.236/trunk@192153 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-10 17:37:22 +00:00
beng%bengoodger.com
19a6ee894c
329956 - add bookmark button on toolbar no longer works. r=joe@retrovirus.com
...
git-svn-id: svn://10.0.0.236/trunk@192112 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-09 22:03:26 +00:00
annie.sullivan%gmail.com
fb4af785cd
Added code to re-initialize bookmarks toolbar after customizing. bug=327479 r=ben@mozilla.org
...
git-svn-id: svn://10.0.0.236/trunk@192096 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-09 19:39:35 +00:00
beng%bengoodger.com
fe2648bf3e
revert part of previous change to 329586 to reduce Ts on windows
...
git-svn-id: svn://10.0.0.236/trunk@192046 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-09 04:58:07 +00:00
beng%bengoodger.com
71f043ee27
329586 - browser shim cleanup, tidies up some UI update notification in the browser, fixes a few menu items here and there, removes unnecessary initialization, moves places to its own window, removes all code to do with maintaining places as a tab, renames osme objects and member variables, formatting issues, creates a browser controller for updating commands. r=annie.sullivan@gmail.com
...
git-svn-id: svn://10.0.0.236/trunk@192043 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-09 02:09:28 +00:00
annie.sullivan%gmail.com
56853bff31
Fixes a bug in closing the menus after middle-clicking a bookmark. Bug=329321 r=ben@mozilla.org
...
git-svn-id: svn://10.0.0.236/trunk@191938 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-07 23:31:22 +00:00
annie.sullivan%gmail.com
80e6be148f
Fixes JavaScript warnings about trailing commas and redefined variables. bug=329171 r=ben@mozilla.org
...
git-svn-id: svn://10.0.0.236/trunk@191937 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-07 23:20:46 +00:00
annie.sullivan%gmail.com
309fb9de94
Makes toolbar and menu initialize from place attribute
...
bug=329531 r=ben@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@191899 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-07 16:10:37 +00:00
joe%retrovirus.com
fb37866416
* Allows the user to access Bookmark Properties dialog from context menus.
...
* Adds support for editing the bookmark shortcut (formerly keyword) in the Bookmark Properties dialog.
* Improves the appearance of the Bookmark Properties dialog.
* Removes dead code from PlacesBrowserShim in browser.js
NOTE: This doesn't reflect the final UI for this functionality; rather,
this change is intended to add functionality for users of the nightlies.
bug=322988
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com
git-svn-id: svn://10.0.0.236/trunk@191866 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-07 00:52:35 +00:00
gavin%gavinsharp.com
c87b1ddf14
fix whitespace
...
git-svn-id: svn://10.0.0.236/trunk@191862 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-06 23:57:47 +00:00
brettw%gmail.com
f18dece57d
Bug 318817 r=ben@mozilla.org Uncommented patch for this (Ben commented out
...
to see if it affected PLT on tinderboxes).
git-svn-id: svn://10.0.0.236/trunk@191832 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-06 17:51:17 +00:00
annie.sullivan%gmail.com
24061c7be6
Opens Bookmarks Menu when the mouse drags over it. r=ben@mozilla.org bug=329065
...
git-svn-id: svn://10.0.0.236/trunk@191794 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-05 07:20:53 +00:00
annie.sullivan%gmail.com
a0262af41d
Moving "Open in Tabs" out of menu/toolbar binding and into browser code.
...
bug=329266 r=ben@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@191789 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-05 01:40:26 +00:00
annie.sullivan%gmail.com
c53df84f97
Adds menuitem for Open In Tabs.
...
Reorganizes code so that command/click handlers for toolbar/menu bindings can be attached by overlays.
r=ben@mozilla.org bug=327034
git-svn-id: svn://10.0.0.236/trunk@191751 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-04 01:12:05 +00:00
beng%bengoodger.com
edfaf44aec
329146 - bookmarks toolbar does not show up because id is different and user customized toolbar in the past. r=annie.sullivan@gmail.com
...
git-svn-id: svn://10.0.0.236/trunk@191736 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-03 22:14:33 +00:00
gavin%gavinsharp.com
a1860a87a1
fix whitespace nit to sync branch/trunk
...
git-svn-id: svn://10.0.0.236/trunk@191718 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-03 19:51:18 +00:00
brettw%gmail.com
dddeb09ba4
Bug 325286 r=ben@mozilla.org Don't unnecessarily load favicons, make them get
...
set properly.
git-svn-id: svn://10.0.0.236/trunk@191713 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-03 19:11:10 +00:00
gavin%gavinsharp.com
00868e82ec
Back out the fix for bug 271359 from the trunk too (it was forgotten), original backout had r=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@191664 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-03 04:09:10 +00:00
gavin%gavinsharp.com
39b3968d79
little nits to sync 1.8 branch/trunk
...
git-svn-id: svn://10.0.0.236/trunk@191660 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-03 03:59:44 +00:00
annie.sullivan%gmail.com
8dbff3147f
Implements history menu and binds Ctrl-H to places view, for now.
...
r=ben@mozilla.org bug=325605
git-svn-id: svn://10.0.0.236/trunk@191525 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-01 21:36:53 +00:00
annie.sullivan%gmail.com
fa749291d3
Makes items on places toolbar show up as a button during customize so that they can easily be moved. r=ben@mozilla.org bug=327364
...
git-svn-id: svn://10.0.0.236/trunk@191512 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-01 19:45:02 +00:00
beng%bengoodger.com
a8e1802f35
bug 328895 - broken personal toolbar in places builds due to init being commented out, and bookmarks not in personal toolbar in default bookmarks file. also fixes duplication of bookmarks in personal toolbar and places list. r=annie.sullivan@gmail.com
...
git-svn-id: svn://10.0.0.236/trunk@191502 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-01 18:52:28 +00:00
gavin%gavinsharp.com
9c5b0b9609
Revert accidental checkin.
...
git-svn-id: svn://10.0.0.236/trunk@191363 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-28 04:18:01 +00:00
gavin%gavinsharp.com
5d08a4e012
Bug 323537: add DOMLinkAdded event listener in Startup instead of delayedStartup, since delayedStartup is too late to catch some of the events, r=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@191362 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-28 04:15:56 +00:00
gavin%gavinsharp.com
e5449ba452
Bug 328619: Places toolbar shown in popups, take two, patch by Phil Ringnalda <philringnalda@gmail.com>, r=ben
...
git-svn-id: svn://10.0.0.236/trunk@191320 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-27 19:23:20 +00:00
beng%bengoodger.com
14c8bfd862
bug 328243 - disband the browser shim, move locale to locales dir, move theme to themes dir. r=annie.sullivan@gmail.com
...
git-svn-id: svn://10.0.0.236/trunk@191199 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-24 21:41:34 +00:00
gavin%gavinsharp.com
1e06f74f1c
fix whitespace to sync branch/trunk
...
git-svn-id: svn://10.0.0.236/trunk@191114 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-24 01:29:51 +00:00
gavin%gavinsharp.com
1117faf7a3
add newline to sync branch/trunk
...
git-svn-id: svn://10.0.0.236/trunk@191111 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-24 01:25:06 +00:00
gavin%gavinsharp.com
cf438d4116
Fix review nit from bug 298004. (syncs branch/trunk)
...
git-svn-id: svn://10.0.0.236/trunk@190911 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-22 22:54:08 +00:00
gavin%gavinsharp.com
3b5257446d
Remove old comment that no longer applies. rs=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@190730 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-21 19:58:41 +00:00
joshmoz%gmail.com
a7f2f6ff98
Add comment explaining extra menu nodes when using Carbon widgets. This comment becomes necessary since I have to sync 324180 to the branch. Follow-up to 324180.
...
git-svn-id: svn://10.0.0.236/trunk@190729 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-21 19:53:35 +00:00
dbaron%dbaron.org
6c577935ba
Only do the security icon's click action for left clicks. b=304920 r=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@190648 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-21 06:38:34 +00:00
beng%bengoodger.com
252e489673
327500 - clean up remaining uses of old bookmarks fe into ifndef MOZ_PLACES. fix build orange and other issues. r=annie.sullivan@gmail.com
...
git-svn-id: svn://10.0.0.236/trunk@190225 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-16 19:00:25 +00:00
beng%bengoodger.com
1072e47200
a stab at further improvements to Ts, Tp, and orange on balsa. Remove scripts when MOZ_PLACES is set that are not required. Don't attach a page show listener - it doesn't work anyway unless the buttons are visible!
...
git-svn-id: svn://10.0.0.236/trunk@190221 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-16 17:22:16 +00:00
beng%bengoodger.com
7d0d2acb36
324704 - query creation and execution for bookmarks menu bar is ill-timed... need to do asynchronously in delayed startup or on popup showing, rather than at startup! r=brettw
...
git-svn-id: svn://10.0.0.236/trunk@190204 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-16 05:24:26 +00:00
brettw%gmail.com
951797b133
Bug 318817 r=beng: Import, store, and use bookmark keywords.
...
git-svn-id: svn://10.0.0.236/trunk@190177 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-16 00:42:46 +00:00
benjamin%smedbergs.us
7641bcece7
Revert a probably-accidental change from bug 327223
...
git-svn-id: svn://10.0.0.236/trunk@190116 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-15 16:07:11 +00:00
beng%bengoodger.com
2c7de3b787
327223 - ensure sidebar framework remains for extensions to use. r=annie.sullivan@gmail.com
...
git-svn-id: svn://10.0.0.236/trunk@190047 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-15 01:21:30 +00:00
gavin%gavinsharp.com
a3f438370f
Bug 175074: URN:ISBN link converted to URN://ISBN, patch by Christian Schmidt <bugzilla.mozilla.org@chsc.dk>, r=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@189792 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-12 18:01:48 +00:00
gavin%gavinsharp.com
4cd0fed23a
Bug 320437: Spellchecking menu checkboxes don't work, patch by Dave Townsend <mossop@blueprintit.co.uk>, r=brettw
...
git-svn-id: svn://10.0.0.236/trunk@189571 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-10 20:28:50 +00:00
gavin%gavinsharp.com
e7717e810f
Bug 325236: cleanup unneeded wrapper usage in pageInfo.js, r=mconnor
...
git-svn-id: svn://10.0.0.236/trunk@189529 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-09 23:04:48 +00:00
darin%meer.net
70ea809bca
fixes bug 324644 "Add list of pings to link properties dialog" r=beng
...
git-svn-id: svn://10.0.0.236/trunk@189509 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-09 21:00:15 +00:00