190 Commits

Author SHA1 Message Date
pkasting%google.com
1c6caea9d0 Small followup fix for bug 321973 so the suggested bookmark title for
untitled pages is correct again.


git-svn-id: svn://10.0.0.236/trunk@208964 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-01 01:37:11 +00:00
pkasting%google.com
9b70e7b374 Bug 321973: Make "Bookmark This Link" work.
r=jhughes
sr=beng


git-svn-id: svn://10.0.0.236/trunk@208954 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-01 00:33:23 +00:00
gavin%gavinsharp.com
03f8ce2186 Bug 346662: fix crash when deleting a Live bookmark via "Bookmark Properties", patch by Joel Nackman <joelnackman@gmail.com>, r=annie.sullivan
git-svn-id: svn://10.0.0.236/trunk@207162 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-11 20:42:53 +00:00
gavin%gavinsharp.com
27872df3d4 Bug 346447: loadFolderAndReplace=false ignores "loading" tabs, patch by Pablo Greco <pablo@fliagreco.com.ar>, r=mano
git-svn-id: svn://10.0.0.236/trunk@206773 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-07 23:01:32 +00:00
sspitzer%mozilla.org
451440563b fix for bug #344040: when warning on "opening too many tabs", only count non-deleted bookmarks (and not folders or separators)
r=ben


git-svn-id: svn://10.0.0.236/trunk@203434 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-22 06:52:51 +00:00
gavin%gavinsharp.com
0eec265eab Bug 343958: fix strict warnings in controller.js, patch by Regis Caspar <regis.caspar+bz@gmail.com>, r=annie
git-svn-id: svn://10.0.0.236/trunk@201844 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-10 22:48:48 +00:00
gavin%gavinsharp.com
399ddf1a21 Bug 337076: Place window leaks 3 PrefHandlers, patch by Regis Caspar <regis.caspar+bz@gmail.com>, r=annie/mano
git-svn-id: svn://10.0.0.236/trunk@201843 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-10 22:45:43 +00:00
darin%meer.net
8ef91351f5 fixes bug 333167 "remove idle timer / timer manager after bug 326273 is fixed" r=pavlov
git-svn-id: svn://10.0.0.236/trunk@201170 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-29 00:01:58 +00:00
sspitzer%mozilla.org
17b07f233e fix for bug #340966, regression, "node QI Failed When middle clicking a bookmark"
also address another scenario of bug #333734, "Protect against opening too many tabs at once"

r=ben


git-svn-id: svn://10.0.0.236/trunk@200059 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-15 22:58:34 +00:00
sspitzer%mozilla.org
e89fe2a455 supplimental checkin for bug #333734, protect (warn) against opening too many tabs at once. ugh.
git-svn-id: svn://10.0.0.236/trunk@199584 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-09 08:04:10 +00:00
sspitzer%mozilla.org
3a41db1475 follow-up checkin for #333734, fix coding style per ben.
git-svn-id: svn://10.0.0.236/trunk@199583 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-09 07:58:20 +00:00
sspitzer%mozilla.org
3cd53db8af fix for bug #333734. protect (warn) against opening too many tabs at once.
r=ben, UI and strings r=beltzner


git-svn-id: svn://10.0.0.236/trunk@199582 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-09 07:53:12 +00:00
jminta%gmail.com
bf6f2355e3 Bug 333864 Non-localizable label in Places popup: Search:' r=annie, a=brettw
git-svn-id: svn://10.0.0.236/trunk@199163 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-06 23:06:32 +00:00
gavin%gavinsharp.com
2c25ccefa8 Bug 337029: bookmark properties dialog leaks a microsummaryObserver when canceled, patch by Regis Caspar <regis.caspar+bz@gmail.com>, r=annie, r=mconnor
git-svn-id: svn://10.0.0.236/trunk@198298 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-24 02:27:14 +00:00
myk%mozilla.org
09a4320333 unhork adding a new bookmark from the bookmarks manager
bug=337305
r=brettw
sr=ben
a=ben for 1.8 branch


git-svn-id: svn://10.0.0.236/trunk@196284 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-11 00:58:54 +00:00
myk%mozilla.org
e3fb608fb9 Initial support for microsummaries via a service and integration into the bookmarks UI.
bug=334471
r=brettw
a=ben for the branch


git-svn-id: svn://10.0.0.236/trunk@196058 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-05 22:46:57 +00:00
brettw%gmail.com
096593b4e7 Bug 335548 r=ben Places history view demo
git-svn-id: svn://10.0.0.236/trunk@195450 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-26 17:24:56 +00:00
brettw%gmail.com
9df31947f3 Bug 318057 r=ben bookmarks.html exporter, modifications to importer
git-svn-id: svn://10.0.0.236/trunk@195259 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-24 16:40:02 +00:00
beng%bengoodger.com
34fe8b6a16 329367 -cannot return to bookmarks after a search r=annie.sullivan@gmail.com and 334401 - assorted places organizer fixes including new debug panel r=brettw@gmail.com
git-svn-id: svn://10.0.0.236/trunk@194665 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-19 03:34:26 +00:00
gavin%gavinsharp.com
6fab413d71 Bug 332201: the same keys conflict in places' context menu, patch by changdong.cui@sun.com, r=ben
git-svn-id: svn://10.0.0.236/trunk@194590 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-18 11:02:32 +00:00
joe%retrovirus.com
d0895ce7be Removes the history item mode for the (Bookmark) Properties dialog, which
just showed disabled title and URI fields.  The "Properties" context menu
item is now disabled for URI nodes which are not bookmarked.

bug=330876
r/sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@194575 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-18 01:49:10 +00:00
brettw%gmail.com
9a284f8498 Bug 333450 r=beng Add bookmark indices to result nodes.
git-svn-id: svn://10.0.0.236/trunk@194521 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-17 18:57:52 +00:00
mozilla.mano%sent.com
e02215985e Bug 333947 - [Mac] Collapse-toolbar button does nothing in Places Organizer. r=annie, sr=ben.
git-svn-id: svn://10.0.0.236/trunk@194418 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-14 17:28:45 +00:00
beng%bengoodger.com
9776ca9ad4 332495 - grouping by site is not preserved when searching + various other search/sort fixes. r=annie.sullivan@gmail.com, brettw@gmail.com (history pieces)
git-svn-id: svn://10.0.0.236/trunk@194357 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 22:51:36 +00:00
joe%retrovirus.com
60817e663a Resubmitting this patch, which adds a editing for livemark URIs as well
as fixing a few small livemark bugs, now that I've fixed a couple reference
leaks in nsLivemarkService (see bugs 333764 and 333784).

NOTE: I expect this to cause an increase in allocations on branch balsa,
since it causes nsLivemarkService to be instantiated to set up the menus.
(nsLivemarkService previously wasn't used in the balsa bloat test)

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@194326 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 17:20:31 +00:00
brettw%gmail.com
c411b948c4 Bug 332144 r=brettw sr=beng (checkin for pamg) Subscriptions context menu should have "reload all livemarks"
git-svn-id: svn://10.0.0.236/trunk@194323 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 16:40:12 +00:00
annie.sullivan%gmail.com
0a71c1ddda Adds places popup. bug=329180 r=ben@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@194286 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 00:50:53 +00:00
beng%bengoodger.com
f20f584c64 329779 - wrong text shows for properties item on linux - shows 'get info' instead of 'properties'... patch by Tuukka Tolvanen <tuukka.tolvanen@gmail.com> r=joe@retrovirus.com sr=ben@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@194253 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-12 20:44:57 +00:00
gavin%gavinsharp.com
0f60b6f38b Bug 332888: JS warning: variable folderId hides argument, r=ben
git-svn-id: svn://10.0.0.236/trunk@194238 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-12 18:23:33 +00:00
myk%mozilla.org
95a6500a6b makes the bookmarks toolbar display bookmark titles generated by the microsummary service or extensions and stored in the bookmarks/generatedTitle annotation
bug=333052
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@194042 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-10 20:56:37 +00:00
beng%bengoodger.com
3b6934ea91 331414 - accesskeys collide in bookmark organizer window. patch by changdong.cui@sun.com r=ben@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@194035 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-10 20:01:19 +00:00
beng%bengoodger.com
92f22b8821 332061 - places window does not retain maximized state. patch by Simon Bunzli <zeniko@gmail.com> r=ben@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@194029 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-10 19:30:27 +00:00
beng%bengoodger.com
360db6244c 332873 - dragging a folder within places trees fail... make sure we use the right interface to look up constants on, and that folder containers are opened before use. r=brettw@gmail.com
git-svn-id: svn://10.0.0.236/trunk@194027 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-10 19:26:20 +00:00
beng%bengoodger.com
5f66947cb2 333374 - first steps to making advanced query builder match UE spec... make +/- buttons work better and improve visual appearance also some general places organizer cleanup r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@194026 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-10 19:26:11 +00:00
beng%bengoodger.com
0b2c084a31 329733 - problems with drag & drop to bookmarks menus. ensure that we properly close up bookmarks menus after they have been opened. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@194025 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-10 19:26:01 +00:00
joe%retrovirus.com
a495b02fad Backing out patch from bug 330063 to see if it's responsible for the
branch balsa allocation increases, and if so, fix before resubmitting.


git-svn-id: svn://10.0.0.236/trunk@193946 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-08 17:58:56 +00:00
joe%retrovirus.com
7743954cf5 * Added ability to edit Live Bookmark feed & site URIs in Bookmark Properties dialog
* Fixed a setFeedURI bug in the LivemarkService
* Fixed problems that broke the toolbar when a live bookmark had no site URI
* Converted some browser UI code to use LivemarkService methods rather than manipulating the annotations directly

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@193764 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-06 23:29:46 +00:00
beng%bengoodger.com
1932ed1159 329343 - hook up bookmark import menu item. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193520 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 16:50:10 +00:00
joe%retrovirus.com
abc6a9eccd Implements "Bookmark All Tabs..." for Places. (Also fixes a small error
when undoing aggregate transactions.)

bug=330929
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@193476 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 01:26:58 +00:00
darin%meer.net
abbff9281c fixes bug 329634 "No apparent way to Reload Live Bookmark (or update livemarks)" patch by pamg, r=annie, sr=beng
git-svn-id: svn://10.0.0.236/trunk@193469 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 00:32:33 +00:00
beng%bengoodger.com
142a6e54ee 331755 - Use Bookmark option for setting home page is broken. add a new home page selection dialog that uses places. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193467 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 00:13:58 +00:00
roc+%cs.cmu.edu
e9fd34c810 Bug 331522. By default, do not allow keyword searches when navigating to URLs; modify browser UI code to enable keyword searches only on selected URL input mechanisms (e.g., typed into the URL bar). r+sr=darin,r=mconnor
git-svn-id: svn://10.0.0.236/trunk@193458 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-03 23:17:51 +00:00
beng%bengoodger.com
8e71d880a9 331905 - pasted folders/items are inserted at the wrong level in the bookmarks hierarchy. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193353 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-31 22:42:21 +00:00
beng%bengoodger.com
916c7a5969 330263 - off by one error for places drag and drop in tree views. r=brettw. Also a comment change to nsINavHistoryService.idl to improve documentation to prevent future bugs like this.
git-svn-id: svn://10.0.0.236/trunk@193352 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-31 22:42:10 +00:00
joe%retrovirus.com
cb00bb5c6e Convert all the DB-modifying operations in the Bookmark Properties to use
transactions so that they can be undone.  (The "change URI" is the only one
that's not transactionized yet, because it needs deeper work, cf. bug 331655)

bug=326321
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@193288 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-31 00:34:03 +00:00
joe%retrovirus.com
e2625fad02 Changed nsINavBookmarks::getItemTitle() and ::getKeywordForURI() so that
they return a void string (null in JS) when they can't find matches, rather
than throwing an illegal argument exception or returning an empty string,
respectively.  This fixes a problem when bookmarking about: URIs.

bug=331801
r=brettw@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@193286 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-30 22:57:06 +00:00
darin%meer.net
4abf2f1f94 fixes bug 251491 "Live bookmarks: Add menu item for main website (feed parent) (should link to home page)" r=beng
git-svn-id: svn://10.0.0.236/trunk@193271 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-30 18:08:24 +00:00
beng%bengoodger.com
9394f593b2 331935 - grouping no longer works in places organizer r=darin
git-svn-id: svn://10.0.0.236/trunk@193171 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-29 01:20:03 +00:00
beng%bengoodger.com
70f81c13c5 328191, cannot delete history entries + a few other fixes r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193145 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-28 19:59:26 +00:00
beng%bengoodger.com
80748c607e 323812 - fix bogus copy-paste behavior and assorted other issues (insertion bugs, command updating) r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193093 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-28 00:54:10 +00:00