105 Commits

Author SHA1 Message Date
lpsolit%gmail.com
b735434f6f Bug 87795: Creating an account should send token and wait for confirmation (prevent user account abuse) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat r=bkor a=myk
git-svn-id: svn://10.0.0.236/trunk@207935 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-19 18:12:00 +00:00
mozilla%colinogilvie.co.uk
1962186e8b Bug 320197: Watcher editing in userprefs should use a list box instead of text entry
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>; r=wicked; a=myk


git-svn-id: svn://10.0.0.236/trunk@207617 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-16 19:01:24 +00:00
wurblzap%gmail.com
adc3fc4f09 Bug 69000: Permit a stored query to be marked "shared" and accessible by other users.
Patch by Marc Schumann <wurblzap@gmail.com>,
r=vladd, a=myk


git-svn-id: svn://10.0.0.236/trunk@202073 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-13 20:08:00 +00:00
mkanat%bugzilla.org
680d743be8 Bug 173629: Clean up "my" variable scoping issues for mod_perl
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@201662 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-06 06:12:05 +00:00
mkanat%bugzilla.org
520fe42625 Bug 338375: Use Bugzilla->params everywhere instead of Param().
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201503 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:42:47 +00:00
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
lpsolit%gmail.com
a698e74659 Bug 282121: Remove globals.pl from scripts that no longer use it - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@200489 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-21 00:44:48 +00:00
lpsolit%gmail.com
f952ed05cf Bug 304601: Bugzilla::Config's :locations exports need to be in their own module - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat for the main patch, r=myk for the patch about CGI.pm a=justdave
Bug 328637: Remove all legal_* versioncache arrays - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave

Bug 110503 - Eliminate versioncache


git-svn-id: svn://10.0.0.236/trunk@200347 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 20:15:18 +00:00
mkanat%bugzilla.org
caee2e9858 Bug 300410: Bugzilla::Auth needs to be restructured to not require a BEGIN block
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@196368 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-12 02:41:22 +00:00
lpsolit%gmail.com
c9a524756a Bug 332598: Move ValidatePassword() and DBNameToIdAndCheck() from globals.pl into User.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@196144 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-07 20:13:49 +00:00
lpsolit%gmail.com
d574ffedbf Bug 287741: changing password from 'password' to 'password' should not invalidate login cookies - Patch by Marc Schumann <wurblzap@gmail.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@186338 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-20 22:25:57 +00:00
lpsolit%gmail.com
c861863af0 Bug 320866: Watching the same address twice produces software error - Patch by Frédéric Buclin <LpSolit@gmail.com> r=kevin r=bkor a=justdave
git-svn-id: svn://10.0.0.236/trunk@186335 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-20 21:49:26 +00:00
karl%kornel.name
c24e7e6db3 Bug 313679: Changing email address in sudo mode logs user in as
impersonated user - Patch by A. Karl Kornel <karl@kornel.name>
r=wurblzap a=justdave


git-svn-id: svn://10.0.0.236/trunk@186009 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-13 20:03:13 +00:00
lpsolit%gmail.com
7c3f38ad5d Bug 301062: [PostgreSQL] whine.pl fails when using PostgreSQL 8.0.x - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat r=manu a=justdave
git-svn-id: svn://10.0.0.236/trunk@184543 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-13 17:36:21 +00:00
lpsolit%gmail.com
64f1a95f02 Bug 304075: Eliminate use of $::userid from Bugzilla - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@183259 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-30 21:31:29 +00:00
lpsolit%gmail.com
743c9a1707 Bug 308340: General Preferences tab is empty except for submit button when no user prefences are enabled - Patch by Frédéric Buclin <LpSolit@gmail.com> r=GavinS a=justdave
git-svn-id: svn://10.0.0.236/trunk@183179 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-28 09:56:54 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
c8bd8ab3fb Bug 303699: Eliminate deprecated Bugzilla::DB routines from userprefs.cgi - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182049 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-12 01:21:16 +00:00
bugreport%peshkin.net
205c3f3402 Bug 304583: Remove all remaining need to rederive inherited groups
Patch by Joel Peshkin <bugreport@peshkin.net>
r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@178200 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-18 20:09:37 +00:00
lpsolit%gmail.com
88c468dba1 Bug 304653: remove 'use Bugzilla::Error' from Util.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@177759 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-15 17:43:38 +00:00
lpsolit%gmail.com
ae7abb5289 Bug 304044: Missing scalar() for some parameters - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@177696 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:35:12 +00:00
mkanat%kerio.com
0cbbdcfee7 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
bugreport%peshkin.net
9778732be8 Backout of bug 303669 which broke AppendComment and possibly a number
of other items.


git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
lpsolit%gmail.com
c047143952 Bug 303061: userprefs.cgi should call ThrowUserError for old_password_required - Patch by Marc Schumann <wurblzap@gmail.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@177041 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-03 00:10:08 +00:00
lpsolit%gmail.com
261b52e47c Bug 302200: uninitialized value when saving email prefs - Patch by Rob Siklos <robzilla@siklos.ca> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@176707 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-27 21:03:14 +00:00
lpsolit%gmail.com
a68c2a62b5 Bug 301453: Move CheckEmailSyntax out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@176363 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 21:24:19 +00:00
lpsolit%gmail.com
5457769092 Bug 257767: Option to have fields in CSV files separated by semicolons instead of commas - Patch by Marc Schumann <wurblzap@gmail.com> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@176301 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 02:14:34 +00:00
mkanat%kerio.com
7e57a969dd Bug 300336: Bugzilla::Auth should not contain any exported subroutines
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175984 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-13 03:57:02 +00:00
mkanat%kerio.com
4ffb7300db Bug 287436: [SECURITY] After having logged in, links to change the report type contain username and password
Patch By Marc Schumann <wurblzap@gmail.com> r=gerv, a=justdave


git-svn-id: svn://10.0.0.236/trunk@173308 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-12 01:54:08 +00:00
lpsolit%gmail.com
f3f72e2a0d Bug 289729: fix several "uninitialized value" messages - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@172043 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-12 20:21:45 +00:00
mkanat%kerio.com
833b2e61f6 Bug 286235: Implicit joins should be replaced by explicit joins - installment A
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:52:06 +00:00
gerv%gerv.net
7b09ffbc80 Bug 73665 - migrate email preferences to their own table, and rearchitect email internals. Patch by gerv; r=jake, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@171337 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-29 21:43:00 +00:00
travis%sedsystems.ca
62918f18a8 Bug 280517 : Let me know who is watching my account
Patch by Frederic Buclin <LpSolit@gmail.com>  r=myk a=myk


git-svn-id: svn://10.0.0.236/trunk@170707 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 16:10:18 +00:00
travis%sedsystems.ca
5b98831b40 Bug 98123 : Create a user preferences infrastructure (became 'General Settings')
Patch by Shane H. W. Travis <travis@sedsystems.ca>   r=jouni, mkanat  a=myk


git-svn-id: svn://10.0.0.236/trunk@170515 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-10 15:51:43 +00:00
mkanat%kerio.com
da1c0470db Bug 279693: Move UserCanBlessGroup() into a Bugzilla::User function
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@169815 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-25 03:07:05 +00:00
mkanat%kerio.com
ec61adb419 Bug 281550: Remove RelationSet from userprefs.cgi (and thus fix non-ANSI INSERT)
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@169810 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-25 02:34:11 +00:00
mkanat%kerio.com
4366849e89 Bug 280502: Replace "INTERVAL" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169516 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-20 08:02:07 +00:00
mkanat%kerio.com
fe14d8a2d1 Bug 280497: Replace "LIMIT" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=justdave


git-svn-id: svn://10.0.0.236/trunk@169390 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:14:27 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
travis%sedsystems.ca
b63354eba2 Bug 280994 : Move ValidateNewUser out of globals.pl
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169041 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-09 06:42:43 +00:00
travis%sedsystems.ca
6427625246 Bug 278792 : Move Crypt() to Bugzilla::Auth
Patch by Max Kanat-Alexander <mkanat@kerio.com>   r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168559 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 19:26:01 +00:00
travis%sedsystems.ca
b75c9da900 Bug 108870: Bugzilla does not set email prefs for new user until user visits userprefs.cgi
Patch: travis  r=mkanat  a=justdave

Also includes fixes for
Bug 109573: New bugzilla accounts should by default have 'CC field changes' turned off, and
Bug 275599: flag request email prefs not behaving correctly


git-svn-id: svn://10.0.0.236/trunk@167399 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-07 20:56:01 +00:00
jocuri%softhome.net
378b821e00 Patch for bug 275788: Provide a line of code that defines legal query formats for other scripts to use; patch by Colin S. Ogilvie <colin.ogilvie@gmail.com>, r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@167132 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-31 08:01:17 +00:00
jake%bugzilla.org
a0a44f13e7 Bug 274397 - Editing a saved search should now work even after clicking "Show List" from a bug.
Patch by Colin S. Ogilvie <colin.ogilvie@gmail.com>
r=wurblzap, a=justdave


git-svn-id: svn://10.0.0.236/trunk@166982 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-23 09:54:18 +00:00
bugreport%peshkin.net
4253758cff Bug 251837: Add UI to add/remove 'My Bugs' link in footer
r=joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159899 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 05:54:13 +00:00
bugreport%peshkin.net
83ce1f0a5f Bug 236779: Add UI for changing "linkinfooter" flag for saved searches
r=gerv,preed
a=justdave


git-svn-id: svn://10.0.0.236/trunk@156358 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-13 16:04:27 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
kiko%async.com.br
36171a62bf Fix for bug 226764: Move InvalidateLogins into Bugzilla::Auth::CGI.
Consolidates the logout code into Bugzilla::Auth::CGI, and provides
simple front-end wrappers in Bugzilla.pm for use in the CGIs we have.
r=bbaetz, joel; a=justdave.

Adds a set of constants to the logout() API which allow specifying "how
much" we should log out -- all sessions, the current session, or all
sessions but the current one.

Fixes callsites to use this new API; cleans and documents things a
bit while we're at it. Part I in the great COOKIE apocalypse.


git-svn-id: svn://10.0.0.236/trunk@154327 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 01:28:29 +00:00