556 Commits

Author SHA1 Message Date
buster%netscape.com
952ca09fa5 My previous check-in had an important line accidentally commented out. This just re-enables that line. This fixes bug 58257
git-svn-id: svn://10.0.0.236/trunk@81996 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-30 04:48:53 +00:00
buster%netscape.com
d61dcff924 accidentally checked this in with a debug flag turned on that wrote a bunch of output to stdout. turned off.
git-svn-id: svn://10.0.0.236/trunk@81993 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-30 04:10:44 +00:00
warren%netscape.com
a8b9664a8c Bug 47207. Backing out logging/PRINTF changes until we can fix stopwatch.h, introduce double parens, etc.
git-svn-id: svn://10.0.0.236/trunk@81967 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-28 22:17:53 +00:00
warren%netscape.com
c6b67eceeb Bug 47207. Changing printf to PRINTF to use new logging facility. r=valeski,sr=waterson
git-svn-id: svn://10.0.0.236/trunk@81885 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-27 22:43:51 +00:00
buster%netscape.com
c696b64b4d bug 57596 (crash caused by reframing XBL reparented explicit children)
fix by rickg
r=buster
a=waterson


git-svn-id: svn://10.0.0.236/trunk@81867 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-27 14:14:36 +00:00
buster%netscape.com
09d59fd2f9 backed out my/waterson's potential fix for bug 43914
this fixes bug 56102
a=waterson


git-svn-id: svn://10.0.0.236/trunk@81037 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-12 20:30:43 +00:00
buster%netscape.com
59b79617a9 bug 29276 (text inside <label> tags within a table cell breaks out of table cell)
bug 1164 (ALIGN=MIDDLE and ALIGN=ABSMIDDLE values are not being supported)
bug 54119 (percentage (%) image (img) heights do nothing)
r=karnaze, rods, attinasi
a=waterson


git-svn-id: svn://10.0.0.236/trunk@80746 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-09 21:19:36 +00:00
mjudge%netscape.com
81021b1142 fixing 34356. hack to get clickng before table working beta3+
git-svn-id: svn://10.0.0.236/trunk@79312 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-15 07:02:05 +00:00
buster%netscape.com
871bd8d7c0 bug 18445
r=karnaze
This bug fixes the way we treat placement of replaced inline elements when
they have display:block.


git-svn-id: svn://10.0.0.236/trunk@79281 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-15 06:20:07 +00:00
buster%netscape.com
685185593d bug 14280
nsTextTransformer.cpp.
  I moved where we translate the nbsp to a (ascii 32 space character) until after the i18n routines are called, so they can properly account
  for the space as non-breaking and therefore part of the first word in the block.

bug  39901 and 38396
  nsHTMLImageLoader.*, nsImageFrame.cpp
  I backed out the bad fix for 38396, and put in a new fix where I store a little state in the image loader flags for cases where the image
  gets an unconstrained reflow and has %-based width.  This does not handle %-based min-width or max-width, that would be a separate
  bug that I'll file shortly.  But this fixes the vast majority of real cases out there.

bug  18754
  nsHRFrame.cpp, quirks.css, nsCSSFrameConstructor.cpp, last part of nsLineLayout.cpp
  in quirks mode, I changed HR from a block element to a replaced inline element that acts like a block, using generated content to get
  newlines before and after the HR.  This isn't ideal, but it gets us backwards compatibility, and ian and dbaron have blessed the approach.

bug  50257
  nsLineLayout.cpp
  Did a couple of things in here:
       * The actual fix is controlled by FIX_BUG_50257 #define symbol.  This basically says that an break (BR) will always fit on a line.
         A more general solution would probably be to round up to the nearest pixel, and if the thing is less than a pixel make it fit on a
         line.  This is a wimpier, safer solution.
       * I noticed that the way we got the compatibility mode was way out of date, very wasteful.  So I fixed that.
       * I noticed that there were a bunch of redundant SetFlag calls.  Since the flag variable is initialized to 0, setting a flag to 0 on a newly
         created object is a waste.

  nsBlockFrame.cpp  --  just added a comment to some odd looking code, to make sure no one comes along later and breaks it


git-svn-id: svn://10.0.0.236/trunk@78763 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-11 21:15:02 +00:00
buster%netscape.com
f407725c66 bug 28811
r=karnaze
The problem was we were over-eager in optimizing away a resize reflow for lines
that contain %-aware children.  We were only looking at the first-level children
of a line, not all the children.  Now, we compute a bit for each inline container
based on it's children, true if any of them are %-aware wrt any width measurement.
We propogate this bit upwards to a bit on the line itself, and check this bit during reflow.


git-svn-id: svn://10.0.0.236/trunk@78755 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-11 20:46:44 +00:00
dbaron%fas.harvard.edu
c7f877db2d Don't apply top margin to a block containing only floaters. Let it collapse through instead. b=44419
Only do the quirky fix for bug 37657 for tables, not all blocks.  b=43086
r=buster@netscape.com


git-svn-id: svn://10.0.0.236/trunk@78109 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-04 21:44:48 +00:00
buster%netscape.com
342b94a380 bug 45152 (Typed text does not render in TextAreas with a horizontal scrollbar)
fixed by adding a flag in nsLineBox for the content of a line to mark it "forceInvalidate",
logic in nsLineLayout to set the line dirty for initial reflow of text frames,
and logic in block to check the new flag.
r=kin


git-svn-id: svn://10.0.0.236/trunk@77051 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-24 04:26:43 +00:00
rbs%maths.uq.edu.au
fe6ee91829 Enable the code to export the baseline out of the block frame code to support 'vertical-article: baseline' in table-cells. bug 10207. a:waterson@mozilla.org. was r:buster@netscape.com.
git-svn-id: svn://10.0.0.236/trunk@75038 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-28 09:18:15 +00:00
waterson%netscape.com
cf2a3109e3 Bug 44709. Maintain renumbering depth on stack, instead of in a global. r=roc+moz@cs.cmu.edu
git-svn-id: svn://10.0.0.236/trunk@75037 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-28 09:02:34 +00:00
waterson%netscape.com
86cf521ec9 Bug 19051. Remove code that computed and maintained nsTextRun. Instead, compute 'next text' when required by crawling the frame tree in nsLineLayout::FindNextText(). r=roc+moz@cs.cmu.edu
git-svn-id: svn://10.0.0.236/trunk@74887 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-27 05:16:08 +00:00
dbaron%fas.harvard.edu
f756eb4076 Fix bug 43882 (dogfood+) by removing special handling of empty P elements. (Most of the diffs are whitespace changes.) This also fixes bugs 43369, 43991, and 18050. However, it exposes a few other issues as well (the most important of which, nuking top margins on first *normal flow* children of BODY and TD, was previously fixed only in some cases, but shouldn't be hard to fix in general). r=waterson
git-svn-id: svn://10.0.0.236/trunk@73541 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-29 22:03:42 +00:00
buster%netscape.com
e8833a517e fixed nsbeta2+ bugs 42138 35772 37657 38157 40283 35964
r=waterson, rods


git-svn-id: svn://10.0.0.236/trunk@72241 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-14 23:15:59 +00:00
buster%netscape.com
91f736fa91 fixed bug 41757
file also contains some debug only code (disabled), another bug fix (also disabled), the removal of
some obsolete code that was already #ifdef'd out, and a bunch of new comments
r=mjudge, waterson


git-svn-id: svn://10.0.0.236/trunk@72006 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-11 22:14:33 +00:00
rbs%maths.uq.edu.au
918b4d93c1 [#ifdef MOZ_MATHML: not yet part of default build]. Export the baseline out of the block frame code to support 'vertical-align: baseline' in table-cells. bug 10207. r:buster@netscape.com. a:waterson@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@71513 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-05 08:24:18 +00:00
alecf%netscape.com
7ad6d31130 fix #ifdefs to quiet output (speeds up display of complex tables like tinderbox and slashdot.org) - does not affect release builds
git-svn-id: svn://10.0.0.236/trunk@71483 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-04 09:44:08 +00:00
anthonyd%netscape.com
8e4f929fe8 avoiding confusion between line iterator between layout and navigation.
if you want a line iterator for navigation you must explicitly ask for one.


git-svn-id: svn://10.0.0.236/trunk@70013 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-16 08:11:14 +00:00
buster%netscape.com
98dbc47939 bugs 38396, 29429, 32471, 27390, 32581
errors in incremental calcuation of max-element-size and preferred-size


git-svn-id: svn://10.0.0.236/trunk@69635 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-14 04:56:25 +00:00
mjudge%netscape.com
5dc3b3236c updating capture code
git-svn-id: svn://10.0.0.236/trunk@69627 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-14 03:41:25 +00:00
sspitzer%netscape.com
6500e416c5 fix crasher when clicking on a text area. bug #38897.
git-svn-id: svn://10.0.0.236/trunk@69203 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-11 08:41:35 +00:00
mjudge%netscape.com
303c4eb4ce need to check for independent selection to grab mousedown state. will change this to be implemented by selectioncontroller later
git-svn-id: svn://10.0.0.236/trunk@69190 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-11 04:50:16 +00:00
mjudge%netscape.com
2f9bd42697 changing way we access caret. use the selection controller whenever possible. because it will make the caret do the right thing even when we have multiple selections accessing same caret.
git-svn-id: svn://10.0.0.236/trunk@69180 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-11 04:25:43 +00:00
buster%netscape.com
6be2ec13df effectively removed area frame
work troy was holding in his tree
r=buster

also fixed bugs 26952, 30944, 36022
r=troy


git-svn-id: svn://10.0.0.236/trunk@68804 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-09 05:06:16 +00:00
mjudge%netscape.com
ef3e852f95 adjusting how we get nsIFrameSelection. maybe we can QI from SelectionController
git-svn-id: svn://10.0.0.236/trunk@68626 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-08 03:59:53 +00:00
troy%netscape.com
2831676fb5 Reinstated clipping code which had been backed out because it caused
a problem for XUL layout. I added a workaround for the XUL problem


git-svn-id: svn://10.0.0.236/trunk@67078 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-25 04:43:11 +00:00
putterman%netscape.com
97e6e61f3c Backing out troy's changes to fix various UI blocker bugs.
git-svn-id: svn://10.0.0.236/trunk@66999 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-24 22:15:55 +00:00
troy%netscape.com
e90db6dfb9 Changes to bring clipping inline with upcoming CSS2 errata
git-svn-id: svn://10.0.0.236/trunk@66887 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-23 00:56:16 +00:00
rods%netscape.com
fbf8aca833 Add ifdef'ed Performance Reflow Counting code
git-svn-id: svn://10.0.0.236/trunk@66719 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-21 14:59:47 +00:00
troy%netscape.com
acf6fe34f4 b=36202 Patch from roc+moz@cs.cmu.edu that makes sure we invalidate if
necessary when pulling up frames


git-svn-id: svn://10.0.0.236/trunk@66394 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-19 03:12:13 +00:00
buster%netscape.com
00671105d4 one line of debug code accidentally slipped in. Removed.
git-svn-id: svn://10.0.0.236/trunk@66204 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-17 15:03:55 +00:00
buster%netscape.com
2fa9ad90e8 bug 588 (text justification) for Robert O'Callahan <roc+moz@cs.cmu.edu>
r=buster

bug 18545 ([FLOAT] Problem Centering <TABLE> with <DIV> tag)
r=troy

bugs 18827, 19579, 22327 24782, 26512, 30124, 31849, 32846 (floater behavior wrong)
The primary change here is to determine if a block is impacted by a floater, and if so
mark the block's lines dirty when appropriate.
r=troy

no bug number.  performance work.  reduced the size of some reflow data structures by
collapsing multiple fields into a single bit field.
r=troy


git-svn-id: svn://10.0.0.236/trunk@66201 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-17 14:40:46 +00:00
nisheeth%netscape.com
68adc31658 Fix for bug 30958: Reflow commands are now processed asynchronously all the time. The semantics of the API for queuing and processing reflow commands has changed. Now, AppendReflowCommand() initiates an asynchronous reflow event and all reflow command processing happens when that event fires. It is no longer possible for consumers outside the presentation shell to call ProcessReflowCommands() synchronously. Because of this change, reflow locks are no longer needed and have been removed.
git-svn-id: svn://10.0.0.236/trunk@66183 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-17 07:13:57 +00:00
mjudge%netscape.com
b5c40f47f1 table cell selection now shows up background. also small fix for nsBlockFrame to do the right thing for mouse capture.
git-svn-id: svn://10.0.0.236/trunk@65860 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-13 20:21:32 +00:00
mjudge%netscape.com
c25a8377d7 fix for setcapture. passes events to the nsHTMLFrame's areaframe when events are trapped to a given frame's view.
git-svn-id: svn://10.0.0.236/trunk@65649 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-12 03:04:11 +00:00
jim_nance%yahoo.com
b1ccfbf2cb Bug 33322 - Fix compiler warnings. Its been on n.p.m.builds for a few
days for module owners to comment on.  r=troy@netscape.com


git-svn-id: svn://10.0.0.236/trunk@64566 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-30 03:21:26 +00:00
buster%netscape.com
bf63049426 bug 29595 (and others)
fixes layout of pages where a single line is impacted by 2 or more floaters
r=troy


git-svn-id: svn://10.0.0.236/trunk@63783 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-22 23:19:10 +00:00
dbaron%fas.harvard.edu
0936aaafab Fix event targetting bugs by using paint layers in GetFrameForPoint, testing for visibility, and trying GetFrameForPoint on additional views if one fails. r=joki@netscape.com(, hyatt@netscape.com) b=12232,20051,21304,24474,26785, and remaining issues from 23161.
git-svn-id: svn://10.0.0.236/trunk@63689 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-22 02:43:08 +00:00
pierre%netscape.com
c84deb6d8c Fix 32199 (visibility:collapse is not being interpreted as hidden on block and inline level elements) and parts of 21701 (misuse of style attr mVisible).
In the following files, replacing disp->mVisible with disp->IsVisible() is a BUG FIX: nsBlockFrame, nsBulletFrame, nsHRFrame, nsHTMLContainerFrame, nsImageFrame, nsTextFrame.

In all the other files, replacing disp->mVisible with disp->IsVisible() or disp->IsVisibleOrCollapsed() is merely a SYNTACTICAL CHANGE. The respective owners will later review the use of IsVisibleOrCollapsed() and in some cases replace it with IsVisible(). See bug 21701.


git-svn-id: svn://10.0.0.236/trunk@63284 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-17 10:15:13 +00:00
troy%netscape.com
00091b65e3 b=24343 r=karnaze@netscape.com Changes so we properly lay out after changing
the font using the pref UI. Block and table code changed to handle
eReflowReason_StyleChange


git-svn-id: svn://10.0.0.236/trunk@63049 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-15 15:16:03 +00:00
troy%netscape.com
8f7ef0638a b=24506 r=buster@netscape.com When calculating the width of a block frame
and it's an unconstrained reflow, then make sure to include the right
margin


git-svn-id: svn://10.0.0.236/trunk@62844 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-14 04:03:33 +00:00
troy%netscape.com
d4f29d1b5f Now line boxes are allocated out of the pres shell arena. This reduces the
overhead of memory allocation, and it gets us recycling which speeds up
resize reflows


git-svn-id: svn://10.0.0.236/trunk@62680 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-12 03:00:51 +00:00
buster%netscape.com
8876d68b6f fixed bug 25510 and 28084
r=troy
a=jar


git-svn-id: svn://10.0.0.236/trunk@61440 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-22 22:06:19 +00:00
buster%netscape.com
bb33a00be3 bug 27927
r=troy


git-svn-id: svn://10.0.0.236/trunk@61045 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-16 04:11:37 +00:00
buster%netscape.com
ad34728fe0 continuing work on bug 25510
r=troy


git-svn-id: svn://10.0.0.236/trunk@60983 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-16 00:50:06 +00:00
dbaron%fas.harvard.edu
f1cd9a202b Fix bug 15428 as suggested by VYV03354@nifty.ne.jp . Stop using 0 as the initial values for min and max of inline box contents so that lines that do not (vertically) contain their own baseline are sized correctly. Also, correctly size BR frames using their line-height (for strict-mode only).
Fix bugs 24186, 26996, and 26998 by reworking the quirks-mode line-height handling so that inline elements that do not have text as children (or meet a few other conditions that show the author wants real CSS support) will not increase the size of the line, but will be as close to their correct size as possible without enlarging the line.  This fix includes emulation of the strange Nav4/IE quirk that a block's line-height is enforced on the first line of LI elements and the last line of LI, DD, and DT elements.  Many of the changes are removing an earlier fix for 24186.

r=buster


git-svn-id: svn://10.0.0.236/trunk@60795 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-15 04:26:44 +00:00