Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
138,346 Commits 3,986 Branches 0 Tags
Commit Graph

218 Commits

Author SHA1 Message Date
jocuri%softhome.net
930f674f5e Patch for bug 258711: move.pl should honour emailsuffix; patch by Marc Schumann <wurblzap@gmail.com>, r=justdave, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@166321 18797224-902f-48f8-a5cc-f745e15eee43
 2004-12-06 17:08:20 +00:00
jocuri%softhome.net
3be7f3bfa1 Patch for bug 267560: CheckCanChangeField in process_bug.cgi shouldn't request the bug owner, QA contact and reporter too many times; patch by Frédéric Buclin <LpSolit@netscape.net>, r=justdave, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@165543 18797224-902f-48f8-a5cc-f745e15eee43
 2004-11-20 12:31:04 +00:00
jocuri%softhome.net
8610d5bf4e Patch for bug 267774: Remove unused variable in process_bug.cgi; patch by Frédéric Buclin <LpSolit@netscape.net>; r=kiko, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@164995 18797224-902f-48f8-a5cc-f745e15eee43
 2004-11-05 08:58:03 +00:00
justdave%bugzilla.org
4da516c042 [SECURITY] Bug 252638: It is possible to send a carefully crafted HTTP POST message to process_bug.cgi which will remove keywords from a bug even if you don't have permissions to edit all bug fields (the "editbugs" permission). Such changes are reported in "bug changed" email notifications, so they are easily detected and reversed if someone abuses it. 
Patch by Myk Melez <myk@mozilla.org>
r=gerv, a=justdave


git-svn-id: svn://10.0.0.236/trunk@164336 18797224-902f-48f8-a5cc-f745e15eee43
 2004-10-25 07:20:59 +00:00
justdave%bugzilla.org
46e9d71358 Bug 254498: Check for comment required for time validation was too late. 
Patch by Tiago R. Mello <tiago@async.com.br>
r=kiko, a=justdave


git-svn-id: svn://10.0.0.236/trunk@164324 18797224-902f-48f8-a5cc-f745e15eee43
 2004-10-25 04:49:32 +00:00
bugreport%peshkin.net
cd65dc04d7 Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates 
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
 2004-08-04 16:17:10 +00:00
jocuri%softhome.net
2336c8c696 Patch for bug 253604: When commit a bug, validate timetracking before user match; patch by Tiago R. Mello <tiago@async.com.br>; r=kiko, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@160268 18797224-902f-48f8-a5cc-f745e15eee43
 2004-08-03 06:23:25 +00:00
jocuri%softhome.net
23204eca2d Patch for bug 253360: replace IF() with CASE WHEN for database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@160170 18797224-902f-48f8-a5cc-f745e15eee43
 2004-07-31 09:36:18 +00:00
kiko%async.com.br
e3ff662f81 Fix for bug 216008: Time Tracking: default values cause change bug 
errors. Check if the time values haven't actually changed by using                     integer comparison (instead of string comparison). r=jouni, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@160020 18797224-902f-48f8-a5cc-f745e15eee43
 2004-07-29 03:09:10 +00:00
kiko%async.com.br
a89fa3803a Fix for bug 252789: Empty timetrackinggroup causes error "hours worked 
needs to be positive" when changing bug. Sanitizing the AddComment bits
in process_bug.cgi to only touch work_time if user is in
timetrackinggroup. Fixes regression introduced in bug 252159.
r=jouni,joel; a=justdave.


git-svn-id: svn://10.0.0.236/trunk@160017 18797224-902f-48f8-a5cc-f745e15eee43
 2004-07-29 02:59:11 +00:00
kiko%async.com.br
ce412f90e2 Fix for bug 252159: centralize time validation. Adds a ValidateTime 
function to Bugzilla::Bug and uses it in relevant callsites. Patch by
Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>. r=kiko, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@159666 18797224-902f-48f8-a5cc-f745e15eee43
 2004-07-22 17:48:37 +00:00
kiko%async.com.br
f1789c492a Fix for bug 251935: Remove $COOKIE from process_bug.cgi. r=joel, a=myk. 
git-svn-id: svn://10.0.0.236/trunk@159553 18797224-902f-48f8-a5cc-f745e15eee43
 2004-07-20 21:25:33 +00:00
gerv%gerv.net
76b9955c30 Bug 240093 - get canconfirm working again. Patch by gerv; r=joel, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@159396 18797224-902f-48f8-a5cc-f745e15eee43
 2004-07-17 16:09:28 +00:00
jocuri%softhome.net
15cc92865e Patch for bug 242161: make process_bug.cgi contain patchviewer ("diff") link like show_bug.cgi; patch by GavinS <bugzilla@chimpychompy.org>; r=vladd; a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@157231 18797224-902f-48f8-a5cc-f745e15eee43
 2004-06-01 12:53:27 +00:00
gerv%gerv.net
0ee626b3f2 Bug 237838 - make sure CheckCanChangeField() always gets correct resolution. Patch by gerv and Tom Karzes; r, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@155604 18797224-902f-48f8-a5cc-f745e15eee43
 2004-04-27 22:28:06 +00:00
timeless%mozdev.org
50995530ac Bug 192571 Empty default owner (assignee or QA) causes "Reassign bug to owner and QA contact of selected component to NOOP 
r=justdave a=justdave


git-svn-id: svn://10.0.0.236/trunk@155330 18797224-902f-48f8-a5cc-f745e15eee43
 2004-04-22 14:42:14 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and 
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
 2004-03-27 03:51:44 +00:00
justdave%syndicomm.com
f32788afb7 Bug 24496: Adds a parameter "noresolveonopenblockers" which when enabled, prevents bugs from being closed if there are any bugs blocking it which are still open. 
Patch by Andreas Höfler <andreas.hoefler@bearingpoint.com>
r= justdave, a= myk


git-svn-id: svn://10.0.0.236/trunk@154079 18797224-902f-48f8-a5cc-f745e15eee43
 2004-03-18 05:55:41 +00:00
justdave%syndicomm.com
e099454c93 Bug 192516: Moving the loose .pm files into the Bugzilla directory, where they belong. These files pre-date the Bugzilla directory, and would have gone there had it existed at the time. The four files in question were copied on the CVS server to preserve CVS history in the files. This checkin deletes them from the old location and modifies everything else to know where they are now. 
r= myk, gerv
a= justdave


git-svn-id: svn://10.0.0.236/trunk@154078 18797224-902f-48f8-a5cc-f745e15eee43
 2004-03-18 03:57:05 +00:00
gerv%gerv.net
b1374b038a Bug 233645 - fix a number of 'undef' warnings which were killing performance for multiple bug change. Patch by gerv; r,a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@152765 18797224-902f-48f8-a5cc-f745e15eee43
 2004-02-13 20:24:51 +00:00
jocuri%softhome.net
75fce9c684 Bug 219475: The check for null db entries in process_bug.cgi is wrong; patch by Chuck Duvall <caduvall@glue.umd.edu>; r=bbaetz; a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@148968 18797224-902f-48f8-a5cc-f745e15eee43
 2003-11-07 08:05:01 +00:00
jocuri%softhome.net
a0d7e28441 Bug 223854: masscc on change several bugs doesn't honor usermatchmode; patch by Jon <kniht@us.ibm.com>; r=myk; a=myk. 
git-svn-id: svn://10.0.0.236/trunk@148459 18797224-902f-48f8-a5cc-f745e15eee43
 2003-10-28 06:37:40 +00:00
jocuri%softhome.net
312fe61923 Bug 218977: "Table 'namedqueries' was not locked with LOCK TABLES" on ThrowUserError('product_edit_denied'); r=bbaetz; a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@148125 18797224-902f-48f8-a5cc-f745e15eee43
 2003-10-19 08:46:39 +00:00
justdave%syndicomm.com
82642e719e Correcting the previous backout attempt, apparrently typoed a version number last time 
git-svn-id: svn://10.0.0.236/trunk@148053 18797224-902f-48f8-a5cc-f745e15eee43
 2003-10-17 02:07:55 +00:00
justdave%syndicomm.com
ec2098df1b Backing out patch from bug 108528 - failed to take i10n concerns into account 
git-svn-id: svn://10.0.0.236/trunk@148034 18797224-902f-48f8-a5cc-f745e15eee43
 2003-10-16 18:26:09 +00:00
timeless%mozdev.org
72f2fe28cc Bug 108528 - knob is not defined doesn't explain to 2001110503 users what to do 
patch by caduvall@glue.umd.edu r=timeless a=justdave


git-svn-id: svn://10.0.0.236/trunk@148005 18797224-902f-48f8-a5cc-f745e15eee43
 2003-10-15 22:48:12 +00:00
jocuri%softhome.net
925257fbb9 Bug 220034: empty form after changing bug details; patch by wicked@etlicon.fi (Teemu Mannermaa); r=kiko, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@147923 18797224-902f-48f8-a5cc-f745e15eee43
 2003-10-13 21:38:13 +00:00
timeless%mozdev.org
396a5751e1 Bug 221264 Making no changes shouldn't affect Last modified 
r=joel a=justdave


git-svn-id: svn://10.0.0.236/trunk@147671 18797224-902f-48f8-a5cc-f745e15eee43
 2003-10-07 05:59:30 +00:00
bbaetz%acm.org
7d7d7e1532 Bug 208699 - Move Throw{Code,Template}Error into Error.pm 
r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@146857 18797224-902f-48f8-a5cc-f745e15eee43
 2003-09-14 06:05:23 +00:00
justdave%syndicomm.com
e867c6f9cf Bug 215962: Missing {} around implied hash reference in params to ThrowUserError 
patch by Eric Selberg <erik@selberg.com>
r= justdave a= justdave


git-svn-id: svn://10.0.0.236/trunk@145928 18797224-902f-48f8-a5cc-f745e15eee43
 2003-08-12 18:54:16 +00:00
preed%sigkill.com
64c7b7af62 Bug 211435 - Fix "Table 'namedqueries' was not locked with LOCK TABLES" error; Patch by jocuri@softhome.net (Vlad Dascalu), r=bbaetz, a=justdave 
git-svn-id: svn://10.0.0.236/trunk@145133 18797224-902f-48f8-a5cc-f745e15eee43
 2003-07-24 01:00:20 +00:00
preed%sigkill.com
b39ed20403 Fixes singed tinderbox trees; vladd: NO TABS in patches, please. Spaces only. 
git-svn-id: svn://10.0.0.236/trunk@144930 18797224-902f-48f8-a5cc-f745e15eee43
 2003-07-17 23:31:44 +00:00
preed%sigkill.com
6e93bc7800 Bug 82172 - Don't allow empty bug summaries. Patch by jocuri@softhome.net (Vlad Dascalu), r=kiko, a=justdave 
git-svn-id: svn://10.0.0.236/trunk@144926 18797224-902f-48f8-a5cc-f745e15eee43
 2003-07-17 22:54:25 +00:00
bbaetz%acm.org
726bcd99cc Bug 180635 - Enhance Bugzilla::User to store additional information 
r=myk,jake


git-svn-id: svn://10.0.0.236/trunk@143228 18797224-902f-48f8-a5cc-f745e15eee43
 2003-06-03 09:48:15 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output 
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
 2003-05-05 01:15:38 +00:00
myk%mozilla.org
6d65c0a8ff Fix for bug 179510: takes group restrictions into account when sending request notifications 
r=bbaetz,jpreed
a=justdave


git-svn-id: svn://10.0.0.236/trunk@141792 18797224-902f-48f8-a5cc-f745e15eee43
 2003-04-25 05:41:29 +00:00
justdave%syndicomm.com
48935e0919 Bug 193965: On product change, user can accidentally opt-out of required group restriction 
Patch by Joel Peshkin <bugreport@peshkin.net>
r= bbaetz, justdave
a= justdave


git-svn-id: svn://10.0.0.236/trunk@141764 18797224-902f-48f8-a5cc-f745e15eee43
 2003-04-24 21:50:33 +00:00
bbaetz%acm.org
6ee31579fe Bug 199813 - Make all users of ThrowUserError pass $vars in explicitly. 
r=gerv
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140585 18797224-902f-48f8-a5cc-f745e15eee43
 2003-04-02 12:35:07 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line 
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
 2003-03-27 00:07:02 +00:00
bbaetz%acm.org
82d871b866 Bug 194394 - Internal error after turning useqacontact off 
r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@138288 18797224-902f-48f8-a5cc-f745e15eee43
 2003-02-23 07:31:09 +00:00
gerv%gerv.net
5e8fa24f5f Bug 186994 - Unable to accept a new bug that has been assigned. Patch by gerv; r=bbaetz, a=justdave. 
git-svn-id: svn://10.0.0.236/trunk@137864 18797224-902f-48f8-a5cc-f745e15eee43
 2003-02-16 11:59:44 +00:00
justdave%syndicomm.com
c825424954 Bug 193286: Field validation errors had the wrong page title 
r= gerv, a= justdave


git-svn-id: svn://10.0.0.236/trunk@137843 18797224-902f-48f8-a5cc-f745e15eee43
 2003-02-15 08:03:51 +00:00
justdave%syndicomm.com
3235eb35bb Bug 192513: importxml.pl and move.pl now use the new mail routines introduced in bug 124174 (they got broken when processmail was removed). Also fixes several comments referring to processmail (which no longer exists) in other files, and removes references to processmail from the .htaccess files and the executable file list in checksetup.pl. 
r= jaypee, a= justdave


git-svn-id: svn://10.0.0.236/trunk@137622 18797224-902f-48f8-a5cc-f745e15eee43
 2003-02-10 06:26:39 +00:00
preed%sigkill.com
017bee49ea Bug 124174 - make processmail a package (Bugzilla::BugMail), r=gerv, r=jth, a=justdave 
git-svn-id: svn://10.0.0.236/trunk@137613 18797224-902f-48f8-a5cc-f745e15eee43
 2003-02-09 22:04:25 +00:00
bbaetz%acm.org
40e949abcb Bug 192340 - 'unknown_keyword' error doesn't mention keyword 
r=myk, a=justdave


git-svn-id: svn://10.0.0.236/trunk@137576 18797224-902f-48f8-a5cc-f745e15eee43
 2003-02-08 01:38:51 +00:00
burnus%gmx.de
146879dcab bug 191087 - process_bug.cgi: "Mid-air collision!" title when not allowed to change a field 
r=gerv, a=justdave


git-svn-id: svn://10.0.0.236/trunk@137416 18797224-902f-48f8-a5cc-f745e15eee43
 2003-02-05 08:50:03 +00:00
bbaetz%student.usyd.edu.au
4dd0d47760 Bug 171493 - make show_bug use Bug.pm and remove bug_form.pl 
r=justdave, joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134567 18797224-902f-48f8-a5cc-f745e15eee43
 2002-11-28 10:49:58 +00:00
bugreport%peshkin.net
8bd91adeeb Bug 147275 Rearchitect product groups 
Patch by joel
r=bbaetz,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134383 18797224-902f-48f8-a5cc-f745e15eee43
 2002-11-24 19:56:34 +00:00
bbaetz%student.usyd.edu.au
1ec2e67c0a Bug 180966 - warnings in webserver error log (take 2) 
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@134299 18797224-902f-48f8-a5cc-f745e15eee43
 2002-11-22 01:47:38 +00:00
justdave%syndicomm.com
ada2fbdaae Backing out the checkin for bug 180966 (fix warnings in web server error log). This checkin caused commenting on bugs to fail 
if timetracking is not enabled.


git-svn-id: svn://10.0.0.236/trunk@134273 18797224-902f-48f8-a5cc-f745e15eee43
 2002-11-21 18:46:21 +00:00