Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
216,161 Commits 3,986 Branches 0 Tags
Commit Graph

80 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
fb93988c4d Bug 582529: Ambiguous error message "You did not specify a file to attach" when deleting an existing attachment filename 
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262946 18797224-902f-48f8-a5cc-f745e15eee43
 2011-10-01 11:31:19 +00:00
mkanat%bugzilla.org
47c81d81a7 Bug 677187: If the attachment filename contains a newline, an error is thrown when trying to download the attachment 
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@262637 18797224-902f-48f8-a5cc-f745e15eee43
 2011-08-09 23:46:18 +00:00
mkanat%bugzilla.org
2958380e5e Bug 660502: (CVE-2011-2977) [SECURITY] Temporary files for uploaded attachments are not deleted on Windows 
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262584 18797224-902f-48f8-a5cc-f745e15eee43
 2011-08-04 20:33:34 +00:00
mkanat%bugzilla.org
50ea52fcb9 Bug 622943: Simple auditing of changes to Bugzilla::Object subclass objects 
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@262039 18797224-902f-48f8-a5cc-f745e15eee43
 2011-03-14 05:16:46 +00:00
mkanat%bugzilla.org
77394fd1cb Bug 633041: Add an error code for zero_length_file and fill in content_type 
for patches when content_type is missing in Bug.add_attachment in the
WebService
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@261912 18797224-902f-48f8-a5cc-f745e15eee43
 2011-02-11 00:33:27 +00:00
mkanat%bugzilla.org
33225a5517 Bug 413648: Attachment mime type handling should strip leading and trailing spaces 
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@261444 18797224-902f-48f8-a5cc-f745e15eee43
 2010-10-22 13:05:03 +00:00
mkanat%bugzilla.org
a77eb64833 Bug 119703: Create an attachment by pasting it into a text field 
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260809 18797224-902f-48f8-a5cc-f745e15eee43
 2010-07-18 17:31:54 +00:00
mkanat%bugzilla.org
4d8362abd8 Bug 412074: Ability to add attachments to a bug via the WebService 
(Bug.add_attachment)
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260748 18797224-902f-48f8-a5cc-f745e15eee43
 2010-07-13 22:48:31 +00:00
mkanat%bugzilla.org
f7fcd61887 Bug 490930: Always store attachments locally if they are over X size (and below some threshold!), don't ever display "Big File" checkbox 
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260674 18797224-902f-48f8-a5cc-f745e15eee43
 2010-07-08 17:03:37 +00:00
mkanat%bugzilla.org
1a4d14c903 Bug 574892: [SECURITY] Add EXTRA_REQUIRED_FIELDS to Bugzilla::Object, which 
allows specifying that certain fields have validator defaults even if they
also have a database default or are in another table.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260643 18797224-902f-48f8-a5cc-f745e15eee43
 2010-07-06 02:31:41 +00:00
mkanat%bugzilla.org
31015da7f4 Bug 574327 - Map image/x-png to image/png (to fix IE's uploads) 
[r=LpSolit a=LpSolit]


git-svn-id: svn://10.0.0.236/trunk@260623 18797224-902f-48f8-a5cc-f745e15eee43
 2010-07-05 06:18:02 +00:00
mkanat%bugzilla.org
1be00a65d9 Bug 572602: Change the way that Bugzilla::Object determines what fields 
are required for create(). It now assumes that any column that is NOT NULL
and has not DEFAULT in the database is required. We also shift the burden
of throwing errors about empty values to the validators. This fixes the bug
that Bugzilla::Bug->create() wasn't populating default values for fields
if they weren't specified in the create() parameters.
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260542 18797224-902f-48f8-a5cc-f745e15eee43
 2010-06-24 00:47:53 +00:00
mkanat%bugzilla.org
24a1aa979c Bug 565880: Do not throw an error when obsoleting an already obsolete attachment 
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260306 18797224-902f-48f8-a5cc-f745e15eee43
 2010-05-14 13:46:25 +00:00
mkanat%bugzilla.org
98a5bbf59c Bug 430014: Re-write the code hooks system so that it uses modules instead of individual .pl files 
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259069 18797224-902f-48f8-a5cc-f745e15eee43
 2009-11-24 06:09:55 +00:00
lpsolit%gmail.com
c8326196b1 Bug 140999: Users without edit permissions for an attachment should still be able to make comments - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@258513 18797224-902f-48f8-a5cc-f745e15eee43
 2009-09-28 17:24:41 +00:00
lpsolit%gmail.com
2b4f829545 Bug 480986: The BMP -> PNG conversion tool for new attachments should be an extension - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat 
git-svn-id: svn://10.0.0.236/trunk@258106 18797224-902f-48f8-a5cc-f745e15eee43
 2009-08-13 21:32:27 +00:00
lpsolit%gmail.com
7c45662399 Bug 509027: Add a hook in Bugzilla::Attachment::_check_data() - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat 
git-svn-id: svn://10.0.0.236/trunk@258094 18797224-902f-48f8-a5cc-f745e15eee43
 2009-08-13 02:25:09 +00:00
lpsolit%gmail.com
8872215623 Bug 415541: Implement $bug->set_flags() and $attachment->set_flags() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@257948 18797224-902f-48f8-a5cc-f745e15eee43
 2009-08-05 12:36:22 +00:00
lpsolit%gmail.com
15b5e1bde8 Fix a warning thrown in the web server error log (due to bug 454251) 
git-svn-id: svn://10.0.0.236/trunk@256874 18797224-902f-48f8-a5cc-f745e15eee43
 2009-04-09 21:49:04 +00:00
lpsolit%gmail.com
843d034307 Bug 454251: Implement Bugzilla::Attachment->create() and $attachment->update() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit (module owner) 
git-svn-id: svn://10.0.0.236/trunk@256870 18797224-902f-48f8-a5cc-f745e15eee43
 2009-04-09 11:38:01 +00:00
lpsolit%gmail.com
839bd078af Bug 399074: Remove the 'maxpatchsize' parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat 
git-svn-id: svn://10.0.0.236/trunk@255419 18797224-902f-48f8-a5cc-f745e15eee43
 2008-12-10 18:32:30 +00:00
lpsolit%gmail.com
98e5facc75 Fix bustage due to bug 453743: I have to exclude flags related to private attachments you cannot see 
git-svn-id: svn://10.0.0.236/trunk@254120 18797224-902f-48f8-a5cc-f745e15eee43
 2008-09-09 00:30:07 +00:00
lpsolit%gmail.com
4b7fde17a0 Bug 388251: Implement 'new Bugzilla::Attachment' - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@254105 18797224-902f-48f8-a5cc-f745e15eee43
 2008-09-08 17:13:37 +00:00
lpsolit%gmail.com
8a584b1d0c Bug 453743: Decrease the number of calls to the DB about flags when viewing a bug - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat 
git-svn-id: svn://10.0.0.236/trunk@254102 18797224-902f-48f8-a5cc-f745e15eee43
 2008-09-08 16:23:46 +00:00
lpsolit%gmail.com
7b21005ba0 Bug 415155: Remove $cgi from the list of arguments when calling Bugzilla::Flag subroutines - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@244865 18797224-902f-48f8-a5cc-f745e15eee43
 2008-02-04 13:29:29 +00:00
lpsolit%gmail.com
5c70717ea2 Bug 413772: Eliminate sqlify_criteria() in Bugzilla::Flag and replace match() there with Bugzilla::Object::match() - Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r/a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@244862 18797224-902f-48f8-a5cc-f745e15eee43
 2008-02-04 12:23:48 +00:00
lpsolit%gmail.com
bfff4541d6 Bug 413222: Implement $attachment->remove_from_db - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@243608 18797224-902f-48f8-a5cc-f745e15eee43
 2008-01-20 15:03:58 +00:00
mkanat%bugzilla.org
05d4a78dd9 Bug 408172: [Oracle] Bug lists longer than 1000 bugs fail 
Patch By Xiaoou Wu <xiaoou.wu@oracle.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@243446 18797224-902f-48f8-a5cc-f745e15eee43
 2008-01-18 15:56:55 +00:00
mkanat%bugzilla.org
703991ae84 Bug 375007: [Oracle] Some CGIs use SQL names in their "AS" clauses that don't work in Oracle 
Patch By Xiaoou Wu <xiaoou.wu@oracle.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@240889 18797224-902f-48f8-a5cc-f745e15eee43
 2007-12-12 01:51:14 +00:00
lpsolit%gmail.com
ca154f7412 Bug 99215: Attachments have no midair collision protection - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat r=justdave a=justdave 
git-svn-id: svn://10.0.0.236/trunk@240121 18797224-902f-48f8-a5cc-f745e15eee43
 2007-11-29 19:49:16 +00:00
lpsolit%gmail.com
d4fc24bcbd Midair with product change while adding an attachment silently clears flags - Patch by Tiago R. Mello <timello@gmail.com> r/a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@237452 18797224-902f-48f8-a5cc-f745e15eee43
 2007-10-09 13:06:13 +00:00
lpsolit%gmail.com
e0a39066b9 Bug 392175: Move isViewable out of attachment.cgi + some other minor cleanup - Patch by Frédéric Buclin <LpSolit@gmail.com> 
git-svn-id: svn://10.0.0.236/trunk@232034 18797224-902f-48f8-a5cc-f745e15eee43
 2007-08-14 12:34:51 +00:00
timeless%mozdev.org
847afa671a Bug 345970 Avoid using the string 'the web' 
patch by jhulten@tragicallyleet.com r=timeless
I've updated it to trunk r=lpsolit a=lpsolit


git-svn-id: svn://10.0.0.236/trunk@230773 18797224-902f-48f8-a5cc-f745e15eee43
 2007-07-24 18:22:02 +00:00
timeless%mozdev.org
508f030e04 Bug 365756 text/x-patch and text/x-diff should be mapped to [x] patch 
r=lpsolit a=lpsolit


git-svn-id: svn://10.0.0.236/trunk@230346 18797224-902f-48f8-a5cc-f745e15eee43
 2007-07-20 03:16:16 +00:00
lpsolit%gmail.com
20dacaac32 Bug 376497: validateID() should return an attachment object - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@224148 18797224-902f-48f8-a5cc-f745e15eee43
 2007-04-04 15:52:43 +00:00
lpsolit%gmail.com
a2bc326acd Bug 364177: On attachment and bug creation, if *one* requestee cannot see the bug, *all* requests are cancelled - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat 
git-svn-id: svn://10.0.0.236/trunk@219468 18797224-902f-48f8-a5cc-f745e15eee43
 2007-02-04 15:36:47 +00:00
lpsolit%gmail.com
c2c975c0ea Bug 367077: Big attachments which should be stored locally are not - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@218466 18797224-902f-48f8-a5cc-f745e15eee43
 2007-01-16 22:50:02 +00:00
lpsolit%gmail.com
53b38b69a5 Bug 365739: An error is thrown when attaching a too big file on bug creation - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave 
git-svn-id: svn://10.0.0.236/trunk@217689 18797224-902f-48f8-a5cc-f745e15eee43
 2007-01-03 16:23:14 +00:00
lpsolit%gmail.com
2d0af23821 Bug 356395: On bug creation, an error is thrown when the requestee of a private attachment is not in the insidergroup, or when the requestee is not in the grant group (for attachment flags) - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk 
git-svn-id: svn://10.0.0.236/trunk@216262 18797224-902f-48f8-a5cc-f745e15eee43
 2006-12-01 15:55:24 +00:00
lpsolit%gmail.com
21b303adf4 Bug 189627: Implement per-product privileges - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk 
git-svn-id: svn://10.0.0.236/trunk@215097 18797224-902f-48f8-a5cc-f745e15eee43
 2006-11-10 16:51:30 +00:00
lpsolit%gmail.com
c5e32db020 Bug 346086: [SECURITY] attachment.cgi lets you view descriptions of private attachments even when you are not in the insidergroup - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=justdave 
git-svn-id: svn://10.0.0.236/trunk@213649 18797224-902f-48f8-a5cc-f745e15eee43
 2006-10-14 21:11:09 +00:00
lpsolit%gmail.com
94170053e9 Bug 343809: Merge FlagType::validate() with Flag::validate() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk 
git-svn-id: svn://10.0.0.236/trunk@208300 18797224-902f-48f8-a5cc-f745e15eee43
 2006-08-24 15:56:39 +00:00
lpsolit%gmail.com
63b2458081 Bug 174039: Set flags on bug entry - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap r=myk a=myk 
git-svn-id: svn://10.0.0.236/trunk@203576 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-24 23:24:34 +00:00
mkanat%bugzilla.org
520fe42625 Bug 338375: Use Bugzilla->params everywhere instead of Param(). 
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201503 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-03 21:42:47 +00:00
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates 
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
 2006-07-03 21:26:22 +00:00
mkanat%bugzilla.org
dfd7ec9448 Bug 342121: Remove usage of Config qw(:locations) in favor of Constants::bz_locations() 
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201239 18797224-902f-48f8-a5cc-f745e15eee43
 2006-06-29 16:49:56 +00:00
lpsolit%gmail.com
a698e74659 Bug 282121: Remove globals.pl from scripts that no longer use it - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk 
git-svn-id: svn://10.0.0.236/trunk@200489 18797224-902f-48f8-a5cc-f745e15eee43
 2006-06-21 00:44:48 +00:00
lpsolit%gmail.com
68fd3a10ed Bug 5179: Need to be able to put attachment on new bug - Patch by Marc Schumann <wurblzap@gmail.com> r=LpSolit a=justdave 
git-svn-id: svn://10.0.0.236/trunk@200220 18797224-902f-48f8-a5cc-f745e15eee43
 2006-06-17 23:24:36 +00:00
lpsolit%gmail.com
40b049fbee Bug 44595: Implement an interface for administrators to delete attachments - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked, justdave a=justdave 
git-svn-id: svn://10.0.0.236/trunk@194526 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-17 20:19:37 +00:00
lpsolit%gmail.com
b440b8e903 Bug 322285: Cancelling a flag should remove it completely from the DB - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk 
git-svn-id: svn://10.0.0.236/trunk@194416 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-14 16:50:47 +00:00