Commit Graph

308 Commits

Author SHA1 Message Date
asqueella%gmail.com
7304e8117a Bug 378257 - Typo in buildSelectionMetadata causing wrong annotations name to fill in the node metadata
p=onemen.one@gmail.com
r=mano


git-svn-id: svn://10.0.0.236/trunk@225171 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-27 16:37:09 +00:00
mozilla.mano%sent.com
66ed5815d9 Bug 377500 - Result is broken if two bookmarks items have the same URL but with different titles. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@225043 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-25 21:03:29 +00:00
mozilla.mano%sent.com
ccc625067d Bug 376581 - ASSERT: null node when deleting last history item. patch from onemen.one@gmail.com, r=me.
git-svn-id: svn://10.0.0.236/trunk@224913 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-23 23:38:04 +00:00
mozilla.mano%sent.com
d6e9e48b4c Bug 378248 - PlacesCreateLivemarkTransaction doTransaction use getItemURI instead of getFolderURI. patch from onemen.one@gmail.com, r=me.
git-svn-id: svn://10.0.0.236/trunk@224911 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-23 23:34:08 +00:00
mozilla.mano%sent.com
f58b8fddb7 Bug 378470 - refreshVisibleSection fails to update viewIndex properly. patch from onemen.one@gmail.com, r=me.
git-svn-id: svn://10.0.0.236/trunk@224910 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-23 23:30:11 +00:00
dietrich%mozilla.com
b9262cc82c Bug 377066 GetAnnotationInfo always returns VALUE_TYPE_TEXT as the annotation type (r=mano)
git-svn-id: svn://10.0.0.236/trunk@224858 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-22 21:48:53 +00:00
mozilla.mano%sent.com
a8db61026f Bug 376731 - Pasting/Dropping a child of a live-bookmark should not copy over its livemark/bookmarkFeedURI annotation. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@224334 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-10 00:36:43 +00:00
mozilla.mano%sent.com
6973d6a3e3 Bug 376798 - QueriesToQueryString prefixes the first parameter with an ampersand. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@224333 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-10 00:30:52 +00:00
mozilla.mano%sent.com
9843b9658e Bug 376661 - History Sidebar->Bookmark This Link menu-item should be hidden for multiple-items selection. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@224246 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-06 00:03:13 +00:00
mozilla.mano%sent.com
3b5374934f Bug 376618 - History Sidebar->Bookmark This Link should open the bookmark properties dialog in minimal UI mode. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@224237 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-05 22:07:06 +00:00
enndeakin%sympatico.ca
3120c3e964 Bug 376429, sorting not working when clicking column headers in places window, r=mano
git-svn-id: svn://10.0.0.236/trunk@224117 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-04 01:08:43 +00:00
mozilla.mano%sent.com
b3bbf8e7f3 Bug 335323 - Fix bookmark-properties dialog dimensions and the dialog modality flag in the various modes of the dialog. r=sspitzer
git-svn-id: svn://10.0.0.236/trunk@222665 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-30 23:47:07 +00:00
dietrich%mozilla.com
42a045dee5 follow-up to bug 373504 (r=mano)
git-svn-id: svn://10.0.0.236/trunk@222664 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-30 23:16:24 +00:00
mozilla.mano%sent.com
52e16a7109 Bug 373504 - Duplicating (pasting/dropping) a bookmark item does not copy over its annotations. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@222657 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-30 20:36:32 +00:00
mozilla.mano%sent.com
9b5bdc87b9 Set showRoot on the folder tree for real (bug 371076).
git-svn-id: svn://10.0.0.236/trunk@222641 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-30 16:05:19 +00:00
mozilla.mano%sent.com
a2a72a05cb Bug 373264 - bookmarks toolbar event overrides all instances of the toolbar binding. r=dietcih.
git-svn-id: svn://10.0.0.236/trunk@222571 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-29 00:07:42 +00:00
dietrich%mozilla.com
340e220287 Bug 329281 'Add Keyword for this Search' does not work w/ Places (r=mano)
git-svn-id: svn://10.0.0.236/trunk@222554 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-28 20:32:51 +00:00
mozilla.mano%sent.com
491247ba20 Bug 371076 (and bug 371077) - Query the bookmarks root rather than the places root in bookmarks-trees; allow exposing the root node of a query in the tree view (used in the organizer left pane, and in the add-bookmark dialog). This should also allow incremental updates in the bookmarks-sidebar. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@222509 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-28 00:28:35 +00:00
sspitzer%mozilla.org
0c05de2cec fix for regression bug #375481: [places] unable to dnd bookmarks to the personal toolbar
r=mano


git-svn-id: svn://10.0.0.236/trunk@222449 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-27 05:50:29 +00:00
mozilla.mano%sent.com
83b98ac58d Bug 357316 - More add/edit UI work, see comment 18 for the change log. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@222439 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-27 00:53:00 +00:00
mozilla.mano%sent.com
bbf8f35d39 Bug 374986 - Inappropriate commands are enabled for 'special' folders. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@222367 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-25 21:56:52 +00:00
mozilla.mano%sent.com
ed5d69f609 fix typos
git-svn-id: svn://10.0.0.236/trunk@222352 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-25 12:35:15 +00:00
mozilla.mano%sent.com
34439730e5 Bug 373838 - Replace nsNavHistoryResultTreeViewer with a JS, browser-specific tree view. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@222350 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-25 12:28:30 +00:00
mozilla.mano%sent.com
bdfd9c19a9 Bug 374990 - Default insertion-point for a new item is passed as its default description. r=gavin.
git-svn-id: svn://10.0.0.236/trunk@222225 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-23 01:34:28 +00:00
mozilla.mano%sent.com
11dd5284e4 Bug 370105 - Remove ViewConfigurator and 'system-area' cruft. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@222215 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-22 23:43:56 +00:00
mozilla.mano%sent.com
4e9ba1ddf2 Bug 373502 - Implement Fx2 style microsummary picker in the properties dialog. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@222212 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-22 23:13:57 +00:00
mozilla.mano%sent.com
6253feb287 Bug 374238 - assert when adding a bookmark without a microsummary. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221990 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-16 22:05:05 +00:00
sspitzer%mozilla.org
457c9144b0 fix for bug #374166: history-on-places regression, fail to set grouping
my fix for bug #373719 caused this regression.

r=mano


git-svn-id: svn://10.0.0.236/trunk@221962 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-16 03:02:29 +00:00
sspitzer%mozilla.org
5eba9f7f43 fix for bug #374150: [places] assert when I attempt to right click + bookmark a link: Couldn't select folders because no root node was available.
my fix for bug #373719 caused this regression.

r=mano


git-svn-id: svn://10.0.0.236/trunk@221955 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-16 01:51:01 +00:00
sspitzer%mozilla.org
fef42c7f2e fix for bug #373709: open the "Help" menu item in the places' based bookmarks manager dialog gives me a js error
patch=jminta
r=mano


git-svn-id: svn://10.0.0.236/trunk@221903 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-14 23:40:23 +00:00
sspitzer%mozilla.org
2c2d4a3d00 fix typo.
git-svn-id: svn://10.0.0.236/trunk@221896 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-14 20:38:59 +00:00
sspitzer%mozilla.org
c50f0ed270 backing out my previous workarounds for bug #373719 and bug #373721.
instead, per Asaf's advice, fix this with setTimeout() so that we fix all views at once.

again, these bugs are fall out from bug #267833: Fire XBL constructors from EndUpdate(), not before.

r=mano


git-svn-id: svn://10.0.0.236/trunk@221895 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-14 20:38:12 +00:00
sspitzer%mozilla.org
77b7b13c32 workaround for bug #373719: [places] on startup, no children of bookmarks item in the bookmarks sidebar (until I search)
workaround for bug #373721:  no children under "Bookmarks" in the left pane of the "Bookmarks Manager" dialog in places

these bugs are fall out from bug #267833: Fire XBL constructors from EndUpdate(), not before.

bug #373944 tracks backing these workarounds out.

r=dietrich


git-svn-id: svn://10.0.0.236/trunk@221878 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-14 17:32:25 +00:00
mozilla.mano%sent.com
6940f9e440 Bug 370215 - update microsummaries to use unique place: uris for Places bookmarks. r=myk/dietrich.
git-svn-id: svn://10.0.0.236/trunk@221842 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-13 22:35:52 +00:00
sspitzer%mozilla.org
60a2e51c7a fix for bug #373211: history results showing up when you search in the organize bookmarks dialog.
fix for bug #373206:  when searching in bookmarks, if clear the quick search, we don't reset the search.

fix for bug #373207:  fix strings in the organize bookmarks dialog for fx 2 parity and remove a couple unused strings.

patch=jminta
r=mano


git-svn-id: svn://10.0.0.236/trunk@221807 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-13 01:21:32 +00:00
jminta%gmail.com
c1582a8111 Bug 335512 - Import bookmarks from file is broken for Places, r=mano
git-svn-id: svn://10.0.0.236/trunk@221718 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-11 00:41:43 +00:00
mozilla.mano%sent.com
6f8d04f432 Bug 357316 - More add/edit bookmark UI work. Changes listed on comment 15, r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221653 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-10 00:05:50 +00:00
mozilla.mano%sent.com
b86d5eeec8 Bug 329964 - Can't open a bookmark in the Web Panels sidebar in Places. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221531 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-08 09:29:19 +00:00
dietrich%mozilla.com
2b06e121b0 Bug 370013 Bookmarks toolbar folder should be a child of the bookmark menu folder, Bug 370020 No way to set an arbitrary folder as the bookmarks toolbar folder (r=mano)
git-svn-id: svn://10.0.0.236/trunk@221481 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-07 21:22:54 +00:00
mozilla.mano%sent.com
5ee415d24a Update nodeIsLivemarkItem util to the changes done in bug 372647. patch on bug 372647, r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221461 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-07 20:06:29 +00:00
mozilla.mano%sent.com
c674daa9dc Bug 371814 - undo-ing an item move in the organizer fails. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221422 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-07 01:29:27 +00:00
mozilla.mano%sent.com
b5fbc9edfc Export bookmarks functionality is broken in Places Organizer (regression from bug 370959), no bug.
git-svn-id: svn://10.0.0.236/trunk@221417 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-06 23:28:53 +00:00
dietrich%mozilla.com
f3540df799 Bug 372623 - contents of places toolbar are chevron'd after starting app w/ toolbar hidden (r=mano)
git-svn-id: svn://10.0.0.236/trunk@221405 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-06 19:41:15 +00:00
mozilla.mano%sent.com
a8acc179c1 Bug 372647- regression: bookmarkFeedURI annotation is not set on the children of a live bookmark. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221398 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-06 18:37:58 +00:00
mozilla.mano%sent.com
7c3bb47003 More UI-parity pieces for places-bookmarks. Changes include: 1) Implement New Bookmark and New Livemark commands and UI using the shared bookmark properties dialog (bug 365102). 2) Make New Folder command use the shared dialog as well. 3) Show dialog when adding a live-bookmark (bug 332965). 4) Hide most fields when adding a bookmark using 'Bookmark This Page...'. 5) defualt titles for each item type (bookmark/folder/livemark). 6) Changing the uri of a bookmark is now undoable. 7) Tidy up and document the dialog pseudo-API. patch on bug 357316, r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221352 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-05 22:39:21 +00:00
mozilla.mano%sent.com
f74b15c2a2 Copy the feed-uri rather than the site-uri when copying a live bookmark, patch on bug 342381. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@221328 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-05 19:47:55 +00:00
mozilla.mano%sent.com
764688ad7f Bug 371665 - View->Toolbar menu-item does not work in places organizer. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@221327 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-05 19:45:19 +00:00
mozilla.mano%sent.com
4c82eb1d89 Bug 371840 - bookmarkProperties cleanup. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221079 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-28 17:49:49 +00:00
mozilla.mano%sent.com
4892508306 Bug 372044 - Paste command moves an item rather than copying it. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221047 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-28 01:32:58 +00:00
mozilla.mano%sent.com
30c2a41b71 Bug 372040 - nodeIsLivemarkItem asserts for separators. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@221042 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-28 00:43:50 +00:00