Commit Graph

62 Commits

Author SHA1 Message Date
mozilla.mano%sent.com
ccc625067d Bug 376581 - ASSERT: null node when deleting last history item. patch from onemen.one@gmail.com, r=me.
git-svn-id: svn://10.0.0.236/trunk@224913 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-23 23:38:04 +00:00
mozilla.mano%sent.com
491247ba20 Bug 371076 (and bug 371077) - Query the bookmarks root rather than the places root in bookmarks-trees; allow exposing the root node of a query in the tree view (used in the organizer left pane, and in the add-bookmark dialog). This should also allow incremental updates in the bookmarks-sidebar. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@222509 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-28 00:28:35 +00:00
mozilla.mano%sent.com
bbf8f35d39 Bug 374986 - Inappropriate commands are enabled for 'special' folders. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@222367 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-25 21:56:52 +00:00
mozilla.mano%sent.com
34439730e5 Bug 373838 - Replace nsNavHistoryResultTreeViewer with a JS, browser-specific tree view. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@222350 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-25 12:28:30 +00:00
mozilla.mano%sent.com
11dd5284e4 Bug 370105 - Remove ViewConfigurator and 'system-area' cruft. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@222215 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-22 23:43:56 +00:00
sspitzer%mozilla.org
c50f0ed270 backing out my previous workarounds for bug #373719 and bug #373721.
instead, per Asaf's advice, fix this with setTimeout() so that we fix all views at once.

again, these bugs are fall out from bug #267833: Fire XBL constructors from EndUpdate(), not before.

r=mano


git-svn-id: svn://10.0.0.236/trunk@221895 18797224-902f-48f8-a5cc-f745e15eee43
2007-03-14 20:38:12 +00:00
dietrich%mozilla.com
e110ac32dc Bug 371669 Cannot drop or paste items from the history sidebar into the bookmarks toolbar (r=mano)
git-svn-id: svn://10.0.0.236/trunk@221019 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-27 19:35:40 +00:00
dietrich%mozilla.com
4140ac5778 Bug 360133 Bookmarks must be internally uniquely identifiable (r=mano, sspitzer)
git-svn-id: svn://10.0.0.236/trunk@220909 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-26 00:54:36 +00:00
mozilla.mano%sent.com
12aee7ec9a Bug 370959 - places frontend code cleanup. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@220566 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-20 00:51:31 +00:00
mozilla.mano%sent.com
edd4b644d8 Bug 370097 - commands disabled state is not updated in the main window when a node is selected in the history/bookmarks sidebar. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@219986 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-12 19:15:20 +00:00
mozilla.mano%sent.com
2926e25bc8 Bug 346669 - disallow dropping items into a live-bookmark container. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@219976 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-12 12:34:35 +00:00
mozilla.mano%sent.com
397fe43d36 Bug 369407 - Make the history sidebar use the shared places context menu. As part of that: 1) Add context menu for multiple-items selection 2) Remove the Expand/Collapse menu-item. 3) Replace the 'Copy Link Location' menu-item with the generic 'Copy' menu-item, which also copies the node title. r=sspitzer, ui-r=mconnor.
git-svn-id: svn://10.0.0.236/trunk@219915 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-09 22:17:37 +00:00
mozilla.mano%sent.com
6fc50cf4b7 Bug 362292 - [places] implement places-based-bookmarks sidebar (NPOB). patch from Dan Mills <thunder@mozilla.com>, r=me.
git-svn-id: svn://10.0.0.236/trunk@219700 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-08 13:33:04 +00:00
mozilla.mano%sent.com
4a73f4368c Bug 366474 - rootNodeIsSelected is not reliable for the menu view. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@218090 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-09 22:48:50 +00:00
mozilla.mano%sent.com
9527d3db8f Bug 364401 - js error when you drag link from places based history sidebar panel to personal toolbar. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217532 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-29 00:27:33 +00:00
mozilla.mano%sent.com
ff1592d55c Bug 365171 - Bug context menu delete of personal toolbar bookmark can delete history item if focused. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217530 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-28 22:56:59 +00:00
mozilla.mano%sent.com
64e247a4c3 Bug 334451 - Places Organizer: places-list tree should not list bookmark items. This also fixes the selectBookmark dialog bustage from bug 359462. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217440 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-27 00:36:35 +00:00
mozilla.mano%sent.com
8a87c4db26 Bug 364828 - PlacesController efficiency improvements - update places-specific commands for places-events only. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217410 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-24 22:56:08 +00:00
mozilla.mano%sent.com
6235546314 Bug 359462 - Redesign PlacesController interaction with places views (this makes various edit command work in the places-based history sidebar). r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217328 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-22 00:00:21 +00:00
beng%bengoodger.com
34fe8b6a16 329367 -cannot return to bookmarks after a search r=annie.sullivan@gmail.com and 334401 - assorted places organizer fixes including new debug panel r=brettw@gmail.com
git-svn-id: svn://10.0.0.236/trunk@194665 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-19 03:34:26 +00:00
beng%bengoodger.com
9776ca9ad4 332495 - grouping by site is not preserved when searching + various other search/sort fixes. r=annie.sullivan@gmail.com, brettw@gmail.com (history pieces)
git-svn-id: svn://10.0.0.236/trunk@194357 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 22:51:36 +00:00
beng%bengoodger.com
360db6244c 332873 - dragging a folder within places trees fail... make sure we use the right interface to look up constants on, and that folder containers are opened before use. r=brettw@gmail.com
git-svn-id: svn://10.0.0.236/trunk@194027 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-10 19:26:20 +00:00
beng%bengoodger.com
142a6e54ee 331755 - Use Bookmark option for setting home page is broken. add a new home page selection dialog that uses places. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193467 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 00:13:58 +00:00
beng%bengoodger.com
916c7a5969 330263 - off by one error for places drag and drop in tree views. r=brettw. Also a comment change to nsINavHistoryService.idl to improve documentation to prevent future bugs like this.
git-svn-id: svn://10.0.0.236/trunk@193352 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-31 22:42:10 +00:00
beng%bengoodger.com
70f81c13c5 328191, cannot delete history entries + a few other fixes r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193145 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-28 19:59:26 +00:00
beng%bengoodger.com
80748c607e 323812 - fix bogus copy-paste behavior and assorted other issues (insertion bugs, command updating) r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193093 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-28 00:54:10 +00:00
beng%bengoodger.com
714620c65c 324958 - folder undo delete back to previous folder id. Implement folder removal transaction in bookmarks service itself, using private methods to restore folders back to previous ids. Adjust fe to use new api. r=brettw (C++), annie.sullivan (JS)
git-svn-id: svn://10.0.0.236/trunk@192968 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-25 00:46:28 +00:00
joe%retrovirus.com
50f2b58118 * Moved changeBookmarkURI functionality from controller.js into
nsINavBookmarksService
* Added annotation and favicon handling to changeBookmarkURI
* Added brettw's copyAnnotations patch to nsIAnnotationService
* Added a GetAnnotationService() to the annotation service for faster
  intra-component access
* Added a getBookmarkFoldersTArray() to nsINavBookmarksService for easier
  intra-component memory management; updated getBookmarkFolders() to use it
* Added stub for tagRoot to nsINavBookmarksService; DO NOT USE until 329961
  has been resolved
* Quick fix for Add Bookmarks breakage caused by 329546

bug=330192
r=brettw@gmail.com
sr=bryner@bryanryner.com


git-svn-id: svn://10.0.0.236/trunk@192839 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-23 06:26:23 +00:00
brettw%gmail.com
3780cba74a Bug 329546 r=ben@mozilla.org, annie.sullivan Separate out view from history
result.


git-svn-id: svn://10.0.0.236/trunk@192823 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-23 00:32:09 +00:00
joe%retrovirus.com
b35399cf15 This submission is a roll-up of three patches developed & approved during
the branch freeze:
330052 add bookmark dialog should have a default folder selected
329792 remove dead code for old tag-style folder selector in bookmark properties
330023 allow for editing of folder names

r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@192752 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-22 03:36:41 +00:00
beng%bengoodger.com
dfde20d73e 329269 various improvements to view initialization r=annie.sullivan@gmail.com 330736 - bug in query serialization r=brettw@gmail.com
git-svn-id: svn://10.0.0.236/trunk@192511 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-17 02:02:36 +00:00
joe%retrovirus.com
82d23456b2 Changes a few remaining ASSERT() calls to NS_ASSERT() calls that I had missed
when working on bug 327349.

bug=330489
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@192369 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-14 22:58:59 +00:00
beng%bengoodger.com
61e70249c5 329269 - more work on places organizer. menus, accessible sorting and grouping options, etc. still a work in progress. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@192184 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-10 23:48:40 +00:00
beng%bengoodger.com
72e189c054 fallout from 329586 - make sure places organizer trees find the browser window so they can open bookmarks
git-svn-id: svn://10.0.0.236/trunk@192055 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-09 08:42:45 +00:00
annie.sullivan%gmail.com
d36add0136 Bug 328779: Statusbar text for bookmark menu items, Patch by Dave Townsend <mossop@blueprintit.co.uk> r=annie.sullivan@gmail.com sr=ben@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@191909 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-07 18:42:12 +00:00
annie.sullivan%gmail.com
25c5de86b2 Fixed drag and drop support for toolbars and menus. Added lots more visual feedback when dragging and dropping.
bug=318052 r=beng


git-svn-id: svn://10.0.0.236/trunk@190372 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-17 18:31:06 +00:00
beng%bengoodger.com
5d6a68fdd0 326598 - tree D&D massively broken. r=annie.sullivan@gmail.com. checked in on the branch earlier, checking in now to the trunk.
git-svn-id: svn://10.0.0.236/trunk@190001 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-14 21:36:04 +00:00
bryner%brianryner.com
be3171d190 Add support for bookmark separators (bug 320261). r=brettw, ben.
git-svn-id: svn://10.0.0.236/trunk@189381 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-08 01:10:57 +00:00
brettw%gmail.com
41ced7c321 Bug 325161 r=annie.sullivan Make all nsINavHistoryResultNodes support URI attribute, remove nsINavHistoryURIResultNode.
git-svn-id: svn://10.0.0.236/trunk@189277 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-07 01:57:53 +00:00
beng%bengoodger.com
a116bde39d 317633 - undo/redo for Places. Make sure the various transactions work better - e.g. folder undo should save a list of its child nodes for restoration. Also ensure that bookmark edits done in the places tab aren't undone when another tab is selected and Ctrl+Z hit by implementing a transaction manager in the browser window that filters out places-tab transactions if the places tab isn't selected. Make the goDo*Command utility functions in globalOverlay.js consult the window looking for applicable controllers, not just the focused element. r=sullivan. Also 320085 - search menu keybindings for places: allow find bar to be turned off using a state variable, which prevents the opening of the strip but fires an event which other applications like places can listen to: 'find-activated'.
git-svn-id: svn://10.0.0.236/trunk@188580 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-31 18:00:06 +00:00
brettw%gmail.com
4618ad2f22 Bug 320827, fix tree date picker in places.
git-svn-id: svn://10.0.0.236/trunk@188359 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-27 19:25:06 +00:00
brettw%gmail.com
0eac074024 Bug 324876, r=beng. Minor tree fixes for updated result.
git-svn-id: svn://10.0.0.236/trunk@188351 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-27 18:16:21 +00:00
brettw%gmail.com
1446e8ae8d Bug 323492 r=bryner,beng Places history result node refactor, dynamic updates, performance improvements.
git-svn-id: svn://10.0.0.236/trunk@188076 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-24 01:24:15 +00:00
beng%bengoodger.com
cdf23dfbfb save selection across delete operations (not done automatically by the view object)... , also restyle parts of the band across the top of the places view to make the content clearer.
git-svn-id: svn://10.0.0.236/trunk@187732 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-18 00:11:25 +00:00
beng%bengoodger.com
bb14f02244 rejigger places UI a bit, add a title bar across the top of the places view, adjust the default entries in the listbox, etc. also fix icons for generic queries and generic non-favicon pages. r=brettw for changes to the cpp. NPOB
git-svn-id: svn://10.0.0.236/trunk@187587 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-13 20:47:18 +00:00
brettw%gmail.com
8f9c380102 Bug 320422 r=annie.sullivan: Rename nav-history/nsINavHistory to nav-history-service/nsINavHistoryService
git-svn-id: svn://10.0.0.236/trunk@186143 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-16 00:40:48 +00:00
annie.sullivan%gmail.com
8e7ccad57f Added nsIBookmarksContainer interface which allows custom bookmarks types.
Implemented nsILivemarksService as a nsIBookmarksContainer.
bug=317837 r=beng sr=bryner


git-svn-id: svn://10.0.0.236/trunk@186125 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-15 20:56:18 +00:00
beng%bengoodger.com
6e6ee0f491 fix braindead js error in places.js r=bryner
git-svn-id: svn://10.0.0.236/trunk@186122 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-15 20:20:52 +00:00
beng%bengoodger.com
8f0cb1bfe2 Including 318809 - group by site/group by page is not sticky in places. r=annie
git-svn-id: svn://10.0.0.236/trunk@186056 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-14 18:29:41 +00:00
bryner%brianryner.com
81e9f7c99e Support read-only containers. Bug 320005, r=ben.
git-svn-id: svn://10.0.0.236/trunk@185972 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-12 21:03:04 +00:00