40 Commits

Author SHA1 Message Date
alexei.volkov.bugs%sun.com
60253eab1a 340218: Coverity 910, memory leaks in CRMF code. r=nelson
git-svn-id: svn://10.0.0.236/trunk@217787 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-05 00:00:50 +00:00
kaie%kuix.de
5994afe4a4 Bug 350200, Implement DHMAC based POP (ProofOfPossession)
r=rrelyea, r=nelson


git-svn-id: svn://10.0.0.236/trunk@212838 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-28 22:29:07 +00:00
kaie%kuix.de
dd2b511afd Bug 353422, Klocwork bugs in nss/lib/crmf
r=nelson, r=rrelyea
Patch inspired by Nelson


git-svn-id: svn://10.0.0.236/trunk@212394 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-26 18:58:22 +00:00
wtchang%redhat.com
8bf92cd8a2 Bugzilla Bug 349011: marked local functions as static. The patch is
contributed by timeless <timeless@bemail.org>. r=wtc.
Modified files: crmfcont.c crmfpop.c crmfreq.c


git-svn-id: svn://10.0.0.236/trunk@207880 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-18 22:21:34 +00:00
kaie%kuix.de
bb1a2e592b Bug 346551, init SECItem derTemp in crmf_encode_popoprivkey
r=wtchang


git-svn-id: svn://10.0.0.236/trunk@206745 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-07 20:02:59 +00:00
nelson%bolyard.com
50c4d8b146 Coverity bug 340217. Fix leak, crash, and failure to set error codes in
CMMF_POPODecKeyChallContDecryptChallenge. r=alexei.volkov


git-svn-id: svn://10.0.0.236/trunk@203058 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-19 00:45:31 +00:00
kaie%kuix.de
a09102e984 Bug 343682, crash in libcrmf with ecc
patch=rrelyea, r=kengert, r=nelson


git-svn-id: svn://10.0.0.236/trunk@202088 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-13 21:01:40 +00:00
alexei.volkov.bugs%sun.com
d19e8381e1 [Bug 337495] Double free in CRMF_CertReqMsgSetSignaturePOP (security/nss/lib/crmf/crmfpop.c) [Attachment 222949]. r=nelson
git-svn-id: svn://10.0.0.236/trunk@198216 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-22 22:38:56 +00:00
alexei.volkov.bugs%sun.com
b3983d98ac [Bug 337495] Double free in CRMF_CertReqMsgSetSignaturePOP (security/nss/lib/crmf/crmfpop.c). r=nelson
git-svn-id: svn://10.0.0.236/trunk@198206 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-22 21:46:14 +00:00
alexei.volkov.bugs%sun.com
1d9deeee9b [Bug 336482] crash or hopefully deadcode [@ crmf_copy_poposigningkey]
because Pointer "destPopoSignKey" dereferenced before NULL check. r=nelson


git-svn-id: svn://10.0.0.236/trunk@196597 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-15 21:05:20 +00:00
alexei.volkov.bugs%sun.com
fd5b7fc2d2 Patch contributed by timeless@bemail.org
[Bug 336481] oom crash [@ crmf_copy_cert_req_msg]


git-svn-id: svn://10.0.0.236/trunk@196439 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-13 00:03:40 +00:00
alexei.volkov.bugs%sun.com
107da61d56 [Bug 334274] double free in CRMF_EncryptedKeyGetEncryptedValue. r=nelson
git-svn-id: svn://10.0.0.236/trunk@195598 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-27 22:09:28 +00:00
alexei.volkov.bugs%sun.com
7c2de82fc1 Patch contributed by timeless@bemail.org
[Bug 334449] oom Crash in crmf_template_copy_secalg. r=nelson


git-svn-id: svn://10.0.0.236/trunk@195135 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-22 01:26:00 +00:00
kaie%kuix.de
f04215cac3 bug 331648, signed/unsigned bug submitting CRMF cert requests
r=rrelyea, sr=nelson


git-svn-id: svn://10.0.0.236/trunk@193808 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-07 11:41:18 +00:00
rrelyea%redhat.com
15e015d2c3 Bugzilla Bug 326503 producing a ProofOfPossession signature on a EC CRMF fails
Use SEC_GetSignatureAlgorithmOidTag() to map to the signature oid.
r=wtc


git-svn-id: svn://10.0.0.236/trunk@192451 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-15 21:46:24 +00:00
relyea%netscape.com
5ab6a977ba Bug 308887 CRMF request generation problem when using latest firefox
Add crmf tests to the test suite.


git-svn-id: svn://10.0.0.236/trunk@181226 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-29 21:36:42 +00:00
nelsonb%netscape.com
dd98e093ad Support GeneralizeTime in the CRMF library. Bug 219080. r=julien.
Patch by nelson and julien.


git-svn-id: svn://10.0.0.236/trunk@159898 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 05:06:02 +00:00
nelsonb%netscape.com
d4b84e4620 Ensure that the CRMF library always uses a non-null pool pointer when it
calls the ASN1 Decoder.  This prevents leaks.  Bug 178898. r=relyea.


git-svn-id: svn://10.0.0.236/trunk@159121 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-13 05:12:31 +00:00
nelsonb%netscape.com
d855fad3a6 Destroy cert references held inside the CMMFCertRepContent struct when
that struct is being destroyed.  Plugs a cert reference leak.
Bug 245420.  r=wtc.


git-svn-id: svn://10.0.0.236/trunk@158060 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-17 22:12:34 +00:00
nelsonb%netscape.com
ce769a7f15 Fix an erroneous assertion. Clean up some other code. Bug 244929.
r= jpierre, wtc.


git-svn-id: svn://10.0.0.236/trunk@157348 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-03 03:41:07 +00:00
gerv%gerv.net
43cb9e1492 Bug 236613: change to MPL/LGPL/GPL tri-license.
git-svn-id: svn://10.0.0.236/trunk@155484 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-25 15:03:26 +00:00
wchang0222%aol.com
c085f87be8 Bugzilla bug 229297: fixed compiler warning "conversion from 'double' to
'long', possible loss of data".  r=jpierre,relyea.


git-svn-id: svn://10.0.0.236/trunk@152676 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-11 19:43:29 +00:00
jpierre%netscape.com
262472f161 Patch for memory leak . Bug 189976 . r=wtc
git-svn-id: svn://10.0.0.236/trunk@137116 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-30 02:59:35 +00:00
nelsonb%netscape.com
d36cf9c052 Support SHA256, SHA384, and SHA512 hashes in NSS.
git-svn-id: svn://10.0.0.236/trunk@135163 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-12 06:05:45 +00:00
nicolson%netscape.com
4b34ca8158 Fix 164126: makefile build error.
Change the NSS module name from "security" to "nss".


git-svn-id: svn://10.0.0.236/trunk@128961 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-06 16:38:56 +00:00
bishakhabanerjee%netscape.com
ad64d0f773 Checking in riceman+bmo@mail.rit.edu's patch for bug 133702
git-svn-id: svn://10.0.0.236/trunk@126064 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-30 18:49:46 +00:00
ian.mcgreer%sun.com
2bda604c43 bug 141355, CERT_DecodeDERCertificate is not a safe function for some uses, must be replaced with CERT_NewTempCertificate.
git-svn-id: svn://10.0.0.236/trunk@120556 18797224-902f-48f8-a5cc-f745e15eee43
2002-05-02 19:00:13 +00:00
wtc%netscape.com
0ecadf23c7 Bugzilla bug 123938: renamed cert_EncodeGeneralName to
CERT_EncodeGeneralName.  Export CERT_EncodeGeneralName and
CERT_FindKeyUsageExtension from nss.def.  Have cmmfrec.c include
nssrenam.h to get __CERT_NewTempCertificate.
Modified Files:
	lib/certdb/genname.c lib/certdb/genname.h lib/certdb/xconst.c
	lib/crmf/cmmfchal.c lib/crmf/cmmfrec.c lib/nss/nss.def


git-svn-id: svn://10.0.0.236/trunk@114469 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-14 02:25:21 +00:00
relyea%netscape.com
3062b0e3b5 Fix dual key generation crash.
git-svn-id: svn://10.0.0.236/trunk@111902 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-11 00:33:08 +00:00
relyea%netscape.com
f3abd8769b nssren.h needs to be included first in the header file or AIX will fail.
git-svn-id: svn://10.0.0.236/trunk@110028 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-07 21:32:05 +00:00
relyea%netscape.com
c70f425fc3 restore NSS rename to those files that need it.
git-svn-id: svn://10.0.0.236/trunk@110026 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-07 21:13:08 +00:00
wtc%netscape.com
f4db2e0924 Bugzilla bug 111293: the inclusion of "nssrenam.h" in this file breaks
the NSS build (on 64-bit AIX).  I am backing it out.


git-svn-id: svn://10.0.0.236/trunk@108782 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-22 02:27:57 +00:00
relyea%netscape.com
e31243d81f changes for PSM to compile against NSS shared libraries.
Move SSL and S/MIME to the new common MAPFILE usage


git-svn-id: svn://10.0.0.236/trunk@108708 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-21 18:00:28 +00:00
relyea%netscape.com
fbaa312653 Fix compiler errors on HP, Linux, AIX, and Solaris
git-svn-id: svn://10.0.0.236/trunk@103372 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-20 22:16:25 +00:00
javi%netscape.com
00f933ba45 Update the CRMF templates so that the ASN.1 encoder correctly
encodes optional fields that have sub-templates that may
potentially stream.  This will fix PSM Bug 92502


git-svn-id: svn://10.0.0.236/trunk@100330 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-03 22:26:25 +00:00
wtc%netscape.com
9e6c133c84 Bugzilla bug #63768: removed references to the obsolete PURE_LIBRARY,
HAVE_PURIFY etc. make variables in NSS files.  Reviewed by nelson Bolyard.
Modified Files:
	cmd/platrules.mk cmd/crmf-cgi/config.mk cmd/crmftest/config.mk
	cmd/lib/config.mk cmd/zlib/config.mk lib/base/config.mk
	lib/certdb/config.mk lib/certhigh/config.mk lib/ckfw/config.mk
	lib/crmf/config.mk lib/cryptohi/config.mk
	lib/fortcrypt/swfort/config.mk lib/freebl/config.mk
	lib/jar/config.mk lib/nss/config.mk lib/pk11wrap/config.mk
	lib/pkcs12/config.mk lib/pkcs7/config.mk lib/smime/config.mk
	lib/softoken/config.mk lib/ssl/config.mk lib/util/config.mk


git-svn-id: svn://10.0.0.236/trunk@86029 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-02 01:49:57 +00:00
wtc%netscape.com
a620d900b4 Bugzilla bug #65416: assign values explicitly to enumeration constants.
The same values that the compiler would assign are assigned, with only
one exception (cmmfNoPKIStatus in cmmft.h).  This is patch id=22555,
reviewed by Nelson Bolyard.


git-svn-id: svn://10.0.0.236/trunk@85087 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-18 16:36:43 +00:00
nelsonb%netscape.com
bb7974ac11 MSVC won't let you initialize a pointer in a data structure with the
address of an external variable that comes from another DLL.
This is a fundamental difference between WIN32 DLLs and Unix DSOs.
So, for every SEC_ASN1Template inside of libnss3 that is referenced by
other templates outside of libnss3, a new "chooser" function was created
that returns the address of that template.  For WIN32, the templates
outside of libnss3 access libnss3's templates by the chooser function
rather than by direct reference.  Some simple macros allow Unix to
continue to use direct references, avoiding the extra function calls.
With these changes, all.sh (qa script) passes all tests on NT with DLLs.
Modified Files:
	cmd/checkcert/checkcert.c cmd/lib/secutil.c lib/asn1/asn1t.h
	lib/certdb/certdb.c lib/certdb/certt.h lib/certdb/crl.c
	lib/certhigh/certreq.c lib/crmf/asn1cmn.c lib/crmf/crmfcont.c
	lib/crmf/crmftmpl.c lib/cryptohi/secsign.c lib/nss/nss.def
	lib/pkcs12/p12local.c lib/pkcs12/p12tmpl.c
	lib/pkcs7/certread.c lib/pkcs7/p7decode.c lib/pkcs7/p7local.c
	lib/smime/cmsasn1.c lib/smime/cmsattr.c lib/smime/cmspubkey.c
	lib/smime/cmssigdata.c lib/smime/smimeutil.c
	lib/softoken/keydb.c lib/softoken/keydbt.h lib/util/secalgid.c
	lib/util/secasn1.h lib/util/secasn1d.c lib/util/secasn1t.h
	lib/util/secasn1u.c lib/util/secdig.c lib/util/secdig.h
	lib/util/secoid.h


git-svn-id: svn://10.0.0.236/trunk@84523 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-07 08:13:13 +00:00
nelsonb%netscape.com
6da659e535 Eliminate some warnings by adding missing #include lines, or other minor
cleanup.


git-svn-id: svn://10.0.0.236/trunk@84522 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-07 07:56:35 +00:00
relyea%netscape.com
a4d4d45374 Initial NSS Open Source checkin
git-svn-id: svn://10.0.0.236/trunk@64788 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-31 20:13:40 +00:00