122 Commits

Author SHA1 Message Date
jst%mozilla.jstenback.com
6549a2f006 Fixing last part of bug 68215, making FireFox play nicely with the onbeforeunload event too. r+sr=ben@bengoodger.com
git-svn-id: svn://10.0.0.236/trunk@152968 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-19 21:52:31 +00:00
chanial%noos.fr
5e85bf7a28 bug 231824: the bookmarks toolbar folder should be indelible.
git-svn-id: svn://10.0.0.236/trunk@151735 18797224-902f-48f8-a5cc-f745e15eee43
2004-01-23 06:38:54 +00:00
chanial%noos.fr
ac8b33b036 dumpDOM debug function (not shipped) now accepts ID in addition to DOM elements.
git-svn-id: svn://10.0.0.236/trunk@150460 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-19 02:03:29 +00:00
chanial%noos.fr
8180176881 Bug 181033: add a "New Folder" button to the add bookmark dialog
git-svn-id: svn://10.0.0.236/trunk@150290 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-14 10:43:43 +00:00
chanial%noos.fr
f50e155f66 Bug 228040: make the add bookmark dialog resizable.
I didn't noticed that because linux doesn't honor the option "resizable=no".
Patch by Steffen Wilberg, r=me.


git-svn-id: svn://10.0.0.236/trunk@150211 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-11 12:53:30 +00:00
chanial%noos.fr
7334052172 on going work on bug 214527: add folder icons to the menulist.
git-svn-id: svn://10.0.0.236/trunk@150187 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-10 14:45:37 +00:00
chanial%noos.fr
2ac867e980 Landing new add bookmark dialog (bug 214527).
Featuring an expandable tree and a dropdown menu containing the last used folders.
The 'new folder' functionality has not been included, yet.
Thanks to bz for the help on nsCOMArrays.


git-svn-id: svn://10.0.0.236/trunk@150142 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-08 16:30:28 +00:00
varga%nixcorp.com
5c72286e7b Checking in for Jungshik Shin.
Fix for bug 195093. 'modernize'  nsILocale and nsIPlatformCharset.
r=smontagu sr=darin


git-svn-id: svn://10.0.0.236/trunk@148567 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-30 15:08:48 +00:00
chanial%noos.fr
00a6832942 - Rewrite the way we handle print preview so that it can be used in any XUL app. This is achieved by adding a new "public" method to PrintUtils:
PrintUtils.printPreview(enterPPCallback, exitPPCallback) where the optional callback functions are called just before entering and after exiting PP mode

- disable all short keys in PP mode except ctrl-W and fix bug 178485 and bug 215277. Now clicking the close window icon actually closes the window.

- global vars gPrintSettingsAreGlobal, gSavePrintSettings, gPrintSettings, gOldCloseHandler, gInPrintPreviewMode, gWebProgress are removed.

- A lot of cleanup.


git-svn-id: svn://10.0.0.236/trunk@148474 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-29 08:01:27 +00:00
chanial%noos.fr
429ee9db25 - add new debug routine dumpDOM that writes the DOM tree under a given element.
- enhance dumpOBJ debug routine to deal with null and properties not accessible that trigger an error
- enclose all the debug routine by a #ifdef DEBUG


git-svn-id: svn://10.0.0.236/trunk@148271 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-22 07:57:34 +00:00
chanial%noos.fr
29b34a142a removing comm.jar dependencies in the bookmarks component. Escape close the window and fix for bug 168412.
Also remove the bookmark edit command (ex: cmd_bm_paste) and use the edit ones instead (ex: cmd_paste)


git-svn-id: svn://10.0.0.236/trunk@147945 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-14 05:20:35 +00:00
chanial%noos.fr
19b7d720d7 fix regression from last checkin (bug 221667)
git-svn-id: svn://10.0.0.236/trunk@147796 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-09 12:08:44 +00:00
chanial%noos.fr
fb4929d722 - fix regression 221118: Can't drag links into bookmark manager or bookmark sidebar.
- logic change: a transaction will not be performed when one of its item can not be acted on. Before, the only the valid items were processed. A LOT of simplifications have come up. I am slowly moving toward the resolution of bug 168411, by simplifying the interface that will be needed to move the transactions to the bookmarks service.
- fix bug 221550: the selection is not retained when performing an invalid transaction
- no need to restore the selection after an action that doesn't touch the datasource.
- during a batch, the bookmarks toolbar observer wasn't notified.
- much faster preUpdateTreeSelection
- various code cleanup
- DND bookmarks in tree is now significantly faster.
- still need to figure out what is the best BATCH_LIMIT value.


git-svn-id: svn://10.0.0.236/trunk@147752 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 09:01:48 +00:00
chanial%noos.fr
21d5f7a905 checking in back the fix for bug 172113.
an additional fix is included: if no ...#BookmarksToolbarFolder arc is found, then search for an (obsolete) resource "NC:PersonalToolbarFolder" (221410).
When none of them is found, then a new btf is created (only once!).


git-svn-id: svn://10.0.0.236/trunk@147747 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 08:17:23 +00:00
chanial%noos.fr
9ae0c6a598 For the next cycles: backing out the changes for bug 172113 to investigate perf because I landed them just after the tinderbox went down and also because large landings occurred before it went up.
git-svn-id: svn://10.0.0.236/trunk@147740 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 04:45:29 +00:00
chanial%noos.fr
25c51f48de - bug 172113: rewrite the way we handle the bookmarks toolbar folder. Now, there is no more 2 ways to characterize the BTF: by an arc to the resource "...#BookmarksToolbarFolder" that points to the literal "true". As a consequence, the resource NC:PersonalToolbarFolder and "...#folderType" are dead.
- remove unused functions. Note that RDF commands were already broken, so deleteBookmarkItem and insertBookmarkItem (that were not used) may come back, but in another form.
- remove the "New Bookmark Folder" and "New Search Folder"
- refactor the "html" serializer to avoid some duplicated code.
- remove the use of the profile name for the bookmarks root.
- enforce synthax "aArgument" in some random places.


git-svn-id: svn://10.0.0.236/trunk@147534 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-03 20:30:14 +00:00
chanial%noos.fr
d58dde0628 - code level cleaning up of bookmarksProperties.js
- fixing a potential crash in nsBookmarksService::GetTarget (when the RDF resource is null)
- remove unused function isChildOfContainer and GetResource in bookmarks.js though we may need later the latter.


git-svn-id: svn://10.0.0.236/trunk@147460 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-30 16:16:56 +00:00
chanial%noos.fr
2c309d455c - adding bookmark/separator in the bookmark manager now calls the property dialog for consistency with the folders.
- fix the use of the immutable bookmarks.
- remove unused methods: GetLastCharset and AddBookmarkImmediately
- porting several small fixes mainly from Jan's work
- more prototyping for BookmarkTransaction


git-svn-id: svn://10.0.0.236/trunk@147445 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-29 21:43:11 +00:00
hyatt%mozilla.org
24dfd9146a Make cmd+click work to open new tabs. Make cmd+number work to switch tabs. Mac OS X only.
git-svn-id: svn://10.0.0.236/trunk@145609 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-05 09:31:32 +00:00
hyatt%mozilla.org
c3b1369976 Separate the Page Holder concept from sidebar bookmarks.
git-svn-id: svn://10.0.0.236/trunk@145523 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-04 03:40:27 +00:00
hyatt%mozilla.org
6b0d40ba1a Implement the Add Page button in the Web Panels sidebar.
git-svn-id: svn://10.0.0.236/trunk@145508 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-03 08:25:19 +00:00
hyatt%mozilla.org
dd62007e24 Implement support for Web Panel bookmarks.
git-svn-id: svn://10.0.0.236/trunk@145503 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-03 01:58:52 +00:00
noririty%jcom.home.ne.jp
ba2224f002 Fix 212412 - remove unused findbookmark function
git-svn-id: svn://10.0.0.236/trunk@145057 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-22 14:17:24 +00:00
chanial%noos.fr
03837e0a60 remove safe guard and allow now to copy a bookmark in the folder in which it is contained.
git-svn-id: svn://10.0.0.236/trunk@141767 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-24 22:07:17 +00:00
chanial%noos.fr
88582fb263 bug 200480: cut/paste doesn't work on folders and separators
git-svn-id: svn://10.0.0.236/trunk@141763 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-24 21:46:55 +00:00
chanial%noos.fr
d2465b826e re-hook the undo/redo menu listeners
git-svn-id: svn://10.0.0.236/trunk@141702 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 18:08:25 +00:00
chanial%noos.fr
eaf5d01d31 dropping folder group support
git-svn-id: svn://10.0.0.236/trunk@141695 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 15:05:10 +00:00
chanial%noos.fr
401b35e3b4 bug 202879: importing and exporting bookmarks are broken + code clean up
git-svn-id: svn://10.0.0.236/trunk@141693 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 14:10:49 +00:00
chanial%noos.fr
8a6ef3a30e porting bug 174197, font error when link bookmarked
git-svn-id: svn://10.0.0.236/trunk@141566 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-22 02:59:58 +00:00
chanial%noos.fr
bb48f9fed0 1) porting back in phoenix a refactoring I made in seamonkey wrt loading bookmarks
2) no context menus on the static menu items. (original patch by Chu Alan)


git-svn-id: svn://10.0.0.236/trunk@141527 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-21 20:11:58 +00:00
chanial%noos.fr
c7c6082125 getting back phoenix bookmarks in sync with seamonkey
first step to clean the 'add bookmark' mess (removing a flag because we always show the dialog, and moving addBookmarkFor*Browser in browser.js where it belong)


git-svn-id: svn://10.0.0.236/trunk@141506 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-21 05:47:02 +00:00
varga%netscape.com
05113f3b0d IsBookmarked -> isBookmarked
git-svn-id: svn://10.0.0.236/trunk@140359 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-26 22:14:35 +00:00
varga%netscape.com
abacf67d41 Updating JS to the latest nsIBookmarksService API.
git-svn-id: svn://10.0.0.236/trunk@140358 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-26 22:13:13 +00:00
chanial%noos.fr
44c80338cc fix middle click regression in the bookmarks menus
git-svn-id: svn://10.0.0.236/trunk@138380 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-24 22:11:11 +00:00
chanial%noos.fr
f45e0cec4a ooops... backing out. I did not intend to check this in.
git-svn-id: svn://10.0.0.236/trunk@137077 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-29 08:39:01 +00:00
chanial%noos.fr
503d8b81ae fix a stupid js warning
git-svn-id: svn://10.0.0.236/trunk@137076 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-29 07:47:30 +00:00
ben%netscape.com
a153bf466f Fixing bug 172025, "Cancelling a creation of new bookmark folder still leaves a folder called New Folder"
git-svn-id: svn://10.0.0.236/trunk@136975 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-27 06:44:11 +00:00
chanial%noos.fr
b3606d14d1 bookmark cleanup. make clear the distinction between target and selection in trees.
now, insertion on a folder doesn't append but inserts before it.
Allow multiple selection of bookmarks and folders for the home pages.


git-svn-id: svn://10.0.0.236/trunk@135268 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-13 23:06:10 +00:00
chanial%noos.fr
3224abe735 bug 177837: remove help menu in bookmark manager and view source window
git-svn-id: svn://10.0.0.236/trunk@132811 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-01 04:28:57 +00:00
chanial%noos.fr
d24a94210b fix various DND/copy bookmark/folder issues
git-svn-id: svn://10.0.0.236/trunk@132747 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-31 01:30:43 +00:00
chanial%noos.fr
7e167cabce fix some focus issues
git-svn-id: svn://10.0.0.236/trunk@132562 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-26 16:53:19 +00:00
chanial%noos.fr
1784c82911 some cleanup
git-svn-id: svn://10.0.0.236/trunk@132400 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-23 11:56:40 +00:00
chanial%noos.fr
745ed7eb07 don't override single tab when pref is 'append'
git-svn-id: svn://10.0.0.236/trunk@132399 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-23 10:57:20 +00:00
chanial%noos.fr
89869fab2a fix middle-click in bookmarks
+ make it honour the pref


git-svn-id: svn://10.0.0.236/trunk@132313 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-20 08:55:17 +00:00
blakeross%telocity.com
4c375a0621 fix a bug in bookmarks.
git-svn-id: svn://10.0.0.236/trunk@132294 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-19 23:05:59 +00:00
blakeross%telocity.com
2c137d7943 Some modifier cleanup; fix load in background pref.
git-svn-id: svn://10.0.0.236/trunk@132289 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-19 19:38:57 +00:00
hyatt%netscape.com
0ede43e8ae Just to keep everyone guessing, inverting ctrl and shift. ctrl is new tab, shift is new window.
git-svn-id: svn://10.0.0.236/trunk@132284 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-19 01:21:57 +00:00
hyatt%netscape.com
8cc6e5fb7b Implement CTRL+enter www/com completion in the URL bar.
git-svn-id: svn://10.0.0.236/trunk@132262 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-18 20:30:53 +00:00
bryner%netscape.com
88bc5fe693 fixing redeclared variable warning
git-svn-id: svn://10.0.0.236/trunk@132229 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-18 09:58:28 +00:00
chanial%noos.fr
ceb727cc21 use of RDFC Utils methods + fix target check issue
git-svn-id: svn://10.0.0.236/trunk@132198 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-18 00:06:48 +00:00