65 Commits

Author SHA1 Message Date
lpsolit%gmail.com
bc4b75a0c3 Bug 271596: editcomponents priv allows you to see/edit products you don't have access to - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@185946 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-12 03:12:26 +00:00
lpsolit%gmail.com
64f1a95f02 Bug 304075: Eliminate use of $::userid from Bugzilla - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@183259 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-30 21:31:29 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
mkanat%kerio.com
f9d408a8ea Bug 309749: Remove get_x_by_y functions from the new .pm files, in favor of object methods
Patch By André Batosti <batosti@async.com.br> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@181718 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-06 18:45:46 +00:00
lpsolit%gmail.com
529ea73dda Bug 304696: Replace UserInGroup() by $user->in_group() when checking user privs in edit*.cgi files - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@180314 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-15 22:01:56 +00:00
lpsolit%gmail.com
dcefae32a9 Bug 301743: Replace old code from editcomponents.cgi by methods and routines from Component.pm and Product.pm - Patch by Tiago R. Mello <timello@gmail.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@179753 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-06 23:54:00 +00:00
lpsolit%gmail.com
5a6f33a74e Bug 189635: editcomponents.cgi should use user-matching for the default assignee and QA contact - Patch by GavinS <bugzilla@chimpychompy.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@178638 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-22 21:45:32 +00:00
mkanat%kerio.com
0cbbdcfee7 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
bugreport%peshkin.net
9778732be8 Backout of bug 303669 which broke AppendComment and possibly a number
of other items.


git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
lpsolit%gmail.com
9e4a52fdf0 Bug 86328: Deleting bugs doesn't delete dependent records properly - Patch by Frederic Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@171752 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-06 00:19:56 +00:00
mkanat%kerio.com
833b2e61f6 Bug 286235: Implicit joins should be replaced by explicit joins - installment A
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:52:06 +00:00
mkanat%kerio.com
a7459fc221 Bug 287483: Sanitycheck screams about "Bad value 0 found in components.initialqacontact"
Patch By Teemu Mannermaa <wicked@etlicon.fi> r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@171607 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:40:58 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
mkanat%kerio.com
64adf228bd Bug 284975: Any code after Throw*Error is a dead code.
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170414 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 00:26:39 +00:00
mkanat%kerio.com
7f1a179da7 Bug 277782: _throw_error should unlock tables when tables are locked, automatically
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=travis, r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170180 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 00:18:48 +00:00
mkanat%kerio.com
f7471cbb97 Bug 283237: Move DBname_to_id out of globals.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@169799 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:42:48 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
travis%sedsystems.ca
34a792676d Bug 281574 : Combine version_/milestone_/component_no_action errors into one.
Patch by Shane H. W. Travis <travis@sedsystems.ca>   r=LpSolit  a=myk


git-svn-id: svn://10.0.0.236/trunk@169255 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 16:35:54 +00:00
jocuri%softhome.net
6e30566dcd Patch for bug 265898: edit*.cgi files should all use ThrowUserError(); patch by Frédéric Buclin <LpSolit@gmail.com>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167820 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 14:07:31 +00:00
gerv%gerv.net
7633e9d6ae Bug 225687 - add group controls to charts, along with various other cleanups. Patch by gerv; r=joel, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@161457 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-29 21:29:36 +00:00
jocuri%softhome.net
ed3a25a2c3 Patch for bug 190220: templatize editcomponents.cgi; patch by GavinS <bugzilla@chimpychompy.org>; r=jouni, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160154 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-30 22:16:39 +00:00
bugreport%peshkin.net
3f5ac54b70 Bug 252450: Unlock tables in edit*.cgi before sending trailer
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159908 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 15:13:48 +00:00
timeless%mozdev.org
bfc495857e Bug 242405 Turning on QA contact causes taint error in Bugzilla/Series.pm when adding a component
patch by bugzilla@glob.com.au r=joel a=justdave


git-svn-id: svn://10.0.0.236/trunk@158939 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-09 03:33:58 +00:00
jouni%heikniemi.net
02eb0122e5 Bug 141006: Run edit*.cgis in taint mode.
Patch by byron jones <bugzilla@glob.com.au>
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@156794 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-23 07:22:32 +00:00
justdave%syndicomm.com
62d042aa7a Bug 235265: Getting rid of some unwanted form value dumps.
Patch by Jouni Heikniemi <jouni@heikniemi.net>
r= justdave, kiko; a= justdave


git-svn-id: svn://10.0.0.236/trunk@154332 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 04:35:37 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
gerv%gerv.net
950519fd33 Bug 227771 - Migration and product/component create code no longer writes series to database. Patch by gerv; r=kiko, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@150156 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-08 23:13:35 +00:00
bbaetz%acm.org
8fabd677ea Bug 208604 - Make data/template dir locations configurable
git-svn-id: svn://10.0.0.236/trunk@149624 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-22 03:50:42 +00:00
jocuri%softhome.net
3970a6befe Bug 65320: Extra options on editproducts.cgi & editcomponents.cgi; r=jouni; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@149401 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-16 09:30:07 +00:00
gerv%gerv.net
9dd361788f Bug 222564 - The chart made when creating a new Product/Component is not public. Patch by gerv; r=kiko, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@149029 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-08 00:25:31 +00:00
kiko%async.com.br
ad61d77b76 Bug 65316: Typos on edit*.cgi. Change use of PutTrailer() (and the
default output, in certain cases) in the edit pages. Patch by Vlad
Dascalu <jocuri@softhome.net>, r=kiko, a=justdave


git-svn-id: svn://10.0.0.236/trunk@147351 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-26 23:47:07 +00:00
gerv%gerv.net
bbe9d17dd1 Bug 16009 - generic charting. Patch by gerv; r,a=justdave.
git-svn-id: svn://10.0.0.236/trunk@144165 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-25 23:23:13 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
bbaetz%acm.org
4d7be3da2f Bug 197180 - Long comment names not flagged as an error
r,a=justdave


git-svn-id: svn://10.0.0.236/trunk@139557 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-16 06:16:43 +00:00
myk%mozilla.org
393a392d87 Fix for bug 98801: Implementation of the request tracker, a set of enhancements to attachment statuses.
r=gerv,bbaetz


git-svn-id: svn://10.0.0.236/trunk@130672 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-28 18:42:54 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
bbaetz%student.usyd.edu.au
1c2ecdc9c2 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127057 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-12 05:43:05 +00:00
jouni%heikniemi.net
a803887481 Bug 145795: editcomponents had error messages referring to products where it should've been components.
r=bbaetz,afranke


git-svn-id: svn://10.0.0.236/trunk@124677 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-04 11:13:50 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-17 09:39:48 +00:00
bbaetz%student.usyd.edu.au
4e72d39123 Bug 148712 - add component with error/invalid initial owner results in
double header output
patch by stu@xanboo.com (Stu Tomlinson), r=jouni, bbaetz


git-svn-id: svn://10.0.0.236/trunk@123384 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-15 05:35:59 +00:00
gerv%gerv.net
33a5971d2a Bug 140784 - edit*.cgi need a use lib "." on Win32/IIS w/ taint. Patch by jouni@heikniemi.net; r=bbaetz, gerv.
git-svn-id: svn://10.0.0.236/trunk@120207 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-29 19:32:29 +00:00
bbaetz%student.usyd.edu.au
b503102b3d Bug 106377 - processmail rescanall should use lastdiffed
r=justdave, ddkilzer@theracingworld.com


git-svn-id: svn://10.0.0.236/trunk@115685 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-03 22:06:20 +00:00
justdave%syndicomm.com
40ab41ff77 Fix for bug 14461: QA contact is no longer required. You can still leave it blank in editing and creating components if you
want, even if it's enabled now.  This is consistant with the behavior of this field everywhere else in Bugzilla now.
Eventually this will be a per-product setting whether to enforce having one or not.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x 2


git-svn-id: svn://10.0.0.236/trunk@113584 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 00:41:40 +00:00
justdave%syndicomm.com
d27f46ad1e Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@105335 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 01:36:17 +00:00
myk%mozilla.org
e970365251 Fix for bug #53612: The milestone URL appears correctly when deleting a product or a component.
Patch by Jake <jake@acutex.net>.
r=gerv@mozilla.org,myk@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@104021 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-27 23:49:07 +00:00
jake%acutex.net
c88b002e96 Fix for bug 71396 - $::db->do isn't needed anymore
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97282 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-16 14:51:16 +00:00
cyeh%bluemartini.com
d9a28fb8af fix for 66876: Using userids (mediumint) for initialowner and initialqacontact
based on patch submitted by baulig@suse.de (Martin Baulig).


git-svn-id: svn://10.0.0.236/trunk@87678 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-22 18:11:29 +00:00