44 Commits

Author SHA1 Message Date
lpsolit%gmail.com
ffe784ec2f Bug 238780: editversions.cgi should reject newline characters - Patch by Paul <pdemarco@zoominternet.net> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@186732 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-29 22:56:01 +00:00
lpsolit%gmail.com
962762ac28 Backing out bug 238780 (Edit versions should reject newline characters) - This patch prevents you to edit or delete existing versions having control characters.
git-svn-id: svn://10.0.0.236/trunk@186449 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-22 21:45:07 +00:00
lpsolit%gmail.com
bc4b75a0c3 Bug 271596: editcomponents priv allows you to see/edit products you don't have access to - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@185946 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-12 03:12:26 +00:00
lpsolit%gmail.com
0bd2893b1c Bug 238780: editversions.cgi should reject newline characters (and convert them to whitespaces) - Patch by Paul <pdemarco@ppg.com> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@185794 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-08 08:55:42 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
mkanat%kerio.com
f9d408a8ea Bug 309749: Remove get_x_by_y functions from the new .pm files, in favor of object methods
Patch By André Batosti <batosti@async.com.br> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@181718 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-06 18:45:46 +00:00
lpsolit%gmail.com
760b2a0af5 Bug 307604: "Redisplay table with bug counts" should also be available from editmilestones.cgi and editversions.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=GavinS a=justdave
git-svn-id: svn://10.0.0.236/trunk@181080 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-27 22:08:14 +00:00
lpsolit%gmail.com
529ea73dda Bug 304696: Replace UserInGroup() by $user->in_group() when checking user privs in edit*.cgi files - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@180314 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-15 22:01:56 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
lpsolit%gmail.com
8c070283cf Bug 300532: Update editversions.cgi to use routines from Version.pm and Product.pm - Patch by Tiago R. Mello <timello@async.com.br> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@176230 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-19 00:05:11 +00:00
lpsolit%gmail.com
9e4a52fdf0 Bug 86328: Deleting bugs doesn't delete dependent records properly - Patch by Frederic Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@171752 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-06 00:19:56 +00:00
travis%sedsystems.ca
7351a5b76b Bug 283581 : Move UserInGroup out of globals.pl
Patch by Colin Ogilvie <colin.ogilvie@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170734 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 22:10:14 +00:00
mkanat%kerio.com
64adf228bd Bug 284975: Any code after Throw*Error is a dead code.
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170414 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 00:26:39 +00:00
mkanat%kerio.com
7f1a179da7 Bug 277782: _throw_error should unlock tables when tables are locked, automatically
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=travis, r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170180 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 00:18:48 +00:00
mkanat%kerio.com
a88c76e484 Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk


git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
travis%sedsystems.ca
34a792676d Bug 281574 : Combine version_/milestone_/component_no_action errors into one.
Patch by Shane H. W. Travis <travis@sedsystems.ca>   r=LpSolit  a=myk


git-svn-id: svn://10.0.0.236/trunk@169255 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 16:35:54 +00:00
travis%sedsystems.ca
81f64817cf Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>  r=mkanat, LpSolit   a=justdave


git-svn-id: svn://10.0.0.236/trunk@168981 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:51:03 +00:00
justdave%bugzilla.org
2541fed321 Backing out the checking from bug 257315 until it gets corrected. It prevents new bugs from being filed.
a=justdave


git-svn-id: svn://10.0.0.236/trunk@168520 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-30 04:22:28 +00:00
travis%sedsystems.ca
e652a2da94 Bug 257315 : type of delta_ts in bugs table should not be timestamp
Patch by Tomas Kopal <Tomas.Kopal@altap.cz>   r=vladd, LpSolit  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168456 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-28 19:01:28 +00:00
travis%sedsystems.ca
759e270b07 Bug 278650 : editversions.cgi still uses "auth_cant_edit_versions"
Patch by Frederic Buclin <LpSolit@gmail.com>  r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168410 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-27 19:50:25 +00:00
jocuri%softhome.net
b04735457b Patch for bug 190226: templatize editversions.cgi; patch by GavinS <bugzilla@chimpychompy.org>, r=jouni, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167818 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:48:25 +00:00
bugreport%peshkin.net
3f5ac54b70 Bug 252450: Unlock tables in edit*.cgi before sending trailer
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159908 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 15:13:48 +00:00
jouni%heikniemi.net
02eb0122e5 Bug 141006: Run edit*.cgis in taint mode.
Patch by byron jones <bugzilla@glob.com.au>
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@156794 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-23 07:22:32 +00:00
jocuri%softhome.net
331a4124dc Patch for bug 238860: remove %FORM from editversions.cgi; patch by Teemu Mannermaa <wicked@etlicon.fi>; r=justdave; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154338 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 20:07:25 +00:00
justdave%syndicomm.com
62d042aa7a Bug 235265: Getting rid of some unwanted form value dumps.
Patch by Jouni Heikniemi <jouni@heikniemi.net>
r= justdave, kiko; a= justdave


git-svn-id: svn://10.0.0.236/trunk@154332 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 04:35:37 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
bbaetz%acm.org
8fabd677ea Bug 208604 - Make data/template dir locations configurable
git-svn-id: svn://10.0.0.236/trunk@149624 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-22 03:50:42 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
timeless%mozdev.org
54125fd66d Bug 65319 editmilestones & editversions don't have extra add.
r=justdave a=justdave


git-svn-id: svn://10.0.0.236/trunk@140437 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-30 02:46:21 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
bbaetz%student.usyd.edu.au
1c2ecdc9c2 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127057 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-12 05:43:05 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-17 09:39:48 +00:00
gerv%gerv.net
33a5971d2a Bug 140784 - edit*.cgi need a use lib "." on Win32/IIS w/ taint. Patch by jouni@heikniemi.net; r=bbaetz, gerv.
git-svn-id: svn://10.0.0.236/trunk@120207 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-29 19:32:29 +00:00
bbaetz%student.usyd.edu.au
b503102b3d Bug 106377 - processmail rescanall should use lastdiffed
r=justdave, ddkilzer@theracingworld.com


git-svn-id: svn://10.0.0.236/trunk@115685 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-03 22:06:20 +00:00
justdave%syndicomm.com
d27f46ad1e Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@105335 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 01:36:17 +00:00
jake%acutex.net
9307fd5a8a Refixing bug 71396. Each PushGlobalSQLState() needs a PopGlobalSQLState() and this file instead had two "pushes".
git-svn-id: svn://10.0.0.236/trunk@97393 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-19 01:37:02 +00:00
jake%acutex.net
c88b002e96 Fix for bug 71396 - $::db->do isn't needed anymore
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97282 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-16 14:51:16 +00:00
cyeh%bluemartini.com
53b0e2dfbe fix for 44617: edit*.cgi: Should show which product you're working on
patches by mtakacs@pacbell.net (Tak)


git-svn-id: svn://10.0.0.236/trunk@77688 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-30 23:44:36 +00:00
terry%mozilla.org
b541dc2d83 Patch by Ramon Felciano <felciano@ingenuity.com>, with many tweaks by
me.  Added a footer to every page.  Add some options to do things like
display checkboxes instead of scrolling lists, and a new formatting
for email diffs, and show list items capitalized instead of all upper
case.


git-svn-id: svn://10.0.0.236/trunk@57846 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-14 22:35:49 +00:00
terry%mozilla.org
faff995f1c Fixed very very nasty bug which, when deleting a component, would tell
you it had no bugs (even when it had some), and would then proceed to
delete all those bugs (even if you had the param set to never allow
bug deletion.)  Added some paranoia to prevent such things from
happening again.  Yikes.


git-svn-id: svn://10.0.0.236/trunk@56135 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-17 03:41:13 +00:00
dmose%mozilla.org
03ec794132 updated license boilerplate
git-svn-id: svn://10.0.0.236/trunk@52443 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-01 23:33:56 +00:00
terry%mozilla.org
d1fca29577 Need to value_quote() things that go into VALUE attributes in HTML.
git-svn-id: svn://10.0.0.236/trunk@51183 18797224-902f-48f8-a5cc-f745e15eee43
1999-10-19 21:27:41 +00:00
terry%mozilla.org
100e540599 Patch by Holger Schurig <holger@holger.om.org> -- rewriting and enhancing the
ability to edit components, products, and versions.  Yay!


git-svn-id: svn://10.0.0.236/trunk@50498 18797224-902f-48f8-a5cc-f745e15eee43
1999-10-12 23:00:35 +00:00