80 Commits

Author SHA1 Message Date
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
25b4d9f717 Bug 286158: Remove GetSelectableProducts() from globals.pl and use Bugzilla::User::get_selectable_products() instead - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel,kiko a=justdave
git-svn-id: svn://10.0.0.236/trunk@179575 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-02 21:12:10 +00:00
lpsolit%gmail.com
ec2341ffdf Bug 298306: For new products, the charting error message "The tool which gathers bug counts has not been run yet" is misleading - Patch by Marc Schumann <wurblzap@gmail.com> r=gerv a=myk
git-svn-id: svn://10.0.0.236/trunk@179509 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-01 21:52:20 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
lpsolit%gmail.com
8af771d90f Bug 303303: Data aren't displayed in old charts when the product is closed for new bug entry - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave
git-svn-id: svn://10.0.0.236/trunk@177102 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-04 16:06:36 +00:00
lpsolit%gmail.com
3900c1f7e8 Bug 301507: Move PutHeader and PutFooter into Template.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=justdave
git-svn-id: svn://10.0.0.236/trunk@176432 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-22 05:13:36 +00:00
mkanat%kerio.com
0830f4190a Bug 287109: [SECURITY] Names of private products/components can be exposed on certain CGIs
Patch By Frederic Buclin <LpSolit@gmail.com> r=myk, r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@173309 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-12 02:07:10 +00:00
travis%sedsystems.ca
bd5ef25eac Bug 176011 : reports.cgi throws a scary error if collectstats has never been run
Patch by Vlad Dascalu <vladd@bugzilla.org>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169596 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-22 16:02:07 +00:00
bugreport%peshkin.net
1ee01139bf Bug 237627: Validate dataset name in reports.cgi
patch by teemu
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158986 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-10 08:03:15 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
jocuri%softhome.net
fbb3f67f56 Patch for bug 237369: implement relatively simple changes from %FORM to $cgi->param variable; patch by Teemu Mannermaa <wicked@etlicon.fi>; r=kiko, justdave; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154313 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-26 21:00:11 +00:00
bbaetz%acm.org
8fabd677ea Bug 208604 - Make data/template dir locations configurable
git-svn-id: svn://10.0.0.236/trunk@149624 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-22 03:50:42 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
bbaetz%acm.org
eaa2d33a5a Bug 191863 - Clean up Bugzilla.pm
r=gerv, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@137528 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-07 07:19:15 +00:00
bbaetz%student.usyd.edu.au
583c1c6256 Bug 163290 - move DB handling code into a module
r=justdave, myk, joel, preed
a=justdave


git-svn-id: svn://10.0.0.236/trunk@136312 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-14 20:00:11 +00:00
bugreport%peshkin.net
3654c27c31 Bug 184081 Change search interfaces to use Viewable products instead of enterable products
r=bbaetz
a=justdave


git-svn-id: svn://10.0.0.236/trunk@135029 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-10 14:17:05 +00:00
bugreport%peshkin.net
19d15cdfda Bug 182512 Charts over time broken
patch by joel
r=gerv
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134592 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-30 03:47:41 +00:00
bugreport%peshkin.net
8bd91adeeb Bug 147275 Rearchitect product groups
Patch by joel
r=bbaetz,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134383 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-24 19:56:34 +00:00
gerv%gerv.net
34c8aac2ba Bug 172959 - Remove old reporting (most doomed etc.). Patch by gerv; r=bbaetz.
git-svn-id: svn://10.0.0.236/trunk@132103 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-16 23:09:31 +00:00
gerv%gerv.net
d6fe11dfdb Bug 163114 - Templatise all calls to DisplayError. Patch D (the last one). Patch by gerv; r=burnus.
git-svn-id: svn://10.0.0.236/trunk@131264 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-06 11:52:37 +00:00
gerv%gerv.net
97cb7c665b Bug 167476 - unix_timestamp conversion error using MySQL. Patch by finne@stofanet.dk; r=gerv.
git-svn-id: svn://10.0.0.236/trunk@130087 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-19 23:15:14 +00:00
gerv%gerv.net
dd47f59d84 Bug 166821 - reports.cgi broken by recent schema changes. r=bbaetz.
git-svn-id: svn://10.0.0.236/trunk@129257 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-11 13:56:35 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
bbaetz%student.usyd.edu.au
1c2ecdc9c2 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127057 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-12 05:43:05 +00:00
gerv%gerv.net
7998b638b7 Bug 67950 - Move the quip list into the database. Patch by davef@tetsubo.com; r=gerv, preed.
git-svn-id: svn://10.0.0.236/trunk@125742 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-24 23:23:00 +00:00
gerv%gerv.net
064e2e53b6 Move a </center> tag (inserted in bug 129442 in a vain attempt to make this CGI's HTML validate) to the bottom of the initial page. This has the effect of fixing the alignment of the "choose chart" widgets; returning them back to the centre, where it should be. No bug number.
git-svn-id: svn://10.0.0.236/trunk@120002 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-26 21:09:50 +00:00
bbaetz%student.usyd.edu.au
df6c1b8739 Bug 129442 - make html of a default installation (mostly) HTML 4.01
transitional compliant
Original patch by chema@ximian.com, modified/extended by
bbaetz@student.usyd.edu.au
r=gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@118964 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-15 02:48:17 +00:00
gerv%gerv.net
9961bec6d7 Bug 132634 - remove warning in reports.cgi when quips aren't used. Patch by cedric.caron@urbanet.ch; fixed up by xor@ivwnet.com; 2xr=gerv.
git-svn-id: svn://10.0.0.236/trunk@117306 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-23 13:47:31 +00:00
bbaetz%student.usyd.edu.au
37e83dae0b Bug 122744 - charting fails taint checks
r=daa@distributed.net, gerv


git-svn-id: svn://10.0.0.236/trunk@113380 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-31 23:51:38 +00:00
justdave%syndicomm.com
c148fadef8 Fix for bug 108982: enable taint mode for all user-facing CGI files.
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave


git-svn-id: svn://10.0.0.236/trunk@112490 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-20 01:44:52 +00:00
jake%acutex.net
251ac470d6 Bug 63249 - The Bug Counts report was running very slowly due to unneeded fields/joins in the SQL query.
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106049 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-23 14:45:45 +00:00
justdave%syndicomm.com
d27f46ad1e Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@105335 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 01:36:17 +00:00
gerv%gerv.net
d9e5951e98 Make bug chart filenames other-OS friendly by removing colons. Bug 88179. r=jake.
git-svn-id: svn://10.0.0.236/trunk@98408 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-01 19:09:29 +00:00
justdave%syndicomm.com
692f198bc4 Fix for bug 38854: reports.cgi needs to escape (untrusted) url params
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@94448 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-10 03:02:52 +00:00
cyeh%bluemartini.com
335ab846f0 fix for 6682: Chart all bug states
patch submitted by
           gervase.markham@univ.ox.ac.uk
           (Gervase Markham)


git-svn-id: svn://10.0.0.236/trunk@89148 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-09 21:24:53 +00:00
cyeh%bluemartini.com
f1dedfdcf1 fix for 69147: reports.cgi still refers to gif (bugzilla 2.11)
patch contributed to dave@intrec.com (Dave Miller).
remove useless code.


git-svn-id: svn://10.0.0.236/trunk@88209 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-28 23:36:49 +00:00
dave%intrec.com
6e760674f5 Fix for bug 66154, fixes error introduced in v1.42 of reports.cgi from bug 39159. Patch by Alan Shields <shie9022@msmailhub.oulan.ou.edu>
git-svn-id: svn://10.0.0.236/trunk@85610 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-27 02:34:17 +00:00
tara%tequilarista.org
d83fa37873 Landing Ask Bjoern Hansen's fix for bug #39159
git-svn-id: svn://10.0.0.236/trunk@85209 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-20 16:58:32 +00:00
gerv%gerv.net
23e6b28171 More bug 6682. Perhaps this could be it.
git-svn-id: svn://10.0.0.236/trunk@85098 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-18 23:08:22 +00:00
gerv%gerv.net
639725efe1 Bug 6682: moving location of graph creation dir to graphs instead of data/mining, for security reasons.
git-svn-id: svn://10.0.0.236/trunk@83288 18797224-902f-48f8-a5cc-f745e15eee43
2000-12-05 22:36:26 +00:00
terry%mozilla.org
a6732080cc Make 'doomed' reports honor the per-product defaultmilestone setting, rather than looking at the obsolete system-wide 'curmilestone' param.
git-svn-id: svn://10.0.0.236/trunk@82467 18797224-902f-48f8-a5cc-f745e15eee43
2000-11-09 18:57:51 +00:00
tara%tequilarista.org
d598e22507 Landing Gerv and Adam's changes for bug #6682
git-svn-id: svn://10.0.0.236/trunk@82055 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-30 23:02:41 +00:00
dmose%mozilla.org
61eec7e852 The code was trying to use ConnectToDatabase to connect to the shadow db after quietly_check_login() had already called it for us under the covers _without_ the useshadowdb parameter. So reports were being run against the main database, triggering UI stalls. r=endico@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@81715 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-25 02:34:13 +00:00
tara%tequilarista.org
26fe07c589 Fixing bug #46897
git-svn-id: svn://10.0.0.236/trunk@75734 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-07 22:59:55 +00:00
dave%intrec.com
8fd36b7245 Fix for bug 46002 (reports.cgi allows users to view restricted products).
Patch submitted by jmrobins@tgix.com (Joe Robins)


git-svn-id: svn://10.0.0.236/trunk@74590 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-21 17:00:40 +00:00
dave%intrec.com
98bd394231 Fix for bug 27248 (Bug listings saved with .html extension). Patch
submitted by mhamby@logicon.com (Mark Hamby).


git-svn-id: svn://10.0.0.236/trunk@74463 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-19 16:05:52 +00:00
terry%mozilla.org
aec3218cee Fixed links off of 'Most doomed' reports to only list bugs that match the product we're reporting about.
git-svn-id: svn://10.0.0.236/trunk@73828 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-07 21:05:19 +00:00
cyeh%bluemartini.com
56d7c8e6ac committing to close bug 6682 "Chart all bug states". patches
contributed by mhamby@logicon.com


git-svn-id: svn://10.0.0.236/trunk@73083 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-23 18:59:48 +00:00
donm%bluemartini.com
94c6c05b70 patch from bug 2178 applied and fix for versions of GD/Chart::Lines that won't
produce gifs.


git-svn-id: svn://10.0.0.236/trunk@67124 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-25 21:05:32 +00:00