301 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
98a5bbf59c Bug 430014: Re-write the code hooks system so that it uses modules instead of individual .pl files
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259069 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-24 06:09:55 +00:00
mkanat%bugzilla.org
a85d2ccf30 Bug 524034: New hook: bug-end_of_create_validators
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259015 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-18 07:15:23 +00:00
mkanat%bugzilla.org
653cc2f0ac Bug 526189: Silently ignore any attempts to add an inactive group to a bug, which fixes the fact that mandatory groups were being added to bugs when changing products, even if they were inactive (not used for bugs).
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259006 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-18 06:31:59 +00:00
mkanat%bugzilla.org
4ef6a799bc Bug 526165: Make it impossible to set creation_ts via Bugzilla::Bug->create
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258959 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-10 21:21:53 +00:00
lpsolit%gmail.com
e23819934e Bug 505039: Use $user->is_timetracker instead of $user->in_group(Bugzilla->params->{'timetrackinggroup'}) - Patch by XqueZme <xquezme@gmail.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@258957 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-10 16:31:51 +00:00
lpsolit%gmail.com
fe60bd7aa2 Bug 505038: Use $user->is_insider instead of $user->in_group(Bugzilla->params->{'insidergroup'}) - Patch by XqueZme <xquezme@gmail.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@258956 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-10 16:00:25 +00:00
mkanat%bugzilla.org
6d95687b90 Bug 472217: Create a Bugzilla::Comment object and eliminate GetComments
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258951 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-10 01:36:05 +00:00
mkanat%bugzilla.org
b741992017 Bug 524891: Make leading whitespace not be trimmed from comments on display.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258838 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-01 20:14:12 +00:00
lpsolit%gmail.com
20092f5fd7 Bug 493242: UTF-8 characters in custom field names are mangled in show_activity.cgi - Patch by Vitaly Fedrushkov <vitaly.fedrushkov@gmail.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@258788 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-26 11:31:53 +00:00
mkanat%bugzilla.org
3cbe87da3d Bug 522620: Make Bugzilla::Bug->create case-insensitive for version and target_milestone values
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258776 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-24 05:28:13 +00:00
mkanat%bugzilla.org
abc52cac2a Bug 522428: Bugzilla::Bug->create should be case-insensitive for global select field
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258775 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-24 05:27:20 +00:00
lpsolit%gmail.com
4618a6cebe Bug 523869: Insecure dependency error when trying to update some fields (problem with multi-select custom fields) - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@258764 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-23 15:37:40 +00:00
mkanat%bugzilla.org
6d27e57c9b Bug 512618: Make Bugzilla::Bug::choices return Field::Choice objects, not just values
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258606 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-06 05:38:30 +00:00
lpsolit%gmail.com
300f2f05d6 Bug 305993: The requestee field may be omitted even when a requestee is already set - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@257955 18797224-902f-48f8-a5cc-f745e15eee43
2009-08-06 02:18:51 +00:00
lpsolit%gmail.com
8872215623 Bug 415541: Implement $bug->set_flags() and $attachment->set_flags() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@257948 18797224-902f-48f8-a5cc-f745e15eee43
2009-08-05 12:36:22 +00:00
mkanat%bugzilla.org
322b8aa06c Bug 505592: Make add_see_also and remove_see_also call check_can_change_field
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@257773 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-23 02:16:57 +00:00
mkanat%bugzilla.org
87599a62d8 Bug 505390: Make Bugzilla (and thus the WebService) throw an error when you try to add a private comment but aren't an insider.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@257743 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-21 16:08:47 +00:00
mkanat%bugzilla.org
d7e81ffaf7 Bug 495257: [SECURITY] Make check_can_change_field enforce permissions on confirming a bug and on which bug statuses a user can set
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@257663 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-08 13:56:51 +00:00
lpsolit%gmail.com
68f0b16f8b Bug 502950: Unconfirming a bug doesn't reset everconfirmed to 0 - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@257652 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-07 22:47:49 +00:00
lpsolit%gmail.com
fa71595a01 Bug 502682: CheckIfVotedConfirmed fails to confirm a bug if you don't have the permissions to set status/everconfirmed - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@257646 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-07 11:11:24 +00:00
lpsolit%gmail.com
03cbd960b2 Bug 500900: Confirming bugs requires NEW state to exist - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@257612 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-01 11:06:37 +00:00
bbaetz%acm.org
50f3cf433f Bug 491748 - Hook for bug creation
git-svn-id: svn://10.0.0.236/trunk@257551 18797224-902f-48f8-a5cc-f745e15eee43
2009-06-22 08:37:14 +00:00
bbaetz%acm.org
0fa3bb6b97 Bug 499121 - Cache user objects for Bug::GetComments
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@257534 18797224-902f-48f8-a5cc-f745e15eee43
2009-06-19 02:08:41 +00:00
wurblzap%gmail.com
a9b9f7e578 Bug 457657 – Make e-mail comment header localizable.
Patch by Marc Schumann <wurblzap@gmail.com>,
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@257367 18797224-902f-48f8-a5cc-f745e15eee43
2009-06-02 22:04:19 +00:00
lpsolit%gmail.com
64c21303d4 Bug 486881: A powerless user can still see a restricted bug when he removes all his roles related to the bug - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@256827 18797224-902f-48f8-a5cc-f745e15eee43
2009-04-06 20:02:52 +00:00
mkanat%bugzilla.org
d247f72123 Bug 474902: Allow the Bug URL (See Also) field to also accept Launchpad bug URLs
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@255927 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-26 21:59:56 +00:00
mkanat%bugzilla.org
8543ba0598 Bug 471943: Implement Bugzilla::Bug::match
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@255899 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-23 00:53:58 +00:00
mkanat%bugzilla.org
7eaedfb1f9 Bug 472872: Add a field where people can put the URLs to Bugzilla bugs (from any Bugzilla installation)
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@255886 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-22 04:08:53 +00:00
lpsolit%gmail.com
cc0009012f Bug 471633: Sort open bugs and closed bugs separately in show_bug dependson/blocks lists - Patch by Nitish Bezzala <nbezzala@yahoo.com> r/a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@255877 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-21 10:51:01 +00:00
mkanat%bugzilla.org
6fffd48ced Bug 472556: Modify Bug.comments to allow getting comments only comments that have been added since a certain time
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@255781 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-09 07:49:37 +00:00
dkl%redhat.com
ce1f23bec8 Bug 99205: Allow mass-editing of dependencies
Patch by Dave Lawrence <dkl@redhat.com> - r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@255704 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-04 04:38:42 +00:00
lpsolit%gmail.com
898879cb3d Bug 399076: Remove the 'commentonreassignbycomponent' parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@255421 18797224-902f-48f8-a5cc-f745e15eee43
2008-12-10 18:40:02 +00:00
lpsolit%gmail.com
fb38686377 Bug 399075: Remove the 'commentonclearresolution' parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@255420 18797224-902f-48f8-a5cc-f745e15eee43
2008-12-10 18:36:02 +00:00
lpsolit%gmail.com
9eb0bef1cc Bug 465606: If a user doesn't have privs to change the target milestone, it gets set back to default - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@255127 18797224-902f-48f8-a5cc-f745e15eee43
2008-11-19 19:32:57 +00:00
lpsolit%gmail.com
6197d8ee28 Bug 461127: Cannot change status and reassign at the same time if the assignee/QA contact doesn't have editbugs privs - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@254813 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-30 00:17:04 +00:00
mkanat%bugzilla.org
28fdeedefc Bug 141951: Set the max_packet_size for attachments (and bugs_fulltext) when connecting to MySQL
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254772 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-28 01:02:17 +00:00
lpsolit%gmail.com
58e5f9b408 Bug 457642: Users with editbugs privs cannot edit a duplicate anymore if it points to a bug you cannot see - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@254622 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-16 11:53:05 +00:00
mkanat%bugzilla.org
bd1686fafd Bug 452896: A user with no privs who reported a bug couldn't move it to another product if the target milestone was set
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254515 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-03 01:53:09 +00:00
mkanat%bugzilla.org
bdec3cbd37 Bug 455641: Implement Bugzilla::Field::Choice->update and have editvalues.cgi use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bbaetz, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254510 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-03 01:30:45 +00:00
mkanat%bugzilla.org
8a9c03a97e Bug 455632: Add Bugzilla::Field::Choice->create and have editvalues.cgi use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bbaetz, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254509 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-03 01:28:37 +00:00
lpsolit%gmail.com
736545e3ea Bug 340609: Bug->check() should throw an error if no bug ID is passed - Patch by Frédéric Buclin <LpSolit@gmail.com> r=bkor a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@254350 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-21 21:54:33 +00:00
justdave%bugzilla.org
ec25cf5bed Bug 452793 part 2: On bug creation, the first confirmed bug status should be selected by default for users with canconfirm privs, even if UNCONFIRMED is the bug status with the lowest sortkey -- do this when the template doesn't specify a status also (first patch only fixed the default templates).
Patch by justdave/LpSolit, r=LpSolit/justdave, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@254148 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-10 19:21:29 +00:00
lpsolit%gmail.com
8a584b1d0c Bug 453743: Decrease the number of calls to the DB about flags when viewing a bug - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@254102 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-08 16:23:46 +00:00
lpsolit%gmail.com
094fcc354b Bug 452844: Taint error in _check_dup_id() - Patch by John L. Clark <jlc6@po.cwru.edu> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@253958 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-31 22:14:00 +00:00
lpsolit%gmail.com
45232ec608 Better fix for bug 452799, r=justdave
git-svn-id: svn://10.0.0.236/trunk@253949 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-29 23:57:02 +00:00
lpsolit%gmail.com
8a528c5843 Bug 452799: On bug creation, the bug status with the lowest sortkey is chosen for users without editbugs/canconfirm privs, even when UNCONFIRMED is valid - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap r=justdave a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@253947 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-29 21:43:52 +00:00
mkanat%bugzilla.org
727b053bdd Bug 287334: Ability to add custom "Bug ID" fields
Patch By Elliotte Martin <elliotte_martin@yahoo.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@253756 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-21 23:58:45 +00:00
mkanat%bugzilla.org
92ac6e860f Fix a test failure caused by the bug-columns hook.
git-svn-id: svn://10.0.0.236/trunk@253755 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-21 23:30:40 +00:00
mkanat%bugzilla.org
8b17c73a0a Bug 437006: Add hooks to Bugzilla\Bug.pm to display additional columns
Patch By Elliotte Martin <elliotte_martin@yahoo.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@253749 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-21 22:56:49 +00:00
mkanat%bugzilla.org
4ae65e64a8 Bug 449306: Add a hook after a bug gets saved, and after flags get updated.
Patch By Jesse Clark <jjclark1982@gmail.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@253709 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-19 22:14:02 +00:00