111 Commits

Author SHA1 Message Date
mozilla.mano%sent.com
9ca4a35a24 Bug 366027 - Redo command is broken once a remove-separator command is undone. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217910 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-07 00:46:55 +00:00
mozilla.mano%sent.com
d555426b0e Bug 365981 - Places XUL cleanup. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217818 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-05 11:45:15 +00:00
mozilla.mano%sent.com
ff1592d55c Bug 365171 - Bug context menu delete of personal toolbar bookmark can delete history item if focused. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217530 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-28 22:56:59 +00:00
mozilla.mano%sent.com
ced59144f3 Use the right array lenght in the fix for bug 365100.
git-svn-id: svn://10.0.0.236/trunk@217527 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-28 21:26:11 +00:00
mozilla.mano%sent.com
cbc4777865 Bug 365100 - 'Open in Tabs' doesn't work in the left pane of the organizer. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217482 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-27 21:03:02 +00:00
mozilla.mano%sent.com
64e247a4c3 Bug 334451 - Places Organizer: places-list tree should not list bookmark items. This also fixes the selectBookmark dialog bustage from bug 359462. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217440 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-27 00:36:35 +00:00
mozilla.mano%sent.com
b9299566db Bug 329949 - browser.tabs.loadBookmarksInBackground is ignored in places views (histrory sidebar, bookmarks toolbar etc.). r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217437 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-26 20:26:38 +00:00
mozilla.mano%sent.com
e7ccd5bf3c Bug 365002 - newFolder/Separator methods should not try to focus the controller's view. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217414 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-26 01:57:23 +00:00
mozilla.mano%sent.com
da56f8b8df Bug 336990 - Choosing delete on bookmarks toolbar deletes everything there indeed (this should only affect --enable-places-bookmarks builds). r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217413 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-26 01:54:51 +00:00
mozilla.mano%sent.com
6235546314 Bug 359462 - Redesign PlacesController interaction with places views (this makes various edit command work in the places-based history sidebar). r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@217328 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-22 00:00:21 +00:00
sayrer%gmail.com
6dacac1bce Bug 358946. Let the places unit tests pass. r=sspitzer,mano
git-svn-id: svn://10.0.0.236/trunk@216987 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-14 17:28:52 +00:00
sspitzer%mozilla.org
8412607c42 fix for bug #356487
make MOZ_PLACES (if enabled) only build the places based history UI, use MOZ_PLACES_BOOKMARKS to turn off the places based bookmarks UI.

also addresses bugs:

bug #330923:  "View -> Sidebar menu" is empty if you build with places
bug #355738:  implement history sidebar on top of places backend
bug #356175:  hook up the history menu to the places backend
bug #356453:  add back "Clear Private Data" menu item
bug #356630:  add back "History | Show in Sidebar" menu item
bug #356631:  remove "search in history" and "view all history" menu items
bug #357301:  add back history and bookmark sidebar toolbar button items, remove places toolbar button
bug #358831:  history sidebar, right mouse button click should not expand / collapse item

r=dietrich, r=gavin


git-svn-id: svn://10.0.0.236/trunk@214697 18797224-902f-48f8-a5cc-f745e15eee43
2006-11-04 04:48:06 +00:00
sayrer%gmail.com
057ed191f6 Bug 353434. Remove C++ feed parsing for livemarks on trunk (places). r=dietrich
git-svn-id: svn://10.0.0.236/trunk@213839 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-19 02:24:30 +00:00
sspitzer%mozilla.org
12df9d9a2e fix for bug #342930: "You have asked to open [lots of] tabs at once" should read "You are about to open..."
backporting the fix from the MOZILLA_1_8_BRANCH to work on the trunk (both with places enabled and without)

r=dietrich, original patch r=mconnor, ui-r=beltzner


git-svn-id: svn://10.0.0.236/trunk@213472 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-10 23:19:01 +00:00
pkasting%google.com
9b70e7b374 Bug 321973: Make "Bookmark This Link" work.
r=jhughes
sr=beng


git-svn-id: svn://10.0.0.236/trunk@208954 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-01 00:33:23 +00:00
gavin%gavinsharp.com
27872df3d4 Bug 346447: loadFolderAndReplace=false ignores "loading" tabs, patch by Pablo Greco <pablo@fliagreco.com.ar>, r=mano
git-svn-id: svn://10.0.0.236/trunk@206773 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-07 23:01:32 +00:00
sspitzer%mozilla.org
451440563b fix for bug #344040: when warning on "opening too many tabs", only count non-deleted bookmarks (and not folders or separators)
r=ben


git-svn-id: svn://10.0.0.236/trunk@203434 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-22 06:52:51 +00:00
gavin%gavinsharp.com
0eec265eab Bug 343958: fix strict warnings in controller.js, patch by Regis Caspar <regis.caspar+bz@gmail.com>, r=annie
git-svn-id: svn://10.0.0.236/trunk@201844 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-10 22:48:48 +00:00
sspitzer%mozilla.org
17b07f233e fix for bug #340966, regression, "node QI Failed When middle clicking a bookmark"
also address another scenario of bug #333734, "Protect against opening too many tabs at once"

r=ben


git-svn-id: svn://10.0.0.236/trunk@200059 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-15 22:58:34 +00:00
sspitzer%mozilla.org
e89fe2a455 supplimental checkin for bug #333734, protect (warn) against opening too many tabs at once. ugh.
git-svn-id: svn://10.0.0.236/trunk@199584 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-09 08:04:10 +00:00
sspitzer%mozilla.org
3a41db1475 follow-up checkin for #333734, fix coding style per ben.
git-svn-id: svn://10.0.0.236/trunk@199583 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-09 07:58:20 +00:00
sspitzer%mozilla.org
3cd53db8af fix for bug #333734. protect (warn) against opening too many tabs at once.
r=ben, UI and strings r=beltzner


git-svn-id: svn://10.0.0.236/trunk@199582 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-09 07:53:12 +00:00
myk%mozilla.org
e3fb608fb9 Initial support for microsummaries via a service and integration into the bookmarks UI.
bug=334471
r=brettw
a=ben for the branch


git-svn-id: svn://10.0.0.236/trunk@196058 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-05 22:46:57 +00:00
beng%bengoodger.com
34fe8b6a16 329367 -cannot return to bookmarks after a search r=annie.sullivan@gmail.com and 334401 - assorted places organizer fixes including new debug panel r=brettw@gmail.com
git-svn-id: svn://10.0.0.236/trunk@194665 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-19 03:34:26 +00:00
joe%retrovirus.com
d0895ce7be Removes the history item mode for the (Bookmark) Properties dialog, which
just showed disabled title and URI fields.  The "Properties" context menu
item is now disabled for URI nodes which are not bookmarked.

bug=330876
r/sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@194575 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-18 01:49:10 +00:00
beng%bengoodger.com
9776ca9ad4 332495 - grouping by site is not preserved when searching + various other search/sort fixes. r=annie.sullivan@gmail.com, brettw@gmail.com (history pieces)
git-svn-id: svn://10.0.0.236/trunk@194357 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 22:51:36 +00:00
joe%retrovirus.com
60817e663a Resubmitting this patch, which adds a editing for livemark URIs as well
as fixing a few small livemark bugs, now that I've fixed a couple reference
leaks in nsLivemarkService (see bugs 333764 and 333784).

NOTE: I expect this to cause an increase in allocations on branch balsa,
since it causes nsLivemarkService to be instantiated to set up the menus.
(nsLivemarkService previously wasn't used in the balsa bloat test)

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@194326 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 17:20:31 +00:00
brettw%gmail.com
c411b948c4 Bug 332144 r=brettw sr=beng (checkin for pamg) Subscriptions context menu should have "reload all livemarks"
git-svn-id: svn://10.0.0.236/trunk@194323 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 16:40:12 +00:00
gavin%gavinsharp.com
0f60b6f38b Bug 332888: JS warning: variable folderId hides argument, r=ben
git-svn-id: svn://10.0.0.236/trunk@194238 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-12 18:23:33 +00:00
beng%bengoodger.com
0b2c084a31 329733 - problems with drag & drop to bookmarks menus. ensure that we properly close up bookmarks menus after they have been opened. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@194025 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-10 19:26:01 +00:00
joe%retrovirus.com
a495b02fad Backing out patch from bug 330063 to see if it's responsible for the
branch balsa allocation increases, and if so, fix before resubmitting.


git-svn-id: svn://10.0.0.236/trunk@193946 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-08 17:58:56 +00:00
joe%retrovirus.com
7743954cf5 * Added ability to edit Live Bookmark feed & site URIs in Bookmark Properties dialog
* Fixed a setFeedURI bug in the LivemarkService
* Fixed problems that broke the toolbar when a live bookmark had no site URI
* Converted some browser UI code to use LivemarkService methods rather than manipulating the annotations directly

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@193764 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-06 23:29:46 +00:00
joe%retrovirus.com
abc6a9eccd Implements "Bookmark All Tabs..." for Places. (Also fixes a small error
when undoing aggregate transactions.)

bug=330929
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@193476 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 01:26:58 +00:00
darin%meer.net
abbff9281c fixes bug 329634 "No apparent way to Reload Live Bookmark (or update livemarks)" patch by pamg, r=annie, sr=beng
git-svn-id: svn://10.0.0.236/trunk@193469 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 00:32:33 +00:00
beng%bengoodger.com
142a6e54ee 331755 - Use Bookmark option for setting home page is broken. add a new home page selection dialog that uses places. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193467 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 00:13:58 +00:00
roc+%cs.cmu.edu
e9fd34c810 Bug 331522. By default, do not allow keyword searches when navigating to URLs; modify browser UI code to enable keyword searches only on selected URL input mechanisms (e.g., typed into the URL bar). r+sr=darin,r=mconnor
git-svn-id: svn://10.0.0.236/trunk@193458 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-03 23:17:51 +00:00
beng%bengoodger.com
8e71d880a9 331905 - pasted folders/items are inserted at the wrong level in the bookmarks hierarchy. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193353 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-31 22:42:21 +00:00
joe%retrovirus.com
cb00bb5c6e Convert all the DB-modifying operations in the Bookmark Properties to use
transactions so that they can be undone.  (The "change URI" is the only one
that's not transactionized yet, because it needs deeper work, cf. bug 331655)

bug=326321
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@193288 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-31 00:34:03 +00:00
beng%bengoodger.com
70f81c13c5 328191, cannot delete history entries + a few other fixes r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193145 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-28 19:59:26 +00:00
beng%bengoodger.com
80748c607e 323812 - fix bogus copy-paste behavior and assorted other issues (insertion bugs, command updating) r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@193093 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-28 00:54:10 +00:00
beng%bengoodger.com
714620c65c 324958 - folder undo delete back to previous folder id. Implement folder removal transaction in bookmarks service itself, using private methods to restore folders back to previous ids. Adjust fe to use new api. r=brettw (C++), annie.sullivan (JS)
git-svn-id: svn://10.0.0.236/trunk@192968 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-25 00:46:28 +00:00
annie.sullivan%gmail.com
9316eae604 Bug 329743: fixes dropmarker icon not showing up on places toolbar folders on mac.
Patch by Pam Greene <pamg.bugs@gmail.com>
r=annie.sullivan@gmail.com sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@192850 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-23 16:30:27 +00:00
joe%retrovirus.com
50f2b58118 * Moved changeBookmarkURI functionality from controller.js into
nsINavBookmarksService
* Added annotation and favicon handling to changeBookmarkURI
* Added brettw's copyAnnotations patch to nsIAnnotationService
* Added a GetAnnotationService() to the annotation service for faster
  intra-component access
* Added a getBookmarkFoldersTArray() to nsINavBookmarksService for easier
  intra-component memory management; updated getBookmarkFolders() to use it
* Added stub for tagRoot to nsINavBookmarksService; DO NOT USE until 329961
  has been resolved
* Quick fix for Add Bookmarks breakage caused by 329546

bug=330192
r=brettw@gmail.com
sr=bryner@bryanryner.com


git-svn-id: svn://10.0.0.236/trunk@192839 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-23 06:26:23 +00:00
beng%bengoodger.com
e5d1d8cd9e 329269, more command handling cleanup for places views. make sure the right commands are enabled for items in the readonly area of the places list, and generally. make sure reload commands are enabled appropriately. also, some spit and polish for the organizer window r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@192826 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-23 00:54:35 +00:00
joe%retrovirus.com
b35399cf15 This submission is a roll-up of three patches developed & approved during
the branch freeze:
330052 add bookmark dialog should have a default folder selected
329792 remove dead code for old tag-style folder selector in bookmark properties
330023 allow for editing of folder names

r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@192752 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-22 03:36:41 +00:00
beng%bengoodger.com
dfde20d73e 329269 various improvements to view initialization r=annie.sullivan@gmail.com 330736 - bug in query serialization r=brettw@gmail.com
git-svn-id: svn://10.0.0.236/trunk@192511 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-17 02:02:36 +00:00
annie.sullivan%gmail.com
78ce903b68 Fixes several bugs with open in tabs: makes menus set selection in command events in case DOMMenuItemActive doesn't get sent, only shows Open in Tabs menuitem if there are two or more items in the menu, and respects browser.tabs.loadFolderAndReplace and browser.tabs.loadBookmarksInBackground prefs. Also moves #include of debug.js to browser.js as this was causing JavaScript errors on the mac. r=ben@mozilla.org sr=darin@meer.net bug=330130
git-svn-id: svn://10.0.0.236/trunk@192438 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-15 19:59:09 +00:00
joe%retrovirus.com
8afe1d3f15 Moved Ben's JavaScript ASSERT function to be NS_ASSERT in
toolkit/content/debug.js

debug.js is now included by globalOverlay.js, but if that's not in your
scope you can just #include debug.js directly.

NS_ASSERT() shows a dialog box containing a stack trace when it's called
with a condition that isn't true.  The dialog box will be suppressed in
final builds, but in nightlies and alphas, it's useful for encouraging
bug submissions.  To disable the dialogs, set XUL_ASSERT_PROMPT=0 in
your environment.

bug=327349
r=darin@meer.net, gavin.sharp@gmail.com


git-svn-id: svn://10.0.0.236/trunk@192291 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-14 01:57:26 +00:00
beng%bengoodger.com
61e70249c5 329269 - more work on places organizer. menus, accessible sorting and grouping options, etc. still a work in progress. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/trunk@192184 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-10 23:48:40 +00:00
joe%retrovirus.com
b5ef892f4b Changes to bookmark properties dialog:
* Customized bookmark properties dialog for add vs. edit cases
* Added support for changing URI of bookmark (annotations not carried over yet)
* Add support for viewing properties of history entries
* Changed from tag-style control to folder tree for folder selection,
  yielding layout and accessibility improvements
* Switched to using standard dialog buttons

bug=329272
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com


git-svn-id: svn://10.0.0.236/trunk@192153 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-10 17:37:22 +00:00