65 Commits

Author SHA1 Message Date
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
justdave%syndicomm.com
b944887bd0 Bug 196101: use ANSI-compliant SQL for group checks in sanitycheck
git-svn-id: svn://10.0.0.236/trunk@139150 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-08 08:29:01 +00:00
preed%sigkill.com
017bee49ea Bug 124174 - make processmail a package (Bugzilla::BugMail), r=gerv, r=jth, a=justdave
git-svn-id: svn://10.0.0.236/trunk@137613 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-09 22:04:25 +00:00
bugreport%peshkin.net
8bd91adeeb Bug 147275 Rearchitect product groups
Patch by joel
r=bbaetz,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134383 18797224-902f-48f8-a5cc-f745e15eee43
2002-11-24 19:56:34 +00:00
gerv%gerv.net
d6fe11dfdb Bug 163114 - Templatise all calls to DisplayError. Patch D (the last one). Patch by gerv; r=burnus.
git-svn-id: svn://10.0.0.236/trunk@131264 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-06 11:52:37 +00:00
matty%chariot.net.au
02150d6352 ... and also fix a bug introduced trying to unrot the general bug check rewrite, due to product IDs.
git-svn-id: svn://10.0.0.236/trunk@131240 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 15:29:20 +00:00
matty%chariot.net.au
1c05ab7258 Back out a stupid stupid change I made earlier when fixing the stupid stupid bustage I made even earlier. I need sleep.
git-svn-id: svn://10.0.0.236/trunk@131239 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 15:26:23 +00:00
matty%chariot.net.au
c5399b95da ... oops missed a reviewer checkin condition.
git-svn-id: svn://10.0.0.236/trunk@131238 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 15:08:50 +00:00
matty%chariot.net.au
84277bc1b7 Bug #93667: Minor style fix, uninit var fix, add explanatory comments to CrossCheck/DoubleCrossCheck.
git-svn-id: svn://10.0.0.236/trunk@131237 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 15:07:16 +00:00
matty%chariot.net.au
141d8c1565 Bug #93667: More movement, commenting, and remove an unused variable.
git-svn-id: svn://10.0.0.236/trunk@131236 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 14:37:52 +00:00
matty%chariot.net.au
924bd2581c Bug #93667: Move some code around, add some section heading comments.
git-svn-id: svn://10.0.0.236/trunk@131235 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 14:25:13 +00:00
matty%chariot.net.au
53ca666882 Bug #93667: Rewrite double cross checking.
git-svn-id: svn://10.0.0.236/trunk@131234 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 14:14:47 +00:00
matty%chariot.net.au
75bef9c45f Bug #93667: Rewrite single cross checking.
git-svn-id: svn://10.0.0.236/trunk@131233 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 14:14:22 +00:00
matty%chariot.net.au
842908b2fa ... and fix build.
git-svn-id: svn://10.0.0.236/trunk@131232 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 13:50:12 +00:00
matty%chariot.net.au
3f714789af Bug #93667: General bug check refactoring.
git-svn-id: svn://10.0.0.236/trunk@131231 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-05 13:23:44 +00:00
myk%mozilla.org
e46967d5d3 Fix for bug 171506: Fixes bustage in sanitycheck.cgi by making it check for correct product IDs in the flaginclusions and flagexclusions
tables instead of the flagtypes table, which no longer has a product_id field.
r=joel


git-svn-id: svn://10.0.0.236/trunk@130737 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-29 20:14:13 +00:00
myk%mozilla.org
393a392d87 Fix for bug 98801: Implementation of the request tracker, a set of enhancements to attachment statuses.
r=gerv,bbaetz


git-svn-id: svn://10.0.0.236/trunk@130672 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-28 18:42:54 +00:00
bugreport%peshkin.net
2194da2336 bug 157756 - Groups_20020716_Branch Tracking : > 55 groups now supported
r=bbaetz, gerv


git-svn-id: svn://10.0.0.236/trunk@130217 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-22 17:15:13 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
bbaetz%student.usyd.edu.au
1c2ecdc9c2 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127057 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-12 05:43:05 +00:00
bbaetz%student.usyd.edu.au
2e29da5498 Bug 105472 - expectbigqueries unnecessary with mysql >=3.23.2
r=jouni x2


git-svn-id: svn://10.0.0.236/trunk@124746 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-08 06:10:47 +00:00
bbaetz%student.usyd.edu.au
1873bc6ab1 Bug 148488 - more HTML validation fixes
r=jouni, gerv


git-svn-id: svn://10.0.0.236/trunk@124240 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-28 00:18:32 +00:00
matty%chariot.net.au
08a6affc66 Bug 93667: Add comments to uncommented sections of sanitycheck.cgi
git-svn-id: svn://10.0.0.236/trunk@122016 18797224-902f-48f8-a5cc-f745e15eee43
2002-05-22 09:21:35 +00:00
bbaetz%student.usyd.edu.au
69904efa2b Bug 126883 - bugzilla.dtd isn't quite correct
r=gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@118078 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-04 04:19:58 +00:00
bbaetz%student.usyd.edu.au
b503102b3d Bug 106377 - processmail rescanall should use lastdiffed
r=justdave, ddkilzer@theracingworld.com


git-svn-id: svn://10.0.0.236/trunk@115685 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-03 22:06:20 +00:00
justdave%syndicomm.com
c148fadef8 Fix for bug 108982: enable taint mode for all user-facing CGI files.
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave


git-svn-id: svn://10.0.0.236/trunk@112490 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-20 01:44:52 +00:00
jake%acutex.net
8412c48c7b Fix for bug 83474 - The tables were not being unlocked properly when rebuilding the keyword cache if there were no keywords to rebuild.
Patch by Lukasz Engel <Lukasz.Engel@softax.pl>
r= matty@chariot.net.au


git-svn-id: svn://10.0.0.236/trunk@104663 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-05 15:18:12 +00:00
jake%acutex.net
6b6097c59e Fix for bug 97971 - Sanity check should check statuses, resolutions, everconfirmed & number of votes.
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@103198 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-19 15:06:43 +00:00
jake%acutex.net
5c859df96e Fix for bug 76140 - Adding some more sanity checks.
Patch by Matthew Tuck <matty@chariot.net.au>
r= caillon@returnzero.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@102650 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-10 15:20:11 +00:00
jake%acutex.net
e2de88b45f Fix for bug 71664 - Don't complain about a bad keyword cache for a bug that doesn't exist.
Patch by Matthew Tuck <matty@chariot.net.au>
r= afranke@ags.uni-sb.de, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@102645 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-10 14:12:10 +00:00
justdave%syndicomm.com
cc43b69ce0 refix for bug 91808: previous patch for this bug used an INNER JOIN construct in the SQL, which is not supported by the
minimum version of MySQL that we require.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@102500 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-07 01:32:13 +00:00
justdave%syndicomm.com
e3c9d88972 Fix for bug 91808: Additional sanitycheck tests for the duplicates table.
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net, caillon@returnzero.com


git-svn-id: svn://10.0.0.236/trunk@102179 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-03 01:08:05 +00:00
justdave%syndicomm.com
a32206490b Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99057 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-11 05:29:21 +00:00
jake%acutex.net
f76024a6dd sanitycheck.cgi was able to be run by anybody - even people without Bugzilla accounts. It is now restricted to only people with the editbugs permission (bug 54556).
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96240 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-02 14:24:45 +00:00
justdave%syndicomm.com
362a8f742b Fix for bug 66014: Correct sanitycheck for the new initialowner and
initialqacontact fields in the components table.
Patch by Matthew Tuck <matty@chariot.net.au>
r= afranke, justdave


git-svn-id: svn://10.0.0.236/trunk@91676 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-08 02:33:02 +00:00
cyeh%bluemartini.com
d9a28fb8af fix for 66876: Using userids (mediumint) for initialowner and initialqacontact
based on patch submitted by baulig@suse.de (Martin Baulig).


git-svn-id: svn://10.0.0.236/trunk@87678 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-22 18:11:29 +00:00
tara%tequilarista.org
b2e7b0ef95 Landing suggested addition from Bernd Eckenfels for bug # 56822
git-svn-id: svn://10.0.0.236/trunk@85169 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-19 20:57:52 +00:00
terry%mozilla.org
0e2cfc5de9 Oops! This was changed a couple of months ago in such a way that a
large class of problems wouldn't be reported.  (It wouldn't show most
cases where a table had an invalid ID pointing into another table.)


git-svn-id: svn://10.0.0.236/trunk@79532 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-19 15:42:53 +00:00
endico%mozilla.org
cdf41fdd89 use big sql tables because checking keywords requires a fairly huge query
git-svn-id: svn://10.0.0.236/trunk@77432 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-29 00:46:28 +00:00
tara%tequilarista.org
c8019b562f Landing Adam Spiers' contributions for security and small functional issues
git-svn-id: svn://10.0.0.236/trunk@74752 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-25 18:58:54 +00:00
terry%mozilla.org
d22aab65d0 If bugs with an invalid product/component are found, provide a link to bring up the list of invalid bugs.
git-svn-id: svn://10.0.0.236/trunk@73671 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-05 15:17:36 +00:00
cyeh%bluemartini.com
045c3716f1 fix for bug #44040 "sanitycheck.cgi dies if apostrophes in product, component, version,
or milestone". thanks to dave@intrec.com (Dave Miller) for the patch


git-svn-id: svn://10.0.0.236/trunk@73416 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-28 17:54:11 +00:00
terry%mozilla.org
3c786fb189 Patch by "Matt Masson" <matthew@zeroknowledge.com> -- allow definition
of different target milestones by product.


git-svn-id: svn://10.0.0.236/trunk@63597 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-21 16:47:06 +00:00
terry%mozilla.org
fd5541afb9 Named queries (and the default query) are now stored server side, in
the database, rather than in cookies.  This means you have to log
in to use these features, but I have plans that require them to be
server-side.  (Besides, some people were beginning to run out of
cookie space.)


git-svn-id: svn://10.0.0.236/trunk@58443 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-23 20:31:50 +00:00
terry%mozilla.org
76d8aaddef Added much more crosschecks, and simplified a lot of the code.
git-svn-id: svn://10.0.0.236/trunk@58430 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-23 04:37:40 +00:00
terry%mozilla.org
071c01f7ca Honor the emailregexp param when checking email addresses.
git-svn-id: svn://10.0.0.236/trunk@58415 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-22 22:19:05 +00:00
terry%mozilla.org
d8d959532a Added a new table fielddefs that records information about the
different fields we keep an activity log on.  The bugs_activity table
now has a pointer into that table instead of recording the name directly.

Set up a new, highly experimental email-notification scheme.  To turn
it on, the maintainer has to turn on the "New email tech" param, and
then individual users have to turn on the "New email tech" preference.


git-svn-id: svn://10.0.0.236/trunk@58386 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-22 04:24:42 +00:00
terry%mozilla.org
ba523f0ca7 Let's outlaw whitespace in keywords.
git-svn-id: svn://10.0.0.236/trunk@58252 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-19 19:26:37 +00:00
terry%mozilla.org
45c66f7115 Check for and rebuild busted password stuff.
git-svn-id: svn://10.0.0.236/trunk@58092 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-18 14:26:16 +00:00
terry%mozilla.org
b11185bb65 Added a "keywords" field to a bug, which is a cached string-based copy
of all the keywords assigned to the bug.  Right now, we only have code
that generates and maintains this field; soon will come code that
actually uses it.


git-svn-id: svn://10.0.0.236/trunk@58008 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-17 11:38:41 +00:00