155 Commits

Author SHA1 Message Date
gerv%gerv.net
a7c2106ebe Backing out mistakenly-checked-in code fragment. Thanks to MattyT for pointing this out.
git-svn-id: svn://10.0.0.236/trunk@122180 18797224-902f-48f8-a5cc-f745e15eee43
2002-05-26 07:01:53 +00:00
gerv%gerv.net
ff1cf6b73e Bug 145849 - Non-maintainers with ability to bless others need "users" link in footer. Patch by bugreport@peshkin.net; r=gerv, justdave.
git-svn-id: svn://10.0.0.236/trunk@122163 18797224-902f-48f8-a5cc-f745e15eee43
2002-05-25 10:35:53 +00:00
gerv%gerv.net
7420557e49 Bug 140437 - clean up parameters. Patch by gerv; 2xr=justdave.
git-svn-id: svn://10.0.0.236/trunk@121039 18797224-902f-48f8-a5cc-f745e15eee43
2002-05-08 04:40:35 +00:00
gerv%gerv.net
fc485f3bf1 Bug 140435 - Templatise GetCommandMenu. Patch by gerv; r=bbaetz, justdave.
git-svn-id: svn://10.0.0.236/trunk@120980 18797224-902f-48f8-a5cc-f745e15eee43
2002-05-07 21:28:52 +00:00
gerv%gerv.net
333d8ec13b Bug 140993 - Pass javascript correctly into header; templatise the rest of the header-related parameters. Patch by gerv; r=bbaetz, caillon.
git-svn-id: svn://10.0.0.236/trunk@120850 18797224-902f-48f8-a5cc-f745e15eee43
2002-05-06 19:30:21 +00:00
gerv%gerv.net
a94f85d68d Bug 140006 - ThrowTemplateError should try a template before using print statements. Patch by gerv, r=bbaetz, justdave.
git-svn-id: svn://10.0.0.236/trunk@120152 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-28 22:09:38 +00:00
gerv%gerv.net
858b27bae9 Bug 140103 - various templatisations or cleanups in CGI.pl. Patch by gerv; r=justdave, bbaetz.
git-svn-id: svn://10.0.0.236/trunk@120147 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-28 21:57:10 +00:00
gerv%gerv.net
2893ccfdb3 Bug 140124 - PuntTryAgain must die. Patch by gerv, 2xr=myk.
git-svn-id: svn://10.0.0.236/trunk@119945 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-26 06:13:41 +00:00
gerv%gerv.net
716e0c938b Bug 140110 - remove 273 lines of redundant code from CGI.pl. Patch by gerv; 2xr=ddk.
git-svn-id: svn://10.0.0.236/trunk@119846 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-25 19:43:50 +00:00
gerv%gerv.net
c8a771fb68 Bug 138588 - change to use new template structure. Patch by gerv, r=myk, afranke.
git-svn-id: svn://10.0.0.236/trunk@119695 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-24 07:24:50 +00:00
justdave%syndicomm.com
0bb9b498d5 Fix for bug 125013: ProcessMultipartFormFields in CGI.pl would hang if the posting browser included regexp metacharacters in its boundary string.
Patch by tkl@telenet.ch (Thomas Klaeger)
2xr= justdave


git-svn-id: svn://10.0.0.236/trunk@119495 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-20 16:17:54 +00:00
gerv%gerv.net
9d344704a9 Bug 135815 - Regression on CGI.pl for link to showvotes.cgi. Patch by ddk, 2xr=gerv. This one line has caused me so much grief...
git-svn-id: svn://10.0.0.236/trunk@118297 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-05 22:42:26 +00:00
gerv%gerv.net
6868cdf0c5 Bug 126456 - fix our error handling. Change the name of the functions to something more sane; a few enhancements. Patch by gerv, 2xr=myk.
git-svn-id: svn://10.0.0.236/trunk@118277 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-05 20:03:09 +00:00
gerv%gerv.net
dd1e9b50d4 Bug 117760 - Templatise showvotes.cgi and incorporate doeditvotes.cgi. Patch by gerv, r=myk, bbaetz.
git-svn-id: svn://10.0.0.236/trunk@118221 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-05 07:13:55 +00:00
gerv%gerv.net
b52965c686 Bug 126456 - improve our error handling. Patch by gerv, r=myk, bbaetz.
git-svn-id: svn://10.0.0.236/trunk@118044 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-03 23:00:29 +00:00
gerv%gerv.net
334afd0307 Bug 124937 - templatise show_activity.cgi. Patch by me, r=myk, bbaetz.
git-svn-id: svn://10.0.0.236/trunk@118017 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-03 18:54:18 +00:00
justdave%syndicomm.com
45f5cf551d Remaining pieces of Bug 23067 from yesterday... no idea why the first commit didn't pick these up.
git-svn-id: svn://10.0.0.236/trunk@117881 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-01 22:52:40 +00:00
gerv%gerv.net
812b0c773f Bug 133425 - FILTERs and other fixes in show_bug.html.tmpl. Patch by gerv, r=justdave, bbaetz.
git-svn-id: svn://10.0.0.236/trunk@117633 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-27 08:13:35 +00:00
bbaetz%student.usyd.edu.au
cb033cc810 Bug 129466 - use IP addr (not hostname) in logincookies table
r=gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@116706 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-16 06:03:09 +00:00
myk%mozilla.org
8382a27dc5 Fix for bug 103778: Rewrites and templatizes buglist.cgi.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv


git-svn-id: svn://10.0.0.236/trunk@116392 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-12 13:55:07 +00:00
myk%mozilla.org
b4d3313c3d Fix for bug 72184: prevents users from entering too-large comments/descriptions that get rejected by MySQL's MAX_PACKET_SIZE restrictions.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv


git-svn-id: svn://10.0.0.236/trunk@116320 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-11 07:33:03 +00:00
justdave%syndicomm.com
b74c77bfa4 Fix for bug 125516: the recent fix for emails truncating when a period occurred on a line by itself broke Exim because it
needs the -t and -i as separate parameters instead of stacked (the original patch had -ti)
Patch by Tobias Burnus <burnus@gmx.de>
r= justdave, gerv


git-svn-id: svn://10.0.0.236/trunk@114723 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-17 08:22:31 +00:00
justdave%syndicomm.com
686d81fb26 Fix for bug 117055: Emails were being truncated if they contained a line with nothing but a period on them. We now pass -i to
sendmail and its clones to tell it to ignore periods (since we close the pipe when we're done, rather than signalling it with
a period).  Has been tested with sendmail and postfix.
Patch by Dave Miller <justdave@syndicomm.com>
r= afranke, bugzilla@bkor.dhs.org, jake


git-svn-id: svn://10.0.0.236/trunk@113739 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 02:47:00 +00:00
bbaetz%student.usyd.edu.au
8ec543447a Bug 119715 - strictvaluechecks should always be enabled
r=justdave, gerv


git-svn-id: svn://10.0.0.236/trunk@113648 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-05 00:20:09 +00:00
bbaetz%student.usyd.edu.au
e20fe58870 Bug 95732 - remove logincookies.cryptpassword, and invalidate cookies from
the db when required instead.
(Also fixes bug 58242 as a side effect)

r=myk, kiko


git-svn-id: svn://10.0.0.236/trunk@113598 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 12:23:05 +00:00
myk%mozilla.org
f89a91a9e4 Fix for bug 121747: Stops every script before it does anything else if Bugzilla is currently shut down. Also adds global template
instantiation code to globals.pl.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv,kiko


git-svn-id: svn://10.0.0.236/trunk@113573 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-03 09:28:48 +00:00
myk%mozilla.org
3bad919c98 Fix for bug 104521: Removes old attachment interface in favor of new attachment tracker.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,kiko


git-svn-id: svn://10.0.0.236/trunk@113204 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-30 14:14:12 +00:00
gerv%gerv.net
4c6b3e1925 Bug 117509 - createaccount.cgi templatisation.
git-svn-id: svn://10.0.0.236/trunk@113165 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-29 23:26:37 +00:00
bbaetz%student.usyd.edu.au
c53115e19f Bug 120543 - Software error when entering a bug when not logged in & only
one product.
r=caillon,jake


git-svn-id: svn://10.0.0.236/trunk@112535 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-22 22:23:21 +00:00
justdave%syndicomm.com
c148fadef8 Fix for bug 108982: enable taint mode for all user-facing CGI files.
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave


git-svn-id: svn://10.0.0.236/trunk@112490 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-20 01:44:52 +00:00
justdave%syndicomm.com
17f6281e23 SECURITY FIX bug 54901: If you were using LDAP authentication it would let you log in as anyone if you left the password
blank.
Patch by David Crowe <crow@waveset.com>
r= jmrobins, justdave


git-svn-id: svn://10.0.0.236/trunk@110128 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-09 15:56:23 +00:00
jake%acutex.net
acaebc81a5 Bug 108312 - The mid-air collision page was only showing the most recent changes if two people comitted changes to a bug while you were viewing it.
r=louie, myk


git-svn-id: svn://10.0.0.236/trunk@109001 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-27 15:04:52 +00:00
gerv%gerv.net
f2a3c7158a Bug 98707. Query.cgi rewrite. Patch by me, layout by mpt and others, r=justdave, mattyt. Wahey!
git-svn-id: svn://10.0.0.236/trunk@108457 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 22:23:31 +00:00
matty%chariot.net.au
ca6d7f14fc Moving a comment to the right place, in order to be able to make a comment about my previous check in that accidentally got checked in without a comment, and hence didn't show up on Tinderbox I think.
It was a change to CGI.pl, a fix for bug 105812: Rename "Components" link in sub GetCommandMenu() to "Products".

The patch was by James A Laska <jlaska@us.ibm.com>.


git-svn-id: svn://10.0.0.236/trunk@108420 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 03:54:54 +00:00
matty%chariot.net.au
067fbac069 *** empty log message ***
git-svn-id: svn://10.0.0.236/trunk@108419 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 03:22:50 +00:00
myk%mozilla.org
b5c6611091 Fix test bustage by removing tabs.
git-svn-id: svn://10.0.0.236/trunk@106762 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-31 00:21:28 +00:00
myk%mozilla.org
dc4c583cd4 Fix for bug 98602: re-implementation of "create attachment" page.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org,jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106739 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-30 23:42:22 +00:00
jake%acutex.net
d377a74d28 Bug 105879 - Footer links have an extra | by Sanity Check
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106377 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-26 18:49:33 +00:00
bbaetz%cs.mcgill.ca
cced8d8047 Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.

Also fxed bug 101560, by clearing BASH_ENV

r=myk,justdave


git-svn-id: svn://10.0.0.236/trunk@106051 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-23 15:44:53 +00:00
jake%acutex.net
71b60e4071 Bug 105480 - Use the friendly name from the fielddefs table when reporting strictvalue errors if it's available.
Patch by James A. Laska <jlaska@us.ibm.com>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105860 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-20 00:50:27 +00:00
gerv%gerv.net
0aa19e6335 Bug 104105 - cosmetic change to make it obvious that you can create an account.
git-svn-id: svn://10.0.0.236/trunk@105399 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-15 03:59:19 +00:00
justdave%syndicomm.com
d27f46ad1e Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@105335 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 01:36:17 +00:00
justdave%syndicomm.com
defa1bc955 Fix for bug 19910: Bugzilla installs on the same server would interfere with each others' cookies. Cookies now have a path value that can be set to indicate which bugzilla install they belong to. Browsers will only send the cookie to the appropriate installation. The path can be set in the 'cookiepath' parameter in editparams.cgi.
Patch by Dave Lawrence <dkl@redhat.com>
r= myk, justdave


git-svn-id: svn://10.0.0.236/trunk@105325 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 00:40:41 +00:00
justdave%syndicomm.com
25caa8b542 Fix for bug 101056: multiple form values of the same name were not getting correctly stashed if the user had to log in as part
of a form submit.
Patch by Myk Melez <myk@mozilla.org>
r= gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@105295 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-12 21:33:21 +00:00
gerv%gerv.net
0ab43dc59d Bug 100490 - better error message with no JavaScript for QuickSearch. Patch by afranke, r=kiko, gerv.
git-svn-id: svn://10.0.0.236/trunk@105284 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-12 20:54:26 +00:00
jake%acutex.net
fff7589bc3 Fix for bug 104180 - &nbsp; should only be used in the display for a saved query w/a space, not in the URL.
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105189 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-11 19:51:33 +00:00
jake%acutex.net
40a00dee48 Fix for bug 104117 - The editkeywords.cgi link was broken as a result of the fix for bug 103554.
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105185 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-11 19:07:00 +00:00
justdave%syndicomm.com
c7e784100c Fix for bug 103554: HTML generated by the PutHeader and GetCommandMenu subroutines now validates as HTML 4.01 at W3C.
Patch by Christian Reis <kiko@async.com.br>
r= caillon, gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@105115 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-10 23:36:29 +00:00
jake%acutex.net
58d1809148 Fix for bug 65164 - Bugzilla wasn't sending </html> at the end of its pages.
Patch by Christian Reis <kiko@async.com.br>
r= gerv@mozilla.org, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105030 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-10 13:26:28 +00:00
timeless%mac.com
c21ee7ffe6 Bugzilla Bug 97185 make_select should add a newline after each option
patch by kiko. r=zach, gerv


git-svn-id: svn://10.0.0.236/trunk@105011 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-10 04:52:09 +00:00