85 Commits

Author SHA1 Message Date
bugreport%peshkin.net
e1139e8f3a Bug 290000: lock email settings table before adding new user
Patch by bugreport@peshkin.net
r=glob,a=justdave


git-svn-id: svn://10.0.0.236/trunk@172049 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-12 23:28:47 +00:00
lpsolit%gmail.com
445e0bdd09 Bug 289062: editusers.cgi is querying for groups twice on update - Patch by Tomas Kopal <Tomas.Kopal@altap.cz> r=wurblzap, joel a=justdave
git-svn-id: svn://10.0.0.236/trunk@172038 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-12 18:08:21 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
travis%sedsystems.ca
72f7202d3b Bug 284262 : Bundle of small editusers.cgi post-checkin fixes
Patch by Marc Schumann <wurblzap@gmail.com>   r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170296 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 18:11:37 +00:00
travis%sedsystems.ca
13ccc1dd98 Bug 284155 : New editusers.cgi broke group visibility
Patch by GavinS <bugzilla@chimpychompy.org>   r=wurblzap a=justdave


git-svn-id: svn://10.0.0.236/trunk@170290 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 17:45:21 +00:00
mkanat%kerio.com
7f1a179da7 Bug 277782: _throw_error should unlock tables when tables are locked, automatically
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=travis, r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170180 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 00:18:48 +00:00
travis%sedsystems.ca
abce7fe4c4 Bug 119485 : Templatise editusers.cgi
Patch by Marc Schumann <wurblzap@gmail.com>   r=GavinS, mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170004 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-28 20:41:45 +00:00
mkanat%kerio.com
da1c0470db Bug 279693: Move UserCanBlessGroup() into a Bugzilla::User function
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@169815 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-25 03:07:05 +00:00
mkanat%kerio.com
f7471cbb97 Bug 283237: Move DBname_to_id out of globals.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@169799 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:42:48 +00:00
mkanat%kerio.com
c8f7e44c64 Bug 280494: Replace "SELECT LAST_INSERT_ID()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169387 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:01:48 +00:00
mkanat%kerio.com
4f73e1f64b Bug 280495: Replace "REGEXP" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@169274 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 18:40:13 +00:00
travis%sedsystems.ca
3c4af7dae0 Bug 281845 : Possible to delete users who are initial QA contacts (Regression from bug 43600)
Patch by Shane H. W. Travis <travis@sedsystems.ca>   r=justdave, a=justdave


git-svn-id: svn://10.0.0.236/trunk@169087 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-10 21:34:48 +00:00
travis%sedsystems.ca
b63354eba2 Bug 280994 : Move ValidateNewUser out of globals.pl
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169041 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-09 06:42:43 +00:00
travis%sedsystems.ca
6427625246 Bug 278792 : Move Crypt() to Bugzilla::Auth
Patch by Max Kanat-Alexander <mkanat@kerio.com>   r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168559 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 19:26:01 +00:00
jocuri%softhome.net
6e30566dcd Patch for bug 265898: edit*.cgi files should all use ThrowUserError(); patch by Frédéric Buclin <LpSolit@gmail.com>, r=vladd, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167820 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 14:07:31 +00:00
travis%sedsystems.ca
b75c9da900 Bug 108870: Bugzilla does not set email prefs for new user until user visits userprefs.cgi
Patch: travis  r=mkanat  a=justdave

Also includes fixes for
Bug 109573: New bugzilla accounts should by default have 'CC field changes' turned off, and
Bug 275599: flag request email prefs not behaving correctly


git-svn-id: svn://10.0.0.236/trunk@167399 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-07 20:56:01 +00:00
jocuri%softhome.net
65b4dc513f Patch for bug 261434: implement functionality to delete a user semi-properly (only works for users with no bugs/comments); patch by Ivan Todoroski <grnch@gmx.net>; r=justdave, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@163925 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-17 11:08:50 +00:00
jocuri%softhome.net
23204eca2d Patch for bug 253360: replace IF() with CASE WHEN for database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160170 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 09:36:18 +00:00
bugreport%peshkin.net
1b0c07d9df Bug 251837: Extend group_group_map to control which groups can see each other
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159914 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 16:33:41 +00:00
bugreport%peshkin.net
5383f86c9f Bug 253088: Fix ability of users with bless privileges to bless users
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159890 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-27 00:25:55 +00:00
bugreport%peshkin.net
a573481913 Bug 252190: Fix unitialized value in editusers.cgi
r=vlad
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159616 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-21 21:26:20 +00:00
bugreport%peshkin.net
ba7b83aa6f Bug 241900: Allow Bugzilla::Auth to have multiple login and validation styles
patch by erik
r=joel, kiko
a=myk


git-svn-id: svn://10.0.0.236/trunk@159556 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 22:41:22 +00:00
bugreport%peshkin.net
dd7434d263 Backing out bug 241900
git-svn-id: svn://10.0.0.236/trunk@159043 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-12 03:48:48 +00:00
bugreport%peshkin.net
864d1bce45 Bug 241900: Allow Bugzilla::Auth to have multiple login and validation styles
patch by erik
r=joel
a=justdave


git-svn-id: svn://10.0.0.236/trunk@159037 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-11 23:36:53 +00:00
bugreport%peshkin.net
f532dc6eeb Bug 244272: Remove editusers 'query' parameter
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158982 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-10 07:52:11 +00:00
bugreport%peshkin.net
1bf7dd2bbc Bug 233486: Only process groups user is supposed to be able to bless in editgroups.cgi
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158979 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-10 07:39:56 +00:00
bugreport%peshkin.net
757e859a98 Bug 236650: html_quote and validate email addresses in editueser.cgi
patch by vlad
r=joel,justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158976 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-10 07:31:07 +00:00
bugreport%peshkin.net
5fe78bc59c Bug 240325: Keep regexp-based groups up-to-date
git-svn-id: svn://10.0.0.236/trunk@157940 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-16 05:04:48 +00:00
jouni%heikniemi.net
191a8e93a1 Bug 224021: taint issues in editusers.cgi
Patch by byron jones <bugzilla@glob.com.au>
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@156795 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-23 07:32:00 +00:00
jouni%heikniemi.net
02eb0122e5 Bug 141006: Run edit*.cgis in taint mode.
Patch by byron jones <bugzilla@glob.com.au>
r=jouni, a=justdave


git-svn-id: svn://10.0.0.236/trunk@156794 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-23 07:22:32 +00:00
justdave%syndicomm.com
9ef32167c2 Bug 240439: "Edit user again" link didn't work if the user had a + in their email address
R= timeless, vladd; a= justdave


git-svn-id: svn://10.0.0.236/trunk@154827 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-13 21:45:35 +00:00
justdave%syndicomm.com
62d042aa7a Bug 235265: Getting rid of some unwanted form value dumps.
Patch by Jouni Heikniemi <jouni@heikniemi.net>
r= justdave, kiko; a= justdave


git-svn-id: svn://10.0.0.236/trunk@154332 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 04:35:37 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
kiko%async.com.br
36171a62bf Fix for bug 226764: Move InvalidateLogins into Bugzilla::Auth::CGI.
Consolidates the logout code into Bugzilla::Auth::CGI, and provides
simple front-end wrappers in Bugzilla.pm for use in the CGIs we have.
r=bbaetz, joel; a=justdave.

Adds a set of constants to the logout() API which allow specifying "how
much" we should log out -- all sessions, the current session, or all
sessions but the current one.

Fixes callsites to use this new API; cleans and documents things a
bit while we're at it. Part I in the great COOKIE apocalypse.


git-svn-id: svn://10.0.0.236/trunk@154327 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 01:28:29 +00:00
jocuri%softhome.net
9906ba0730 Patch for bug 238033: eliminate HTML closing tags that haven't been opened and fix an identation issue; patch by Rudolf Ramler <rudolf.ramler@scch.at>; r=vlad, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@154141 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-21 14:26:58 +00:00
kiko%async.com.br
edf09f144f Fix for bug 232397: .bz_obsolete shouldn't specify "underline". Define
specific bz_obsolete/closed/inactive classes (that don't specify
underline, but line-through instead) and additional Template filters for
conveniently applying them. Change occurences of <strike> to use new
classes and clean up callsites. Patch by byron jones
<bugzilla@glob.com.au>. r=myk, gerv. a=myk.


git-svn-id: svn://10.0.0.236/trunk@154049 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-16 23:53:01 +00:00
timeless%mozdev.org
fd44078c52 Bug 214457 Updated user page is useless
r=justdave a=justdave


git-svn-id: svn://10.0.0.236/trunk@153957 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-14 06:30:35 +00:00
jocuri%softhome.net
6a9a5184f6 Bug 225234: Wrong comment in editusers.cgi; r=timeless; a=myk.
git-svn-id: svn://10.0.0.236/trunk@149119 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-10 17:56:03 +00:00
kiko%async.com.br
ad61d77b76 Bug 65316: Typos on edit*.cgi. Change use of PutTrailer() (and the
default output, in certain cases) in the edit pages. Patch by Vlad
Dascalu <jocuri@softhome.net>, r=kiko, a=justdave


git-svn-id: svn://10.0.0.236/trunk@147351 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-26 23:47:07 +00:00
justdave%syndicomm.com
c8730f0796 Bug 178935: Eliminating the "Add another user" link on the confirmation screen after editing a user if the user doing the editing doesn't have permission to add users.
Patch by kniht@us.ibm.com
r= justdave, a= justdave


git-svn-id: svn://10.0.0.236/trunk@144978 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-19 20:37:20 +00:00
bbaetz%acm.org
726bcd99cc Bug 180635 - Enhance Bugzilla::User to store additional information
r=myk,jake


git-svn-id: svn://10.0.0.236/trunk@143228 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-03 09:48:15 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
bbaetz%acm.org
3f031986ac Bug 201018 - editusers.cgi never calls DeriveGroup prior to changing a bug
patch mostly by justdave, bits by me
r=bbaetz,justdave,myk
a=justdave


git-svn-id: svn://10.0.0.236/trunk@141774 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-24 23:12:00 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
bbaetz%acm.org
2b0b42744f Bug 180642 - Move authentication code into a module
r=gerv, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140041 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-22 04:47:35 +00:00
bugreport%peshkin.net
2194da2336 bug 157756 - Groups_20020716_Branch Tracking : > 55 groups now supported
r=bbaetz, gerv


git-svn-id: svn://10.0.0.236/trunk@130217 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-22 17:15:13 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
bbaetz%student.usyd.edu.au
1c2ecdc9c2 Bug 43600 - Convert products/components to use ids instead of names.
Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed


git-svn-id: svn://10.0.0.236/trunk@127057 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-12 05:43:05 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-17 09:39:48 +00:00
preed%sigkill.com
4be6720d1d Bug 147486 - Fixes cross site scripting issues; first checked in on the 2.14.1 branch, but I forgot the 2.16 branch/trunk (thanks bbaetz); patch=preed, r=bbaetz,myk
git-svn-id: svn://10.0.0.236/trunk@122486 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-01 09:26:25 +00:00