justdave%syndicomm.com
ab0ed93ca8
Backing out previous checkin, it broke the tree. :(
...
git-svn-id: svn://10.0.0.236/trunk@108396 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:28:24 +00:00
justdave%syndicomm.com
2f07aa0c10
Fix for bug 102487: If admin has set preferences to require a comment on a product/component change, prompt the user that they
...
forgot to comment first, before prompting for component, milestone, and version for new product.
Patch by Garvase Markham <gerv@mozilla.org>
r= kiko, ddk
git-svn-id: svn://10.0.0.236/trunk@108394 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:12:53 +00:00
bbaetz%cs.mcgill.ca
9ca8a3c375
Bug 107718 pt 2 - use subtraction instead of the ~ operator, which older
...
mysql versions don't support. Remove the checksetup.pl restriction, too.
r=jake x2
git-svn-id: svn://10.0.0.236/trunk@108061 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-14 15:12:23 +00:00
justdave%syndicomm.com
e78b6416c2
Fix for bug 99519: timestamps were not being set correctly in the activity table in some situations, and the delta_ts on the
...
bug itself was not always being updated if dependencies or CCs changed.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake
git-svn-id: svn://10.0.0.236/trunk@107644 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 03:38:12 +00:00
justdave%syndicomm.com
2d28f97361
SECURITY FIX see bug 108385: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to add a comment to a bug pretending to be someone else if you edited the HTML by hand before submitting. The bug form did not include the field in question, but due to legacy processing code, the field was still trusted if it was present.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake x2
git-svn-id: svn://10.0.0.236/trunk@107350 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-05 20:47:17 +00:00
bbaetz%cs.mcgill.ca
b2918e050d
Bug 107718 - mass changes give all changed bugs the groupset of the first
...
bug in the list.
Do bit fiddling instead of adding groupsets from the first bug.
r=justdave, jake
git-svn-id: svn://10.0.0.236/trunk@107224 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-03 05:49:23 +00:00
jake%acutex.net
e6f2627084
Bug 104065 - Stop uninitilized string warnings from getting into the error log when the login cookie doesn't exist.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= gerv@mozilla.org , jake@acutex.net
git-svn-id: svn://10.0.0.236/trunk@106273 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-25 14:46:58 +00:00
bbaetz%cs.mcgill.ca
cced8d8047
Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
...
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.
Also fxed bug 101560, by clearing BASH_ENV
r=myk,justdave
git-svn-id: svn://10.0.0.236/trunk@106051 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-23 15:44:53 +00:00
justdave%syndicomm.com
d27f46ad1e
Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
...
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2
git-svn-id: svn://10.0.0.236/trunk@105335 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 01:36:17 +00:00
myk%mozilla.org
d66bb72fd8
Fix for bug 98744: No more software error when the user clicks "remove cc" without specifying users to remove.
...
Fix by Jake <jake@acutex.net>.
r=myk@mozilla.org , no second review needed.
git-svn-id: svn://10.0.0.236/trunk@104118 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-28 19:49:53 +00:00
myk%mozilla.org
ded048fcee
Fix for bug 90333: Bugzilla now displays an appropriate error message if a user hits process_bug.cgi without specifying any bugs to change.
...
Patch by Myk Melez <myk@mozilla.org>
r=jake@acutex.net
git-svn-id: svn://10.0.0.236/trunk@102994 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-17 18:55:31 +00:00
jake%acutex.net
b176facdc0
Fix for bug 30731 - Reassigning closed bugs from the mass change page caused their status to be set to new.
...
r= myk@mozilla.org , zach@zachlipton.com
git-svn-id: svn://10.0.0.236/trunk@102955 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-14 21:50:08 +00:00
justdave%syndicomm.com
d595b24c15
Fix for bug 92266: Prevent dataloss in the bugs_activity table by wrapping
...
entries into additional entries if they're too long to fit.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
git-svn-id: svn://10.0.0.236/trunk@101815 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-26 22:58:34 +00:00
jake%acutex.net
ca886b1282
Bug 96085 - bypassing group security checks using duplicate bugs
...
Patch by Christopher Aillon <christopher@aillon.com>
r= jake@acutex.net
git-svn-id: svn://10.0.0.236/trunk@101811 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-26 18:51:45 +00:00
justdave%syndicomm.com
21573c54a7
Fix for bug 95235: variables with untrusted content were being echoed back to the user in error messages. Those variables are now run through html_quote() first.
...
Patch by Gavin Shelley <gavins@iplbath.com>
r= justdave@syndicomm.com
git-svn-id: svn://10.0.0.236/trunk@101751 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-24 17:32:25 +00:00
jake%acutex.net
4d649ab63c
Refixing bug 95875 - The code that breakes the typed in CC list into individual lists is now slightly more robust and allows perl to handle the splitting more efficiently (by using a space as the delimiter).
...
r= myk@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@101398 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-18 03:35:36 +00:00
justdave%syndicomm.com
1136151446
Fix for bug 95857: process_bugs.cgi sees blank address in cc: line (would show up as __UNKNOWN__)
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
git-svn-id: svn://10.0.0.236/trunk@101390 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-18 01:49:02 +00:00
jake%acutex.net
e7597bc03e
Fix for bug 95747 - CC List validation (for additions) wasn't happening until after the bug's changes were in the process of being commited. This caused problems if a typo was made in the e-mail address.
...
r= myk@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@101338 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-17 20:18:33 +00:00
justdave%syndicomm.com
b2c6ce4e69
Fix for bug 95743: the role-accessible checkboxes were getting cleared if a user with group access had to log in to make changes to a public bug.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
git-svn-id: svn://10.0.0.236/trunk@101296 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-17 11:15:04 +00:00
justdave%syndicomm.com
929927863c
Fix for bug 39816: Anyone in CC, Reporter, QA Contact, or Asigned To fields can now be given access to view a bug even if the permissions on that bug are set to a group that would normally exclude those people.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
git-svn-id: svn://10.0.0.236/trunk@100906 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-13 00:46:20 +00:00
zach%zachlipton.com
c8d61a878f
fix for bug 66235: process_bug.cgi: multiple product change misses the groupset bit. Patch by Myk <myk@mozilla.org> r=Jake, oh, and it's my first checkin, yahoo!
...
git-svn-id: svn://10.0.0.236/trunk@100858 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-11 01:18:24 +00:00
justdave%syndicomm.com
ad1725e23f
Fix for bug 84714 and bug 88797: You can now change bug groups from the "change several bugs" form even if the bugs aren't all in the same groups. Also, the groups are no longer cleared when you make a change from the "change several bugs" form (unless you tell it to)
...
Patch by Joe Robins <jmrobins@tgix.com> and Dave Miller <justdave@syndicomm.com>
r= zach@zachlipton.com
a= justdave@syndicomm.com
git-svn-id: svn://10.0.0.236/trunk@99724 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-22 00:29:45 +00:00
jake%acutex.net
559c643f79
Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
...
r= justdave@syndicomm.com
git-svn-id: svn://10.0.0.236/trunk@99648 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-20 15:18:30 +00:00
justdave%syndicomm.com
9993af1ff9
Fix for bug 80289: Group restrictions are now identified with checkboxes instead of select widgets. Also, product groups are now only offered if they are either already set, or match the current product (i.e. the option to set a product bit for a product other than the one the bug is in is no longer available) This results in much less clutter for the admin folks on sites with lots of products.
...
Patch by Joe Robbins <jmrobins@tgix.com>
r= justdave@syndicomm.com
git-svn-id: svn://10.0.0.236/trunk@98014 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-27 01:44:34 +00:00
justdave%syndicomm.com
62f8abbb9a
Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
git-svn-id: svn://10.0.0.236/trunk@96648 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 20:26:40 +00:00
justdave%syndicomm.com
0d88c2a487
Fix for bug 21253: removing all single-parameter system() calls from Bugzilla
...
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org
git-svn-id: svn://10.0.0.236/trunk@96556 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 21:17:42 +00:00
tara%tequilarista.org
cbb24b9172
Landing Myk's patch for bug #71767
...
git-svn-id: svn://10.0.0.236/trunk@96243 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-02 22:02:02 +00:00
jake%acutex.net
ce19d8c942
Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533.
...
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net
git-svn-id: svn://10.0.0.236/trunk@96121 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-31 15:52:25 +00:00
justdave%syndicomm.com
f539fe27ee
Correcting my email address in the comments
...
git-svn-id: svn://10.0.0.236/trunk@92493 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-17 02:26:16 +00:00
dave%intrec.com
6e429169a6
Fix for bug 71606: Duplicates not getting marked in comments which bug they're a dupe of.
...
git-svn-id: svn://10.0.0.236/trunk@89292 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-11 18:54:05 +00:00
dave%intrec.com
a37c952cf0
Fix for bug 7873: Duplicate marking now happens AFTER privs are checked to make sure a) the user is allowed to dupe it, and b) the change hasn't caused a midair collision.
...
git-svn-id: svn://10.0.0.236/trunk@89261 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-11 00:53:22 +00:00
cyeh%bluemartini.com
f3825ec9e4
back out change
...
git-svn-id: svn://10.0.0.236/trunk@89161 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-09 23:59:40 +00:00
cyeh%bluemartini.com
017c2f1299
fix for 70039: Mid-air collision page confusing, users think comments will be lost
...
git-svn-id: svn://10.0.0.236/trunk@89159 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-09 23:41:37 +00:00
cyeh%bluemartini.com
45e7f30e33
fix for bug 51670: Dependency loops are possible
...
we now search each list (dependson, blocks) to see if a bug number shows
up in each list. a bug can't be dependent upon and block the same bug.
also make it so you can't set a bug blocking or dependent on itself.
git-svn-id: svn://10.0.0.236/trunk@88020 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-26 22:50:58 +00:00
dave%intrec.com
964eb35031
Oops, typo in patch. = -> eq
...
git-svn-id: svn://10.0.0.236/trunk@87821 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-23 19:32:13 +00:00
cyeh%bluemartini.com
d9a28fb8af
fix for 66876: Using userids (mediumint) for initialowner and initialqacontact
...
based on patch submitted by baulig@suse.de (Martin Baulig).
git-svn-id: svn://10.0.0.236/trunk@87678 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-22 18:11:29 +00:00
dave%intrec.com
b72541c22a
Fix for bug 49306: Resolution field getting cleared on midair-collision.
...
git-svn-id: svn://10.0.0.236/trunk@87596 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-21 22:13:34 +00:00
cyeh%bluemartini.com
6e713e8510
fix for 28676 :
...
When a bug is marked duplicate, the reporter should be added to the bug that it duplicated.
patch submitted by jake@acutex.net (Jake).
git-svn-id: svn://10.0.0.236/trunk@87145 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-15 22:42:13 +00:00
dmose%mozilla.org
fe2693b9e6
fix for bug found in original 17464 patch, where removal from the CC list was not generating a mail. r=donm@bluemartini.com
...
git-svn-id: svn://10.0.0.236/trunk@87020 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-14 20:41:26 +00:00
tara%tequilarista.org
fe63832e0e
Cleaning up the language for matty for bug #45213
...
git-svn-id: svn://10.0.0.236/trunk@85063 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-18 02:20:04 +00:00
gerv%gerv.net
b7a9e184b2
Formatting change. Trivial.
...
git-svn-id: svn://10.0.0.236/trunk@83626 18797224-902f-48f8-a5cc-f745e15eee43
2000-12-14 12:17:11 +00:00
tara%tequilarista.org
d8048e08f1
Landing duplicates stuff from gervase markham
...
git-svn-id: svn://10.0.0.236/trunk@81621 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-23 22:01:31 +00:00
cyeh%bluemartini.com
f7368dde1b
fix for 49063: no sanity checking when setting duplicate. sanity checking
...
is done for the dup id field, but not for the originating bug id.
now checks to see if the original bug id is valid as well, although i don't
understand how this could get corrupted in the first place
git-svn-id: svn://10.0.0.236/trunk@77486 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-29 18:01:07 +00:00
cyeh%bluemartini.com
dcb7c1906c
fix for 47790 : A bug to track which bugs Zach's bugzilla patch resolves.
...
patches by zach@zachlipton.com . Thanks!
git-svn-id: svn://10.0.0.236/trunk@77360 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-28 17:48:59 +00:00
dave%intrec.com
8229bb32ee
Re-fixing bug 30824 the correct way (which also fixes bug 46753)
...
git-svn-id: svn://10.0.0.236/trunk@76229 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-12 23:30:51 +00:00
tara%tequilarista.org
25ceaa604f
Landing Dave Miller's patch for #25693
...
git-svn-id: svn://10.0.0.236/trunk@74762 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-25 22:00:16 +00:00
endico%mozilla.org
47f5d073f0
Bug moving code is now fully implemented. To use it, turn on the param and set the move related params.
...
git-svn-id: svn://10.0.0.236/trunk@74198 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-13 23:12:52 +00:00
terry%mozilla.org
9126128ba9
Keywords were already enforced to never differ only in capitalization. So, changed the code so that case no longer matters when typing in the name of a keyword.
...
git-svn-id: svn://10.0.0.236/trunk@74167 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-13 20:04:15 +00:00
cyeh%bluemartini.com
8e0ab1fd6e
fixes for the attachment widths. fix by dave@intrec.com (Dave Miller),
...
original bug found by timeless@bemail.org
git-svn-id: svn://10.0.0.236/trunk@73677 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-05 18:21:54 +00:00
cyeh%bluemartini.com
37dd6ebd32
Checkin for Bug 42851 'Use listbox with input for CC management on bug form'
...
contributed by dave@intrec.com (Dave Miller)
git-svn-id: svn://10.0.0.236/trunk@72791 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-21 19:03:45 +00:00