232 Commits

Author SHA1 Message Date
timeless%mozdev.org
af51e73d0e Bug 106386 Correct misspellings in source code
r=bernd rs=brendan


git-svn-id: svn://10.0.0.236/trunk@191013 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-23 09:36:43 +00:00
mark%moxienet.com
be70e1165b 320660 When opening multiple tabs, the first new one is always focused, ignoring browser.tabs.loadInBackground pref. Respect it. Patch by HÃ¥kan Waara <hwaara@gmail.com>. r=smorgan sr=smfr
git-svn-id: svn://10.0.0.236/trunk@189031 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-06 19:47:36 +00:00
cbiesinger%web.de
6322c04952 bug 183156 remove *UCS2* functions, replacing them with *UTF16* ones
r+sr=darin


git-svn-id: svn://10.0.0.236/trunk@188844 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-03 14:18:39 +00:00
smfr%smfr.org
f6a8eccb98 Fix the UI from getting into a locked state when Camino puts up sheet while there is already a modal dialog on screen, or the window already has a sheet. Fixes bugs 279350, 314072. r=mento
Fix bug 324901: hide the checkbox in prompt dialogs when the checkMsg param is null or an empty string, to match FF behaviour. r=mento.
Disable the open menu commands when the window has a sheet on it.


git-svn-id: svn://10.0.0.236/trunk@188419 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-29 04:56:30 +00:00
smfr%smfr.org
f132c3b57a Fix 3 tooltip bugs: 285601, 323387 and 311220. When showing tooltips, make sure that their browser is still frontmost, and that their window is the main window. Also hide tooltips when switching tabs.
Also contains a localized string fix related to bug 321882.


git-svn-id: svn://10.0.0.236/trunk@187678 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-16 05:41:00 +00:00
smfr%smfr.org
d9bceeb765 Fix bug 169816: implement bookmark sorting (really arranging) in Camino. Selecting a single folder will sort its children. Selecting two or more items will sort them together. Holding down the Option key will do a deep sort of all selected items. If nothing is selected, the current collection is sorted (if allowed).
Fix bug 322809: bookmarks toolbar and menu folders should have localized names.
Other fixes:
Re-order the bookmarks and history context menus slightly to reduce the number of separators.
Fix the bookmarks toolbar to not respond to every bookmark update by looking for a button with the changed bookmark.
Fix the bookmarks toolbar to notice child re-orderings and update appropriately.
Clean up the key handling code in ExtendedOutlineView and ExtendedTableView, and make our outline and table views respond to the home and end keys by scrolling to top/bottom.


git-svn-id: svn://10.0.0.236/trunk@187660 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-15 21:03:32 +00:00
smfr%smfr.org
fa4759caaf Fix bug 308897: put a context menu on the lock icon that has items to show the site certificate, and go to Page Info.
Fix the "Reset Camino" warning string to remove the reference to saved passwords (re: bug 320208).
Improve some #include hygiene in AutoCompleteDataSource.h and fallout.
Fix it so that main windows don't have to all implement -autosaveWindowFrame.
Fix some ownership issues in AutoCompleteDataSource that could cause us to use potentially released images in the autocomplete popup.
Push the code for accessing page security information down into CHBrowserView, and change Page Info to use it. Also fix some spelling errors, and improve Page Info strings for mixed content.
Fix an nsIDOMWindow leak in Page Info, and use a already_AddRefed<> return value in CHBrowserView to make ref counting of nsIDOMWindows less prone to bugs.
Change some code to use pre-existing CHBrowserView.h constants.
No longer show the "trust" checkboxes in the certificate view if we can't read the trust settings (cert not in DB), unless we're accepting a CA cert.
When showing a cert from Page Info or the lock icon, show trust for SERVER_CERT usage, rather than CA_CERT usage.
Tweak ad blocking.


git-svn-id: svn://10.0.0.236/trunk@186569 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-25 01:52:35 +00:00
smfr%smfr.org
29fd197f21 Fix Camino bugs:
Bug 319509: When doing Reset Camino, don't prompt about closing windows with multiple tabs open.
Bug 320208: Reset Camino should not clear out keychain passwords, since we don't know whether we created them.
Bug 319491: Reset Camino should clear the visit counts on the bookmarks, thus clearing the top 10 list.

Also changed -getFrontmostBrowserWindow and -browserWindows to not return windows that are not visible (e.g. those that are being created or destroyed), which fixing some odd cascading issues, and should prevent us from ever showing sheets on hidden windows.


git-svn-id: svn://10.0.0.236/trunk@186251 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-19 05:23:49 +00:00
smfr%smfr.org
fadd0891a6 Fix bug 298458: if page content has a oncontextmenu handler, don't show the normal context menu. r=pinkeron
git-svn-id: svn://10.0.0.236/trunk@185988 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-13 07:28:05 +00:00
smfr%smfr.org
7ab6a73865 Fix bug 319257: when opening new windows from external apps, make sure we bring them to the front if appropriate.
git-svn-id: svn://10.0.0.236/trunk@185893 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-10 20:19:25 +00:00
smfr%smfr.org
ebe421a9cc Standardize terminology in Send Link/Email Page Location strings. Bug 315877.
git-svn-id: svn://10.0.0.236/trunk@185682 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-05 03:02:51 +00:00
smfr%smfr.org
b53ff11592 Fix bug 318884: crash when closing last window if built with 10.4u SDK. Don't release menus in the nib.
git-svn-id: svn://10.0.0.236/trunk@185651 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-03 18:54:31 +00:00
smfr%smfr.org
17ed09b145 Fix bug 159048: implement Page Info for camino. This uses a new set of views that have size-to-fix behavior, which are also used now for the certificate view, and the downloads window.
git-svn-id: svn://10.0.0.236/trunk@185563 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-02 05:20:36 +00:00
mark%moxienet.com
5ab4b6a3f0 Bug 314602, Bookmark toolbar doesn't match unified title bar and toolbar on Tiger. When the unified appearance is in effect, draw a matching background for the bookmark toolbar: a vertical gradient with a light top and a darker bottom. Also moves OS feature-check utilities from MainController to NSWorkspace. Camino-only, npotdb. r=smfr
git-svn-id: svn://10.0.0.236/trunk@185022 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-20 23:03:38 +00:00
smfr%smfr.org
ae0564cff6 Fix bug 315810: allow shift modifier key to reverse the sense of the "load in background" pref when loading a url with Command-Return. Patch by Chris Lawson.
git-svn-id: svn://10.0.0.236/trunk@184565 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-14 04:56:05 +00:00
smfr%smfr.org
fd6b8df3ac Change the Camino pref pane identifiers to contain "org.mozilla.camino" rather than "org.mozilla.chimera", and fix the text encoding of many of the pref panel Localized.strings files.
git-svn-id: svn://10.0.0.236/trunk@182574 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-20 02:31:36 +00:00
smfr%smfr.org
2b8bd9c844 Fix bug 175863: Add a "reload all tabs" item to the tab context menu. Patch by Chris Lawson.
git-svn-id: svn://10.0.0.236/trunk@182464 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-18 17:44:41 +00:00
smfr%smfr.org
45f6edada1 Fix bug 196359: show an optional warning when closing a window with multiple tabs, or quitting when multiple windows or tabs are open. Patch partially by Nathaniel Madura.
git-svn-id: svn://10.0.0.236/trunk@182439 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-18 04:06:55 +00:00
smfr%smfr.org
2bd5264d46 Fix camino bug 311683. The earlier fix for bug 297343 introduced a short delay before the dispatch of focus/activate events on window activation. It turns out that this was bad, as you could end up with two windows which continually each come to the front ("duelling windows"). This patch makes things synchronous again, but fixes the original bug by exposing a category on NSWindow in the widget code that allows the embedder to know if a SetFocus() call is coming as a result of window activation. r=mento
git-svn-id: svn://10.0.0.236/trunk@182094 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-12 17:38:29 +00:00
smfr%smfr.org
2b7daeecde Rename the -[PreferenceManager homePage:] method to -[PreferenceManager homePageUsingStartPage:].
Also add the ability to map Gecko pref changed callbacks into NSNotifications, via the PreferenceManager.


git-svn-id: svn://10.0.0.236/trunk@182038 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-12 00:48:34 +00:00
smfr%smfr.org
6190c513a8 Fix bug 299030: ensure that we correctly update the Close Window menu shortcut when closing a multi-tabbed window with another simple window behind it.
git-svn-id: svn://10.0.0.236/trunk@181829 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-09 00:24:30 +00:00
smfr%smfr.org
a3b90777f9 Fixes for Camino bugs:
311049: fix focus issue in popup windows.
307743: export of bookmark keywords etc (patch by Chris Lawson).
293768: we now remember which container was selected in bookmarks.

Fixed HTML export by ensuring that the root folder has the appropriate special flag set.
Fixed "Redo" when moving a bookmark within a folder.
Fixed the first Undo after showing bookmarks (which used to throw an exception) by avoiding using the bookmarks undo manager for URL bar text operations.
Fixed drag and drop in the bookmarks to show the correct feedback when copying, and allow copying into the containers table again.
Fixed Undo in the url bar to not create undo items for no-op changes.
Fixed the context menu for empty rows in the bookmarks to enable the "New Folder" item.

Also cleaning up bookmarks reading and import code to deal better with corrupted bookmarks files, ensuring that we always end up with toolbar and menu containers. Fixed setting up the toolbar folder from a bookmarks.xml conversion. Allow us to read a Safari Bookmarks.plist file as the bookmarks file (rather than an import) in case a user copies it over. Break assumptions about the container ordering, so that if container folders get moved around in the bookmarks file, we'll still find them OK.


git-svn-id: svn://10.0.0.236/trunk@181674 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-05 20:24:03 +00:00
smfr%smfr.org
b41bbabdde Fix bug 299758: ensure that "Add to Address Book" string is localizable. Patch by Smokey Ardisson.
git-svn-id: svn://10.0.0.236/trunk@181272 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-30 04:17:27 +00:00
smfr%smfr.org
e30266dd2a Camino part of fix for bug 297343: avoid re-entrant -[NSWindow makeKeyAndOrderFront:] calls by postponing the focus and activate calls into Gecko so that they get called the next time through the event loop, when window visibility and key status are correct. This allows embedder code that implements to nsIEmbeddingWindow::SetFocus() to check those and avoid re-entrant/redundant makeKeyAndOrderFront: calls. r=mento. Only affects Camino.
git-svn-id: svn://10.0.0.236/trunk@181250 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-30 00:55:05 +00:00
smfr%smfr.org
9d6c876510 Fix bug 308219: don't load the throbber images if we don't have to.
git-svn-id: svn://10.0.0.236/trunk@180048 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-12 20:10:27 +00:00
smfr%smfr.org
b6ab0bc8f4 Fix bug 307837: Choose sensible window bounds if no bounds are saved in user defaults. r=mark.
git-svn-id: svn://10.0.0.236/trunk@179951 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-10 05:29:25 +00:00
smfr%smfr.org
dea7fb0ccc Fix bug 160008: make keyword lookups happen from the location sheet. patch by Ulrik Sverdrup, r=me, sr=pinkerton.
git-svn-id: svn://10.0.0.236/trunk@179915 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-09 17:56:00 +00:00
smfr%smfr.org
dd58b7a7ad Fix bug 242906 and bug 181158: wrong context menu and possible crash when context-clicking on embeds. We were keeping stale, non-owned pointers to DOM nodes in the BrowserWindowController. Fixed by clearing out those pointers when we get back to the main event loop (making use of the autorelease of a little dummy object). r=pinkerton
git-svn-id: svn://10.0.0.236/trunk@179214 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-29 17:55:07 +00:00
smfr%smfr.org
ffde60f96b Fix bug 306084: avoid crashes when closing the last tab (or trying to move it to a new window), and disable the menu items as appropriate.
git-svn-id: svn://10.0.0.236/trunk@179123 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-27 03:43:23 +00:00
smfr%smfr.org
d4b4a80f53 Fix bug 174427: if hitting Return in an empty url bar, keep focus in the url bar. r=pinkerton
git-svn-id: svn://10.0.0.236/trunk@179007 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-25 22:48:31 +00:00
pinkerton%aol.net
24bc8fca4c dbl-click on tab bg creates a new fg tab.
git-svn-id: svn://10.0.0.236/trunk@178700 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-23 16:50:13 +00:00
pinkerton%aol.net
987f48de94 change window stagger to the height of the titlebar to match HIG (bug 288390)
git-svn-id: svn://10.0.0.236/trunk@177296 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-07 22:03:10 +00:00
pinkerton%aol.net
e6ee9e3981 reduce click-hold delay on back/fwd buttons to 0.45 (bug 296596)
git-svn-id: svn://10.0.0.236/trunk@177294 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-07 20:28:07 +00:00
smfr%smfr.org
e5fd666f67 Fix bug 160008: make autocomplete work in the Location sheet.
git-svn-id: svn://10.0.0.236/trunk@177016 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-02 20:28:45 +00:00
pinkerton%aol.net
1911232793 add toolbar button to show history (bug 229957)
git-svn-id: svn://10.0.0.236/trunk@176914 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-01 01:03:10 +00:00
smfr%smfr.org
b7342a473c Fix bug 302732: favicon can remain in tab when going back/forward; fixed by swapping favicons even if there is no new network load (which happens wiht bfcache).
Fix bug 195169: when making bookmarks, we save the URL with relataive anchors now (before, we just used the page URL).
Fix bug 295731: when a favicon loads, make sure it's for the current page before showing it.
Fix bug 231039: we save the bookmarks splitter location now.
Fix bug 284829: about:bookmarks/about:history have a favicon now.
Fix bug 293768: we save the expanded state of bookmarks folders in the bookmarks outliner now (which requires us to save UUIDs to the bookmarks file)
Maybe help bug 289769: avoid using 'nil' as a premature argument to [NSDictionary dictionaryWithObjectsAndKeys], which may have contributed to lost bookmarks.
Fix bug 285097: show the correct (localizable) window title for bookmarks and history.

Code cleanup: removed [CHBrowserView getCurrentURLSpec] and replaced all calls with calls to [CHBrowserView getCurrentURI], which should return the same thing. Standardized wrapper methods to match.


git-svn-id: svn://10.0.0.236/trunk@176906 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-31 22:36:56 +00:00
joshmoz%gmail.com
e6d51687a6 fix bad access of protected variable. b=302264 r=mento
git-svn-id: svn://10.0.0.236/trunk@176649 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-26 22:46:47 +00:00
smfr%smfr.org
44397e0be9 NSWindowController releases the nib items for you, so we don't have to, so these extra retains are wrong.
git-svn-id: svn://10.0.0.236/trunk@176522 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-25 15:59:12 +00:00
smfr%smfr.org
37c025b139 Fix bug 176421: even if window.open() hides parts of the chrome with chrome flags, make sure the user can show the toolbar and bookmarks toolbar.
git-svn-id: svn://10.0.0.236/trunk@176508 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-25 01:00:37 +00:00
smfr%smfr.org
5945faf6e1 Make sure we release top-level nib items to reduce leaking.
git-svn-id: svn://10.0.0.236/trunk@176501 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-24 22:56:16 +00:00
smfr%smfr.org
7e17199091 Finish off bug 294019: when opening a set of urls in tabs, select the first tab that we changed.
git-svn-id: svn://10.0.0.236/trunk@176414 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-21 22:30:13 +00:00
smfr%smfr.org
63178370b6 Fix bug 294019: when opening files, open them in the current and later tabs, rather than the first tab (patch by Nick Kreeger).
Clean up bookmarks loading code to be clearer about the threading model, and avoid the need for locking.
Removing the RunLoopMessenger stuff which we no longer need on 10.2 and later.


git-svn-id: svn://10.0.0.236/trunk@176348 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 19:01:36 +00:00
smfr%smfr.org
9e28f48109 Fix bug 298320: when showing a prompt via nsIPromptService, make sure that the tab from which the prompt originates is brought to the front. r=josh
git-svn-id: svn://10.0.0.236/trunk@175274 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-29 01:25:35 +00:00
smfr%smfr.org
2ab51e7eab Fix bug 279270: remove unused code adding nsICommandParams to cmd_copyImageContents. Also fix warning relating to calling closeTab on a tab view item.
git-svn-id: svn://10.0.0.236/trunk@175201 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-28 04:24:16 +00:00
joshmoz%gmail.com
f1eb0b2e88 get rid of blue globe/lock icon in status bar for UI cleanliness reasons. what did the blue globe mean anyway? b=297138 r=armen sr=pinkerton
git-svn-id: svn://10.0.0.236/trunk@174367 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-09 18:09:57 +00:00
smfr%smfr.org
8efc99418e Add site icons to the history outliner and history menus.
Add support for site icons specified in link elements (bug 162893), part of patch by Ludovic Hirlimann.
Add a site icon image cache, so that we can get site icons without a round trip through necko, and avoid duplicate images (bug 294675).
Add a Clear History item to the end of the go menu (bug 294205).
Make the history menus no more than 100 items long, with a "Show More" item at the end, to avoid long delays when showing them (bug 291414).


git-svn-id: svn://10.0.0.236/trunk@173698 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-23 03:36:08 +00:00
pinkerton%aol.net
ed37a67244 add toolbar item for form fill
git-svn-id: svn://10.0.0.236/trunk@172990 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-03 14:49:57 +00:00
pinkerton%aol.net
336b5387c0 manual form fill
git-svn-id: svn://10.0.0.236/trunk@172932 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-01 17:59:45 +00:00
pinkerton%aol.net
3f9679fac3 if status bar or bookmark bar are turned off from JS flags, dont allow
tab bar to always show if pref is on and don't register for the pref
changed notifications (bug 291786)


git-svn-id: svn://10.0.0.236/trunk@172688 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-25 14:49:25 +00:00
pinkerton%aol.net
e1fb44ac0b pref to have tab bar always visible (bug 162241)
git-svn-id: svn://10.0.0.236/trunk@172650 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-23 21:09:04 +00:00