21 Commits

Author SHA1 Message Date
chanial%noos.fr
29b34a142a removing comm.jar dependencies in the bookmarks component. Escape close the window and fix for bug 168412.
Also remove the bookmark edit command (ex: cmd_bm_paste) and use the edit ones instead (ex: cmd_paste)


git-svn-id: svn://10.0.0.236/trunk@147945 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-14 05:20:35 +00:00
chanial%noos.fr
fb4929d722 - fix regression 221118: Can't drag links into bookmark manager or bookmark sidebar.
- logic change: a transaction will not be performed when one of its item can not be acted on. Before, the only the valid items were processed. A LOT of simplifications have come up. I am slowly moving toward the resolution of bug 168411, by simplifying the interface that will be needed to move the transactions to the bookmarks service.
- fix bug 221550: the selection is not retained when performing an invalid transaction
- no need to restore the selection after an action that doesn't touch the datasource.
- during a batch, the bookmarks toolbar observer wasn't notified.
- much faster preUpdateTreeSelection
- various code cleanup
- DND bookmarks in tree is now significantly faster.
- still need to figure out what is the best BATCH_LIMIT value.


git-svn-id: svn://10.0.0.236/trunk@147752 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 09:01:48 +00:00
chanial%noos.fr
21d5f7a905 checking in back the fix for bug 172113.
an additional fix is included: if no ...#BookmarksToolbarFolder arc is found, then search for an (obsolete) resource "NC:PersonalToolbarFolder" (221410).
When none of them is found, then a new btf is created (only once!).


git-svn-id: svn://10.0.0.236/trunk@147747 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 08:17:23 +00:00
chanial%noos.fr
9ae0c6a598 For the next cycles: backing out the changes for bug 172113 to investigate perf because I landed them just after the tinderbox went down and also because large landings occurred before it went up.
git-svn-id: svn://10.0.0.236/trunk@147740 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-08 04:45:29 +00:00
chanial%noos.fr
25c51f48de - bug 172113: rewrite the way we handle the bookmarks toolbar folder. Now, there is no more 2 ways to characterize the BTF: by an arc to the resource "...#BookmarksToolbarFolder" that points to the literal "true". As a consequence, the resource NC:PersonalToolbarFolder and "...#folderType" are dead.
- remove unused functions. Note that RDF commands were already broken, so deleteBookmarkItem and insertBookmarkItem (that were not used) may come back, but in another form.
- remove the "New Bookmark Folder" and "New Search Folder"
- refactor the "html" serializer to avoid some duplicated code.
- remove the use of the profile name for the bookmarks root.
- enforce synthax "aArgument" in some random places.


git-svn-id: svn://10.0.0.236/trunk@147534 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-03 20:30:14 +00:00
blakeross%telocity.com
583f9b7c15 Hacky workaround for bug 210910 -- to be removed after 0.7.
git-svn-id: svn://10.0.0.236/trunk@146390 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-27 19:03:27 +00:00
hyatt%mozilla.org
539151a004 Fix Open in Tabs on Mac with a hacky JS workaround.
git-svn-id: svn://10.0.0.236/trunk@145829 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-10 01:50:05 +00:00
noririty%jcom.home.ne.jp
c2ada7156d Fix 213787 - Add an id for 'Open in Tabs' menuseparator. Patch by logan@dct.com.
git-svn-id: svn://10.0.0.236/trunk@145749 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-08 14:42:01 +00:00
hyatt%mozilla.org
be959c309a Slight simplifcation to the way open in tabs works.
git-svn-id: svn://10.0.0.236/trunk@145606 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-05 08:59:45 +00:00
noririty%jcom.home.ne.jp
c96af621ca Bug 180156 - fix overlap chevron, patch (mostly) by dkoppenh@null.net
git-svn-id: svn://10.0.0.236/trunk@145515 18797224-902f-48f8-a5cc-f745e15eee43
2003-08-03 14:49:27 +00:00
varga%netscape.com
c1c2acd6b5 Landing bookmarks changes.
Bug 205378 - Meta bug for changes in bookmarks sorting code
r=jag, sr=sspitzer, a=sspitzer,asa

The CloneResource() has been back ported from Firebird, originally
implemented by Pierre Chanial.


git-svn-id: svn://10.0.0.236/trunk@142814 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-23 12:03:40 +00:00
chanial%noos.fr
88582fb263 bug 200480: cut/paste doesn't work on folders and separators
git-svn-id: svn://10.0.0.236/trunk@141763 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-24 21:46:55 +00:00
chanial%noos.fr
eaf5d01d31 dropping folder group support
git-svn-id: svn://10.0.0.236/trunk@141695 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-23 15:05:10 +00:00
chanial%noos.fr
20126ee452 fixing middle click in menus
git-svn-id: svn://10.0.0.236/trunk@141630 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-22 23:12:25 +00:00
chanial%noos.fr
54ca88ecde fixing 'open in tabs' and commenting
git-svn-id: svn://10.0.0.236/trunk@141565 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-22 02:55:55 +00:00
chanial%noos.fr
bb48f9fed0 1) porting back in phoenix a refactoring I made in seamonkey wrt loading bookmarks
2) no context menus on the static menu items. (original patch by Chu Alan)


git-svn-id: svn://10.0.0.236/trunk@141527 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-21 20:11:58 +00:00
chanial%noos.fr
c7c6082125 getting back phoenix bookmarks in sync with seamonkey
first step to clean the 'add bookmark' mess (removing a flag because we always show the dialog, and moving addBookmarkFor*Browser in browser.js where it belong)


git-svn-id: svn://10.0.0.236/trunk@141506 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-21 05:47:02 +00:00
chanial%noos.fr
1b4bbe7752 Bug 194756: fix doubled bookmarks in the toolbar by moving the tooltip definition outside of the toolbar in order not to confuse the template builder.
git-svn-id: svn://10.0.0.236/trunk@138545 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-26 16:37:46 +00:00
chanial%noos.fr
6da209b5be fix DND in an empty area of the bookmarks toolbar
fix chevron menu update


git-svn-id: svn://10.0.0.236/trunk@138424 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-25 04:45:31 +00:00
chanial%noos.fr
44c80338cc fix middle click regression in the bookmarks menus
git-svn-id: svn://10.0.0.236/trunk@138380 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-24 22:11:11 +00:00
chanial%noos.fr
6232b15b6b Fixes for:
bug 168504: de-XBLify the bookmarks toolbar
bug 172328, 172291: various DND problems
bug 192028: add context menus to the bookmark menu and the bookmarks toolbar.


git-svn-id: svn://10.0.0.236/trunk@138306 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-23 21:49:19 +00:00