1196 Commits

Author SHA1 Message Date
myk%mozilla.org
cb97f8190d Fix for bug 109240: fixes the regression that changed the way comments regarding attachment creation are formatted.
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org, no second review needed.


git-svn-id: svn://10.0.0.236/trunk@108542 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 02:59:55 +00:00
zach%zachlipton.com
a8d489f851 Fix for bug 107120, templates/default/global/header has invalid HTML.
Patch removes a <meta> tag as per bug 38856.

Patch by David D. Kilzer <mailto:ddkilzer@theracingworld.com>.
r1=Christopher Aillon <mailto:caillon@returnzero.com>. No 2nd review
required as per caillon.


git-svn-id: svn://10.0.0.236/trunk@108525 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-20 01:59:57 +00:00
gerv%gerv.net
f2a3c7158a Bug 98707. Query.cgi rewrite. Patch by me, layout by mpt and others, r=justdave, mattyt. Wahey!
git-svn-id: svn://10.0.0.236/trunk@108457 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 22:23:31 +00:00
gerv%gerv.net
34838abe95 Bug 98707. Query.cgi rewrite, reformatting and templatisation. Patch by me, layout by mpt and others, r=justdave,matty. Wahey!
git-svn-id: svn://10.0.0.236/trunk@108455 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 22:20:20 +00:00
matty%chariot.net.au
ca6d7f14fc Moving a comment to the right place, in order to be able to make a comment about my previous check in that accidentally got checked in without a comment, and hence didn't show up on Tinderbox I think.
It was a change to CGI.pl, a fix for bug 105812: Rename "Components" link in sub GetCommandMenu() to "Products".

The patch was by James A Laska <jlaska@us.ibm.com>.


git-svn-id: svn://10.0.0.236/trunk@108420 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 03:54:54 +00:00
matty%chariot.net.au
067fbac069 *** empty log message ***
git-svn-id: svn://10.0.0.236/trunk@108419 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-18 03:22:50 +00:00
justdave%syndicomm.com
bfa6922bde Fix for bug 100788: enter_bug.cgi wasn't correctly interpretting whether or not a partial URL needed an http:// added to the
front of it, which had the side-effect of duplicating the http:// on the front when a URL was passed from Bugzilla Helper.
Patch by Josh Soref <timeless@mac.com>
r= justdave, caillon


git-svn-id: svn://10.0.0.236/trunk@108404 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 23:05:48 +00:00
justdave%syndicomm.com
f7a62b41f9 Fix for bug 109354: After entering a new bug, the link offering to add an attachment to the bug you just created pointed at
the old attachment form instead of the new one.
Patch by Josh Soref <timeless@mac.com>
r= myk x2


git-svn-id: svn://10.0.0.236/trunk@108402 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 22:40:02 +00:00
justdave%syndicomm.com
b696d2648c Fix for bug 107120: templates/default/global/header was generating HTML that wouldn't validate as HTML 4.01 Transitional
Patch by Dave Miller <justdave@syndicomm.com>
r= jake, bbaetz


git-svn-id: svn://10.0.0.236/trunk@108401 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 22:25:15 +00:00
justdave%syndicomm.com
1a5671d3ab Fix for bug 92500: line-feeds were not being properly converted when submitting parameter changes with some Mac browsers.
Patch by Gervase Markham <gerv@mozilla.org>
r= ddk, justdave


git-svn-id: svn://10.0.0.236/trunk@108399 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 22:18:07 +00:00
justdave%syndicomm.com
ab0ed93ca8 Backing out previous checkin, it broke the tree. :(
git-svn-id: svn://10.0.0.236/trunk@108396 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:28:24 +00:00
justdave%syndicomm.com
2f07aa0c10 Fix for bug 102487: If admin has set preferences to require a comment on a product/component change, prompt the user that they
forgot to comment first, before prompting for component, milestone, and version for new product.
Patch by Garvase Markham <gerv@mozilla.org>
r= kiko, ddk


git-svn-id: svn://10.0.0.236/trunk@108394 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:12:53 +00:00
justdave%syndicomm.com
38ae4f7251 Fix for bug 12284: allow user to specify which columns to display in a bug list
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= gerv, kiko


git-svn-id: svn://10.0.0.236/trunk@108392 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 21:04:37 +00:00
zach%zachlipton.com
0d8c3fd7a1 Fix the double testing of .pm files.
No review needed for tests at this time.


git-svn-id: svn://10.0.0.236/trunk@108382 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 17:29:06 +00:00
matty%chariot.net.au
2ddf8be3ca Bug 104677 : Votes field (text style) on showvotes.cgi defaults to size 5, not natural size and doesn't include a maxlength attribute.
Patch by Christoper Aillon <caillon@returnzero.com>.


git-svn-id: svn://10.0.0.236/trunk@108373 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 10:29:55 +00:00
bbaetz%cs.mcgill.ca
eb246d5306 Bug 101560, pt 2. Perl 5.00503 gives a (bogus?) warning which 5.6 doesn't.
Quote manually rather than using qw to get arround this


git-svn-id: svn://10.0.0.236/trunk@108365 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 07:57:25 +00:00
bbaetz%cs.mcgill.ca
3bc2957b7a Bug 101560 - clear some more env vars so that system calls will run in
taint mode. The perforce integration stuff needs this.

r=gerv,mattyt


git-svn-id: svn://10.0.0.236/trunk@108362 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 07:19:46 +00:00
gerv%gerv.net
52ebafa034 Bug 6419 - command-line query tools by Andreas Franke <afranke@ags.uni-sb.de>.
git-svn-id: svn://10.0.0.236/trunk@108177 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-15 17:04:58 +00:00
bbaetz%cs.mcgill.ca
9ca8a3c375 Bug 107718 pt 2 - use subtraction instead of the ~ operator, which older
mysql versions don't support. Remove the checksetup.pl restriction, too.

r=jake x2


git-svn-id: svn://10.0.0.236/trunk@108061 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-14 15:12:23 +00:00
jake%acutex.net
ff3e46489b We don't really need to look for fragments that are pulled in by [% INCLUDE %] or [% PROCESS %]. While removing this code bit doesn't allow us to seperatly check that those fragments exist and compile, they'll be checked atomatically when the the template that wants them is run through the process() routine by the 004template.t test. This issue was raised because bug 98707 introduced a [% BLOCK %] element and the syntax for using that is the same as for including a template fragment.
git-svn-id: svn://10.0.0.236/trunk@108008 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-14 03:44:07 +00:00
gerv%gerv.net
8891347238 Fix license headers and make attachment changed page look like bug changed page. Bug 99518 and 98110. r-myk, no second review.
git-svn-id: svn://10.0.0.236/trunk@107963 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-13 17:24:24 +00:00
jake%acutex.net
9b3a845780 Fix for bug 86300 - If a bug didn't exist and GetBugLink() tried to create a tooltip for it, you'd get uninitialized variables warnings in your error log. This path also introduces a cache so if the same bug # is mentioned more than once during the same running of the script, it only has to query the database once.
r= mattyt, gerv


git-svn-id: svn://10.0.0.236/trunk@107921 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-12 13:43:59 +00:00
bbaetz%cs.mcgill.ca
58006fb10f Oops. Bug 109690 again, r=justdave, gerv
git-svn-id: svn://10.0.0.236/trunk@107916 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-12 05:47:24 +00:00
bbaetz%cs.mcgill.ca
c2a13c0ac1 Bug 109690: Check $bug before using it.
r=justdave,gerv


git-svn-id: svn://10.0.0.236/trunk@107915 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-12 05:39:14 +00:00
timeless%mac.com
01aa33c91c Bugzilla Bug 109138 platform detection not working on macintosh
r=bbaetz,dkl


git-svn-id: svn://10.0.0.236/trunk@107728 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-09 05:32:43 +00:00
myk%mozilla.org
94f803c2c3 Fix for bug 109048: fixes error when creating attachments without logging in.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv


git-svn-id: svn://10.0.0.236/trunk@107716 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-09 01:11:09 +00:00
justdave%syndicomm.com
e78b6416c2 Fix for bug 99519: timestamps were not being set correctly in the activity table in some situations, and the delta_ts on the
bug itself was not always being updated if dependencies or CCs changed.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake


git-svn-id: svn://10.0.0.236/trunk@107644 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 03:38:12 +00:00
myk%mozilla.org
3b483d8209 Fix for bug 104652: Duplicate bugs in the dependency tree now get marked with the message "This bug appears elsewhere in this tree." so users know why the bug does not appear to have dependencies.
Patch by Gerv <gerv@mozilla.org>.
r=jake@acutex.net,myk@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@107640 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 02:43:55 +00:00
myk%mozilla.org
f128dfb46b Fix for bug 108822: Prevent any user from changing their own groupset.
Patch by Jake <jake@acutex.net>.
r=bbaetz,myk


git-svn-id: svn://10.0.0.236/trunk@107633 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 00:54:15 +00:00
myk%mozilla.org
37c1fa29af Fix for bug 108821: Prevent users with any blessgroupset privileges from blessing any group set.
Patch by Jake <jake@acutex.net> and Bradley <bbaetz@cs.mcgill.ca>.
r=jake,myk for Bradley's portion, r=bbaetz,myk for Jake's portion.


git-svn-id: svn://10.0.0.236/trunk@107632 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 00:52:13 +00:00
myk%mozilla.org
f0967cda10 Fix for bug 108812: Prevent users from running queries containing arbitrary SQL.
Patch by Jake <jake@acutex.net>
r=bbaetz,myk


git-svn-id: svn://10.0.0.236/trunk@107631 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-08 00:49:18 +00:00
bbaetz%cs.mcgill.ca
8904a09db5 Require (temporarily) mysql >= 3.23.5 for the ~ operator, needed for the
fix to bug 107718. This should be removed when the group stuff lands (bug
60822).

r=justdave x 2


git-svn-id: svn://10.0.0.236/trunk@107624 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-07 22:42:32 +00:00
bbaetz%cs.mcgill.ca
9caaabcc10 Bug 101166 - users seeing a bug via _accessible bits should see that its
the group

r=justdave,jake


git-svn-id: svn://10.0.0.236/trunk@107605 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-07 16:11:33 +00:00
jake%acutex.net
7a6b9817cc Bug 108547 - Make the JavaScript use proper DOM
Patch by Christopher Aillon <caillon@returnzero.com>
r= timeless@bemail.org, kiko@async.com.br


git-svn-id: svn://10.0.0.236/trunk@107604 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-07 14:58:56 +00:00
jake%acutex.net
b4c2275ed0 Refixing bug 71840 - The name should be the 'name' should be the same as what the 'href' points it too...
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@107468 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-06 18:06:02 +00:00
justdave%syndicomm.com
2d28f97361 SECURITY FIX see bug 108385: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to add a comment to a bug pretending to be someone else if you edited the HTML by hand before submitting. The bug form did not include the field in question, but due to legacy processing code, the field was still trusted if it was present.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake x2


git-svn-id: svn://10.0.0.236/trunk@107350 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-05 20:47:17 +00:00
justdave%syndicomm.com
2218691609 SECURITY FIX see bug 108516: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to file a
bug pretending to be someone else if you edited the HTML by hand before submitting.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake


git-svn-id: svn://10.0.0.236/trunk@107349 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-05 20:43:35 +00:00
timeless%mac.com
b2399744c5 Bugzilla Bug 107672 Browser OS/Platform discrimination alg sucks
r=bbaetz, jake
Windows XP references are #'d because of bug 92763


git-svn-id: svn://10.0.0.236/trunk@107311 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-05 04:44:34 +00:00
bbaetz%cs.mcgill.ca
b2918e050d Bug 107718 - mass changes give all changed bugs the groupset of the first
bug in the list.

Do bit fiddling instead of adding groupsets from the first bug.

r=justdave, jake


git-svn-id: svn://10.0.0.236/trunk@107224 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-03 05:49:23 +00:00
justdave%syndicomm.com
4aaa66afe8 Fix for bug 105773: Email addresses in the CC list are now sorted case-insensitively
Patch by Adam Kennedy <bugzilla@ali.as>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@107178 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-03 02:05:43 +00:00
justdave%syndicomm.com
a0a44f7175 Fix for bug 95615: cosmetic change to clarify error message when trying to use too many votes
Patch by Adam Kennedy <bugzilla@ali.as>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@107115 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-02 20:05:13 +00:00
jake%acutex.net
066f569e09 Fixing tinderbox bustage (removing <Tab>s and adding a "use vars" line)
git-svn-id: svn://10.0.0.236/trunk@106800 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-31 03:31:00 +00:00
zach%zachlipton.com
a96de0e001 Have the tests test .pm files as well, yes this creates bustage, this is
intentional!

No review needed for tests at this time.


git-svn-id: svn://10.0.0.236/trunk@106772 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-31 01:06:31 +00:00
myk%mozilla.org
b5c6611091 Fix test bustage by removing tabs.
git-svn-id: svn://10.0.0.236/trunk@106762 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-31 00:21:28 +00:00
myk%mozilla.org
dc4c583cd4 Fix for bug 98602: re-implementation of "create attachment" page.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org,jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106739 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-30 23:42:22 +00:00
zach%zachlipton.com
87b667ee3b Fix for bug 96675: checksetup should require admin e-mail address satisfy emailregexp. This fix has
checksetup.pl use the emailregexp set in params if the params file exists, or ensures that it matches the
default emailregexp from defparams.pl.

r1=justdave, r2=bbaetz.


git-svn-id: svn://10.0.0.236/trunk@106499 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-28 03:40:59 +00:00
jake%acutex.net
be3ee559e5 A few enhancements to the template test:
* If there's a compilation error, report what it is
 * Don't try to compile a template if it doesn't exist
   - We already tested for that and issued an ERROR
 * Define the 'url' FILTER


git-svn-id: svn://10.0.0.236/trunk@106481 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-27 15:27:31 +00:00
jake%acutex.net
d377a74d28 Bug 105879 - Footer links have an extra | by Sanity Check
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106377 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-26 18:49:33 +00:00
jake%acutex.net
6786208022 Bug 81594 - SQL error after editing user entry when changing numerous things at once (including the login name).
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106375 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-26 18:35:04 +00:00
jake%acutex.net
e8bbc7ef2a Check templates for tabs, also.
git-svn-id: svn://10.0.0.236/trunk@106358 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-26 13:21:38 +00:00