58 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
3c3491cd57 Bug 686786: Decreasing votestoconfirm in editproducts.cgi crashes Bugzilla
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@262922 18797224-902f-48f8-a5cc-f745e15eee43
2011-09-28 23:33:06 +00:00
mkanat%bugzilla.org
a8771e6751 Bug 679516: Call Bugzilla::Object->remove_from_db when deleting an object
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262725 18797224-902f-48f8-a5cc-f745e15eee43
2011-08-21 18:46:14 +00:00
mkanat%bugzilla.org
586717bbda Bug 653477: (CVE-2011-2380) [SECURITY] Group names can be guessed when creating or editing a bug
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262581 18797224-902f-48f8-a5cc-f745e15eee43
2011-08-04 20:17:35 +00:00
mkanat%bugzilla.org
d678fe0c21 Bug 553266: config.cgi?ctype=rdf spends most of its time loading flagtypes from the database
a=LpSolit (module owner)


git-svn-id: svn://10.0.0.236/trunk@261430 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-20 00:48:51 +00:00
mkanat%bugzilla.org
782a4a185f Bug 519835: Remove Bugzilla::Product::check_product() in favor of Bugzilla::Product->check()
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260656 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-07 02:01:50 +00:00
mkanat%bugzilla.org
53343dad0b Bug 514618: Allow restricting the visibility and values of fields by
classification.
r=mkanat, r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260630 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-05 22:02:05 +00:00
mkanat%bugzilla.org
1be00a65d9 Bug 572602: Change the way that Bugzilla::Object determines what fields
are required for create(). It now assumes that any column that is NOT NULL
and has not DEFAULT in the database is required. We also shift the burden
of throwing errors about empty values to the validators. This fixes the bug
that Bugzilla::Bug->create() wasn't populating default values for fields
if they weren't specified in the create() parameters.
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260542 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-24 00:47:53 +00:00
mkanat%bugzilla.org
79a5fd7406 Bug 556731 - Make Bugzilla::Milestone, Bugzilla::Version, and
Bugzilla::Component use VALIDATOR_DEPENDENCIES instead of UPDATE_VALIDATORS
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260308 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-14 14:32:41 +00:00
mkanat%bugzilla.org
3a08c53603 Bug 526189: Refactor the way that groups are checked for being validly
settable in a particular product, to eliminate the possibility of ever
setting an inactive or invalid group on a product.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259989 18797224-902f-48f8-a5cc-f745e15eee43
2010-03-16 05:45:48 +00:00
mkanat%bugzilla.org
913bf84f3e Bug 526184: Allow groups to be specified when creating bugs using email_in.pl
or the WebService Bug.create method.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259796 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-23 00:31:25 +00:00
mkanat%bugzilla.org
bcd3592f3b Bug 547428: SQL error when deleting a product and its related series when it has none
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259767 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-20 16:02:37 +00:00
mkanat%bugzilla.org
a68210b184 Bug 372979: Make voting into an extension
r=mkanat, a=mkanat, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259709 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-15 23:32:10 +00:00
mkanat%bugzilla.org
095f29b6d2 Bug 487508: Allow restricting the visibility of custom fields and values by component
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259590 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-03 20:21:09 +00:00
mkanat%bugzilla.org
3875453816 Bug 514970: Clean up duplicates.cgi and make it use Bug objects
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259557 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-01 23:57:10 +00:00
mkanat%bugzilla.org
7ec4e12560 Bug 162060: Remove the relationship between "votestoconfirm" and whether or not the UNCONFIRMED status is available, by adding a checkbox to enable the UNCONFIRMED status in editproducts.cgi.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259248 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-17 23:31:56 +00:00
mkanat%bugzilla.org
19291a798d Bug 369489: Remove the milestoneurl feature and link "Target Milestone" to the fields.html page
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259215 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-13 22:07:50 +00:00
mkanat%bugzilla.org
b31ce53818 Bug 523411: Hook: product-end_of_create
Patch by Dave Lawrence <dkl@redhat.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259100 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-30 04:18:37 +00:00
lpsolit%gmail.com
67c5dcfe48 Bug 451716: Deleting a product does not remove its entries from the 'Series' table - Patch by Frédéric Buclin <LpSolit@gmail.com> r=gerv a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@259066 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-23 22:46:48 +00:00
mkanat%bugzilla.org
3945837e05 Bug 522404: Allow Bugzilla::Product->create to create multiple products in one script.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258773 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-24 05:24:53 +00:00
mkanat%bugzilla.org
2c0d810ad2 Bug 522396: Bugzilla::Product->create should do better with missing input fields
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258753 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-22 22:33:34 +00:00
lpsolit%gmail.com
03cbd960b2 Bug 500900: Confirming bugs requires NEW state to exist - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@257612 18797224-902f-48f8-a5cc-f745e15eee43
2009-07-01 11:06:37 +00:00
ghendricks%novell.com
85f515c346 Bug 493090 - Product disallownew should be converted to isactive
patch by ghendricks r=mkanat a=mkanat


git-svn-id: svn://10.0.0.236/trunk@257245 18797224-902f-48f8-a5cc-f745e15eee43
2009-05-20 23:10:23 +00:00
lpsolit%gmail.com
67dd7b4dac Bug 471871: Bugzilla::Version has duplicated code compared to Bugzilla::Object (make Bugzilla::Version really a subclass of Bugzilla::Object) - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@256879 18797224-902f-48f8-a5cc-f745e15eee43
2009-04-10 09:36:46 +00:00
lpsolit%gmail.com
bfda31bbd9 Bug 478972: Remove the 'useentrygroupdefault' parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@256770 18797224-902f-48f8-a5cc-f745e15eee43
2009-03-31 19:17:03 +00:00
mkanat%bugzilla.org
c1235fcba2 Bug 371995: Allow the Product field to restrict visibility of custom fields
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@256152 18797224-902f-48f8-a5cc-f745e15eee43
2009-02-08 19:42:49 +00:00
lpsolit%gmail.com
c66c43cd5e Bug 339381: Make Bugzilla::Classification use Bugzilla::Object - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@255698 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-02 13:47:57 +00:00
mkanat%bugzilla.org
945b27fcd6 Bug 460509: Deleting a product with bugs fails because it hasn't loaded Bugzilla::Bug
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@254652 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-18 16:14:02 +00:00
mkanat%bugzilla.org
bdec3cbd37 Bug 455641: Implement Bugzilla::Field::Choice->update and have editvalues.cgi use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bbaetz, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254510 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-03 01:30:45 +00:00
lpsolit%gmail.com
739ac8d191 Bug 448593: Move code to edit product group settings from editproducts.cgi to Bugzilla/Product.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@253592 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-14 16:36:12 +00:00
lpsolit%gmail.com
4957ccad73 Bug 449390: "Add Product" fails with software error "Column 'defaultmilestone' cannot be null" - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@253405 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-06 21:56:23 +00:00
lpsolit%gmail.com
d608504d16 Bug 449248: Improve $product->group_controls - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@253394 18797224-902f-48f8-a5cc-f745e15eee43
2008-08-05 21:55:48 +00:00
lpsolit%gmail.com
e301779c2a Bug 313122: Implement Product->create, $product->update and $product->remove_from_db, and make editproducts.cgi use them - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
git-svn-id: svn://10.0.0.236/trunk@253342 18797224-902f-48f8-a5cc-f745e15eee43
2008-07-30 21:47:30 +00:00
mkanat%bugzilla.org
e3786a2294 Bug 372795: Implement Bugzilla::Product::preload() to speed up query.cgi when there are many products
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@248669 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-27 05:08:08 +00:00
mkanat%bugzilla.org
40c04f383e Bug 401965: Move groups updating from process_bug.cgi to Bugzilla::Bug
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@242954 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-12 16:23:14 +00:00
lpsolit%gmail.com
53078c46f2 Bug 339384: Make Bugzilla::Milestone use Bugzilla::Object - Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@217189 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-19 10:35:43 +00:00
mkanat%bugzilla.org
c7ae56b4db Bug 339385: Make Bugzilla::Version use Bugzilla::Object
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@217180 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-19 06:41:46 +00:00
mkanat%bugzilla.org
4a41fcb4c8 Bug 339380: Make Bugzilla::Component use Bugzilla::Object
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@217179 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-19 06:39:29 +00:00
lpsolit%gmail.com
21b303adf4 Bug 189627: Implement per-product privileges - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@215097 18797224-902f-48f8-a5cc-f745e15eee43
2006-11-10 16:51:30 +00:00
lpsolit%gmail.com
29547d5f4f Bug 346588: Versions should be sorted using vers_cmp() - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@206509 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-03 19:40:26 +00:00
lpsolit%gmail.com
63b2458081 Bug 174039: Set flags on bug entry - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap r=myk a=myk
git-svn-id: svn://10.0.0.236/trunk@203576 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-24 23:24:34 +00:00
mkanat%bugzilla.org
5e20d8beaa Bug 322848: Extremely slow performance with a lot of products (~1800) and security groups for each
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@203353 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-21 08:33:57 +00:00
mkanat%bugzilla.org
7db96ff00c Bug 339379: Make Bugzilla::Product use Bugzilla::Object
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@203030 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-18 21:20:25 +00:00
mkanat%bugzilla.org
efb83cd824 Bug 342238: There is a dependency loop between Bugzilla::User and Bugzilla::Component
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bkor, a=myk


git-svn-id: svn://10.0.0.236/trunk@201791 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-09 05:00:20 +00:00
lpsolit%gmail.com
2d2caede4d Bug 314088: Several Bugzilla::Foo->new crash when passing a string instead of a valid ID as a param - Patch by Frédéric Buclin <LpSolit@gmail.com> r=kiko a=justdave
git-svn-id: svn://10.0.0.236/trunk@183184 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-28 10:33:18 +00:00
bugreport%peshkin.net
170d35dab8 Bug 313008 Lists of products, milestones, etc... should be sorted
Patch by Joel Peshkin <bugreport@peshkin.net>
r=lpsolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@182540 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-19 20:04:20 +00:00
lpsolit%gmail.com
05576a5760 Bug 299753: Replace old code in editproducts.cgi by routines from Product.pm - Patch by André Batosti <batosti@async.com.br> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182417 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-17 21:43:42 +00:00
lpsolit%gmail.com
c20f49f42e Bug 306601: Bugzilla::Classification needs a products() method - Patch by André Batosti <batosti@async.com.br> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182204 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-13 23:42:43 +00:00
lpsolit%gmail.com
1072a83812 Bug 311419: Update the group_controls method from Product.pm to use Group.pm - Patch by André Batosti <batosti@async.com.br> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182057 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-12 02:27:06 +00:00
mkanat%kerio.com
f9d408a8ea Bug 309749: Remove get_x_by_y functions from the new .pm files, in favor of object methods
Patch By André Batosti <batosti@async.com.br> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@181718 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-06 18:45:46 +00:00
lpsolit%gmail.com
25b4d9f717 Bug 286158: Remove GetSelectableProducts() from globals.pl and use Bugzilla::User::get_selectable_products() instead - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel,kiko a=justdave
git-svn-id: svn://10.0.0.236/trunk@179575 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-02 21:12:10 +00:00