144 Commits

Author SHA1 Message Date
bzrmirror%bugzilla.org
fd8b5cfb03 Bug 950491: When viewing a dependency graph, an "uninitialized value" warning is thrown
r/a=sgreen


git-svn-id: svn://10.0.0.236/trunk@265149 18797224-902f-48f8-a5cc-f745e15eee43
2013-12-19 17:45:41 +00:00
bzrmirror%bugzilla.org
96f4436167 Bug 916633 - join_activity_entries doesn't reconstitute text with commas correctly.
r=glob, a=sgreen


git-svn-id: svn://10.0.0.236/trunk@265105 18797224-902f-48f8-a5cc-f745e15eee43
2013-11-08 00:45:57 +00:00
bzrmirror%bugzilla.org
3dcb5f6e7e Bug 917669 - invalid or expired authentication tokens and cookies should throw errors, not be silently ignored
r/a=glob


git-svn-id: svn://10.0.0.236/trunk@265036 18797224-902f-48f8-a5cc-f745e15eee43
2013-09-26 15:18:15 +00:00
bzrmirror%bugzilla.org
68f6c3d877 Bug 853638 - Status and resolution values in dependency graphs not localizable.
r=dkl, a=sgreen


git-svn-id: svn://10.0.0.236/trunk@264969 18797224-902f-48f8-a5cc-f745e15eee43
2013-08-15 11:30:58 +00:00
bzrmirror%bugzilla.org
008ced32b6 Bug 898830: Improve loading time of show_bug.cgi
r=sgreen a=justdave


git-svn-id: svn://10.0.0.236/trunk@264964 18797224-902f-48f8-a5cc-f745e15eee43
2013-08-13 18:55:07 +00:00
bzrmirror%bugzilla.org
c9f2d293ab Bug 868330 - Password creation directions incomplete
r=sgreen, a=sgreen


git-svn-id: svn://10.0.0.236/trunk@264957 18797224-902f-48f8-a5cc-f745e15eee43
2013-08-13 18:47:50 +00:00
bzrmirror%bugzilla.org
ebf24bde9d Bug 898830: Improve loading time of show_bug.cgi
r=sgreen a=justdave


git-svn-id: svn://10.0.0.236/trunk@264953 18797224-902f-48f8-a5cc-f745e15eee43
2013-08-13 18:42:43 +00:00
mkanat%bugzilla.org
dac1d37569 Bug 885646: Bugzilla::BugMail::_get_diff should rejoin split activity entries
r=glob, a=justdave


git-svn-id: svn://10.0.0.236/trunk@264883 18797224-902f-48f8-a5cc-f745e15eee43
2013-07-09 03:00:52 +00:00
mkanat%bugzilla.org
a53fa92e42 Bug 785283 - Support increased values for PASSWORD_SALT_LENGTH without breaking compat with old hashes
[r=LpSolit a=LpSolit]


git-svn-id: svn://10.0.0.236/trunk@264599 18797224-902f-48f8-a5cc-f745e15eee43
2012-12-31 22:00:44 +00:00
mkanat%bugzilla.org
1764f0df90 Bug 787668: Use |use parent| instead of |use base|
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264508 18797224-902f-48f8-a5cc-f745e15eee43
2012-12-01 01:31:00 +00:00
mkanat%bugzilla.org
f6af30d002 Bug 816747 - Add dummy POD for unPODded methods.
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264502 18797224-902f-48f8-a5cc-f745e15eee43
2012-11-30 14:45:59 +00:00
mkanat%bugzilla.org
1ae57fd497 Bug 804093: Fix autodetected charset for windows-1252 encoded content
r=glob,a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264486 18797224-902f-48f8-a5cc-f745e15eee43
2012-11-27 15:00:49 +00:00
mkanat%bugzilla.org
ca9fbfbf5b Bug 797636: Improve performance for buglists
r=dkl a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264452 18797224-902f-48f8-a5cc-f745e15eee43
2012-11-16 17:15:44 +00:00
mkanat%bugzilla.org
73121c5630 Bug 676844: Replace ThrowCodeError() by ThrowUserError() when the error is not triggered by the code itself
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264418 18797224-902f-48f8-a5cc-f745e15eee43
2012-11-12 18:00:45 +00:00
mkanat%bugzilla.org
1b0922643b Bug 772359: LogActivityEntry shouldn't remove any characters from the field when splitting long lines; and delimiters need to be inserted when joining split entries
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264385 18797224-902f-48f8-a5cc-f745e15eee43
2012-10-25 17:45:40 +00:00
mkanat%bugzilla.org
0fd3ecb628 Bug 577329 - WebServices should filter email addresses same as the web UI as users are not always required to login
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264347 18797224-902f-48f8-a5cc-f745e15eee43
2012-10-16 21:00:45 +00:00
mkanat%bugzilla.org
b0e0162ff5 Bug 795650: Cache the HTML::Scrubber object for improved performance
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264307 18797224-902f-48f8-a5cc-f745e15eee43
2012-10-08 15:15:42 +00:00
mkanat%bugzilla.org
8e47ba629a Bug 787529: Use |use 5.10.1| everywhere
r=wicked a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264195 18797224-902f-48f8-a5cc-f745e15eee43
2012-09-01 21:45:59 +00:00
mkanat%bugzilla.org
746ac953a2 Bug 655477: Bugzilla now requires Perl 5.10.1
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264188 18797224-902f-48f8-a5cc-f745e15eee43
2012-08-31 10:45:54 +00:00
mkanat%bugzilla.org
c3c4eb9489 Bug 635882: html_light_quote() should accept the "target" attribute for links
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263984 18797224-902f-48f8-a5cc-f745e15eee43
2012-06-26 17:15:45 +00:00
mkanat%bugzilla.org
9958219bdb Bug 747189: Remove Bugzilla::Util::file_mod_time()
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263758 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-26 11:46:11 +00:00
mkanat%bugzilla.org
8ec173480f Bug 728639: (CVE-2012-0465) [SECURITY] User lockout policy can be bypassed by altering the X-FORWARDED-FOR header
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263711 18797224-902f-48f8-a5cc-f745e15eee43
2012-04-18 17:06:52 +00:00
mkanat%bugzilla.org
c0165d07a7 Bug 554819: Quicksearch should be using Text::ParseWords instead of custom code in splitString
Also fixes QS with accented characters (bug 730207)
r=dkl a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263617 18797224-902f-48f8-a5cc-f745e15eee43
2012-03-29 18:03:39 +00:00
mkanat%bugzilla.org
d22395cdef Bug 319953: Missing real email syntax check
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263298 18797224-902f-48f8-a5cc-f745e15eee43
2012-01-23 16:17:04 +00:00
mkanat%bugzilla.org
3b5e8524aa Bug 680131: Replace the MPL 1.1 license by the MPL 2.0 one in all files, and add it to files which miss one
r=kiko r=mkanat r=mrbball a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263258 18797224-902f-48f8-a5cc-f745e15eee43
2012-01-11 22:48:45 +00:00
mkanat%bugzilla.org
1ee11c83b1 Bug 703928: Bugzilla::Util should depend on Bugzilla::Error, not the opposite
r=dkl a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263091 18797224-902f-48f8-a5cc-f745e15eee43
2011-11-21 07:46:22 +00:00
mkanat%bugzilla.org
8f368a6e69 cancelled -> canceled
git-svn-id: svn://10.0.0.236/trunk@263088 18797224-902f-48f8-a5cc-f745e15eee43
2011-11-19 00:16:27 +00:00
mkanat%bugzilla.org
786389d94b Bug 703788: Improve performance of diff_arrays() with large arrays
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@263087 18797224-902f-48f8-a5cc-f745e15eee43
2011-11-19 00:01:51 +00:00
mkanat%bugzilla.org
761321c9ad Bug 696537: Load DateTime only when datetime_from() is called
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@263084 18797224-902f-48f8-a5cc-f745e15eee43
2011-11-18 12:16:30 +00:00
mkanat%bugzilla.org
445178c2c6 Bug 662070: Use say() instead of print() where appropriate
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262709 18797224-902f-48f8-a5cc-f745e15eee43
2011-08-17 11:31:30 +00:00
mkanat%bugzilla.org
0a298ff384 Bug 658407: Make Bugzilla not use Math::Random::Secure anymore, due to the
difficulty of installing its dependencies. Instead move the code directly
into Bugzilla itself.
r=LpSolit, r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@262589 18797224-902f-48f8-a5cc-f745e15eee43
2011-08-04 23:16:18 +00:00
mkanat%bugzilla.org
13b93bb211 Bug 659816: Fix url_decoding of utf8 strings
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@262350 18797224-902f-48f8-a5cc-f745e15eee43
2011-05-30 08:33:40 +00:00
mkanat%bugzilla.org
eeda9a8f58 Bug 633776: Automatic charset detection for text attachments
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@262027 18797224-902f-48f8-a5cc-f745e15eee43
2011-03-09 10:01:49 +00:00
mkanat%bugzilla.org
dd46cfe5a2 Bug 620827: Refactor remove see also to use remove_from_db instead.
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@261915 18797224-902f-48f8-a5cc-f745e15eee43
2011-02-11 01:46:44 +00:00
mkanat%bugzilla.org
1455271c76 Bug 619594: (CVE-2010-4568) [SECURITY] Improve the randomness of
generate_random_password, to protect against an account compromise issue
and other critical vulnerabilities.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@261817 18797224-902f-48f8-a5cc-f745e15eee43
2011-01-24 22:07:59 +00:00
mkanat%bugzilla.org
160ef05099 Bug 595410: Make it faster to display a bug that has a lot of dependencies.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@261706 18797224-902f-48f8-a5cc-f745e15eee43
2011-01-04 02:16:57 +00:00
mkanat%bugzilla.org
85209319bc Bug 573195: Make Bug.get return all of a bug's standard and custom field
information
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@261302 18797224-902f-48f8-a5cc-f745e15eee43
2010-09-30 01:03:22 +00:00
mkanat%bugzilla.org
cb0d08e43d Bug 466968: Remove hardcoded strings from BugMail.pm, and refactor it so that bugmails are 100% localizable
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260996 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-06 10:46:40 +00:00
mkanat%bugzilla.org
1be00a65d9 Bug 572602: Change the way that Bugzilla::Object determines what fields
are required for create(). It now assumes that any column that is NOT NULL
and has not DEFAULT in the database is required. We also shift the burden
of throwing errors about empty values to the validators. This fixes the bug
that Bugzilla::Bug->create() wasn't populating default values for fields
if they weren't specified in the create() parameters.
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260542 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-24 00:47:53 +00:00
mkanat%bugzilla.org
e2c46e0470 A few tinderbox bustage fixes from the checkin of bug 24896.
git-svn-id: svn://10.0.0.236/trunk@260473 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-16 06:31:26 +00:00
mkanat%bugzilla.org
6add188323 Bug 24896: Make the First/Last/Prev/Next navigation on bugs work with
multiple buglists at once
r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260472 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-16 01:46:23 +00:00
mkanat%bugzilla.org
f7e990146a Bug 560009: Use firstidx from List::MoreUtils instead of lsearch
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260217 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-22 18:16:55 +00:00
mkanat%bugzilla.org
7cc9991a5d Bug 556439: Prevent datetime_from from dying if it gets 0000-00-00 as a
date from the database
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260133 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-02 23:47:51 +00:00
mkanat%bugzilla.org
5754033260 Bug 498309: Speed up show_bug.cgi when there are many comments by caching
field-descs globally for all template calls
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259959 18797224-902f-48f8-a5cc-f745e15eee43
2010-03-14 00:46:13 +00:00
reed%reedloden.com
56f209ba82 Bug 534587 - "Bugmail uses the timezone of the changee instead of the user receiving the mail" [p=reed r=mkanat a=mkanat]
git-svn-id: svn://10.0.0.236/trunk@259334 18797224-902f-48f8-a5cc-f745e15eee43
2010-01-05 07:07:46 +00:00
mkanat%bugzilla.org
0cc827bc54 Bug 527586: Use X-Forwarded-For instead of REMOTE_ADDR for trusted proxies
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259326 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-31 12:53:21 +00:00
lpsolit%gmail.com
bc7a9d7a59 Bug 329638: https login page switches to http on submit if ssl_redirect = false - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat
git-svn-id: svn://10.0.0.236/trunk@259088 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-25 23:57:53 +00:00
reed%reedloden.com
f092b2d524 Bug 360626 - "ThrowTemplateError() used in Util.pm" [p=reed r=LpSolit a=LpSolit]
git-svn-id: svn://10.0.0.236/trunk@259024 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-18 18:25:45 +00:00
reed%reedloden.com
e52faa4e68 Bug 528872 - "Attachments in attachments table should have CSS classes to help with styling" [p=reed r=LpSolit a=LpSolit]
git-svn-id: svn://10.0.0.236/trunk@258997 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-16 16:33:12 +00:00
mkanat%bugzilla.org
6d95687b90 Bug 472217: Create a Bugzilla::Comment object and eliminate GetComments
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258951 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-10 01:36:05 +00:00