86 Commits

Author SHA1 Message Date
reed%reedloden.com
c6b19165cf Backed out elif's patch from bug 307242 due to it causing a reftest failure for the test for bug 218473.
git-svn-id: svn://10.0.0.236/trunk@237249 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-04 04:33:43 +00:00
reed%reedloden.com
dcc5727a4b Bug 307242 - "ASSERTION: bad argument: '(aRight > mLeft) && (aRight < mRight)', @ nsSpaceManager::BandRect::SplitHorizontally" [p=elif (sharparrow1) r+sr+a1.9=roc]
git-svn-id: svn://10.0.0.236/trunk@237237 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-04 03:18:31 +00:00
martijn.martijn%gmail.com
b3b6168e5a Bug 92543 - BandRect.mFrames should be created as an nsAutoVoidArray, patch by Alfred Kayser, r+sr=roc, a=dbaron
git-svn-id: svn://10.0.0.236/trunk@233403 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-30 15:29:07 +00:00
gijskruitbosch%gmail.com
71a4dfaf55 Backing out fix for bug 92543 due to build bustage
git-svn-id: svn://10.0.0.236/trunk@233200 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-28 09:10:23 +00:00
gijskruitbosch%gmail.com
a8bef70bc4 Bug 92543 - BandRect.mFrames should be created as an nsAutoVoidArray
p=alfredkayser@nl.ibm.com (Alfred Kayser)
r+sr=roc@ocallahan.org (Robert O'Callahan)
a=dbaron@mozilla.com (David Baron)


git-svn-id: svn://10.0.0.236/trunk@233199 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-28 08:53:33 +00:00
sharparrow1%yahoo.com
6236326904 Bug 391412: Regression in float layout causing clear to be ignored. r+sr=roc, a=dbaron
git-svn-id: svn://10.0.0.236/trunk@232412 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-20 21:05:47 +00:00
sharparrow1%yahoo.com
03252b67f1 Bug 387201: ASSERTION: If we asked for force-fit, it should have been placed with float, padding. r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@230973 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-25 21:52:20 +00:00
sharparrow1%yahoo.com
5a7426877f Bug 384762: Negative margin + clear broken. r+sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@230379 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-20 20:05:02 +00:00
asqueella%gmail.com
a6ab533de7 back out 92543 due to DEBUG builds bustage
git-svn-id: svn://10.0.0.236/trunk@230147 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-17 21:52:27 +00:00
asqueella%gmail.com
96cf2d302c Bug 92543 - BandRect.mFrames should be created as an nsAutoVoidArray
p=Alfred Kayser <alfredkayser@nl.ibm.com>
r+sr=roc


git-svn-id: svn://10.0.0.236/trunk@230135 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-17 21:00:27 +00:00
jwalden%mit.edu
dda6ff3c99 Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
git-svn-id: svn://10.0.0.236/trunk@229504 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-08 07:08:56 +00:00
bzbarsky%mit.edu
105ac72207 Missed a spot where we should update our cached band rect. Bug 368330, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@219098 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-29 02:16:23 +00:00
bzbarsky%mit.edu
5791846622 Keep a "last band we touched" cursor so we can avoid seeking through the whole
linked list for multiple appends to the end.  Bug 270392, r+sr=roc


git-svn-id: svn://10.0.0.236/trunk@218816 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-23 21:42:41 +00:00
bzbarsky%mit.edu
44ecd11243 Update our cached YMosts when our regions are cleared. Bug 351202, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@209310 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-07 03:01:25 +00:00
bzbarsky%mit.edu
9bfaa5ca42 Speed up ClearFloats for cases when we have lots of floats. Bug 349113, r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@208758 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-29 21:56:51 +00:00
roc+%cs.cmu.edu
b1ae3cf7e7 relanding fix for bug 317278 :-(
git-svn-id: svn://10.0.0.236/trunk@201179 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-29 01:19:48 +00:00
roc+%cs.cmu.edu
bd9175c940 Bug 237085. Move string subdivision code to gfx so we can efficiently make it metrics-dependent. r=smontagu,sr=rbs
git-svn-id: svn://10.0.0.236/trunk@200963 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-26 22:18:23 +00:00
roc+%cs.cmu.edu
d643001e93 Bug 317278. Reland patch that reflows lines again if we detect some already-placed floats need to move to the next line. This time, with changes to nsSpaceManager's PushState/PopState infrastructure so that dynamic allocations are never required; the saved state is always stack-allocated by callers. r+sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@200367 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-19 23:06:59 +00:00
dbaron%dbaron.org
9911a9b756 Remove uses of MOZ_DECL_CTOR_COUNTER, which is always defined to nothing. b=332745 rs=roc,bzbarsky
git-svn-id: svn://10.0.0.236/trunk@193572 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-05 00:00:44 +00:00
dbaron%dbaron.org
b258ce85ca Single line comments to describe files (helpful in LXR)
git-svn-id: svn://10.0.0.236/trunk@193203 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-29 18:29:03 +00:00
cbiesinger%web.de
6322c04952 bug 183156 remove *UCS2* functions, replacing them with *UTF16* ones
r+sr=darin


git-svn-id: svn://10.0.0.236/trunk@188844 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-03 14:18:39 +00:00
timeless%mozdev.org
a05383ef1b Bug 106386 Correct misspellings in source code
patch by mats.palmgren@bredband.net r=dbaron sr=dbaron


git-svn-id: svn://10.0.0.236/trunk@185018 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-20 22:05:24 +00:00
timeless%mozdev.org
b048e1083d Bug 292348 NewEmbededPluginStream misspelled
patch by pythonesque+bugzilla@gmail.com r=jst sr=jst a=asa


git-svn-id: svn://10.0.0.236/trunk@174323 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-08 23:42:15 +00:00
roc+%cs.cmu.edu
7f1a3c9c93 Bug 263825. Make paginated floats work, and other fixes. r+sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@171036 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-23 03:35:08 +00:00
roc+%cs.cmu.edu
2baddd70c5 Bug 276602. The rects added to the space manager are not real rects; they are still significant if empty. r+sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@170257 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 02:30:14 +00:00
roc+%cs.cmu.edu
d4a6c32e7b Bug 209694. Major rework of margin-collapsing and clearance to match CSS 2.1 rules. Also includes major incremental reflow fixes for those situations. See the bug for details. rubber-stamp r+sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@165781 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-25 14:51:00 +00:00
roc+%cs.cmu.edu
52f58bd652 Fixing bustage
git-svn-id: svn://10.0.0.236/trunk@162211 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-13 15:24:11 +00:00
roc+%cs.cmu.edu
26dae9e55b Bug 257216. Fix sundry block issues for columns. In particular, remove overflowing floats from the space manager before we compute the space manager's XMost and YMost to include in the block size. r+sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@162210 18797224-902f-48f8-a5cc-f745e15eee43
2004-09-13 13:35:46 +00:00
bryner%brianryner.com
865734bf2f Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc
git-svn-id: svn://10.0.0.236/trunk@160184 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 23:15:21 +00:00
dbaron%dbaron.org
2c97c45164 Move clearing from nsBlockBandData to nsSpaceManager so that 'clear' works even when the floats to be cleared don't overlap the block's border-box. b=148994 Patch by Blake Kaplan <mrbkap@rice.edu>. r+sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@157603 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-08 19:18:30 +00:00
jim_nance%yahoo.com
3f4820cc7f Fix bug #242044 - Reduce number of allocations by nsSpaceManager::PushState
git-svn-id: svn://10.0.0.236/trunk@157468 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-06 18:45:02 +00:00
gerv%gerv.net
2ac510b678 Bug 236613: change to MPL/LGPL/GPL tri-license.
git-svn-id: svn://10.0.0.236/trunk@155068 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-18 14:30:37 +00:00
bryner%brianryner.com
2359d2f7c4 More nsIPresContext deCOMtamination (bug 229371). r+sr=roc.
git-svn-id: svn://10.0.0.236/trunk@154743 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-13 00:28:44 +00:00
bryner%brianryner.com
b5347dd60c Change all callers of nsIPresContext::GetShell() to use the non-refcounting versions. Most callers now use PresShell(), a few that were checking for null conditions are using GetPresShell() -- this will be remedied once we can ensure that a prescontext never has a null pres shell. Bug 227690, r+sr=bzbarsky.
git-svn-id: svn://10.0.0.236/trunk@150598 18797224-902f-48f8-a5cc-f745e15eee43
2003-12-21 05:36:36 +00:00
dbaron%dbaron.org
33601224e0 Use the correct term "float" instead of "floater". b=218654 r+sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@147924 18797224-902f-48f8-a5cc-f745e15eee43
2003-10-13 21:51:02 +00:00
jkeiser%netscape.com
d214c656a8 Fix crash printing fixed-position float elements (bug 200347), r=kin@netscape.com, sr=dbaron@dbaron.org, a=asa
git-svn-id: svn://10.0.0.236/trunk@142762 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-22 20:56:35 +00:00
dbaron%dbaron.org
36264b0339 Make nsSpaceManager::ClearRegions reset mLowestTop as well. b=198485 r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@139896 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-21 03:11:47 +00:00
dbaron%dbaron.org
28c762385d Remember the lowest floater top for CSS2 9.5.1 rule 5 (a float cannot be higher than earlier floats) on the space manager rather than the block reflow state so that it works across blocks sharing the same space manager. Save and restore it in the space manager's PushState and PopState to fix incremental reflow bug (177331). b=196919 r+sr=roc+moz Change PRIntn to PRInt32. b=115153 r+sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@139299 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-11 23:56:49 +00:00
dbaron%dbaron.org
e6a2b29ebf Remove nsISizeOfHandler and associated SizeOf methods. b=106792 r=bzbarsky sr=jst
git-svn-id: svn://10.0.0.236/trunk@138193 18797224-902f-48f8-a5cc-f745e15eee43
2003-02-22 15:34:38 +00:00
dbaron%fas.harvard.edu
a7efa8275b Replace NS_BLOCK_WRAP_SIZE with making unconstrained-width reflow of frames with NS_BLOCK_SPACE_MGR consider the floats. This means we no longer use the overflow area for layout (other than the overflow property). Handle right floaters in unconstrained width reflow by just treating them as left floaters. b=172896 r+sr=roc
git-svn-id: svn://10.0.0.236/trunk@135476 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-19 00:12:08 +00:00
kin%netscape.com
a850d5d255 Fix for bug #96736: [FLOATER]The "Top 1000 Reviewer" is overwritten by text
mozilla/layout/base/src/nsSpaceManager.cpp
  mozilla/layout/base/src/nsSpaceManager.h

    - Implemented nsSpaceManager methods PushState()
      and PopState().

  mozilla/layout/html/base/src/nsBlockReflowContext.cpp

    - Modified nsBlockReflowContext::DoReflowBlock() to
      call PushState() and PopState() to remove any
      floaters that may have been added to the SpaceManager
      during the intermediate "unconstrained" Reflow()
      call, used to calculate the max block width. This
      allows the Reflow() call that immediately follows
      it to properly place the floaters.


r=waterson@netscape.com  sr=dbaron@fas.harvard.edu


git-svn-id: svn://10.0.0.236/trunk@127595 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-19 04:41:57 +00:00
seawood%netscape.com
a7c7e77b8b Add CPP_THROW_NEW macro to the build system. This macro should be used when defining a local |operator new| function. It will be set to an empty throw function by default on all platforms except mac CW builds. This will allow us to not crash on systems that expect |operator new| to throw an exception by default and will suppress compiler warnings about how |operator new| should throw an exception instead of returning NULL.
Bug 149032 r=timeless sr=scc


git-svn-id: svn://10.0.0.236/trunk@124526 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-02 20:25:30 +00:00
waterson%netscape.com
5bae3657e6 Bug 129115. Change the reflow path from a list structure to a tree structure to amortize state recovery and damage propagation costs. Eliminate table timeout reflows. r=kin,karnaze,rods,rbs; sr=attinasi
git-svn-id: svn://10.0.0.236/trunk@121265 18797224-902f-48f8-a5cc-f745e15eee43
2002-05-10 18:22:41 +00:00
dbaron%fas.harvard.edu
7ddeb79974 Remove unnecessary XPCOM interface around nsSpaceManager. b=102453 r=jag sr=waterson
git-svn-id: svn://10.0.0.236/trunk@106331 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-26 05:06:07 +00:00
mkaply%us.ibm.com
3fb7e38337 Attempt to fix OS/2 bustage
git-svn-id: svn://10.0.0.236/trunk@106269 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-25 13:13:28 +00:00
dbaron%fas.harvard.edu
8b3489a026 Bug 86947:
Make the line list doubly linked and access it through a list class and iterators.
Stop recomputing margins on all of the children of each block in the reflow chain (which causes O(N^2) state recovery during incremental reflow).  Instead, add a second dirty bit to the lines and walk backwards through the line list to recompute vertical margins only when either dirty bit is set and the previous line was not reflowed.  Add nsIFrame::IsEmpty to identify frames through which margins collapse.
Fix O(N^2) propagation of float damage by maintaining a set of intervals damaged by floats (bug 61962) and be sure to damage the correct areas (bug 48138).
Introduce nsCollapsingMargin to do correct collapsing of combinations of positive and negative margins (bug 50142).
Clean up some odds and ends and fix another smaller O(N^2) problem in nsBlockFrame::AddFrames.
r=attinasi, rbs  sr=waterson


git-svn-id: svn://10.0.0.236/trunk@106224 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-25 01:08:40 +00:00
dbaron%fas.harvard.edu
7bb7b59a69 Replace uses of overloaded |fputs| and most uses of |ns[C]String::ToCString|. b=104763 r=jag rs=scc
git-svn-id: svn://10.0.0.236/trunk@105460 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-16 03:53:44 +00:00
gerv%gerv.net
13afb6d0f9 Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089.
git-svn-id: svn://10.0.0.236/trunk@104119 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-28 20:14:13 +00:00
jst%netscape.com
2ec1ee65c2 Fixing bug 98828. Cache a few nsSpaceManager objects to avoid spending 43%cvs ci -m ! of the time spent in PresShell::ProcessReflowCommand() in new and delete. r=dbaron@fas.harvard.edu, sr=waterson@netscape.com
git-svn-id: svn://10.0.0.236/trunk@102715 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-11 00:55:05 +00:00
dbaron%fas.harvard.edu
3485888237 Replace uses of deprecated NS_IMPL_ISUPPORTS and NS_IMPL_QUERYINTERFACE macros with NS_IMPL_{ISUPPORTS,QUERYINTERFACE}{1,0}. r=jag rs=brendan b=45797
git-svn-id: svn://10.0.0.236/trunk@101462 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-21 01:48:11 +00:00