r=myself, I'll take the heat if this goes bad. It's a very simple change.
The text control optimization was turned on for single line text controls,
and turned off for text areas. With this change, the optimization is also
turned off for password fields. This shouldn't effect performance in any
noticable way, because there are very rarely more than one or two password
controls on a single page. The optimization in the case of password fields
isn't worth the extra code and complexity for dealing with replacing
characters with '*'
git-svn-id: svn://10.0.0.236/trunk@52688 18797224-902f-48f8-a5cc-f745e15eee43
This fixed 6 warnings and cases where reset and set property where not working properly for
all form elements. r = rods@netscape.com.
git-svn-id: svn://10.0.0.236/trunk@52619 18797224-902f-48f8-a5cc-f745e15eee43
r=brade
change is in nsGfxTextControl.cpp. I used to just blindly set the text of the underlying text frame.
Now I check if it's a password field, and replace the display text with '*' if it is.
git-svn-id: svn://10.0.0.236/trunk@52546 18797224-902f-48f8-a5cc-f745e15eee43
we now display the content of a single line text control using a child pseudo frame
until the text control first gets focus. at that time, a webshell and editor are created on the fly.
fixed bug bug 14727
r=rods
git-svn-id: svn://10.0.0.236/trunk@52330 18797224-902f-48f8-a5cc-f745e15eee43
reflow paths for NavQuirks and Standard mode. Also, Standard mode reflow now obeys
cols rows etc. Although there may be a little code bloat, this will make maintaining
the input text and textarea much much easier.
r=kmcclusk, b=6695,7461
git-svn-id: svn://10.0.0.236/trunk@51818 18797224-902f-48f8-a5cc-f745e15eee43
for the input text and textarea, I also changed the border calc for only when the
the size is explicitly set.
r=kmcclusk, Bug #3040,11285
git-svn-id: svn://10.0.0.236/trunk@51130 18797224-902f-48f8-a5cc-f745e15eee43
r=rods@netscape.com
also did some associated performance work, factoring code and collapsing multiple listener
objects down to 1. This saves a few allocations and about 60 bytes per text control.
bug 11803 Need new event for text value changing
r=hyatt@netscape.com
not dogfood approved, but the fix has been sitting in my tree for 2 weeks
git-svn-id: svn://10.0.0.236/trunk@50825 18797224-902f-48f8-a5cc-f745e15eee43
bugs # see the log of the check in into branch
author/reviewer:
mozilla/layout/base/src/nsRangeList.cpp brade/mjudge
mozilla/layout/html/forms/src/nsGfxTextControlFrame.cpp brade/ftang
mozilla/layout/events/src/nsDOMEvent.cpp brade/joki
mozilla/layout/events/src/nsEventStateManager.cpp brade/joki
mozilla/widget/public/nsGUIEvent.h akkana/ftang
mozilla/widget/src/windows/nsWindow.cpp ftang/mjudge
mozilla/widget/src/windows/nsWindow.h ftang/mjudge
mozilla/widget/src/mac/nsTextAreaWidget.cpp brade/ftang
mozilla/widget/src/mac/nsMacEventHandler.cpp brade/simon
mozilla/widget/src/xpwidgets/nsKeyBindMgr.cpp brade/ftang
mozilla/widget/src/gtk/nsGtkEventHandler.cpp akkana/?
mozilla/widget/src/gtk/nsWidget.cpp erik/ftang
mozilla/layout/xul/base/src/nsTreeCellFrame.cpp brade/ftang
mozilla/editor/base/nsEditorEventListeners.cpp brade/akkana
mozilla/editor/base/nsHTMLEditor.cpp brade/akkana
mozilla/rdf/content/src/nsXULKeyListener.cpp ftang/saari
fix the master bug- 15693
fix at least, but not limited to, the following bugs
10158,11956,6053,9333,10901,14348,6449,11845,13016,14410,15657,15307,15842,13856
git-svn-id: svn://10.0.0.236/trunk@50688 18797224-902f-48f8-a5cc-f745e15eee43
event handlers can retreive the correct state of the form element. bug 15366; r=rods@netscape.com
Submit the form when a text field is clicked on only if the JavaScript event handler
has not consumed the event. bug 15949; r=rods@netscape.com
git-svn-id: svn://10.0.0.236/trunk@50488 18797224-902f-48f8-a5cc-f745e15eee43
event handlers can retreive the correct state of the form element. bug 15366; r=rods@netscape.com
Submit the form when a text field is clicked on only if the JavaScript event handler
has not consumed the event. bug 15949; r=rods@netscape.com
git-svn-id: svn://10.0.0.236/trunk@50478 18797224-902f-48f8-a5cc-f745e15eee43
controls ifdef for just me. Renamed aMetrics to aDesiredSize
Did some clean. Nav Quirks obeys padding and not border.
Reworked how computed size is used r=kmcclusk
git-svn-id: svn://10.0.0.236/trunk@50143 18797224-902f-48f8-a5cc-f745e15eee43
this cleans up focus switching in general, and specifically enables tabbing
between single-line text controls and other html form elements.
git-svn-id: svn://10.0.0.236/trunk@48703 18797224-902f-48f8-a5cc-f745e15eee43
causing round trips through the editor unnecessarily.
thanks for pointing out the problem, akkana and bruce m.
git-svn-id: svn://10.0.0.236/trunk@48310 18797224-902f-48f8-a5cc-f745e15eee43
bad copy-and-paste of some event propogation code. the gfx text control
event listeners exist just to propogate the event from the embedded shell
to the content, and should not pass the event back to the frame itself, except
for keyPress (for default action).
git-svn-id: svn://10.0.0.236/trunk@47931 18797224-902f-48f8-a5cc-f745e15eee43
