70 Commits

Author SHA1 Message Date
jfrancis%netscape.com
bd7c2eb18f this checkin includes diff for 61232. was supposed to be in previous checkin. r=sfraser; sr=kin; a=asa
git-svn-id: svn://10.0.0.236/trunk@97356 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-18 21:35:07 +00:00
jfrancis%netscape.com
978ab248f8 fixes for:
61232 - Caret comes back to previous line after creating paragraph
54520 - Extra break with list items
54539 - Disappearing numbered list with outdent
60867 - Composer adds extra break when round-tripping empty document through View Source
62347 - Selecting Body Text doesn't work inside other blocks that have embedding breaks


git-svn-id: svn://10.0.0.236/trunk@97351 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-18 21:15:43 +00:00
kin%netscape.com
3a9a2b59a4 Fix for bug #62577 - Sublist content disappears when unlisting.
mozilla/editor/base/nsHTMLEditRules.cpp
      - Moved list handling code in WillRemoveList() into a new recursive
        method RemoveListStructure() which WillRemoveList() now calls.

      - Modified WillOutdent() to call MoveNode() when a sublist is encountered.

      - Made ConvertListType() recursive so that all sublists are coverted.

  mozilla/editor/base/nsHTMLEditRules.cpp

      - Added RemoveListStructure() method.

r=jfrancis@netscape.com  sr=sfraser@netscape.com  a=asa@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@97214 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-15 13:57:01 +00:00
jfrancis%netscape.com
95dc24ae05 fix for 82612: this is just asimple refactoring of a large routine so that we need less mem to do an optimized build.
r=kin; sr=sfraser; a=asa


git-svn-id: svn://10.0.0.236/trunk@96992 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-12 23:17:47 +00:00
jfrancis%netscape.com
73072cd5e7 bug 65557 and cast of thousands: making the editor behave more intelligently wrt html whitespace rules. Improved ws handling for:
insert text,
insert break,
join blocks,
split block,
delete
Yet to be tackled is html copy & paste.  r=fm; sr=kin


git-svn-id: svn://10.0.0.236/trunk@94635 18797224-902f-48f8-a5cc-f745e15eee43
2001-05-11 12:43:22 +00:00
mjudge%netscape.com
77323a8468 66318 r= kin, sr=kin tested by ducarozz ,phil chofmann approved..changing APIS to be idl so we can use in embedding land... lots of string changes too to nsAStrings
git-svn-id: svn://10.0.0.236/trunk@91610 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-07 00:45:26 +00:00
jfrancis%netscape.com
7cde2dddd5 bug 66290: embedding work: refactor editor to allow smaller plaintext only library. Embedding clients may be interested inthis library if they want to embed a browser but not composer/mail-compose. Reduces library footprint for plaintext-only library by over 50% on all three platforms. r=fm; sr=kin
git-svn-id: svn://10.0.0.236/trunk@85666 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-28 20:13:07 +00:00
mjudge%netscape.com
2fc6190bef small but pervasive change to make nsIDOMSelection an xpidl interface. also broke it into 2 interfaces, nsISelection and nsISelectionPrivate. moved nsIDOMSelectionListener also to xpidl. these new idl files live in layout/base/public. r=sfraser, r=anthonyd bug 48575
git-svn-id: svn://10.0.0.236/trunk@79118 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-14 11:45:01 +00:00
jfrancis%netscape.com
6340d3a57b fixes for 45608, 51398, 51591; r=cmanske
git-svn-id: svn://10.0.0.236/trunk@79084 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-14 05:59:19 +00:00
jdunn%netscape.com
bb4f9e6413 Specify that the base class is indeed 'public' since some compilers (AIX)
assumes 'private'.  I ok'd each of these with the appropriate module
owners (see bug)

r= scc@mozilla.org & brendan@mozilla.org + everyone listed in bug
#= 52254


git-svn-id: svn://10.0.0.236/trunk@79018 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-13 13:50:30 +00:00
jfrancis%netscape.com
366066d723 fixes 40363, 40364: deletion bugs with tables; r=fm
git-svn-id: svn://10.0.0.236/trunk@77352 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-28 05:11:49 +00:00
jfrancis%netscape.com
84db5fa624 fixes bugs 46782,50161,48643,49266,49265,46395;
groundwork for bugs 47931,49952;
r=fm


git-svn-id: svn://10.0.0.236/trunk@77257 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-26 04:03:50 +00:00
jfrancis%netscape.com
879fac6cf9 adding a hidden pref for the editor:
editor.liReturnBehavior "no" will disable the default behavior of popping you out of lists if you hit return in an empty list item.


git-svn-id: svn://10.0.0.236/trunk@76539 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-17 05:26:32 +00:00
jfrancis%netscape.com
691e87aa2b groundwork for 44684: adding a "GetAlignment" call to the editor so that ui can reflect alignment of selection
git-svn-id: svn://10.0.0.236/trunk@76274 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-14 12:07:10 +00:00
jfrancis%netscape.com
868ae3f8f1 take 2: fix for 22227 and partial fix for 46209; r=mjudge; a=beppe
git-svn-id: svn://10.0.0.236/trunk@74873 18797224-902f-48f8-a5cc-f745e15eee43
2000-07-27 01:03:16 +00:00
jfrancis%netscape.com
af793dca0e backend work for 41034: getting format feedback and list feedback untangled from each other.
git-svn-id: svn://10.0.0.236/trunk@71349 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-02 07:47:53 +00:00
jfrancis%netscape.com
695763bc3d fixes
41075: forward delete can delete wrong char,
41149: incorrect format feedback when in lists


git-svn-id: svn://10.0.0.236/trunk@71346 18797224-902f-48f8-a5cc-f745e15eee43
2000-06-02 06:03:46 +00:00
jfrancis%netscape.com
ed99ef899d fixes:
14753, 29843, 39864, 40141, 
40139, 36679, 39542, 34729, 
34855, 37216, 39292, 26447

r=sfraser,cmanske,fm; a=beppe


git-svn-id: svn://10.0.0.236/trunk@70759 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-24 23:00:24 +00:00
jfrancis%netscape.com
994d0de6a6 editor embedding work; fixing bug with making lists
git-svn-id: svn://10.0.0.236/trunk@68883 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-09 21:06:49 +00:00
jfrancis%netscape.com
ce54ba7bc9 fixing bugs with paste; making paste not inherit local inline stlyes
git-svn-id: svn://10.0.0.236/trunk@68414 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-05 20:42:36 +00:00
jfrancis%netscape.com
70ffe624ce fix for 29320; deletion putting caret in wrong table cell
git-svn-id: svn://10.0.0.236/trunk@68292 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-04 23:54:00 +00:00
mjudge%netscape.com
447ac72532 massive change to prepare for ender-lite. should be a no-op for current implementation
git-svn-id: svn://10.0.0.236/trunk@68218 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-04 08:33:48 +00:00
jfrancis%netscape.com
4a240e0ec1 partial fix for bug 30763
git-svn-id: svn://10.0.0.236/trunk@68002 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-03 01:34:34 +00:00
jfrancis%netscape.com
c1c92a17d8 implementing list behavior spec, plus a few bug fixes
git-svn-id: svn://10.0.0.236/trunk@67974 18797224-902f-48f8-a5cc-f745e15eee43
2000-05-03 00:14:28 +00:00
jfrancis%netscape.com
612bfa299f lots of improvements to block transformations:
1) looks inside inlines for breaks;
2) fixes the "extra break when unlisting" bug
3) changing paragraph style to normal consistently gets breaks
4) any splitting needed occurs when blocks inserted
plus a lot of small bug fixes


git-svn-id: svn://10.0.0.236/trunk@66975 18797224-902f-48f8-a5cc-f745e15eee43
2000-04-24 11:51:12 +00:00
jfrancis%netscape.com
d806359a89 cleanup and small bug fixes
git-svn-id: svn://10.0.0.236/trunk@64637 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-30 22:57:19 +00:00
jfrancis%netscape.com
973e5a251c making editor hip to inline style changes on collapsed selections. plus lots of removal of unused code.
git-svn-id: svn://10.0.0.236/trunk@64489 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-29 12:53:23 +00:00
jfrancis%netscape.com
386e43e682 improved paste performance in editor (WIP) (bug 28783)
set/remove inline stlye rewrite (lots of bug #s)


git-svn-id: svn://10.0.0.236/trunk@63948 18797224-902f-48f8-a5cc-f745e15eee43
2000-03-24 00:26:47 +00:00
jfrancis%netscape.com
50f00945bf fixes for the following bugs:
27914, 27305, 28690, 14608, 27306, 28757
These fixes reviewed by cmanske, apprvd rickg;

also fix for 28724 (caret positioning problems)
reviewed by mjudge, apprvd by jar.


git-svn-id: svn://10.0.0.236/trunk@61653 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-25 04:39:30 +00:00
jfrancis%netscape.com
056f231676 implementing font increase/decrease size for html editor (bug 18774) r=floppy moose
git-svn-id: svn://10.0.0.236/trunk@60127 18797224-902f-48f8-a5cc-f745e15eee43
2000-02-08 12:53:34 +00:00
akkana%netscape.com
831fa6d5c7 22662, 16720: greatly improve formatting of html source for inserted html tags. r=jfrancis
git-svn-id: svn://10.0.0.236/trunk@58667 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-26 00:57:37 +00:00
jfrancis%netscape.com
de4c509f39 fix for 21412 - backspace wouldn't remove list items in html editor.
In addition some improvements were made to the adjustment of selection after an edit action (example: backspacing through a list item now pops you up to the previous item)


git-svn-id: svn://10.0.0.236/trunk@58013 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-17 12:41:34 +00:00
jfrancis%netscape.com
3384856d4f * fixed 19596;
* fixed 23597;
* fixed deletion bug that could cause to breaks to be deleted instead of one, when backspacing once. (no #)
* partial fix for current paragraph style not being properly reported in the composer toolbar.  (no #)


git-svn-id: svn://10.0.0.236/trunk@57934 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-15 14:29:29 +00:00
jfrancis%netscape.com
8f19524dca added in some rules code for mail quoting. This
fixes bug: 19979   (extra blank line showing up in
mail that has quotes)

partial progress on block transformation work:
unlisting a list now works mostly correctly again,
instead of merging all the former list items into
one run of text (no bug number).

Moz-br's are now added in one more circumstance:
when you have a br at the end of some inline
content that is followed by a new block (like a
list, table, etc.).  This is needed for the same
reason that the other moz-br's are: to generate a
blank line that the user expects after hitting
return. (no bug number)

DTD-related work to enable the editor to check if
you should be able to type given the current
selection.

fixed bug 22944: inserting an <A> in a table
splits the table.

Made some progress on text paste performance, but
it's still too slow.  That's 19273, which I'm
leaving open

fixed bug 15258:  selection capable of getting out
of the body element.

fixed a bug where code that merged adjacent text
nodes would merge the non-editable "formatting"
textnodes, (no bug number).  Added code to prevent
selection from ending up inside a non-editable
text node.

fix for 11994, an IME bug.


git-svn-id: svn://10.0.0.236/trunk@57272 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-10 10:13:58 +00:00
jfrancis%netscape.com
11faed23b2 Fix for bug 21346.
This is actually a major reworking of how the low level editor txns perturb selection.  There is a mode now for telling the txns not to disturb the selection.  There is also a fix for unlisting lists (sometimes list items got merged unintentionally when unlisting).


git-svn-id: svn://10.0.0.236/trunk@56714 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-04 03:09:41 +00:00
jfrancis%netscape.com
edba5add24 fix for 20457: deletion in editor pretty darn screwy. Lots of changes to improve this. Document modifying entry points in editor now go thru a standard sandwich, which allows tracking of what changed in the doc, which allows proper post-processing of what changed. Also, all deletions now go thru the rules code, if applicable. Also some bugs in tracking the changed document portion have been fixed. Finally selection setting after a delete is improved.
git-svn-id: svn://10.0.0.236/trunk@55568 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-07 08:30:19 +00:00
jfrancis%netscape.com
c3b10ef137 fix for bug 20205: selection was getting jerked around by whitespace conversion code.
git-svn-id: svn://10.0.0.236/trunk@54765 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-30 21:58:37 +00:00
jfrancis%netscape.com
ed38a43f75 * ported the html editor work for the "caret doesn't move when i hit return" bug (16715) back to the plaintext editor.
* fixed a paste/rules interaction problem (19367)
* introduced an init time pass over html documents to populate empty list items and table cells with special breaks so that the user can click in them and actually get a caret
* fixed some warnings
r = floppy moose


git-svn-id: svn://10.0.0.236/trunk@54561 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-29 08:28:46 +00:00
jfrancis%netscape.com
efe6e42352 fixing bad const in interface (not caught by mac compiler)
git-svn-id: svn://10.0.0.236/trunk@54466 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-25 00:36:34 +00:00
jfrancis%netscape.com
5020ab053b implemented a system to track what portion of a document is affect by an editor action. Used that system to help solve extensive whitespace handling problems, ans also problems with caret placement in response to returns (this lattter fix for html editors only - plaintext coming later). Fixed numerous list bugs involving outdenting, unlisting, and splitting lists.
Checkin addressees these bugzilla bugs:
2073 & 12337 - whitespace trouble when typing (you can end up with all nbsp's instead of spaces)


git-svn-id: svn://10.0.0.236/trunk@54463 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-25 00:19:45 +00:00
dmose%mozilla.org
0efb7c174c updated xPL license boilerplate to v1.1, a=chofmann@netscape.com,r=endico@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@52910 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-06 03:43:54 +00:00
jfrancis%netscape.com
53c8075ee8 fixes for bugs: 16361,12253,15696,15734; r=sfraser
git-svn-id: svn://10.0.0.236/trunk@52381 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-01 15:15:35 +00:00
jfrancis%netscape.com
0209785bbb revised rules system api to include "handled" parameter and ceased to overload the meaning of the "cancel" parameter; added TypedText() method to editor, editorshell, and logging, so that logging will work properly with typing; coallesce deletions for undo purposes r=buster@netscape.com
git-svn-id: svn://10.0.0.236/trunk@49999 18797224-902f-48f8-a5cc-f745e15eee43
1999-10-06 19:34:09 +00:00
jfrancis%netscape.com
8e3610bfe2 revised UNDO; introduced first cut at the "mozdiv" typing rules
git-svn-id: svn://10.0.0.236/trunk@49317 18797224-902f-48f8-a5cc-f745e15eee43
1999-09-29 20:08:15 +00:00
jfrancis%netscape.com
23d9478cc5 fix for 12675; also added a wrapper for GetNextNode()/GetPriorNode() that checks for containment in the <body>
git-svn-id: svn://10.0.0.236/trunk@47001 18797224-902f-48f8-a5cc-f745e15eee43
1999-09-12 01:36:07 +00:00
jfrancis%netscape.com
14c949b1d4 fix for bug 13482
git-svn-id: svn://10.0.0.236/trunk@46644 18797224-902f-48f8-a5cc-f745e15eee43
1999-09-09 22:22:14 +00:00
jfrancis%netscape.com
132134ca11 implemented RemoveList();
deletion doesn't scatter so many empty nodes;
mailcite rules started;
general deletion work (still WIP);
several small bugfixes;
refactored list item outdenting code


git-svn-id: svn://10.0.0.236/trunk@46126 18797224-902f-48f8-a5cc-f745e15eee43
1999-09-06 19:51:59 +00:00
jfrancis%netscape.com
a1542a6e29 more deletion work...
git-svn-id: svn://10.0.0.236/trunk@45518 18797224-902f-48f8-a5cc-f745e15eee43
1999-09-01 21:23:47 +00:00
jfrancis%netscape.com
99de773e68 refactoring text insertion code; indent/outdent now work with lists and list items.
git-svn-id: svn://10.0.0.236/trunk@44276 18797224-902f-48f8-a5cc-f745e15eee43
1999-08-24 08:56:51 +00:00
jfrancis%netscape.com
41485faa2c some reorg of block transformation code; implemented make-{header,preformatted,address,normal}; tweaked make list to honor <br> in some circumstances; rewrote "return in list item" to pop you out of list if item is empty; rewrote "return in header" to work with non-trivial headers.
git-svn-id: svn://10.0.0.236/trunk@43484 18797224-902f-48f8-a5cc-f745e15eee43
1999-08-18 08:13:06 +00:00