Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
85,302 Commits 3,986 Branches 0 Tags
Commit Graph

2249 Commits

Author SHA1 Message Date
justdave%syndicomm.com
107bf6572e Fix for bug 45918: the old password field on the userprefs page is now used to log you back in if you try to change your password with cookies turned off, which avoids the confusing login screen after entering your new password in which you used to have to enter your old password one more time in order to let it set your new password (yes, it used to be as confusing as that just sounded :) 
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@97448 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-19 22:02:53 +00:00
dmose%mozilla.org
4955447ce0 Changing despot owner to endico@mozilla.org with her permission 
git-svn-id: svn://10.0.0.236/trunk@97405 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-19 04:04:34 +00:00
jake%acutex.net
3d6379f41c Running a query using the Added Comment option was very slow (bug 57350). 
Patch by Myk Melez <myk@mozilla.org> and Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97396 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-19 02:05:08 +00:00
jake%acutex.net
9307fd5a8a Refixing bug 71396. Each PushGlobalSQLState() needs a PopGlobalSQLState() and this file instead had two "pushes". 
git-svn-id: svn://10.0.0.236/trunk@97393 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-19 01:37:02 +00:00
jake%acutex.net
5743b31229 Allow '\' as a path delimiter (bug 29064) 
Patch Concept by <timeless@mac.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97370 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-18 23:13:18 +00:00
jake%acutex.net
73d667cb49 Fix for bug 85832 - QuickSearch should strip leading and trailing spaces. 
Patch by Andreas Franke <afranke@ags.uni-sb.de>


git-svn-id: svn://10.0.0.236/trunk@97331 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-18 19:24:17 +00:00
tara%tequilarista.org
176266cd1f applying handy patch to refix version table to be 64 instead of 16--partial fix of bug 9352 
git-svn-id: svn://10.0.0.236/trunk@97283 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-16 23:01:12 +00:00
jake%acutex.net
c88b002e96 Fix for bug 71396 - $::db->do isn't needed anymore 
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97282 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-16 14:51:16 +00:00
jake%acutex.net
0c19e11337 Fix for bug 83619 - QuickSearch was crashing Netscape 4.76 and 4.77 on Unix 
Patch by Andreas Franke <afranke@ags.uni-sb.de>


git-svn-id: svn://10.0.0.236/trunk@97238 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-15 20:16:59 +00:00
jake%acutex.net
0e2e8615a5 Checking in the cleaner version of the fix for "No Available Products". This was attached to bug 65311. 
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97164 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-14 20:02:31 +00:00
jake%acutex.net
3f301421a8 Backing out previous changes as there was a better patch already attached to a different bug 
git-svn-id: svn://10.0.0.236/trunk@97163 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-14 20:00:03 +00:00
jake%acutex.net
6125f97685 Bugzilla shouldn't display empty header in the New: email notifications (bug 85734) 
r=timeless


git-svn-id: svn://10.0.0.236/trunk@97146 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-14 14:16:27 +00:00
justdave%syndicomm.com
35ab8d3d93 Fix for bug 84596: Syncshadowdb wasn't using the db_user and db_pass from localconfig, which meant that it previously wouldn't run unless it was running under a user that had access to the bugs and shadowbugs dbs and didn't have a password. It now looks for db_user and db_pass and specifies them on the command line to mysqldump and mysql if they're in use. 
r= tara


git-svn-id: svn://10.0.0.236/trunk@96822 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-10 17:38:15 +00:00
justdave%syndicomm.com
64139789dc Re-fix for bug 21253: fix calling conventions for syncshadowdb so that a phony parameter to get past the multi-param system() test in tinderbox actually works. 
r= tara


git-svn-id: svn://10.0.0.236/trunk@96819 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-10 17:15:56 +00:00
jake%acutex.net
8e42d674c4 Give a logical error message if no products are available to a user for bug entry (bug 84285). 
Patch by Paul Thomas <paul.thomas@sse.ie>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96712 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-08 13:12:13 +00:00
justdave%syndicomm.com
2a73def3a6 Hopefully the fix for bug 77778: component lists, etc stuttering due to corruption in data/versioncache. 
Patch design by Terry Weissman <terry@mozilla.org>
Patch implemented by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96651 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-07 21:26:49 +00:00
justdave%syndicomm.com
62f8abbb9a Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in. 
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96648 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-07 20:26:40 +00:00
justdave%syndicomm.com
5c9e4da69d fix typo 
git-svn-id: svn://10.0.0.236/trunk@96598 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-07 01:31:51 +00:00
justdave%syndicomm.com
70301d4eb1 Fix "used only once" error, per tinderbox build log. 
git-svn-id: svn://10.0.0.236/trunk@96563 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-06 23:09:54 +00:00
justdave%syndicomm.com
0d88c2a487 Fix for bug 21253: removing all single-parameter system() calls from Bugzilla 
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96556 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-06 21:17:42 +00:00
justdave%syndicomm.com
ca7f7346ea Fix for bug 83872: Bugzilla no longer requires the Mysql Perl module, but the DBD::mysql Perl module, and has been this way for a while. Fixing the version checks in checksetup.pl to check the correct module. Also eliminates a DBD::mysql-specific database function call that is depricated in the current version of DBD_mysql. 
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net, tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96555 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-06 21:10:47 +00:00
jake%acutex.net
cceefc3d43 Users should only be able to view attachments if they can view the bug that the file is attached to (bug 70189) 
r=tara


git-svn-id: svn://10.0.0.236/trunk@96543 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-06 18:36:25 +00:00
jake%acutex.net
3cb4dd4427 Fixing typo. Attachments isn't spelled 'Attachemnts' (bug 84295). 
git-svn-id: svn://10.0.0.236/trunk@96532 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-06 14:25:18 +00:00
justdave%syndicomm.com
4bc7340572 Fix for bug 39557: doeditvotes.cgi will no longer create a vote record for a nonexistant bug if the HTML is tampered with or other bugs cause bad bug numbers in the submitted form. 
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96496 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-06 04:51:55 +00:00
justdave%syndicomm.com
9e1f7b46e4 Fix for bug 82781: describecomponents.cgi now checks viewing permissions to make sure you can see a product 
Patch by Myk Melez <myk@mozilla.org>
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96493 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-06 04:32:45 +00:00
justdave%syndicomm.com
ebc34ab007 Fix for bug 28458: "NEW" bugs were not getting CC or QA Contact information displayed. 
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96491 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-06 04:28:52 +00:00
justdave%syndicomm.com
8928aa2555 Fix for bug 75482: adding the capability to deactivate a group without deleting it (prevent new bugs from being placed into that group, but don't remove the group restriction from bugs already in it). 
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96488 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-06 03:16:52 +00:00
ian%hixie.ch
c39644bda6 * Improved the helpfulness of the extremely verbose debugging information of PLIF.pm by quoting embedded variables 
* Implemented MagicCollectingArray, which acts like MagicPipingArray except that the result is collected into one big array instead of multiple arrayrefs
* Added the relevant getCollecting*List methods to the Controller class
* Added DESTROY methods to the magic array to prevent DESTROY method calls from being propagated
* Made the debug.dumpVars string more robust when the data hash includes one of the three magic characters '(', '.' or ')'
* Implemented sanitation in COSES so that any keys in the data hash containing one of the three magic characters '(', '.' or ')' will have them transliterated to '[', ':' and ']' respectively (sanitation is optional and can be bypassed)
* Changed the API of the generic output module's 'output' method to take the optional $session argument last, thus simplifying the call sites a lot
* Implemented the 'dispatcher.output' service in several classes to return strings that must be support in variants (required for a good UI in the COSES editor)
* Renamed the Login module's strings so that they use the dot-notation separating significant parts


git-svn-id: svn://10.0.0.236/trunk@96296 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-04 06:13:22 +00:00
ian%hixie.ch
31afdd6c43 Stub implementation of a COSES editor component, plus added 'component.nameOfComponent' to the list of services provided by the other two components 
git-svn-id: svn://10.0.0.236/trunk@96279 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-03 23:06:09 +00:00
ian%hixie.ch
a4e5deac24 Moved AdminCommands.pm and Login.pm to a Component directory 
git-svn-id: svn://10.0.0.236/trunk@96278 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-03 22:45:37 +00:00
ian%hixie.ch
c77a5c18e0 Minor bug fixes required to make the code run without crashing... 
git-svn-id: svn://10.0.0.236/trunk@96276 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-03 16:14:41 +00:00
ian%hixie.ch
c054620213 Some more minor corrections to get it to run as well as compile... (removes some XXX comments and adds some error checking) 
git-svn-id: svn://10.0.0.236/trunk@96275 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-03 15:27:16 +00:00
ian%hixie.ch
e283e3f98d Fixing a gazillion syntax, logic and XML errors and adding some debug code. It compiles! 
git-svn-id: svn://10.0.0.236/trunk@96274 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-03 14:49:41 +00:00
ian%hixie.ch
1c4b9ea728 * Added some comments (including some XXX comments where I realised we had missing code) 
* Added implicit data to the hash passed to the string expander from the generic output service
* To support the implicit data, added a |hash| stub method to the Session.pm module (and changed the already implemented version in the descendant user service to take this into account)
* To support the implicit data, added |hash| and |getArguments| methods to the Input.pm module (and implemented |getArguments| in the Arguments.pm module)
* To support the implicit data, made the Program.pm module keep track of the executing command
* To support the implicit data, added |hash| and |name| methods to the Program.pm module (actually, |name| was already assumed to exist in other parts of the codebase)
* Corrected trivial semantic mistake in Program.pm's |verifyInput| method
* Added a way to get a user not by username but by a specific address (modifies the user service and the user data source and it's MySQL implementation)
* Implemented GenericOutputs.pm, an implementation of 'dispatcher.output.generic' and 'dataSource.strings.default' for some strings used by other parts of PLIF (currently only supports 'stdout' and 'http' protocols, and minimally at that)
* Implemented Login.pm, a helper module that implements user authentication, user creation and the sending of a new password if it is forgotten, a utility method |hasRight| to ensure that the authenticated user has a particular right (resulting in a message if not), and various routines to support all this.


git-svn-id: svn://10.0.0.236/trunk@96268 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-03 10:11:58 +00:00
tara%tequilarista.org
cbb24b9172 Landing Myk's patch for bug #71767 
git-svn-id: svn://10.0.0.236/trunk@96243 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-02 22:02:02 +00:00
jake%acutex.net
f76024a6dd sanitycheck.cgi was able to be run by anybody - even people without Bugzilla accounts. It is now restricted to only people with the editbugs permission (bug 54556). 
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96240 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-02 14:24:45 +00:00
justdave%syndicomm.com
f8543b2ba4 Fix for bug 65190: add comparison type "all words as substrings" and "any words as substrings" to the text fields in query.cgi 
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96226 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-02 04:02:13 +00:00
justdave%syndicomm.com
21860cdbe4 Fix for bug 78407: extra safeguard against overpopping the email list when pruning people who aren't supposed to get mail. 
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96224 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-02 03:19:26 +00:00
justdave%syndicomm.com
c0b8428705 Fix for bug 83596: optional dependency on XML::Parser now checked in checksetup.pl 
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96214 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-02 01:57:22 +00:00
justdave%syndicomm.com
9018fe3035 Fix for bug 83618: checksetup.pl crashes if DBI module isn't already installed. 
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96211 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-02 01:53:01 +00:00
jake%acutex.net
8401f362a9 More leak pluggin. This one fixes bug 39526. 
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96180 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-01 13:38:01 +00:00
justdave%syndicomm.com
603852acc2 Fix for bug 83633: perl warnings in 5.6 
r= Hixie


git-svn-id: svn://10.0.0.236/trunk@96174 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-01 10:03:52 +00:00
justdave%syndicomm.com
581eaee916 Fix for bug 73249: perl warnings under 5.6.0. 
Patch by Chris Yeh <Chris.Yeh@nokia.com>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96172 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-01 08:34:45 +00:00
justdave%syndicomm.com
ac828bb8f0 Fix for bug 79317: dependency on CGI::Carp not caught by checksetup.pl 
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96166 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-01 03:13:28 +00:00
justdave%syndicomm.com
0ed9a380b7 backing out previous fix to importxml.pl. It fixed it on Perl 5.6 and broke it on Perl 5.005. Will need to investigate. 
git-svn-id: svn://10.0.0.236/trunk@96165 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-01 02:27:52 +00:00
justdave%syndicomm.com
f693a23060 Fix for bug 72862: fixes more Perl warnings in RelationSet.pm and globals.pl 
git-svn-id: svn://10.0.0.236/trunk@96164 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-01 02:14:23 +00:00
justdave%syndicomm.com
fc2f6bb5a8 Fix for bug 57848, perl warnings in several files. 
Patch by Nick Hibma <n_hibma@qubesoft.com>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96163 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-01 02:07:28 +00:00
ian%hixie.ch
1e260d62d7 * fixing some syntactic errors 
* added addUserGroup and removeUserGroup to the data source interface for users
* added some comments
* changed many double quotes |"| to single quotes |'| where double quotes were not needed
* implemented the remaining methods for the MySQL implementation of the user data source
* added a mode flag to user fields (idea from MattyT) so that fields can be disabled, hidden, etc


git-svn-id: svn://10.0.0.236/trunk@96152 18797224-902f-48f8-a5cc-f745e15eee43
 2001-06-01 00:32:35 +00:00
jake%acutex.net
ce19d8c942 Bugzilla was leaking information about bugs marked secure (using bug groups). This checkin fixes bugs 39524, 39527, 39531, and 39533. 
Patches by Myk Melez <myk@mozilla.org>.
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96121 18797224-902f-48f8-a5cc-f745e15eee43
 2001-05-31 15:52:25 +00:00
jake%acutex.net
c462166cb5 Bug 80388 - cvsblame shouldn't require layers for popups 
r=baloo


git-svn-id: svn://10.0.0.236/trunk@96073 18797224-902f-48f8-a5cc-f745e15eee43
 2001-05-30 22:13:03 +00:00