304 Commits

Author SHA1 Message Date
julien.pierre.bugs%sun.com
600a141f4c Fix for bug 225525 . Resolve race assigning NSSCertificate fields which leaked memory and slot reference. r=nelson
git-svn-id: svn://10.0.0.236/trunk@208124 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-22 22:54:11 +00:00
nelson%bolyard.com
7aa683b767 Fix race in CERT_NewTempCertificate. Bug 341323. r=julien,rrelyea
git-svn-id: svn://10.0.0.236/trunk@208087 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-22 03:30:14 +00:00
julien.pierre.bugs%sun.com
a48ba8324d Fix for bug 178894 . Quick decoder updates for lib/certdb and lib/certhigh . r=nelson .
git-svn-id: svn://10.0.0.236/trunk@206742 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-07 19:09:41 +00:00
julien.pierre.bugs%sun.com
d8757a4062 Fix for bug 336477 . Fix for CERT_UncacheCRL error checking. r=nelson
git-svn-id: svn://10.0.0.236/trunk@198715 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-31 01:58:50 +00:00
nelson%bolyard.com
0b6cbc463e Plug leak. Free cache. Coverity bug 338201. r=alexei.volkov
git-svn-id: svn://10.0.0.236/trunk@197951 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-18 20:47:46 +00:00
wtchang%redhat.com
674b3349ea Bugzilla Bug 337025: removed more unused or trivially used variables.
r=alexei.volkov,nelson.bolyard.


git-svn-id: svn://10.0.0.236/trunk@196627 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-16 01:57:04 +00:00
alexei.volkov.bugs%sun.com
a71a7d0dd6 Patch contributed by timeless@bemail.org
[Bug 337025] Coverity 411, dead code in mozilla/security/nss/lib/certdb/stanpcertdb.c. r=nelson


git-svn-id: svn://10.0.0.236/trunk@196582 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-15 20:39:38 +00:00
alexei.volkov.bugs%sun.com
df555d9fd3 Patch contributed by timeless@bemail.org
[Bug 336466] oom crash [@ CERT_DecodeAuthKeyID]. r=nelson


git-svn-id: svn://10.0.0.236/trunk@196444 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-13 00:33:14 +00:00
julien.pierre.bugs%sun.com
9202c9eb23 Fix for bug 336477. Memory leak in CERT_UncacheCRL . r=nelson
git-svn-id: svn://10.0.0.236/trunk@196442 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-13 00:27:53 +00:00
julien.pierre.bugs%sun.com
145d6ac5e1 Fix for bug 311164 . Initialize stan cert store object early to fix a race condition. r=nelson
git-svn-id: svn://10.0.0.236/trunk@193801 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-07 05:49:04 +00:00
nelson%bolyard.com
aec5c79ea6 Bug 326315. Warning Reduction. On TRUNK only. r=Julien.Pierre
git-svn-id: svn://10.0.0.236/trunk@191371 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-28 05:56:07 +00:00
wtchang%redhat.com
d5a4f4cfb3 Bugzilla Bug 327529: unnamed arguments (third and after) for CERT_CreateRDN
must have the correct CERTAVA * type because compilers can't do automatic
type conversions. r=nelsonb,jpierre.
Modified files: alg1485.c secname.c


git-svn-id: svn://10.0.0.236/trunk@190617 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-20 23:06:55 +00:00
julien.pierre.bugs%sun.com
c94cc640d1 Fix for bug 321765. Allow NSS to decode certs with unsupported critical extensions. r=wtchang,nelson,rrelyea.
git-svn-id: svn://10.0.0.236/trunk@190162 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-16 00:06:24 +00:00
julien.pierre.bugs%sun.com
dc079f7645 Fix for bug 217024. add a function for comparing cert validity periods. r=wtchang
git-svn-id: svn://10.0.0.236/trunk@177925 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-17 02:04:12 +00:00
julien.pierre.bugs%sun.com
166d66e866 Fix for 217024 . Address Wan-Teh's concerns about naming and documentation. Also fix AIX build by removing extraneous comma.
git-svn-id: svn://10.0.0.236/trunk@175863 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-09 00:34:43 +00:00
julien.pierre.bugs%sun.com
1d6851fd77 Fix for bug 217024 . Add a function to compare validity times. r=relyea
git-svn-id: svn://10.0.0.236/trunk@175831 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-08 07:06:56 +00:00
wtchang%redhat.com
b528d8f9e4 Bugzilla Bug 287057: fixed memory leaks in callers of cert_FindExtension.
pass NULL as the SECItem* argument if we only want to know if the extension
exists but don't need its value. r=jpierre,nelsonb.
Modified Files:
	certdb/certdb.c certdb/genname.c certhigh/certhigh.c
	certhigh/certhtml.c certhigh/crlv2.c certhigh/ocsp.c


git-svn-id: svn://10.0.0.236/trunk@175420 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-30 20:53:57 +00:00
julien.pierre.bugs%sun.com
233358aeec Fix for 290121. Replace PRIntervalTime with PRTime when checking for the need to query the token for CRLs. r=nelson
git-svn-id: svn://10.0.0.236/trunk@172359 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-17 03:17:07 +00:00
julien.pierre.bugs%sun.com
8df034a65c Fix for 290121 - always fill the CRL cache on first entry, to fix AIX problem. r=nelson
git-svn-id: svn://10.0.0.236/trunk@172084 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-13 18:08:48 +00:00
alexei.volkov.bugs%sun.com
775e2d0de9 Fix for bug 265003: Add CRL generation to crlutil. Reviewed JP+
git-svn-id: svn://10.0.0.236/trunk@172015 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-12 02:24:17 +00:00
julien.pierre.bugs%sun.com
7ab8e0190f Remove unused variable
git-svn-id: svn://10.0.0.236/trunk@171493 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-02 05:17:27 +00:00
neil.williams%sun.com
8395d7fafb r=nelson Bug=263779
git-svn-id: svn://10.0.0.236/trunk@170477 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 23:02:48 +00:00
julien.pierre.bugs%sun.com
88d1026757 Fix for 285233 - need extra symbols to be exported to support CRL generation. Ch
ecking in for alexei volkov . r=nelson


git-svn-id: svn://10.0.0.236/trunk@170373 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-08 07:08:48 +00:00
nelsonb%netscape.com
784913e894 Export CERT_SequenceOfCertExtensionTemplate on Windows.
Fix type of "attributes" member of struct CERTCertificateRequestStr.
Bug 284200.  r=nelson.williams & wtchang.


git-svn-id: svn://10.0.0.236/trunk@170202 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 08:03:04 +00:00
julien.pierre.bugs%sun.com
a906b21c0a Fix crash in CRL sorting callbacks from qsort.
git-svn-id: svn://10.0.0.236/trunk@170118 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-03 04:07:26 +00:00
julien.pierre.bugs%sun.com
dd31c2d763 Move static functions out of certi.h header file and into crl.c source file, to remove warnings with gcc
git-svn-id: svn://10.0.0.236/trunk@169803 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-25 00:54:29 +00:00
julien.pierre.bugs%sun.com
0513932046 Fix compiler warnings under Linux
git-svn-id: svn://10.0.0.236/trunk@169703 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 00:22:59 +00:00
julien.pierre.bugs%sun.com
37edfe8363 Add comment for bug 243585
git-svn-id: svn://10.0.0.236/trunk@169702 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 00:22:23 +00:00
julien.pierre.bugs%sun.com
926b40d5fa Fix compilation on AIX
git-svn-id: svn://10.0.0.236/trunk@169209 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-15 19:26:28 +00:00
julien.pierre.bugs%sun.com
761d5cc7c7 Fix for 243585 - add the ability to use CRL objects from RAM . r=nelson, neil.williams
git-svn-id: svn://10.0.0.236/trunk@169200 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-15 06:26:43 +00:00
nelsonb%netscape.com
45ed99ddc6 Workaround the occasional SSL server cert that has the step-up OID but
not the SSL server OID.  Patch by Aaron Spangler <aaron@spangler.ods.org>
Bug 231775. r=nelson


git-svn-id: svn://10.0.0.236/trunk@166174 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-02 22:08:14 +00:00
nelsonb%netscape.com
69c8d2d723 When attempting to find an SMIME profile for a given email address,
firt ensure that the email address is not NULL and not empty.
Bugzilla bug 263596. r=wan-teh.
Modified Files: lib/certdb/stanpcertdb.c lib/pk11wrap/pk11nobj.c


git-svn-id: svn://10.0.0.236/trunk@166165 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-02 21:34:15 +00:00
wchang0222%aol.com
53fa50ce06 Bugzilla bug 248435: declare the exported functions CERT_DecodeGeneralName
and CERT_EncodeGeneralName in the public header cert.h.  r=jpierre.
Modified Files: cert.h genname.h xconst.c


git-svn-id: svn://10.0.0.236/trunk@165153 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-09 06:13:32 +00:00
relyea%netscape.com
cb8fbb0164 Bug 250687
NSS Crashes or leaks Cert references if bad certs are passed up by PKCS #11 modules.
r=nelson
sr=ian


git-svn-id: svn://10.0.0.236/trunk@159599 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-21 18:18:05 +00:00
wchang0222%aol.com
b4c8df8df4 Bugzilla bug 249284: removed a duplicate declaration of
CERT_DecodeDERCertificate. r=nelsonb. Thanks to Chris Newman
of Sun for the bug report.


git-svn-id: svn://10.0.0.236/trunk@158814 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-07 00:48:53 +00:00
nelsonb%netscape.com
44c47c0478 Treat non-repudiation-only certs as valid signature certs.
Bug 240456.  r=wtc, sr=relyea.


git-svn-id: svn://10.0.0.236/trunk@158624 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-01 00:26:00 +00:00
nelsonb%netscape.com
b463fcd106 Correct NSS to use the most specific, not most general CN attribute in
a cert subject name.  Bug 197964.  r=wtc.


git-svn-id: svn://10.0.0.236/trunk@158623 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-01 00:21:42 +00:00
nelsonb%netscape.com
464c8d0e9b Don't crash when CERT_DestroyCertificate is called with a cert with a
null arena pointer.  Bug 245943. r=julien


git-svn-id: svn://10.0.0.236/trunk@157647 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-09 07:47:51 +00:00
ian.mcgreer%sun.com
f7fd7e85b4 bug 180268, reimplement ssl step-up for builtins
git-svn-id: svn://10.0.0.236/trunk@156475 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-17 20:08:38 +00:00
jpierre%netscape.com
5e7e772f3a Fix for 240361 - crash in CERT_CheckValidTimes
git-svn-id: svn://10.0.0.236/trunk@156219 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-11 02:43:10 +00:00
jpierre%netscape.com
1d0c147cec Fix for 202979 . Resolve binary compatibility issue for CERT_ImportCerts . r=wtc, jpierre
git-svn-id: svn://10.0.0.236/trunk@155956 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-05 01:15:39 +00:00
gerv%gerv.net
43cb9e1492 Bug 236613: change to MPL/LGPL/GPL tri-license.
git-svn-id: svn://10.0.0.236/trunk@155484 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-25 15:03:26 +00:00
nelsonb%netscape.com
f0478237c1 Remove code that attempted to compare simple host names in URLs with
FQDNs in certificate host names.  This was insecure.  Bug 234058. r=wtc.


git-svn-id: svn://10.0.0.236/trunk@154607 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-08 00:17:46 +00:00
wchang0222%aol.com
d658ec460b Bugzilla bug 238565: made the comment match the code. r=nelsonb.
git-svn-id: svn://10.0.0.236/trunk@154329 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 01:51:25 +00:00
nelsonb%netscape.com
675d519e51 Correct the parsing of certain forms of GeneralName. Bug 233586.
r=julien.pierre


git-svn-id: svn://10.0.0.236/trunk@154277 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-26 01:15:33 +00:00
nelsonb%netscape.com
96643781b8 Fix a regression introduced by rev 1.19, after NSS 3.9 was released.
r=julien.pierre.  bugscape 56484.


git-svn-id: svn://10.0.0.236/trunk@154181 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-23 03:30:34 +00:00
nelsonb%netscape.com
aa4efc8531 Detect NULL arguments to CERT_DecodeTrustString instead of crashing.
Bug 235617. r=wtc.


git-svn-id: svn://10.0.0.236/trunk@153252 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-26 00:05:29 +00:00
jpierre%netscape.com
908536cb6c Fix for bug 233605 . Check CRL entry extensions after partial decoding. Also add some new CRL decoding errors. r=nelsonb
git-svn-id: svn://10.0.0.236/trunk@152653 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-11 06:05:18 +00:00
jpierre%netscape.com
1f99d2576b Fix for 233118 . additional check for CRL signing usage. r=nelsonb
git-svn-id: svn://10.0.0.236/trunk@152649 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-11 05:25:01 +00:00
wchang0222%aol.com
8f1f979564 Bugzilla bug 225808: 1. Use a 32-bit integer type for cert->nsCertType so
that it can be safely passed to PR_AtomicSet on all platforms.  Note that
we still use an unsigned type to avoid introducing signed/unsigned compiler
warnings.  2. Added a (PRInt32 *) cast to eliminate a pre-existing
signed/unsigned warning.  r=nelsonb.
Modified Files: certdb.c certt.h


git-svn-id: svn://10.0.0.236/trunk@152447 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-07 01:41:15 +00:00