70 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
cf8cbc482d Bug 783222 - Make set_all() throw error on invalid param names
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264191 18797224-902f-48f8-a5cc-f745e15eee43
2012-08-31 20:45:43 +00:00
mkanat%bugzilla.org
55b75d523a Bug 528918: Bugzilla::Object->match() shouldn't call _check_field() when the field being passed can be trusted (deserialising the DB schema is slow)
r=dkl a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263499 18797224-902f-48f8-a5cc-f745e15eee43
2012-02-28 23:17:05 +00:00
mkanat%bugzilla.org
cb3d9dfb15 Bug 715902: Do not log personal common activities in audit_log
r=dkl a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263259 18797224-902f-48f8-a5cc-f745e15eee43
2012-01-11 23:17:34 +00:00
mkanat%bugzilla.org
3b5e8524aa Bug 680131: Replace the MPL 1.1 license by the MPL 2.0 one in all files, and add it to files which miss one
r=kiko r=mkanat r=mrbball a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263258 18797224-902f-48f8-a5cc-f745e15eee43
2012-01-11 22:48:45 +00:00
mkanat%bugzilla.org
3c3491cd57 Bug 686786: Decreasing votestoconfirm in editproducts.cgi crashes Bugzilla
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@262922 18797224-902f-48f8-a5cc-f745e15eee43
2011-09-28 23:33:06 +00:00
mkanat%bugzilla.org
50ea52fcb9 Bug 622943: Simple auditing of changes to Bugzilla::Object subclass objects
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@262039 18797224-902f-48f8-a5cc-f745e15eee43
2011-03-14 05:16:46 +00:00
mkanat%bugzilla.org
1caec144d2 Bug 617477: Fix numerous consistency and behavior issues surroudning Bug.update
and Bugzilla::Bug. See https://bugzilla.mozilla.org/show_bug.cgi?id=617477#c2
for details.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@261653 18797224-902f-48f8-a5cc-f745e15eee43
2010-12-13 21:02:10 +00:00
mkanat%bugzilla.org
0f6811ce30 Bug 590334: Change Bug.pm to use the comment object (Bugzilla::Comment)
when creating or updating bug comment
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@261388 18797224-902f-48f8-a5cc-f745e15eee43
2010-10-13 23:37:31 +00:00
mkanat%bugzilla.org
211ad76604 Bug 587793: Add a new "object_end_of_create" hook so that extensions can
operate on any new objects
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@261163 18797224-902f-48f8-a5cc-f745e15eee43
2010-09-01 23:06:21 +00:00
mkanat%bugzilla.org
fd470cc2f7 Bug 583690: (CVE-2010-2759) [SECURITY][PostgreSQL] Bugzilla crashes when viewing a bug if a comment contains 'bug <num>' or 'attachment <num>' where <num> is greater than the max allowed integer
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260976 18797224-902f-48f8-a5cc-f745e15eee43
2010-08-04 22:22:01 +00:00
mkanat%bugzilla.org
1a4d14c903 Bug 574892: [SECURITY] Add EXTRA_REQUIRED_FIELDS to Bugzilla::Object, which
allows specifying that certain fields have validator defaults even if they
also have a database default or are in another table.
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260643 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-06 02:31:41 +00:00
mkanat%bugzilla.org
1be00a65d9 Bug 572602: Change the way that Bugzilla::Object determines what fields
are required for create(). It now assumes that any column that is NOT NULL
and has not DEFAULT in the database is required. We also shift the burden
of throwing errors about empty values to the validators. This fixes the bug
that Bugzilla::Bug->create() wasn't populating default values for fields
if they weren't specified in the create() parameters.
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260542 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-24 00:47:53 +00:00
mkanat%bugzilla.org
05f390461e Bug 567846: Modify set_status, set_resolution, and set_dup_id to use
VALIDATOR_DEPENDENCIES, so that they don't need custom code in set_all.


git-svn-id: svn://10.0.0.236/trunk@260420 18797224-902f-48f8-a5cc-f745e15eee43
2010-06-03 19:31:22 +00:00
mkanat%bugzilla.org
980d27c51a "part" can return "undef" for a list, so sometimes $has_deps or $no_deps
in Bugzilla::Object::_sort_by_deps were undef.


git-svn-id: svn://10.0.0.236/trunk@260371 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-25 03:31:27 +00:00
mkanat%bugzilla.org
29d1c47764 Bug 567303: Implement a working algorithm for sorting fields based on
VALIDATOR_DEPENDENCIES in Bugzilla::Object. (The previous code did not
actually sort fields correctly.)
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260370 18797224-902f-48f8-a5cc-f745e15eee43
2010-05-24 23:01:27 +00:00
mkanat%bugzilla.org
a066f0c3b7 Bug 539865: Make Bugzilla::Object pass $params to validators during create()
(implement VALIDATOR_DEPENDENCIES)
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260219 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-22 18:22:51 +00:00
mkanat%bugzilla.org
b9f9993bcf Bug 556869: New Hook: object_before_delete
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260131 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-02 21:17:50 +00:00
mkanat%bugzilla.org
468f302c50 Bug 556695: New Hook: object_end_of_set
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260121 18797224-902f-48f8-a5cc-f745e15eee43
2010-04-02 05:47:50 +00:00
mkanat%bugzilla.org
7487781c6d Bug 486074: Allow the JSON-RPC interface to properly serialize objects
to JSON, so that the Bug.get "internals" return item works.
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259792 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-23 00:22:25 +00:00
mkanat%bugzilla.org
a68210b184 Bug 372979: Make voting into an extension
r=mkanat, a=mkanat, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259709 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-15 23:32:10 +00:00
mkanat%bugzilla.org
e68544b6f9 Bug 545551: Hook: object_update_columns
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@259685 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-11 01:46:31 +00:00
mkanat%bugzilla.org
69d853b916 Bug 545541: New Hook: object_columns
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@259683 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-11 01:01:40 +00:00
mkanat%bugzilla.org
83dc2fc2f8 Fix a typo in Object.pm.
git-svn-id: svn://10.0.0.236/trunk@259682 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-11 00:17:40 +00:00
mkanat%bugzilla.org
fe4c8eab48 Bug 545524: New Hook: object_validators
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@259681 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-11 00:16:29 +00:00
mkanat%bugzilla.org
2b3d3c2ab8 Bug 543986: False positive in 012throwables.t, 'object_does_not_exist' is still in use
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259623 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-05 22:02:19 +00:00
mkanat%bugzilla.org
3875453816 Bug 514970: Clean up duplicates.cgi and make it use Bug objects
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259557 18797224-902f-48f8-a5cc-f745e15eee43
2010-02-01 23:57:10 +00:00
mkanat%bugzilla.org
98a5bbf59c Bug 430014: Re-write the code hooks system so that it uses modules instead of individual .pl files
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259069 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-24 06:09:55 +00:00
mkanat%bugzilla.org
5f41b9260d Fix checkin of bug 528062--it was missing ::process in the hook call.
git-svn-id: svn://10.0.0.236/trunk@259062 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-23 07:07:12 +00:00
mkanat%bugzilla.org
ec45876855 Bug 528062: Hook: Object-end_of_update
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259057 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-23 06:34:29 +00:00
mkanat%bugzilla.org
4f112293e6 Bug 521413: Hook: object-end_of_set_all
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259056 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-23 06:29:13 +00:00
mkanat%bugzilla.org
a2daa283c5 Bug 525426: Hook: object-before_set
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259016 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-18 07:17:52 +00:00
mkanat%bugzilla.org
142a010168 Bug 524007: New Hook: object-end_of_create_validators
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@259014 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-18 07:13:25 +00:00
mkanat%bugzilla.org
9f4660984d Bug 521373: Hook: object-before_create
git-svn-id: svn://10.0.0.236/trunk@259013 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-18 07:11:36 +00:00
mkanat%bugzilla.org
17aaca86e7 Bug 523977: Make Bugzilla::Object->check send the trimmed value to new(), and also be more accurate about what's "empty". This also makes detaint_natural and detaint_signed call int() on their return values.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258774 18797224-902f-48f8-a5cc-f745e15eee43
2009-10-24 05:26:35 +00:00
mkanat%bugzilla.org
c0f1709c2a Bug 515191: [SECURITY] SQL Injection via Bug.search (CVE-2009-3125) and Bug.create (CVE-2009-3165)
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258359 18797224-902f-48f8-a5cc-f745e15eee43
2009-09-11 16:14:09 +00:00
mkanat%bugzilla.org
b3e604abe5 Bug 449705: Make buglist.cgi's LookupNamedQuery use Bugzilla::Search::Saved
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258194 18797224-902f-48f8-a5cc-f745e15eee43
2009-08-21 21:33:31 +00:00
mkanat%bugzilla.org
992afafa72 Bug 509045: Make "use_keywords" a global template variable instead of having to pass it to templates all the time
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258054 18797224-902f-48f8-a5cc-f745e15eee43
2009-08-11 04:34:22 +00:00
mkanat%bugzilla.org
766d8af55e Bug 474897: Give Bug.search sensible default search types for its fields
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=ghendricks, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@257069 18797224-902f-48f8-a5cc-f745e15eee43
2009-04-28 20:14:29 +00:00
lpsolit%gmail.com
0fd71f2e8c Fix the warning thrown by 011pod.t
git-svn-id: svn://10.0.0.236/trunk@256856 18797224-902f-48f8-a5cc-f745e15eee43
2009-04-08 21:28:21 +00:00
mkanat%bugzilla.org
22d4b4a1bd Bug 432907: Create a JSON frontend for WebServices
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@256768 18797224-902f-48f8-a5cc-f745e15eee43
2009-03-31 06:38:02 +00:00
mkanat%bugzilla.org
8e5214f45c Fix some nits that I forgot to fix on checkin for bug 474715.
git-svn-id: svn://10.0.0.236/trunk@255902 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-23 03:27:47 +00:00
mkanat%bugzilla.org
196f3f1b93 Bug 474715: Add 'limit', 'offset' and 'changed_since' arguments to WebService::Bug.search()
Patch By Kip Hampton <khampton@totalcinema.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@255901 18797224-902f-48f8-a5cc-f745e15eee43
2009-01-23 03:19:37 +00:00
mkanat%bugzilla.org
d9ed95495e Bug 291433: Ability to have custom fields whose visibility depends on the values of other fields
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bbaetz, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254756 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-24 23:11:51 +00:00
mkanat%bugzilla.org
8eacc9bd1f Bug 460293: Implement Bugzilla::Object::set_all and have editkeywords.cgi use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@254654 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-18 16:30:21 +00:00
mkanat%bugzilla.org
9d8547c521 Bug 456919: Implement Bugzilla::Field::Choice->remove_from_db and have editvalues.cgi use it
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=bbaetz, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254511 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-03 01:37:20 +00:00
mkanat%bugzilla.org
bdec3cbd37 Bug 455641: Implement Bugzilla::Field::Choice->update and have editvalues.cgi use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bbaetz, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254510 18797224-902f-48f8-a5cc-f745e15eee43
2008-10-03 01:30:45 +00:00
mkanat%bugzilla.org
58e4977aa8 Bug 357904: Create an object for a Field Value and have Bugzilla::Field->legal_values use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bbaetz, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254382 18797224-902f-48f8-a5cc-f745e15eee43
2008-09-24 02:55:24 +00:00
mkanat%bugzilla.org
e3786a2294 Bug 372795: Implement Bugzilla::Product::preload() to speed up query.cgi when there are many products
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@248669 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-27 05:08:08 +00:00
mkanat%bugzilla.org
05d4a78dd9 Bug 408172: [Oracle] Bug lists longer than 1000 bugs fail
Patch By Xiaoou Wu <xiaoou.wu@oracle.com> r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@243446 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-18 15:56:55 +00:00
mkanat%bugzilla.org
dfcc3ead8a Bug 397099: Date/Time Fields should have a JavaScript widget for picking a date
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@240082 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-29 02:20:35 +00:00