2174 Commits

Author SHA1 Message Date
mkanat%bugzilla.org
cff5681e70 Bug 580208: Search.pm: Combine all the user search types into one search
function
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260840 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-22 00:46:42 +00:00
mkanat%bugzilla.org
f98a0d8a34 Bug 428313: Properly expire the browser's CSS and JS cache when there
are new versions of those files. This also eliminates single-file skins
and should also allow Extensions to have skins.
r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260830 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-21 03:48:22 +00:00
mkanat%bugzilla.org
fd32004814 Bug 579514: Make Bug.attachments also return attachment data
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260827 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-20 22:03:21 +00:00
mkanat%bugzilla.org
e7c68db0e1 Bug 579797: Restore ValidateGroupName in Bugzilla::Group, because it is
still in use by the whining system
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260825 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-20 21:31:49 +00:00
mkanat%bugzilla.org
dd5ffc6198 Bug 575475: ANSI coloring of error messages was hiding template compilation
errors
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260819 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-20 06:04:54 +00:00
mkanat%bugzilla.org
038e91d709 Bug 580174: Search.pm: Move special parsing functions around, to be more
orderly
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260818 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-20 06:01:55 +00:00
mkanat%bugzilla.org
a77eb64833 Bug 119703: Create an attachment by pasting it into a text field
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260809 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-18 17:31:54 +00:00
mkanat%bugzilla.org
dcf37601ba Bug 579568: Search.pm: Improve the implementation and performance of
substring and "words" searches, improve the formatting of generated SQL,
and use real subselects instead of performing the subselect and using its
results in an IN.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260807 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-18 01:01:41 +00:00
mkanat%bugzilla.org
5711e7a218 Bug 67036: Allow searching for product, component, etc. names that contain
commas
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260805 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-16 22:01:43 +00:00
mkanat%bugzilla.org
6a9394375f Bug 578335: The "Show next bug in my list" user pref either doesn't display the next bug or display one from the wrong buglist
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260799 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-16 10:04:35 +00:00
mkanat%bugzilla.org
c634e6e71e Bug 398308: Make Search.pm take a hashref for its "params" argument
instead of taking a CGI object.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260794 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-16 03:01:42 +00:00
mkanat%bugzilla.org
d9437423f7 Bug 521416: Some web servers fail to set the QUERY_STRING parameter
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260786 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 17:34:25 +00:00
mkanat%bugzilla.org
c8197e8456 Bug 577800: Finish the cleanup of Search.pm's "init" function by removing
it and having its work be done by a new "sql" accessor instead. Also adds
some comments, moves functions around into sections, and creates a new
_user accessor.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260784 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 11:24:27 +00:00
mkanat%bugzilla.org
a2ebe51f39 Bug 578904: Search.pm: Fully generate the FROM clause inside of an accessor
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260778 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 10:16:41 +00:00
mkanat%bugzilla.org
354474afad Bug 578888: Search.pm: Add and store joins as data structures instead of
raw SQL.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260777 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 05:46:39 +00:00
mkanat%bugzilla.org
a196f5150e Bug 578602: Search.pm: Move the parsing of boolean charts out of init
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260776 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-15 03:16:42 +00:00
mkanat%bugzilla.org
c501f77423 Bug 578739: Instead of removing REFERENCES from _bz_real_schema and then
populating FKs from _bz_schema at the end of checksetup, store REFERENCES
in _bz_real_schema with a special "created => 0" key that tells us that
we still need to create the FK.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260775 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 22:46:37 +00:00
mkanat%bugzilla.org
ff2c251501 Bug 578587: Make checksetup be way quieter when creating a new install
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260772 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 19:01:37 +00:00
mkanat%bugzilla.org
78df5f870c Bug 578308: Move the parsing of special fields and the creation of
@specialcharts out of init in Search.pm
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260768 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 05:16:31 +00:00
mkanat%bugzilla.org
9a3f7d202f Bug 578594: Search.pm: Move deadlinefrom and deadlineto parsing into a
special method
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260767 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 04:46:37 +00:00
mkanat%bugzilla.org
844f51805e The changes to accept positional parameters in XML-RPC meant that sometimes
$params wouldn't just be undef, but actually missing, so validate() was
getting @keys where $params should have been.


git-svn-id: svn://10.0.0.236/trunk@260766 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 04:04:43 +00:00
mkanat%bugzilla.org
2d0ddb344e Bug 578531: Move the chfield stuff out of init, and make
the changedbefore/after charts include the date specified
(they previously did exclusive searches)
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260764 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-14 02:16:34 +00:00
mkanat%bugzilla.org
4f6d79db10 Bug 578323: Remove the special parsing of "changedin" from Search.pm.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260759 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:46:36 +00:00
mkanat%bugzilla.org
3f376a9401 Bug 577765: Allow XML-RPC to accept multiple positional parameters
r=ghendricks, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260758 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:27:05 +00:00
mkanat%bugzilla.org
51d426d529 Remove some errors from WS_ERROR_CODE that don't exist on trunk.
git-svn-id: svn://10.0.0.236/trunk@260755 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:16:45 +00:00
mkanat%bugzilla.org
1e9ece0681 Bug 578324: The "Hours Worked" field in show_bug.cgi rejects all values passed to it if it would make the Remaining Time negative
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260750 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 23:05:56 +00:00
mkanat%bugzilla.org
4d8362abd8 Bug 412074: Ability to add attachments to a bug via the WebService
(Bug.add_attachment)
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260748 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 22:48:31 +00:00
mkanat%bugzilla.org
d00170cc62 Bug 578316: Search.pm: Move the parsing of email* fields into a method
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260744 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 11:02:11 +00:00
mkanat%bugzilla.org
9cf3dc10b0 Bug 578313: Search.pm: Move the parsing of basic fields (ones that map to
fielddefs) into methods
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260743 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 10:31:53 +00:00
mkanat%bugzilla.org
3084e8d1d5 Bug 578310: Search.pm: Move the special parsing of bug_status and resolution
out of init and into some _special_parse_* functions.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260742 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 10:16:45 +00:00
mkanat%bugzilla.org
38529a9513 Bug 578299: Search.pm: Generate the GROUP BY clause in a method
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260741 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 09:31:48 +00:00
mkanat%bugzilla.org
6a6d6ed46b Bug 578275: Search.pm: Fully generate the ORDER BY clause inside of an
accessor
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260736 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 06:02:02 +00:00
mkanat%bugzilla.org
dd8741db43 Bug 578278: Search.pm: Fully generate the SELECT clause inside of an accessor
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260735 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 05:50:30 +00:00
mkanat%bugzilla.org
48ca940e07 Bug 578266: Clean up the SPECIAL_ORDER code and make it into an accessor,
in Search.pm
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260734 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 04:01:55 +00:00
mkanat%bugzilla.org
fe97848dd8 alias_not_allowed should be multiple_alias_not_allowed
git-svn-id: svn://10.0.0.236/trunk@260727 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 02:23:04 +00:00
mkanat%bugzilla.org
ffd9f09c9d Bug 415813: Implement Bug.update() as an API for WebServices
r=dkl, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260726 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 01:51:32 +00:00
mkanat%bugzilla.org
5886523d89 Bug 578197: [PostgreSQL] When associating sequences with columns, also
fix the default of the columns so that it's identical to what a new
checksetup run would create.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260721 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-13 00:46:37 +00:00
mkanat%bugzilla.org
1bc2c64b47 Bug 578197: [PostgreSQL] Properly associate sequences that had no
column association
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260718 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-12 23:31:36 +00:00
mkanat%bugzilla.org
9b87c64225 Bug 577807: Convert the hard-coded stuff that adds map_* tables to @supptables
in Search.pm into a data structure and a series of functions that parse the
data structure.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260710 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 12:46:46 +00:00
mkanat%bugzilla.org
2850470be9 Bug 577805: Make chart_fields into an accessor in Search.pm
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260709 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 11:01:47 +00:00
mkanat%bugzilla.org
08abde2503 Bug 577803 - Make multi_select_fields into an accessor in Search.pm
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260708 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 10:34:02 +00:00
mkanat%bugzilla.org
7c5c6eb8e7 Bug 577754: Make updating bugs_fulltext during checksetup.pl WAY faster
for MySQL.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260707 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 05:36:00 +00:00
mkanat%bugzilla.org
a54682ffe0 Bug 577602: Don't put multi-select fields into the GROUP BY in Search.pm,
because they are created by an aggregate. (This fixes multi-select buglist
columns on Pg.)
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260706 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 05:17:04 +00:00
mkanat%bugzilla.org
f38eeae1ef Bug 451219: Allow altering from one SERIAL type to another on PostgreSQL,
for people upgrading Testopia from 1.3 to 2.0+.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260703 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 04:23:40 +00:00
mkanat%bugzilla.org
91679ae846 Bug 577793: Improve the Pg SERIAL-altering code now that we require 8.3
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260702 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-10 04:17:08 +00:00
mkanat%bugzilla.org
0b5e02b469 Bug 576670: Optimize Search.pm's "init" method for being called many times
in a loop
r=glob, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260692 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-09 02:16:39 +00:00
mkanat%bugzilla.org
9e50634048 Bug 577582: longdescs.isprivate "changedfrom" and "changedto" weren't
working on PostgreSQL, because Search.pm always converted the value
into 1 or 0 and passed that as a number to the database, and Pg didn't
support numeric comparison with a text column.
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260689 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-09 00:16:55 +00:00
mkanat%bugzilla.org
970784abc3 Bug 577577: Make bz_drop_fk be tolerant of SQL failure
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260688 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 23:50:06 +00:00
mkanat%bugzilla.org
db394fa150 Bug 577575: If percentage_complete is a column in the buglist, remaining_time
must also be selected from the database for PostgreSQL.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260687 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 23:31:50 +00:00
mkanat%bugzilla.org
a982e4fad4 Bug 577569: [PostgreSQL] Make sql_position explicitly cast both its arguments
to text, to avoid an error when searching "longdescs.isprivate" with the
"casesubstring" operator in Search.pm.
r=mkanat, a=mkanat (module owner)


git-svn-id: svn://10.0.0.236/trunk@260686 18797224-902f-48f8-a5cc-f745e15eee43
2010-07-08 23:03:46 +00:00