66 Commits

Author SHA1 Message Date
bzrmirror%bugzilla.org
84c5be6eb5 Bug 996893: Perl 5.18 and newer throw tons of warnings about deprecated modules
r=dkl a=sgreen


git-svn-id: svn://10.0.0.236/trunk@265490 18797224-902f-48f8-a5cc-f745e15eee43
2014-08-13 11:01:07 +00:00
bzrmirror%bugzilla.org
4f435f4fdd Bug 969881: All "Help" links in the header and footer of pages point to inexistent files
r=gerv a=justdave


git-svn-id: svn://10.0.0.236/trunk@265237 18797224-902f-48f8-a5cc-f745e15eee43
2014-02-12 14:16:00 +00:00
mkanat%bugzilla.org
8e47ba629a Bug 787529: Use |use 5.10.1| everywhere
r=wicked a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264195 18797224-902f-48f8-a5cc-f745e15eee43
2012-09-01 21:45:59 +00:00
mkanat%bugzilla.org
3b5e8524aa Bug 680131: Replace the MPL 1.1 license by the MPL 2.0 one in all files, and add it to files which miss one
r=kiko r=mkanat r=mrbball a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263258 18797224-902f-48f8-a5cc-f745e15eee43
2012-01-11 22:48:45 +00:00
mkanat%bugzilla.org
92c9d74c0b Bug 711714: (CVE-2011-3667) [SECURITY] The User.offer_account_by_email WebService method lets you create new user accounts independently of the value of Bugzilla::Auth::Verify::*::user_can_create_account
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263204 18797224-902f-48f8-a5cc-f745e15eee43
2011-12-28 22:17:49 +00:00
mkanat%bugzilla.org
ec2b135086 Fix bustage due to bug 705474
git-svn-id: svn://10.0.0.236/trunk@263171 18797224-902f-48f8-a5cc-f745e15eee43
2011-12-17 13:01:29 +00:00
mkanat%bugzilla.org
cd7853a286 Bug 705474 - CSRF vulnerability in createaccount.cgi allows possible unauthorized account creation e-mail request
[r=mkanat a=mkanat]


git-svn-id: svn://10.0.0.236/trunk@263160 18797224-902f-48f8-a5cc-f745e15eee43
2011-12-13 22:31:32 +00:00
mkanat%bugzilla.org
ba97af1e21 Bug 678970: Use $user and $cgi instead of Bugzilla->user and Bugzilla->cgi
r=timello a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262672 18797224-902f-48f8-a5cc-f745e15eee43
2011-08-16 23:02:57 +00:00
mkanat%bugzilla.org
bd9b5b9606 Bug 622513 - Email-related regexp checking should be case-insensitive. a=mkanat.
git-svn-id: svn://10.0.0.236/trunk@262017 18797224-902f-48f8-a5cc-f745e15eee43
2011-03-08 16:17:04 +00:00
lpsolit%gmail.com
8b80993aad Part 4 of bug 182083: add Help for non-admin pages - Patch by me, r=Colin
git-svn-id: svn://10.0.0.236/trunk@239166 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-11 22:03:21 +00:00
mkanat%bugzilla.org
d7e641858a Bug 399954: Make Bugzilla able to hold its dependencies in a local directory
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@237891 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-19 06:46:19 +00:00
timeless%mozdev.org
cf65aca309 Bug 254758 creating an account that doesn't match the create email regexp should not say "New accounts must be created by an administrator."
r=lpsolit a=lpsolit


git-svn-id: svn://10.0.0.236/trunk@230671 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-23 21:52:49 +00:00
mkanat%bugzilla.org
9cd61530a5 Bug 351098: Make Bugzilla::Object able to update objects in the database, and make Bugzilla::Keyword use it
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@209194 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-05 19:18:27 +00:00
mkanat%bugzilla.org
8aa56fc69e Bug 349349: Use ->create from Bugzilla::Object instead of insert_new_user for Bugzilla::User
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@208468 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-25 22:10:39 +00:00
lpsolit%gmail.com
b735434f6f Bug 87795: Creating an account should send token and wait for confirmation (prevent user account abuse) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat r=bkor a=myk
git-svn-id: svn://10.0.0.236/trunk@207935 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-19 18:12:00 +00:00
mkanat%bugzilla.org
520fe42625 Bug 338375: Use Bugzilla->params everywhere instead of Param().
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201503 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:42:47 +00:00
mkanat%bugzilla.org
8323e09c40 Bug 342869: Use Bugzilla->params everywhere except templates
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@201499 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-03 21:26:22 +00:00
lpsolit%gmail.com
a698e74659 Bug 282121: Remove globals.pl from scripts that no longer use it - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@200489 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-21 00:44:48 +00:00
lpsolit%gmail.com
a4475004a2 Bug 312935: User Account Log should start with a creation date - Patch by Frédéric Buclin <LpSolit@gmail.com> r=bkor, r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@199443 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-07 20:31:10 +00:00
mkanat%bugzilla.org
caee2e9858 Bug 300410: Bugzilla::Auth needs to be restructured to not require a BEGIN block
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@196368 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-12 02:41:22 +00:00
lpsolit%gmail.com
4bba466645 Bug 320436: New self-created accounts dont get regexp group memberships - Patch by Joel Peshkin <bugreport@peshkin.net> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@186337 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-20 22:16:09 +00:00
lpsolit%gmail.com
e334b85a95 Bug 312157: Remove $::template and $::vars from globals.pl - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@182927 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 23:11:56 +00:00
lpsolit%gmail.com
88c468dba1 Bug 304653: remove 'use Bugzilla::Error' from Util.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@177759 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-15 17:43:38 +00:00
lpsolit%gmail.com
b4d7cca746 Bug 301508: Remove CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@177475 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-10 01:30:41 +00:00
lpsolit%gmail.com
b48f197026 Bug 292059: No locking in createaccount.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@176698 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-27 20:18:20 +00:00
lpsolit%gmail.com
a68c2a62b5 Bug 301453: Move CheckEmailSyntax out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@176363 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 21:24:19 +00:00
lpsolit%gmail.com
b4feb71d7f Bug 299572: Move MailPassword() from CGI.pl into BugMail.pm (and remove an unused variable) - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@175906 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-11 00:40:59 +00:00
lpsolit%gmail.com
6ec52f8b8e Bug 294778: Unable to create new accounts when requirelogin is on - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@173591 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-19 19:40:22 +00:00
lpsolit%gmail.com
85bfb55064 Bug 276543: createaccount.cgi should not be displayed if account creation is disabled - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@171376 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-30 09:57:29 +00:00
mkanat%kerio.com
64adf228bd Bug 284975: Any code after Throw*Error is a dead code.
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170414 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-09 00:26:39 +00:00
travis%sedsystems.ca
b63354eba2 Bug 280994 : Move ValidateNewUser out of globals.pl
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169041 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-09 06:42:43 +00:00
travis%sedsystems.ca
0abffd8846 Bug 280124 : Move InsertNewUser to Bugzilla::User
Patch by Max Kanat-Alexander <mkanat@kerio.com>   r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168579 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 21:04:12 +00:00
bugreport%peshkin.net
ba7b83aa6f Bug 241900: Allow Bugzilla::Auth to have multiple login and validation styles
patch by erik
r=joel, kiko
a=myk


git-svn-id: svn://10.0.0.236/trunk@159556 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 22:41:22 +00:00
kiko%async.com.br
319f68a68e Fix for bug 234175: Remove deprecated ConnectToDatabase() and
quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.


git-svn-id: svn://10.0.0.236/trunk@154331 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-27 03:51:44 +00:00
jocuri%softhome.net
5cc84f2b11 Patch for bug 235175: replaces ::FORM from createaccount.cgi with CGI based methods that are mod_perl compatible; r=gerv; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@153156 18797224-902f-48f8-a5cc-f745e15eee43
2004-02-24 12:25:11 +00:00
kiko%async.com.br
c8c51a1d78 Bug 226324: Move relogin.cgi code to Bugzilla::Auth::CGI. Provide a
logout() method that is proxied through Bugzilla.pm's logout(), and fix
callers to use it.  r=justdave, bbaetz, a=justdave


git-svn-id: svn://10.0.0.236/trunk@149789 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-27 01:01:00 +00:00
bbaetz%acm.org
9e1d7096ea Bug 201816 - use CGI.pm for header output
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@142113 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-05 01:15:38 +00:00
jake%bugzilla.org
c3994d7057 Bug 196433 - Bugzilla now uses /usr/bin/perl as the shebang line
r=justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140364 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-27 00:07:02 +00:00
bbaetz%acm.org
2b0b42744f Bug 180642 - Move authentication code into a module
r=gerv, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@140041 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-22 04:47:35 +00:00
bugreport%peshkin.net
a450bd78b1 Bug 86029 create permission restrictions for createaccount.cgi (prevent people from creating accounts)
r=burnus
a=justdave


git-svn-id: svn://10.0.0.236/trunk@134966 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-09 00:24:43 +00:00
gerv%gerv.net
f5ff5cdd26 Bug 163114 - Templatise all calls to DisplayError. Patch C. Patch by gerv; r=burnus.
git-svn-id: svn://10.0.0.236/trunk@130932 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-01 22:41:09 +00:00
preed%sigkill.com
bf699ca6af Bug 165221: Apostrophes not properly handled during account creation. r=joel,r2=bbaetz
git-svn-id: svn://10.0.0.236/trunk@128560 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-30 15:24:12 +00:00
bbaetz%student.usyd.edu.au
71381b40ed Bug 76923 - Don't |use diagnostics| (its really expensive at startup time)
r=joel x2


git-svn-id: svn://10.0.0.236/trunk@128080 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-26 06:17:26 +00:00
jouni%heikniemi.net
8e4855ea07 Bug 156680: "Undefined variable warning" in createaccount.cgi
2xr=bbaetz


git-svn-id: svn://10.0.0.236/trunk@125023 18797224-902f-48f8-a5cc-f745e15eee43
2002-07-11 19:25:29 +00:00
bbaetz%student.usyd.edu.au
4403bbe04e Bug 151053, ConnectToDatabase/quietly_check_login sometimes not called
early enough
r=mattyt, jouni


git-svn-id: svn://10.0.0.236/trunk@123428 18797224-902f-48f8-a5cc-f745e15eee43
2002-06-17 09:39:48 +00:00
gerv%gerv.net
bf209bace0 Bug 138588 - missed a DisplayError -> ThrowTemplateError change.
git-svn-id: svn://10.0.0.236/trunk@119696 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-24 07:28:11 +00:00
gerv%gerv.net
c8a771fb68 Bug 138588 - change to use new template structure. Patch by gerv, r=myk, afranke.
git-svn-id: svn://10.0.0.236/trunk@119695 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-24 07:24:50 +00:00
myk%mozilla.org
3553d6e173 Fix for bug 136506: work-around taint error on Perl 5.005.
Patch by Davidy Avery <daa@rm.incc.net>.
2x r=myk


git-svn-id: svn://10.0.0.236/trunk@119201 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-17 02:55:10 +00:00
justdave%syndicomm.com
45f5cf551d Remaining pieces of Bug 23067 from yesterday... no idea why the first commit didn't pick these up.
git-svn-id: svn://10.0.0.236/trunk@117881 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-01 22:52:40 +00:00
bbaetz%student.usyd.edu.au
8018723bcc Bug 100094 - use generic template handling code
r=mattyt, afranke


git-svn-id: svn://10.0.0.236/trunk@114368 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 02:27:24 +00:00