227 Commits

Author SHA1 Message Date
mrbkap%gmail.com
4c16d780b7 Bug 483847 - Remove bogo-assertion. r=Waldo a=dveditz
git-svn-id: svn://10.0.0.236/trunk@259481 18797224-902f-48f8-a5cc-f745e15eee43
2010-01-27 00:41:26 +00:00
dveditz%cruzio.com
9722e8e709 bug 440982 only get script hook if we're going to call it, to avoid possible calls back into script under JS_GC's notification. r/sr=brendan, a=dveditz
git-svn-id: svn://10.0.0.236/trunk@257586 18797224-902f-48f8-a5cc-f745e15eee43
2009-06-25 21:14:03 +00:00
crowder%fiverocks.com
afff7457f4 Bug 428128 - Removal of legacy JSLL_ routines, r=brendan, a=mtschrep
git-svn-id: svn://10.0.0.236/trunk@250797 18797224-902f-48f8-a5cc-f745e15eee43
2008-04-25 18:40:05 +00:00
igor%mir2.org
088bbf6cb0 [bug 423874] backing out as a simpler patch would do the job with less code.
git-svn-id: svn://10.0.0.236/trunk@248816 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-29 10:34:31 +00:00
igor%mir2.org
99df75fa8a bug=423874 r=brendan a1.9b5=dsicore
Allocating native functions together with JSObject


git-svn-id: svn://10.0.0.236/trunk@248353 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-21 08:19:27 +00:00
timeless%mozdev.org
4b89f5e047 Bug 421303 Crash [@ jsds_ScriptHookProc]
r=caillon a=dsicore

If we reach ~jsdService, that means our client doesn't care about us, so we can
(and should) drop all references to any callbacks (if they cared, they'd have
kept us alive!*).

I think jsdService::Off should clear all the hooks, the strange magic of not
clearing it isn't really a great idea. So for Off, we'll now clear the
ScriptHook too (consumers who use off should really drop any references they
have to our objects...). I'm still on the fence on this point, I suspect we can
actually move it from ::Off to ~jsdService (it must be cleared at some point,
otherwise if jsd_xpc's library manages to get unloaded, the function pointer
would be invalid, which would be *BAD*).

jsds_NotifyPendingDeadScripts needs to clear gDeadScripts whether or not
there's a service or hooks, so it does. Because it's a static callback and
because of the scary way GC works, I'd rather ensure (deathgrip) that jsds is
available (and consistent!) for the duration of the function call. The code
already handles the lack of a hook, so there's no reason to do magical
returns....

The real problem which mayhemer found was that jsdService::Off was returning
early (failure) because gGCStatus wasn't JSGC_END when called from ~jsdService
from JS_GC from the cyclecollector, so we make sure that ~jsdService forces
::Off to act as if it is JSGC_END (after ensuring that there are no callbacks
available).

* a pure javascript (xpcom component, not DOM hosted!) version of a jsdService
consumer means that jsdService will need to talk to the CycleCollector
eventually (this is another bug for the future).


git-svn-id: svn://10.0.0.236/trunk@247513 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-11 00:13:48 +00:00
timeless%mozdev.org
703ea994f4 Bug 421044 get jsdb to finalize runtimes correctly
git-svn-id: svn://10.0.0.236/trunk@247176 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-06 05:24:04 +00:00
timeless%mozdev.org
30ff7c7235 Bug 421052 add gc to jsdb frames
git-svn-id: svn://10.0.0.236/trunk@247175 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-06 05:11:39 +00:00
timeless%mozdev.org
e36ae32722 Bug 421044 get jsdb to finalize runtimes correctly
excluding patch to js shell


git-svn-id: svn://10.0.0.236/trunk@247174 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-06 05:10:10 +00:00
timeless%mozdev.org
64a0c318c7 Bug 420789 jsdb_HandleValToPointer fails JS_ASSERT(p->type == type);
git-svn-id: svn://10.0.0.236/trunk@247173 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-06 05:08:01 +00:00
timeless%mozdev.org
a96741e346 Bug 282660 Crash [@ jsds_NotifyPendingDeadScripts] ds->script is null
r=jst a=beltzner


git-svn-id: svn://10.0.0.236/trunk@247125 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-05 21:10:01 +00:00
timeless%mozdev.org
a0229ac8f7 Bug 394114 Interfaces missing from various QI implementations.
jsdContext
r=caillon sr=jag a=dsicore


git-svn-id: svn://10.0.0.236/trunk@246536 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-26 15:10:19 +00:00
timeless%mozdev.org
f3212eaff6 Bug 405025 ASSERT_VALID_LOCK failed
r=gijs a=dsicore


git-svn-id: svn://10.0.0.236/trunk@246534 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-26 15:07:05 +00:00
timeless%mozdev.org
34d5be5949 Bug 405025 ASSERT_VALID_LOCK failed
r=gijs a=dsicore


git-svn-id: svn://10.0.0.236/trunk@246531 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-26 15:04:13 +00:00
timeless%mozdev.org
9e5379458a Fixing spelling error
git-svn-id: svn://10.0.0.236/trunk@245868 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-17 09:02:53 +00:00
timeless%mozdev.org
074e226316 Bug 416978 jsdb crashes in js_FindProperty because it isn't using JSOPTION_COMPILE_N_GO
r=brendan a=brendan


git-svn-id: svn://10.0.0.236/trunk@245522 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-12 22:36:38 +00:00
timeless%mozdev.org
582800efc0 Bug 416293 unbalanced locking in jsd_SetExecutionHook
r=crowder a=mtschrep


git-svn-id: svn://10.0.0.236/trunk@245327 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-10 04:16:54 +00:00
timeless%mozdev.org
ca6947dd8d Bug 411249 Top crash [@ jsds_ScriptHookProc][@jsds_ScriptHookProc(JSDContext*, JSDScript*, int, void*)] on shutdown with Firebug 1.1.0b10 installed
r=gijs a=beltzner


git-svn-id: svn://10.0.0.236/trunk@244608 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-31 19:12:47 +00:00
benjamin%smedbergs.us
0a44d0e3e2 Bug 411327 - nsIXPCNativeCallContext should not inherit from nsISupports, r=mrbkap, a=schrep
git-svn-id: svn://10.0.0.236/trunk@243117 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-15 15:51:02 +00:00
timeless%mozdev.org
2620dcdacd Bug 336991 Useless null check of jsdscript in _destroyJSDScript
r=gijs sr=bz a=dsicore


git-svn-id: svn://10.0.0.236/trunk@242041 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-23 23:47:36 +00:00
timeless%mozdev.org
04fbbd6773 332241 Resurrect jsdb
r=gijskruitbosch+bugs@gmail.com


git-svn-id: svn://10.0.0.236/trunk@237892 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-19 07:40:57 +00:00
reed%reedloden.com
ba4f3036e4 Backout timeless's check-in for bug 332241 to help find Tp regression.
git-svn-id: svn://10.0.0.236/trunk@237839 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-17 00:27:38 +00:00
timeless%mozdev.org
945b1d859b 332241 Resurrect jsdb
r=gijskruitbosch+bugs@gmail.com


git-svn-id: svn://10.0.0.236/trunk@237779 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-15 18:34:22 +00:00
jwalden%mit.edu
dda6ff3c99 Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
git-svn-id: svn://10.0.0.236/trunk@229504 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-08 07:08:56 +00:00
timeless%mozdev.org
8d97fd0e4c Bug 385765 [@ jsdASObserver::Observe] You can't dereference a NULL nsCOMPtr with operator->()
r=dveditz sr=dveditz


git-svn-id: svn://10.0.0.236/trunk@229103 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-01 19:25:10 +00:00
timeless%mozdev.org
2513d1e683 Bug 365363 Return value for GetJSDValue ignored leading to death
r=silver sr=biesi


git-svn-id: svn://10.0.0.236/trunk@228365 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-20 05:56:13 +00:00
igor%mir2.org
5857116860 Bug 379165: Simplifing JS_DimpHeap while fixing BeOS build problems. r=brendan
git-svn-id: svn://10.0.0.236/trunk@225236 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-29 21:49:01 +00:00
igor%mir2.org
f92cdfb6ca Bug 378261: Replacing GC_MARK_DEBUG by DumpHeap. r=brendan
git-svn-id: svn://10.0.0.236/trunk@225006 18797224-902f-48f8-a5cc-f745e15eee43
2007-04-25 13:43:18 +00:00
benjamin%smedbergs.us
2632165c74 Bug 78081 - Don't export intermediate libraries, r=luser
This is going to break camino until those build scripts are updated.


git-svn-id: svn://10.0.0.236/trunk@220633 18797224-902f-48f8-a5cc-f745e15eee43
2007-02-21 15:13:36 +00:00
timeless%mozdev.org
291717dd61 Bug 325539 typo in mozilla/js/jsd/idl/jsdIDebuggerService.idl
r=silver


git-svn-id: svn://10.0.0.236/trunk@217915 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-07 10:50:23 +00:00
silver%warwickcompsoc.co.uk
bd35b7ad55 Bug 343511 - Don't assert more than necessary. r=rginda
git-svn-id: svn://10.0.0.236/trunk@203252 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-20 15:25:32 +00:00
silver%warwickcompsoc.co.uk
f5ff685a56 Partial backout of bug 341919 to fix bustage caused by DOM_AGNOSTIC3_BRANCH landing.
git-svn-id: svn://10.0.0.236/trunk@200855 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-26 11:11:57 +00:00
silver%warwickcompsoc.co.uk
bc82662e97 Bug 341919 - Remove widget dependency from JSD. r=rginda sr=jst
git-svn-id: svn://10.0.0.236/trunk@200854 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-26 10:36:28 +00:00
bent.mozilla%gmail.com
6e059c15fd Bug 342573 - "Fix accidental return value switch from bug 176182". r=mrbkap.
git-svn-id: svn://10.0.0.236/trunk@200751 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-23 22:29:51 +00:00
gijskruitbosch%gmail.com
713e81a1ce Bug 342074 - JSD crashes on exit when there's two clients
r+a=timeless


git-svn-id: svn://10.0.0.236/trunk@200431 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-20 15:54:58 +00:00
mrbkap%gmail.com
0b7523274b Checking in Ben Turner <bent.mozilla@gmail.com> and timeless's patch to make Gecko use the JS engine's request model to help multithreaded embedders avoid GC races and crashes. bug 176182, r=mrbkap assumed-rs=brendan
git-svn-id: svn://10.0.0.236/trunk@199768 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-12 22:39:55 +00:00
timeless%mozdev.org
14c76fd819 Bug 335315 Null pointer dereference in [@ _newJSDContext]
patch by rflint@dslr.net r=rginda sr=brendan


git-svn-id: svn://10.0.0.236/trunk@196293 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-11 13:19:45 +00:00
darin%meer.net
42edf059cf landing patch for bug 326273 "Implement nsIThreadManager" (Mac portions by Mark Mentovai) with reviews from bienvenu, bsmedberg, bzbarsky, josh, roc, and ssieb
git-svn-id: svn://10.0.0.236/trunk@196254 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-10 17:30:15 +00:00
timeless%mozdev.org
dd5c0e7dd9 Bug 331023 Cleanup of IDL files; fixing type inconsistencies
r=rginda sr=bz


git-svn-id: svn://10.0.0.236/trunk@196128 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-07 01:31:33 +00:00
mrbkap%gmail.com
465662343f More nukage of private API usage.
git-svn-id: svn://10.0.0.236/trunk@195503 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-27 01:33:45 +00:00
brendan%mozilla.org
e461ec8e10 Don't use private APIs, please.
git-svn-id: svn://10.0.0.236/trunk@195502 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-27 01:22:24 +00:00
neil%parkwaycc.co.uk
08397c8422 Followup patch to bug 207327 to move the "service" string from the name to the value of the category entry where it is interpreted to belong r=timeless sr=bz
git-svn-id: svn://10.0.0.236/trunk@191407 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-28 17:36:58 +00:00
timeless%mozdev.org
8134fe8412 Bug 327605 [@ JSD_GetContextFlags - jsdService::GetFlags]
r=rginda


git-svn-id: svn://10.0.0.236/trunk@191299 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-27 04:17:08 +00:00
timeless%mozdev.org
af51e73d0e Bug 106386 Correct misspellings in source code
r=bernd rs=brendan


git-svn-id: svn://10.0.0.236/trunk@191013 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-23 09:36:43 +00:00
timeless%mozdev.org
98c788756e Bug 266208 [@ js_PCToLineNumber] because of crash due to infinite recursion
r=rginda sr=brendan


git-svn-id: svn://10.0.0.236/trunk@189466 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-09 05:47:55 +00:00
gerv%gerv.net
42cb2feea8 Bug 236613: change to MPL/LGPL/GPL tri-license.
git-svn-id: svn://10.0.0.236/trunk@186768 18797224-902f-48f8-a5cc-f745e15eee43
2005-12-31 12:14:46 +00:00
timeless%mozdev.org
dae7b0629a Bug 106386 Correct misspellings in source code
patch by unknown@simplemachines.org r=timeless rs=brendan


git-svn-id: svn://10.0.0.236/trunk@185282 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-25 21:57:13 +00:00
timeless%mozdev.org
f9bdb44b34 Bug 106386 Correct misspellings in source code
patch by unknown@simplemachines.org r=timeless rs=brendan


git-svn-id: svn://10.0.0.236/trunk@185269 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-25 08:16:51 +00:00
timeless%mozdev.org
ae81b727c2 Visual Age properly complained about C++ comments in a C file
fixing.


git-svn-id: svn://10.0.0.236/trunk@177000 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-02 18:46:14 +00:00
timeless%mozdev.org
d324887ac8 fixing some more 64bit non macro usage instances
git-svn-id: svn://10.0.0.236/trunk@176985 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-02 16:34:45 +00:00