Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
197,140 Commits 3,986 Branches 0 Tags
Commit Graph

87 Commits

Author SHA1 Message Date
mozilla.mano%sent.com
8de3d1dc52 Bug 404446 - 'Search in Bookmarks' in the Places Organizer is broken. r=dietrich. 
git-svn-id: svn://10.0.0.236/trunk@239760 18797224-902f-48f8-a5cc-f745e15eee43
 2007-11-21 01:35:15 +00:00
mozilla.mano%sent.com
0ea7e72b56 Bug 387746 - New Left Pane for Places Organizer, along with other places back-end and front-end changes; also fixes bugs 393547, 395994, 401075, 403141. r=dietrich. 
git-svn-id: svn://10.0.0.236/trunk@239684 18797224-902f-48f8-a5cc-f745e15eee43
 2007-11-20 02:01:57 +00:00
mozilla.mano%sent.com
10ceb5e0a4 Bug 401333 - Can't expand folder tree of Edit bookmark dialog. r=sspitzer, a=mconnor. 
git-svn-id: svn://10.0.0.236/trunk@238256 18797224-902f-48f8-a5cc-f745e15eee43
 2007-10-27 21:55:53 +00:00
mozilla.mano%sent.com
d896e69c43 Bug 373944 - revert the workarounds for bug #373719, bug #373721, bug #374150 and bug #374166 caused by bug #267833. patch by seth and me, r=dietrich. a=blocking-m9. 
git-svn-id: svn://10.0.0.236/trunk@238126 18797224-902f-48f8-a5cc-f745e15eee43
 2007-10-25 02:37:05 +00:00
sspitzer%mozilla.org
d80cf82d80 fix for bug #387996: add a "Places" folder to the bookmarks menu, populated with smart folders 
fix for bug #387734:  add a "Places" folder to the bookmarks toolbar, populated with smart folders
fix for bug #385826:  pre-populated places queries
fix for bug #396807:  have "top 10 most visited sites" as a pre-populated smart folder
fix for bug #385831:  Investigate dependencies for Most Used Tags query
fix for bug #378799:  GROUP_BY_FOLDER only works in simple bookmark-folder queries

thanks to dietrich for the initial GROUP_BY_FOLDER patch.

r=dietrich,mano  a=blocking-firefox-3+


git-svn-id: svn://10.0.0.236/trunk@237575 18797224-902f-48f8-a5cc-f745e15eee43
 2007-10-11 06:42:42 +00:00
mozilla.mano%sent.com
1235618fb4 Improve places command updating performance, part 1. Bug 394695, r=dietrich, a=mconnor. 
git-svn-id: svn://10.0.0.236/trunk@236300 18797224-902f-48f8-a5cc-f745e15eee43
 2007-09-19 08:13:20 +00:00
sspitzer%mozilla.org
989b976eda fix for bug #388860: New folder button on Add Bookmark panel does nothing. 
r=mano


git-svn-id: svn://10.0.0.236/trunk@230563 18797224-902f-48f8-a5cc-f745e15eee43
 2007-07-21 08:30:07 +00:00
sspitzer%mozilla.org
a06031e4da backing out, tree is closed 
git-svn-id: svn://10.0.0.236/trunk@230349 18797224-902f-48f8-a5cc-f745e15eee43
 2007-07-20 04:22:07 +00:00
sspitzer%mozilla.org
6d2b86af98 fix for bug #388860: New folder button on Add Bookmark panel does nothing 
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@230348 18797224-902f-48f8-a5cc-f745e15eee43
 2007-07-20 04:18:44 +00:00
sspitzer%mozilla.org
8057c9e0c5 fix for bug #385990: bail out early of command updating for history queries 
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@229610 18797224-902f-48f8-a5cc-f745e15eee43
 2007-07-10 16:20:54 +00:00
sspitzer%mozilla.org
03f5f5897e fix for bug #381751: when I drop a bookmark or link in the sidebar or bookmark manager dialog, it frequently doesn't go where I expect it to go 
fix for bug #385970:  Drag and drop around folders reacts incorrectly to mouse position

fix for bug #382679:  moving items in the organizer down are off by 1

patch by=Christine Yen <cyen@mozilla.com>

r=sspitzer


git-svn-id: svn://10.0.0.236/trunk@228802 18797224-902f-48f8-a5cc-f745e15eee43
 2007-06-27 01:38:50 +00:00
mozilla.mano%sent.com
43981c671e Bug 385614 - Assert like mad when deleting Livemarks from left pane in the BM. r=dietrich. 
git-svn-id: svn://10.0.0.236/trunk@228661 18797224-902f-48f8-a5cc-f745e15eee43
 2007-06-25 00:00:17 +00:00
sspitzer%mozilla.org
d5a744e94f backing out fix for bug #373944 as it causes a performance regression, see bug #385208 
git-svn-id: svn://10.0.0.236/trunk@228407 18797224-902f-48f8-a5cc-f745e15eee43
 2007-06-20 22:46:54 +00:00
sspitzer%mozilla.org
64541928dd fix for bug #373944: revert the workarounds for bug #373719, bug #373721, bug #374150 and bug #374166 caused by bug #267833. 
Now that bug #373756, it is safe to do this.  But note, even when I revert the fix for bug #373756, I am not seeing the problems we saw after bug #267833 first landed.

r=mano


git-svn-id: svn://10.0.0.236/trunk@228371 18797224-902f-48f8-a5cc-f745e15eee43
 2007-06-20 07:43:51 +00:00
mozilla.mano%sent.com
3e2310151b Bug 384515 - ASSERT: null node when moving the root node in a places tree. r=dietrich. 
git-svn-id: svn://10.0.0.236/trunk@228155 18797224-902f-48f8-a5cc-f745e15eee43
 2007-06-16 01:55:15 +00:00
sspitzer%mozilla.org
b92b433260 fix for bug #382195: clicking the "show all bookmark folders" button is slow when we're opening to the bookmarks root. 
r=mano/dietrich


git-svn-id: svn://10.0.0.236/trunk@227258 18797224-902f-48f8-a5cc-f745e15eee43
 2007-05-30 16:08:11 +00:00
sspitzer%mozilla.org
827abb0b51 fix for bug #381750: with lots of bookmarks, opening up the bookmark manager dialog is slow 
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@227098 18797224-902f-48f8-a5cc-f745e15eee43
 2007-05-28 03:57:20 +00:00
sspitzer%mozilla.org
605dfc0ad0 fix for bug #381624: history sidebar slower the first time you open it (or on startup), then when you switch history views. 
fix for regression bug #381896:  history sidebar not sorted properly the first time you open it

r=dietrich, mano


git-svn-id: svn://10.0.0.236/trunk@227046 18797224-902f-48f8-a5cc-f745e15eee43
 2007-05-25 23:50:21 +00:00
sspitzer%mozilla.org
736bfdbfed fix for bug #368240: A link on the bottom of the history list takes long to load 
r=mano


git-svn-id: svn://10.0.0.236/trunk@226808 18797224-902f-48f8-a5cc-f745e15eee43
 2007-05-22 20:36:43 +00:00
mozilla.mano%sent.com
10057bcaef Bug 381281 - Cannot reorder bookmarks. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@226682 18797224-902f-48f8-a5cc-f745e15eee43
 2007-05-20 22:27:04 +00:00
mozilla.mano%sent.com
04bb2a6a56 Yet another attempt to fix result & result nodes leaks (see bug 381239 comment 13) 
git-svn-id: svn://10.0.0.236/trunk@226648 18797224-902f-48f8-a5cc-f745e15eee43
 2007-05-19 20:29:48 +00:00
mozilla.mano%sent.com
f0200cf856 missing semicolon 
git-svn-id: svn://10.0.0.236/trunk@226646 18797224-902f-48f8-a5cc-f745e15eee43
 2007-05-19 19:55:37 +00:00
mozilla.mano%sent.com
fad08ab67a Break cycles between the xbl views to history results (bug 381239). 
git-svn-id: svn://10.0.0.236/trunk@226645 18797224-902f-48f8-a5cc-f745e15eee43
 2007-05-19 19:54:10 +00:00
mozilla.mano%sent.com
fccfe0a9a3 Bug 381042 - Error: childFolder not defined. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@226583 18797224-902f-48f8-a5cc-f745e15eee43
 2007-05-17 20:41:01 +00:00
mozilla.mano%sent.com
b6002e9cf0 Bug 372508 part 2 - remove folderId getter. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@226408 18797224-902f-48f8-a5cc-f745e15eee43
 2007-05-14 21:56:39 +00:00
mozilla.mano%sent.com
ccc625067d Bug 376581 - ASSERT: null node when deleting last history item. patch from onemen.one@gmail.com, r=me. 
git-svn-id: svn://10.0.0.236/trunk@224913 18797224-902f-48f8-a5cc-f745e15eee43
 2007-04-23 23:38:04 +00:00
mozilla.mano%sent.com
491247ba20 Bug 371076 (and bug 371077) - Query the bookmarks root rather than the places root in bookmarks-trees; allow exposing the root node of a query in the tree view (used in the organizer left pane, and in the add-bookmark dialog). This should also allow incremental updates in the bookmarks-sidebar. r=dietrich. 
git-svn-id: svn://10.0.0.236/trunk@222509 18797224-902f-48f8-a5cc-f745e15eee43
 2007-03-28 00:28:35 +00:00
mozilla.mano%sent.com
bbf8f35d39 Bug 374986 - Inappropriate commands are enabled for 'special' folders. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@222367 18797224-902f-48f8-a5cc-f745e15eee43
 2007-03-25 21:56:52 +00:00
mozilla.mano%sent.com
34439730e5 Bug 373838 - Replace nsNavHistoryResultTreeViewer with a JS, browser-specific tree view. r=dietrich. 
git-svn-id: svn://10.0.0.236/trunk@222350 18797224-902f-48f8-a5cc-f745e15eee43
 2007-03-25 12:28:30 +00:00
mozilla.mano%sent.com
11dd5284e4 Bug 370105 - Remove ViewConfigurator and 'system-area' cruft. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@222215 18797224-902f-48f8-a5cc-f745e15eee43
 2007-03-22 23:43:56 +00:00
sspitzer%mozilla.org
c50f0ed270 backing out my previous workarounds for bug #373719 and bug #373721. 
instead, per Asaf's advice, fix this with setTimeout() so that we fix all views at once.

again, these bugs are fall out from bug #267833: Fire XBL constructors from EndUpdate(), not before.

r=mano


git-svn-id: svn://10.0.0.236/trunk@221895 18797224-902f-48f8-a5cc-f745e15eee43
 2007-03-14 20:38:12 +00:00
dietrich%mozilla.com
e110ac32dc Bug 371669 Cannot drop or paste items from the history sidebar into the bookmarks toolbar (r=mano) 
git-svn-id: svn://10.0.0.236/trunk@221019 18797224-902f-48f8-a5cc-f745e15eee43
 2007-02-27 19:35:40 +00:00
dietrich%mozilla.com
4140ac5778 Bug 360133 Bookmarks must be internally uniquely identifiable (r=mano, sspitzer) 
git-svn-id: svn://10.0.0.236/trunk@220909 18797224-902f-48f8-a5cc-f745e15eee43
 2007-02-26 00:54:36 +00:00
mozilla.mano%sent.com
12aee7ec9a Bug 370959 - places frontend code cleanup. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@220566 18797224-902f-48f8-a5cc-f745e15eee43
 2007-02-20 00:51:31 +00:00
mozilla.mano%sent.com
edd4b644d8 Bug 370097 - commands disabled state is not updated in the main window when a node is selected in the history/bookmarks sidebar. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@219986 18797224-902f-48f8-a5cc-f745e15eee43
 2007-02-12 19:15:20 +00:00
mozilla.mano%sent.com
2926e25bc8 Bug 346669 - disallow dropping items into a live-bookmark container. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@219976 18797224-902f-48f8-a5cc-f745e15eee43
 2007-02-12 12:34:35 +00:00
mozilla.mano%sent.com
397fe43d36 Bug 369407 - Make the history sidebar use the shared places context menu. As part of that: 1) Add context menu for multiple-items selection 2) Remove the Expand/Collapse menu-item. 3) Replace the 'Copy Link Location' menu-item with the generic 'Copy' menu-item, which also copies the node title. r=sspitzer, ui-r=mconnor. 
git-svn-id: svn://10.0.0.236/trunk@219915 18797224-902f-48f8-a5cc-f745e15eee43
 2007-02-09 22:17:37 +00:00
mozilla.mano%sent.com
6fc50cf4b7 Bug 362292 - [places] implement places-based-bookmarks sidebar (NPOB). patch from Dan Mills <thunder@mozilla.com>, r=me. 
git-svn-id: svn://10.0.0.236/trunk@219700 18797224-902f-48f8-a5cc-f745e15eee43
 2007-02-08 13:33:04 +00:00
mozilla.mano%sent.com
4a73f4368c Bug 366474 - rootNodeIsSelected is not reliable for the menu view. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@218090 18797224-902f-48f8-a5cc-f745e15eee43
 2007-01-09 22:48:50 +00:00
mozilla.mano%sent.com
9527d3db8f Bug 364401 - js error when you drag link from places based history sidebar panel to personal toolbar. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@217532 18797224-902f-48f8-a5cc-f745e15eee43
 2006-12-29 00:27:33 +00:00
mozilla.mano%sent.com
ff1592d55c Bug 365171 - Bug context menu delete of personal toolbar bookmark can delete history item if focused. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@217530 18797224-902f-48f8-a5cc-f745e15eee43
 2006-12-28 22:56:59 +00:00
mozilla.mano%sent.com
64e247a4c3 Bug 334451 - Places Organizer: places-list tree should not list bookmark items. This also fixes the selectBookmark dialog bustage from bug 359462. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@217440 18797224-902f-48f8-a5cc-f745e15eee43
 2006-12-27 00:36:35 +00:00
mozilla.mano%sent.com
8a87c4db26 Bug 364828 - PlacesController efficiency improvements - update places-specific commands for places-events only. r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@217410 18797224-902f-48f8-a5cc-f745e15eee43
 2006-12-24 22:56:08 +00:00
mozilla.mano%sent.com
6235546314 Bug 359462 - Redesign PlacesController interaction with places views (this makes various edit command work in the places-based history sidebar). r=sspitzer. 
git-svn-id: svn://10.0.0.236/trunk@217328 18797224-902f-48f8-a5cc-f745e15eee43
 2006-12-22 00:00:21 +00:00
beng%bengoodger.com
34fe8b6a16 329367 -cannot return to bookmarks after a search r=annie.sullivan@gmail.com and 334401 - assorted places organizer fixes including new debug panel r=brettw@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@194665 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-19 03:34:26 +00:00
beng%bengoodger.com
9776ca9ad4 332495 - grouping by site is not preserved when searching + various other search/sort fixes. r=annie.sullivan@gmail.com, brettw@gmail.com (history pieces) 
git-svn-id: svn://10.0.0.236/trunk@194357 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-13 22:51:36 +00:00
beng%bengoodger.com
360db6244c 332873 - dragging a folder within places trees fail... make sure we use the right interface to look up constants on, and that folder containers are opened before use. r=brettw@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@194027 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-10 19:26:20 +00:00
beng%bengoodger.com
142a6e54ee 331755 - Use Bookmark option for setting home page is broken. add a new home page selection dialog that uses places. r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@193467 18797224-902f-48f8-a5cc-f745e15eee43
 2006-04-04 00:13:58 +00:00
beng%bengoodger.com
916c7a5969 330263 - off by one error for places drag and drop in tree views. r=brettw. Also a comment change to nsINavHistoryService.idl to improve documentation to prevent future bugs like this. 
git-svn-id: svn://10.0.0.236/trunk@193352 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-31 22:42:10 +00:00
beng%bengoodger.com
70f81c13c5 328191, cannot delete history entries + a few other fixes r=annie.sullivan@gmail.com 
git-svn-id: svn://10.0.0.236/trunk@193145 18797224-902f-48f8-a5cc-f745e15eee43
 2006-03-28 19:59:26 +00:00