ian%hixie.ch
|
b7cb0633c4
|
We should be able to access strings with uppercase letters -- oops. Changing regexp to include 'A-Z' as well as 'a-z'. Also adding a dump statement in the failure case to help when analysing the log looking for a bug.
git-svn-id: svn://10.0.0.236/trunk@107892 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-11 15:33:59 +00:00 |
|
ian%hixie.ch
|
87506d5097
|
Missed a return statement in the setupInstall method. This was causing setup to fail every time, because the function returned a defined value.
git-svn-id: svn://10.0.0.236/trunk@107890 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-11 11:48:14 +00:00 |
|
ian%hixie.ch
|
3176c0d2a4
|
Should have been checking for a defined value, not a true value -- there is nothing to stop a failure from being '0', for instance. (The important thing is to be consistent with the SelectingServiceList code, really, and it uses defined().)
git-svn-id: svn://10.0.0.236/trunk@107889 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-11 11:47:02 +00:00 |
|
ian%hixie.ch
|
e1e5a2a6f1
|
Mute the Net::AIM warnings and add some null-checking code to the close() method.
git-svn-id: svn://10.0.0.236/trunk@107881 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-11 08:08:26 +00:00 |
|
ian%hixie.ch
|
7dc7a687d2
|
First stab at primitive AIM output support as an alternative to e-mail.
git-svn-id: svn://10.0.0.236/trunk@107872 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-11 04:18:09 +00:00 |
|
ian%hixie.ch
|
79a6f20984
|
Fix typo (PLIFF->PLIF)
git-svn-id: svn://10.0.0.236/trunk@107860 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-11 00:58:48 +00:00 |
|
ian%hixie.ch
|
52581f47aa
|
Fix the DESTROY method to actually call the close() method like it was supposed to.
git-svn-id: svn://10.0.0.236/trunk@107858 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-11 00:14:07 +00:00 |
|
ian%hixie.ch
|
3a9a356b60
|
Change the order of the settings so as to match the order in which they are requested. This causes the error message to mention the setting that the user aborted on, instead of some random later setting.
git-svn-id: svn://10.0.0.236/trunk@107852 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 22:06:54 +00:00 |
|
ian%hixie.ch
|
30f7d9e23f
|
Change createArgument so that we drop the default on the floor -- the default should only be used when explicitly requested (e.g. by the user in interactive mode), not in all cases. CommandLine.pm was in fact already assume that this was the case.
git-svn-id: svn://10.0.0.236/trunk@107851 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 22:04:34 +00:00 |
|
ian%hixie.ch
|
38d0af9333
|
Switching to batch mode involves changing the 'batch' argument, not the one being requested... ahem.
git-svn-id: svn://10.0.0.236/trunk@107849 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 21:59:13 +00:00 |
|
ian%hixie.ch
|
e7f0b0e6e4
|
Bracket shuffling to fix a warning in Perl 5.0.x.
git-svn-id: svn://10.0.0.236/trunk@107848 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 21:57:07 +00:00 |
|
ian%hixie.ch
|
d793a48053
|
Handle the case where the user hits Ctrl+D during input, and the case where the user piped a file into us and the file was too short.
git-svn-id: svn://10.0.0.236/trunk@107847 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 21:53:49 +00:00 |
|
ian%hixie.ch
|
c56420bdaf
|
Correct an error in the default handler of the namespaced XML walker: we have to shift out the first argument otherwise weird things will naturally happen.
git-svn-id: svn://10.0.0.236/trunk@107846 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 21:44:28 +00:00 |
|
ian%hixie.ch
|
7d3015eda3
|
The User object was not saving anything if its userID started off as undef (i.e., new user) and the code never changed any properties (which is normal for a new user). Changed the code to automatically assume it is dirty if it starts with an undefined userID. Changed writeProperties to use the return value from the data source to save any changes to userID, so that when it is defined (by inserting a new record, probably) then we can remember it. Finally, changed propertySet so that when userID is changed from an undefined value to a defined value, the change is propagated to the fields and the groups are marked dirty, which will force them to be written out too.
git-svn-id: svn://10.0.0.236/trunk@107843 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 21:00:37 +00:00 |
|
ian%hixie.ch
|
6c7a644159
|
Changed a comment in UserField.pm to be more accurate: it is actually safe to change the userID on the fly from an undefined value to a defined value because the code only uses it at two points: creation, if it was defined (used by the caller) and destruction (at which point it is passed to the data source to save any changes).
git-svn-id: svn://10.0.0.236/trunk@107841 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 20:53:37 +00:00 |
|
ian%hixie.ch
|
1c45721015
|
s/smtp/email/go -- have to be consistent with the rest of the code\!
git-svn-id: svn://10.0.0.236/trunk@107840 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 20:46:29 +00:00 |
|
ian%hixie.ch
|
6738fc00b6
|
Return the user ID even when the user exists, so that there is no need for callers to check the return value.
git-svn-id: svn://10.0.0.236/trunk@107839 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 20:43:44 +00:00 |
|
ian%hixie.ch
|
4b6476a5c9
|
implemented getFieldNamesByCategory() in the user data source, and used it to fill in the list of contact methods for the loginFailed output handler.
git-svn-id: svn://10.0.0.236/trunk@107830 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 10:55:33 +00:00 |
|
ian%hixie.ch
|
77fb90f83b
|
Oops, syntax error.
git-svn-id: svn://10.0.0.236/trunk@107820 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 05:21:17 +00:00 |
|
ian%hixie.ch
|
7ba9f2d1c5
|
Added another set of data to the data hash: the outputter hash. This will be useful for strings that have to embed things like the e-mail address of the application itself. Added hash methods to the Email and Stdout generic outputter modules to support this change. Renamed 'from' to 'address' in the Email outputter to make it easier to reuse the code (hehe). Also, in the same module, changed some of the comments, changed a double quote string literal to a single quote string literal, and added the word 'configure' where it was missing in one of the dump statements.
git-svn-id: svn://10.0.0.236/trunk@107818 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-10 05:00:14 +00:00 |
|
ian%hixie.ch
|
76152f2135
|
Implement some primitive error handling for sending mail.
git-svn-id: svn://10.0.0.236/trunk@107776 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 21:59:21 +00:00 |
|
ian%hixie.ch
|
8429169df5
|
Removing unnecessary spammy debug output (this code works now... honest\!)
git-svn-id: svn://10.0.0.236/trunk@107770 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 21:22:32 +00:00 |
|
ian%hixie.ch
|
3d2d5f544f
|
Decode %XX-encoded strings.
git-svn-id: svn://10.0.0.236/trunk@107769 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 21:19:59 +00:00 |
|
ian%hixie.ch
|
0b383c1d78
|
Factored out the connect/disconnect code, added settings for the host and the from address and made them be handled by a setup.configure handler, wrapped the call to Net::SMTP->new() in a warning-free block.
git-svn-id: svn://10.0.0.236/trunk@107761 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 20:21:11 +00:00 |
|
ian%hixie.ch
|
3443dd9f0e
|
Adding support for generic saving and retrieving of settings.
git-svn-id: svn://10.0.0.236/trunk@107760 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 20:13:21 +00:00 |
|
ian%hixie.ch
|
7b02c6d19e
|
Adding a comment on the use of assert()
git-svn-id: svn://10.0.0.236/trunk@107759 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 20:09:22 +00:00 |
|
ian%hixie.ch
|
de07b8d410
|
Refactored the Database::DBI code. Added support for default values in the setup code. Added support to create the database and the user (although some of this may need refactoring into separate MySQL submodules).
git-svn-id: svn://10.0.0.236/trunk@107756 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 17:23:41 +00:00 |
|
ian%hixie.ch
|
64d32bc1a9
|
Added a missing 'return' statement so that the user.fields setup routine doesn't appear to have failed when it hasn't (without a return statement, the value of the last statement is the return value).
git-svn-id: svn://10.0.0.236/trunk@107754 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 17:15:13 +00:00 |
|
ian%hixie.ch
|
ab6ec76c4d
|
Changed the DESTROY method to make sure it calls its parent.
git-svn-id: svn://10.0.0.236/trunk@107753 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 17:13:27 +00:00 |
|
ian%hixie.ch
|
18252bc48b
|
Added support for printing the default value for requests.
git-svn-id: svn://10.0.0.236/trunk@107752 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 17:12:18 +00:00 |
|
ian%hixie.ch
|
9ff7bb94ea
|
Added the ability to find the length of an array (array.length to go with array.0, array.1, etc). Added assertions to handle the case of invalid order or sort attributes on <set>. Added two new sort types ('default' and 'reverse default').
git-svn-id: svn://10.0.0.236/trunk@107751 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 17:10:22 +00:00 |
|
ian%hixie.ch
|
e819a06972
|
Added two assertions to make sure the handle is defined before using it, and added a check that the handle is defined before releasing it. Also changed the DESTROY method to call its parent.
git-svn-id: svn://10.0.0.236/trunk@107750 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 17:07:18 +00:00 |
|
ian%hixie.ch
|
ca0cb58027
|
Removing excess trailing spaces on one line, and moving a warn from level 5 ('important events') to level 8 ('frequent important events').
git-svn-id: svn://10.0.0.236/trunk@107749 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 17:03:40 +00:00 |
|
ian%hixie.ch
|
7474ccc4a0
|
Fixed DESTROY method to make sure it calls its parent.
git-svn-id: svn://10.0.0.236/trunk@107748 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 17:00:28 +00:00 |
|
ian%hixie.ch
|
ba894a2d01
|
Removing the @arguments array from a dump statement, because if any of the elements in the array are undef then a runtime warning is printed (undef elements is not always a bug).
git-svn-id: svn://10.0.0.236/trunk@107747 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 16:58:38 +00:00 |
|
ian%hixie.ch
|
ad6449583d
|
Added a level 5 dump indicating the completion of the PLIF program.
git-svn-id: svn://10.0.0.236/trunk@107746 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 16:56:49 +00:00 |
|
ian%hixie.ch
|
33359b80b5
|
Fixed DESTROY method to make sure it called it's parent.
git-svn-id: svn://10.0.0.236/trunk@107744 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 16:52:08 +00:00 |
|
ian%hixie.ch
|
7e3afcf26f
|
Change default DEBUG level from 9 to 4, which is what it should be in production releases. Added comments explaining debug levels 6 (reserved for personal use) and 8. Added level 10 debug info to the DESTROY method (makes it easier to track down bugs during shutdown).
git-svn-id: svn://10.0.0.236/trunk@107743 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 16:50:47 +00:00 |
|
ian%hixie.ch
|
1da5e9e25e
|
Made it so the setupEnding event is sent out after the setup failure message is printed but before the setup success message is printed (reduces the number of error messages if you cancel during setup). Changed the semantics of the output.progress string's data.component data. It is now a dotted hierarchical string giving progressively more detail about what is being set up. e.g., 'database', 'database.default.settings', 'database.default.settings.connection.port'. If outputters are interpreting data.component then any trailing unknown levels of detail should be ignored. This allows the setup routines to potentially give much more useful output. Fixed the default stdout output string for setup (it has <text variable=""> instead of value="").
git-svn-id: svn://10.0.0.236/trunk@107740 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-09 16:39:29 +00:00 |
|
ian%hixie.ch
|
0e1edf614f
|
Also send default values to output.
git-svn-id: svn://10.0.0.236/trunk@107679 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-08 17:27:07 +00:00 |
|
ian%hixie.ch
|
738e081f7c
|
Implement default values for arguments. getArgument() and createArgument() now take two parameters like setArgument(). Changed the CommandLine module's createArgument() method so that if the user hits enter at the prompt, the default value is used. Added some comments to clarify what is going on with the 'batch' argument. Changed setArgument() and createArgument() in the Arguments module and createArgument() in the CommandLine module to be more efficient (less array copying).
git-svn-id: svn://10.0.0.236/trunk@107678 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-08 17:09:11 +00:00 |
|
ian%hixie.ch
|
5741b48cad
|
Adding comments to clearly indicate that no dump()s, warn()s or error()s should have a level lower than 5 unless they are not expected to occur during normal operation. Also changing the default level at which the user is notified of problems from 3 to 1.
git-svn-id: svn://10.0.0.236/trunk@107676 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-08 16:47:25 +00:00 |
|
ian%hixie.ch
|
822aa05814
|
Added two new hooks into the setup code: a start notification and an end notification. Added the ability to disable the string datasource (causes it to only use the default strings and not the database). Made the string datasource automatically disable itself during configuration, using the two hooks added to the setup code. This removes the warning messages that are output during a clean setup ('could not get string from database', etc).
git-svn-id: svn://10.0.0.236/trunk@107675 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-08 16:42:42 +00:00 |
|
ian%hixie.ch
|
9cc94f02cd
|
Improved error handling for the case where the database configuration doesn't exist and therefore every output attempt raises database errors. Fatal database errors are now fatal, missing database configurations is not. This would be a lot cleaner if Perl exceptions were objects... Also improved some of the error messages.
git-svn-id: svn://10.0.0.236/trunk@107673 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-08 16:10:21 +00:00 |
|
ian%hixie.ch
|
f74c5a2421
|
Added a little more level 9 verbose debugging feedback to help track down where output is going wrong.
git-svn-id: svn://10.0.0.236/trunk@107651 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-08 05:07:42 +00:00 |
|
ian%hixie.ch
|
97db51b03d
|
Stop complaining about the configuration file missing -- if it is not there then just assume there is nothing to worry about. This makes the output of the initial run with the 'setup' argument a lot quieter.
git-svn-id: svn://10.0.0.236/trunk@107649 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-08 05:06:27 +00:00 |
|
ian%hixie.ch
|
04036664cd
|
Make the STDOUT generic outputter flush everything it outputs -- this fixes a bug whereby sometimes prompts wouldn't appear until after the user had replied to them.
git-svn-id: svn://10.0.0.236/trunk@107648 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-08 05:03:57 +00:00 |
|
ian%hixie.ch
|
78c02b74a7
|
Disambiguate the names of the two methods 'hash' and 'sort'. They are now called 'genericHash' and 'genericSort' so as not to clash with the perl builtins 'CORE::hash' and 'CORE::sort'.
git-svn-id: svn://10.0.0.236/trunk@107539 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-11-07 02:49:21 +00:00 |
|
ian%hixie.ch
|
cbf27479f2
|
Correcting minor typo (extraneous ')'s).
git-svn-id: svn://10.0.0.236/trunk@104586 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-10-04 16:09:32 +00:00 |
|
ian%hixie.ch
|
a6aab56db7
|
The first ContactMethod, namely Email.
git-svn-id: svn://10.0.0.236/trunk@103212 18797224-902f-48f8-a5cc-f745e15eee43
|
2001-09-19 18:56:05 +00:00 |
|