246 Commits

Author SHA1 Message Date
jst%mozilla.org
5b7b60a4c8 Fixing bug 504862. Sanitize modal dialog argument handling. r=mrbkap@gmail.com, sr=bzbarsky@mit.edu, a=dveditz@mozilla.com
git-svn-id: svn://10.0.0.236/trunk@259409 18797224-902f-48f8-a5cc-f745e15eee43
2010-01-15 21:50:54 +00:00
jst%mozilla.org
20898c178d Backing the fix for bug 504862 due to the memory leaks it introduced.
git-svn-id: svn://10.0.0.236/trunk@259141 18797224-902f-48f8-a5cc-f745e15eee43
2009-12-01 23:17:05 +00:00
jst%mozilla.org
370e4495ec Fixing bug 504862. Sanitize modal dialog argument handling. r=mrbkap@gmail.com, sr=bzbarsky@mit.edu, a=dveditz@mozilla.com
git-svn-id: svn://10.0.0.236/trunk@258988 18797224-902f-48f8-a5cc-f745e15eee43
2009-11-13 23:40:57 +00:00
gavin%gavinsharp.com
745560d735 Bug 393707: Landing 389634 broke building without XUL, patch by romaxa <romaxa@gmail.com>, r=smaug, a=beltzner
git-svn-id: svn://10.0.0.236/trunk@250172 18797224-902f-48f8-a5cc-f745e15eee43
2008-04-14 00:53:21 +00:00
jst%mozilla.org
0cf313d564 Fixing bug 414291. Make window.open() ignore modal=yes for backwards compatibility. r+sr=bzbarsky@mit.edu and jonas@sicking.cc
git-svn-id: svn://10.0.0.236/trunk@247869 18797224-902f-48f8-a5cc-f745e15eee43
2008-03-14 21:31:38 +00:00
reed%reedloden.com
ef160fa4e6 Bug 417710 - "Use JS_GET_CLASS, not JS_GetClass" [p=gyuyoung.kim@samsung.com (gyu-young kim) r=jorendorff r=jst sr+a1.9=brendan]
git-svn-id: svn://10.0.0.236/trunk@246437 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-25 08:59:21 +00:00
bzbarsky%mit.edu
2a8ab96873 Stop treating _new as a special window target. No other browser does. Bug
417067, r+sr=jst, a=beltzner


git-svn-id: svn://10.0.0.236/trunk@245671 18797224-902f-48f8-a5cc-f745e15eee43
2008-02-14 05:05:27 +00:00
dolske%mozilla.com
7aaabf137d Bug 244273 - improve current HTTP authentication prompt. r=neil,bsmedberg ui-r=johnath, a=blocking-1.9+, a-latel10n=damons
git-svn-id: svn://10.0.0.236/trunk@244366 18797224-902f-48f8-a5cc-f745e15eee43
2008-01-29 19:33:26 +00:00
stuart.morgan%alumni.case.edu
f0ec01bdaa Follow up to bug 404290, make sure embedding clients don't crash (bug 406108). r+sr=bzbarsky a1.9=blocking1.9
git-svn-id: svn://10.0.0.236/trunk@240369 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-04 00:31:21 +00:00
dolske%mozilla.com
177f0c17ce Bug 403115 - Option missing to save password for HTTP auth. r=benjamin, sr=cbiesinger, blocking1.9=mconnor
git-svn-id: svn://10.0.0.236/trunk@240351 18797224-902f-48f8-a5cc-f745e15eee43
2007-12-03 21:47:45 +00:00
db48x%yahoo.com
a4c11af5e3 Bug 404290 ÃÂ the size of popup windows needs to be specified in css pixels, not device pixels. r=eli,roc sr=bsmedberg
git-svn-id: svn://10.0.0.236/trunk@239977 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-27 13:30:09 +00:00
jst%mozilla.org
c9e2f0e72a Fixing bug 402866. Don't make modal dialogs resizable just because pref dom.disable_window_open_feature.resizable is set to true. r+sr=bzbarsky@mit.edu
git-svn-id: svn://10.0.0.236/trunk@239500 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-15 23:07:13 +00:00
reed%reedloden.com
4995c916bf Bug 402839 - "Modal dialogs should use Linux's native icons" (part A) [p=ventnor.bugzilla@yahoo.com.au (Michael Ventnor) r+sr=biesi a1.9=schrep]
git-svn-id: svn://10.0.0.236/trunk@239426 18797224-902f-48f8-a5cc-f745e15eee43
2007-11-15 06:50:40 +00:00
dolske%mozilla.com
ab0af491b1 Bug 382180: HTTP auth dialogs don't come up if login manager croaks. r=gavin, a=mconnor, aM9=mconnor
git-svn-id: svn://10.0.0.236/trunk@238094 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-24 21:23:51 +00:00
bugzilla%standard8.plus.com
af91f18254 Bug 397403 NS_NewAuthPrompter needs to check if the password manager prompt factory can handle password prompts. r/sr=biesi,a=sayrer
git-svn-id: svn://10.0.0.236/trunk@237703 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-13 09:27:24 +00:00
tglek%mozilla.com
71e7cc9e76 bug 398599. Fix prbool violations. r=bsmedberg a=sayrer
git-svn-id: svn://10.0.0.236/trunk@237691 18797224-902f-48f8-a5cc-f745e15eee43
2007-10-12 23:47:12 +00:00
jst%mozilla.org
43143cad1a Fixing bug 391777. Make window.close() work on a modal content dialogs. r+sr+a=jonas@sicking.cc
git-svn-id: svn://10.0.0.236/trunk@236796 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-27 21:53:26 +00:00
jst%mozilla.org
e0304426c5 Fixing bug 393900. Make windows opened with showModalDialog() obey window feature prefs. r+sr=jonas@sicking.cc, a=dsicore@mozilla.com
git-svn-id: svn://10.0.0.236/trunk@235382 18797224-902f-48f8-a5cc-f745e15eee43
2007-09-07 20:30:16 +00:00
cbiesinger%gmx.at
b936b50f73 more bustage fix
git-svn-id: svn://10.0.0.236/trunk@232941 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-23 18:09:31 +00:00
bzbarsky%mit.edu
289313ec1a Fix build bustage
git-svn-id: svn://10.0.0.236/trunk@232939 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-23 17:39:59 +00:00
cbiesinger%gmx.at
efd4e4589c 391100 move nsAutoWindowStateHelper from nsPrompt to nsPromptService
r=bz sr=jst a=bz


git-svn-id: svn://10.0.0.236/trunk@232937 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-23 17:31:39 +00:00
jst%mozilla.org
450dd656cb Fixing bug 389634. Remove dependency on XUL windows from modal content dialog opening code (window.showModalDialog()). r=bzbarksy@mit.edu, sr=jonas@sicking.cc
git-svn-id: svn://10.0.0.236/trunk@231748 18797224-902f-48f8-a5cc-f745e15eee43
2007-08-09 22:03:02 +00:00
jst%mozilla.org
43a9473fed Fixing bug 194404. Adding support for window.showModalDialog() for compatibility with IE. r+sr=jonas@sicking.cc
git-svn-id: svn://10.0.0.236/trunk@231061 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-26 17:52:53 +00:00
bzbarsky%mit.edu
c57e87303d More consistent handling of principals for loads across docshell type
boundaries.  Bug 388121, r+sr=jst


git-svn-id: svn://10.0.0.236/trunk@230161 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-18 01:47:07 +00:00
mats.palmgren%bredband.net
343a090509 Hold a strong ref on the script context while its JSContext is on the stack. b=380512 r+sr=jst
git-svn-id: svn://10.0.0.236/trunk@229600 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-10 13:53:01 +00:00
jwalden%mit.edu
dda6ff3c99 Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
git-svn-id: svn://10.0.0.236/trunk@229504 18797224-902f-48f8-a5cc-f745e15eee43
2007-07-08 07:08:56 +00:00
bzbarsky%mit.edu
2830ae21c5 Fix assertion to assert about the right thing. Bug 265780 comment 35 followup.
git-svn-id: svn://10.0.0.236/trunk@216215 18797224-902f-48f8-a5cc-f745e15eee43
2006-12-01 04:35:18 +00:00
timeless%mozdev.org
c6467de559 Bug 106386 Correct misspellings in source code
r=glennrp@gmail.com, bclary@bclary.com rs=brendan


git-svn-id: svn://10.0.0.236/trunk@214560 18797224-902f-48f8-a5cc-f745e15eee43
2006-11-01 23:02:18 +00:00
bzbarsky%mit.edu
8e05132cf4 Apply chrome flags to dialogs, even when opened by untrusted content (so alerts
are not resizable, for example).  Bug 294440, r=bsmedberg, sr=jst


git-svn-id: svn://10.0.0.236/trunk@214091 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-24 21:42:18 +00:00
cbiesinger%web.de
0b73b99b02 bug 354410 move auth prompt strings out of necko. also, use the correct
strings for prompting without a realm and for prompting only for a password.
r=darin


git-svn-id: svn://10.0.0.236/trunk@212819 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-28 20:11:33 +00:00
mattwillis%gmail.com
7f8db8993d bug 354522 - Moves rv outside the if so nsIAuthPrompt2 works properly. r=biesi,sr=dmose
git-svn-id: svn://10.0.0.236/trunk@212738 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-27 19:41:01 +00:00
cbiesinger%web.de
b9be660c26 Bug 265780 make FTP use nsIAuthPrompt2
r=darin


git-svn-id: svn://10.0.0.236/trunk@212180 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-22 21:06:57 +00:00
dbaron%dbaron.org
b3ece9b8b4 Be more careful pushing/popping contexts. b=352264 r=jst sr=bzbarsky/jst
git-svn-id: svn://10.0.0.236/trunk@209916 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-12 22:58:11 +00:00
cbiesinger%web.de
50b5a1abdb Bug 265780 part I: Implement nsIAuthPrompt2 and related interfaces per the design at
http://wiki.mozilla.org/Necko:nsIAuthPrompt2
r=darin


git-svn-id: svn://10.0.0.236/trunk@208549 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-26 21:42:54 +00:00
bzbarsky%mit.edu
0583386559 Remove special-casing of about:blank for security purposes; give about:blank
pages the principal of whoever is responsible for loading them, when possible.
Bug 332182, r=mrbkap, sr=jst


git-svn-id: svn://10.0.0.236/trunk@207471 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-15 17:31:16 +00:00
bzbarsky%mit.edu
5554d8d284 Diverting window.open into a tab doesn't stop the about:blank load before
returning the new window.  Bug 348272, r=bsmedberg, sr=jst


git-svn-id: svn://10.0.0.236/trunk@207201 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-12 02:09:23 +00:00
marria%gmail.com
59502dae7c Bug 346851 (LOAD_FLAGS_NEW_WINDOW naming doesn't make much sense) Changed variable name and updated comment. r=cbiesinger, sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@206673 18797224-902f-48f8-a5cc-f745e15eee43
2006-08-06 18:17:29 +00:00
cbiesinger%web.de
87c01b9a27 Bug 344980 make nsPrompt functions always set their out parameters/retvals
r+sr=bz


git-svn-id: svn://10.0.0.236/trunk@203292 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-20 22:16:15 +00:00
bzbarsky%mit.edu
45b187a5f4 Don't set the dependent bit on windows not being opened at chrome, even if it's
in the features.  Bug 344257, r=bsmedberg, sr=jst


git-svn-id: svn://10.0.0.236/trunk@203021 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-18 20:40:43 +00:00
mrbkap%gmail.com
adf3fc0b27 Remove extraneous newline. No bug, r+sr=jst
git-svn-id: svn://10.0.0.236/trunk@201910 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-11 22:55:09 +00:00
jst%mozilla.jstenback.com
fc1a7432cb Fixing bug 334891. Prevent window.close() from closing the window if there's a modal dialog parented at the window. r=dveditz@cruzio.com, sr=bzbarsky@mit.edu
git-svn-id: svn://10.0.0.236/trunk@201619 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-05 22:48:04 +00:00
marria%gmail.com
c8758b856c Bug 241972 (new window opened by window.open('xxx.exe') or target="_blank" isn't closed automatically when a download begins). Fix stores state on the channel indicating whether a window was opened specifically for the download. The external helper app service then closes the window if there is no refresh header and if the window was opened specifically for the download. r=cbiesinger, sr=darin
git-svn-id: svn://10.0.0.236/trunk@201538 18797224-902f-48f8-a5cc-f745e15eee43
2006-07-04 20:48:33 +00:00
mrbkap%gmail.com
ee6bb80696 Restore lost compatibility by not defining an arguments object on the window if there weren't any to begin with. Also, explode nsIArray as well as nsISupportsArray in OpenWindow. bug 342813, r+sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@201022 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-27 20:09:16 +00:00
darin%meer.net
48f7e85325 fixes bug 313101 "HTTP auth dialog is titled 'Prompt'" patch by gavin sharp and darin, r=mconnor
git-svn-id: svn://10.0.0.236/trunk@200546 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-22 00:18:43 +00:00
mrbkap%gmail.com
84778e1771 Fix this to be a real null check. No bug, r+sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@199900 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-14 22:25:12 +00:00
mrbkap%gmail.com
ff2e460cf2 Restore old behavior where an nsISupportsArray is exploded into multiple arguments whereas any other COM object simply becomes argv[0]. bug 341362, r+sr=bzbarsky
git-svn-id: svn://10.0.0.236/trunk@199899 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-14 22:18:03 +00:00
mhammond%skippinet.com.au
e96b5e495a Land DOM_AGNOSTIC3_BRANCH, bug 255942. r=a few people, sr=brendan.
git-svn-id: svn://10.0.0.236/trunk@199778 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-13 03:07:47 +00:00
mrbkap%gmail.com
0b7523274b Checking in Ben Turner <bent.mozilla@gmail.com> and timeless's patch to make Gecko use the JS engine's request model to help multithreaded embedders avoid GC races and crashes. bug 176182, r=mrbkap assumed-rs=brendan
git-svn-id: svn://10.0.0.236/trunk@199768 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-12 22:39:55 +00:00
timeless%mozdev.org
7185e837bc Bug 337917 Make consumers stop using cids from other modules
r=smontagu sr=darin


git-svn-id: svn://10.0.0.236/trunk@198973 18797224-902f-48f8-a5cc-f745e15eee43
2006-06-03 23:35:59 +00:00
darin%meer.net
42edf059cf landing patch for bug 326273 "Implement nsIThreadManager" (Mac portions by Mark Mentovai) with reviews from bienvenu, bsmedberg, bzbarsky, josh, roc, and ssieb
git-svn-id: svn://10.0.0.236/trunk@196254 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-10 17:30:15 +00:00