dbaron%dbaron.org
d9dd451d51
Don't close the same file descriptors twice. b=367817 r+sr=darin
...
git-svn-id: svn://10.0.0.236/trunk@218927 18797224-902f-48f8-a5cc-f745e15eee43
2007-01-25 23:05:22 +00:00
darin%meer.net
7e7cc46ff7
fixes bug 210564 "[nsJARInputStream::Init] leaks file descriptors" patch by sciguyryan+bugzilla@gmail.com, r=alfredkayser, sr=darin
...
git-svn-id: svn://10.0.0.236/trunk@213872 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-19 20:56:48 +00:00
gavin%gavinsharp.com
963502e25f
Bug 337561: Merge nsJARDirectoryInputStream into nsJARInputStream, patch by Alfred Kayser <alfredkayser@nl.ibm.com>, r+sr=darin
...
git-svn-id: svn://10.0.0.236/trunk@213409 18797224-902f-48f8-a5cc-f745e15eee43
2006-10-10 13:24:57 +00:00
gavin%gavinsharp.com
1c83a624fe
back out bug 337561
...
git-svn-id: svn://10.0.0.236/trunk@212248 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-24 16:23:31 +00:00
gavin%gavinsharp.com
9d1e44bc27
Bug 337561: Merge nsJARDirectoryInputStream into nsJARInputStream, patch by Alfred Kayser <alfredkayser@nl.ibm.com>, r+sr=darin
...
git-svn-id: svn://10.0.0.236/trunk@212241 18797224-902f-48f8-a5cc-f745e15eee43
2006-09-24 15:13:57 +00:00
darin%meer.net
78b4d016b3
fixes bug 214672 "Further optimization and correctness improvements of libjar: streamlining nsJarInputStream" patch by Alfred Kayser <alfredkayser@nl.ibm.com>, r=jwalden, sr=darin
...
git-svn-id: svn://10.0.0.236/trunk@195829 18797224-902f-48f8-a5cc-f745e15eee43
2006-05-02 19:33:09 +00:00
mozilla.mano%sent.com
5bc5424042
Bug 269813 - return failure when trying to open a zipreader twice. patch by Nickolay Ponomarev <asqueella@gmail.com>, r=darin, sr=bz.
...
git-svn-id: svn://10.0.0.236/trunk@194463 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-15 14:02:12 +00:00
jwalden%mit.edu
9c66ec0e1d
Bug 309296 - RFE: directory listing for jar:. r=darin, sr=bzbarsky
...
git-svn-id: svn://10.0.0.236/trunk@193219 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-29 22:10:37 +00:00
cbiesinger%web.de
fd32ae606a
bug 315188 make libjar use symlinks on BeOS too
...
patch by tqh <thesuckiestemail@yahoo.se> r=fyysik sr=darin
git-svn-id: svn://10.0.0.236/trunk@184199 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-05 23:23:01 +00:00
db48x%yahoo.com
44f2a51000
bug 296522: nsJAR.cpp uses wrong allocator
...
patch by john <johnli1995@hotmail.com>, r=darin, a=asa
git-svn-id: svn://10.0.0.236/trunk@174559 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-14 10:29:45 +00:00
dougt%meer.net
c3e3eda0f8
Add a scriptable hash function API. basically what this does is moves the hashing function out of the nsISignatureVerifier.idl and creates a new interface nsICryptoHash which is scriptable. Because of this change, we needed to fix up all of the call sites. r=darin, sr=dveditz, a=shaver
...
git-svn-id: svn://10.0.0.236/trunk@173927 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-01 16:06:53 +00:00
timeless%mozdev.org
85a0e83ff8
Bug 277741 bad copy/paste of NS_ASSERT_OWNINGTHREAD(_class)
...
r=dbradley sr=dbaron
git-svn-id: svn://10.0.0.236/trunk@167609 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-12 19:20:01 +00:00
neil%parkwaycc.co.uk
4a9d4511c7
Bug 256504 Make jar cache flushable p=ted.mielczarek@gmail.com r=darin sr=roc
...
git-svn-id: svn://10.0.0.236/trunk@165836 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-27 17:25:25 +00:00
dbaron%dbaron.org
59e7e34558
Fix issues with extraction of file permissions, especially in standalone. b=231083, 235781 r+sr=dveditz a=asa
...
git-svn-id: svn://10.0.0.236/trunk@160840 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-17 00:12:04 +00:00
ben%bengoodger.com
b97d1d64e2
246687 - Firefox gets stuck at Finishing Extension Installation dialog if a newer version of an extension with a smaller xpi is installed over the top of it. Fixes a bug in nsJAR.cpp to truncate files extracted over existing files. Patch by pike, r=dveditz@cruzio.com, sr=ben@mozilla.org
...
git-svn-id: svn://10.0.0.236/trunk@158715 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-03 09:10:13 +00:00
roc+%cs.cmu.edu
0b0fa89131
Bug 226439. Convert codebase to use AppendLiteral/AssignLiteral/LowerCaseEqualsLiteral. r+sr=darin
...
git-svn-id: svn://10.0.0.236/trunk@157992 18797224-902f-48f8-a5cc-f745e15eee43
2004-06-17 00:13:25 +00:00
gerv%gerv.net
586f796c2a
Bug 236613: change to MPL/LGPL/GPL tri-license.
...
git-svn-id: svn://10.0.0.236/trunk@155091 18797224-902f-48f8-a5cc-f745e15eee43
2004-04-18 22:01:16 +00:00
timeless%mozdev.org
2632c24097
Bug 225986 DRefTool analysis for libjar files
...
r=roc sr=roc
git-svn-id: svn://10.0.0.236/trunk@149450 18797224-902f-48f8-a5cc-f745e15eee43
2003-11-17 20:44:14 +00:00
timeless%mozdev.org
44e82de4fb
Bug 220060 Crash using nsJar w/ null mZipFile
...
r=darin sr=darin
git-svn-id: svn://10.0.0.236/trunk@147209 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-24 01:48:09 +00:00
bryner%brianryner.com
a4342aad58
Fix build on gcc 3.4 by removing extra semicolons (bug 218551). r/sr=dbaron, a=brendan.
...
git-svn-id: svn://10.0.0.236/trunk@146622 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-07 22:56:05 +00:00
mkaply%us.ibm.com
36249b362e
#201226
...
r/sr=alecf
Patch from Alfred Keyser - optimize time stuff in nsZipArchive
git-svn-id: svn://10.0.0.236/trunk@144892 18797224-902f-48f8-a5cc-f745e15eee43
2003-07-15 22:18:04 +00:00
timeless%mozdev.org
80eabd2184
Bug 210539 mFd is not initialized in nsJAR [@ PR_Close]
...
r=alecf sr=alecf
git-svn-id: svn://10.0.0.236/trunk@144126 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-25 01:13:36 +00:00
darin%netscape.com
19189351df
fixes bug 209560 "Secure JS doesn't work from https JARs" r=dougt sr=alecf
...
git-svn-id: svn://10.0.0.236/trunk@144073 18797224-902f-48f8-a5cc-f745e15eee43
2003-06-23 22:58:28 +00:00
dwitte%stanford.edu
dc7e857400
bug 100649: Length() being used where IsEmpty() is meant
...
treewide changes to convert incorrect usages of string.Length() to string.IsEmpty().
thanks to afatecha@idea.com.py (Ariel Fatecha) for the patch. r=dwitte, sr=jst.
got the ok from Asa to land into a closed tree.
git-svn-id: svn://10.0.0.236/trunk@142828 18797224-902f-48f8-a5cc-f745e15eee43
2003-05-23 21:34:47 +00:00
seawood%netscape.com
5921049139
Purge XP_PC.
...
Bug #56767 r=mkaply sr=alecf
git-svn-id: svn://10.0.0.236/trunk@140602 18797224-902f-48f8-a5cc-f745e15eee43
2003-04-02 22:45:08 +00:00
alecf%netscape.com
f5cd7d93da
fix for bug 189528 - do on-demand decompression of items in a .jar file
...
instead of allocating all the data into one big buffer, keep a small input buffer around and decompress directly into a client's read buffer..
r=dougt, sr=darin
git-svn-id: svn://10.0.0.236/trunk@139458 18797224-902f-48f8-a5cc-f745e15eee43
2003-03-14 18:59:51 +00:00
dbaron%dbaron.org
e071c7ff2a
Bug 178643: Remove uses of NS_INIT_ISUPPORTS, since it is no longer needed. r=timeless sr=jag
...
git-svn-id: svn://10.0.0.236/trunk@136017 18797224-902f-48f8-a5cc-f745e15eee43
2003-01-08 22:05:52 +00:00
dougt%netscape.com
e6df6a479e
expose the number of signed items a jar. r=mstoltz, sr=dveditz, b=179579
...
git-svn-id: svn://10.0.0.236/trunk@135265 18797224-902f-48f8-a5cc-f745e15eee43
2002-12-13 22:24:12 +00:00
dveditz%netscape.com
691db65f10
bug 164695 prevent heap overrun if jar manifest file has size -1 (corrupt/malicious archive). Also fixes unrelated potential memory leak. r=mstoltz, sr=darin, a=roc
...
git-svn-id: svn://10.0.0.236/trunk@132764 18797224-902f-48f8-a5cc-f745e15eee43
2002-10-31 06:23:52 +00:00
dougt%netscape.com
e289284076
166917. Clean up xpcom SDK includes. r=rpotts@netscape.com, sr=alecf@netscape.com, a=rjesup@wgate.com
...
git-svn-id: svn://10.0.0.236/trunk@129050 18797224-902f-48f8-a5cc-f745e15eee43
2002-09-07 17:13:19 +00:00
mstoltz%netscape.com
ddbf2cb746
Bug 145031 - initialize CurItemMF to null to avoid uninitialized variable warning on tbox.
...
patch by Aleksey Nogin, r=mstoltz, sr=dveditz.
git-svn-id: svn://10.0.0.236/trunk@126387 18797224-902f-48f8-a5cc-f745e15eee43
2002-08-06 00:51:46 +00:00
dougt%netscape.com
d6cc711878
Fixes mozilla/strings requiring unfrozen nsCRT class. patch by scc, r=dougt, sr=jag, b=136756
...
git-svn-id: svn://10.0.0.236/trunk@121534 18797224-902f-48f8-a5cc-f745e15eee43
2002-05-15 18:55:21 +00:00
darin%netscape.com
824def02af
fixes bug 129279 "nsIFile unicode/utf8/ascii task"
...
r=dougt sr=alecf
git-svn-id: svn://10.0.0.236/trunk@120092 18797224-902f-48f8-a5cc-f745e15eee43
2002-04-27 05:33:09 +00:00
bzbarsky%mit.edu
f68919f405
Relanding the Compare --> Equals conversion. a=mcafee
...
git-svn-id: svn://10.0.0.236/trunk@114163 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-10 15:49:46 +00:00
bzbarsky%mit.edu
a8d03c78ee
Testing performance impact of backout of part of patch from bug 115289.
...
See bug 123947 for details. a=mcafee
git-svn-id: svn://10.0.0.236/trunk@114147 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-09 19:00:56 +00:00
bzbarsky%mit.edu
2fd80b82c9
Convert Compare() to Equals() where possible now that we can do
...
case-insensitive Equals(). Bug 115289, r=alecf, sr=jag
git-svn-id: svn://10.0.0.236/trunk@113665 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-05 02:03:07 +00:00
jaggernaut%netscape.com
436d43f211
Bug 104158: Use NS_LITERAL_STRING instead of XXXWithConversion("..."). r=bryner, rs=alecf
...
git-svn-id: svn://10.0.0.236/trunk@110579 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-16 11:58:03 +00:00
blythe%netscape.com
3139904ead
fix linux build bustage that I caused with recent checkin
...
git-svn-id: svn://10.0.0.236/trunk@109953 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-07 02:08:57 +00:00
blythe%netscape.com
9136ac3981
Fix bug 109157, nsZipArchive::BuildFileList footprint reduction
...
R=dp, SR=dveditz,alecf
git-svn-id: svn://10.0.0.236/trunk@109928 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-07 01:16:20 +00:00
timeless%mac.com
535b6f20f2
Bugzilla Bug 107823 change nsIFile
...
to use 'Modified' instead of 'Modification'
r=akkana sr=brendan
git-svn-id: svn://10.0.0.236/trunk@108891 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-26 08:05:05 +00:00
pete%alphanumerica.com
3c4492f3e0
b=107823, r=ccarlen, sr=brendan
...
--pete
git-svn-id: svn://10.0.0.236/trunk@106886 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-01 00:11:15 +00:00
dougt%netscape.com
83b67a7071
Freeze nsIMemory interface bug 99151 r=rpotts@netscape.com, sr=brendan@netscape.com
...
git-svn-id: svn://10.0.0.236/trunk@106295 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-26 00:09:22 +00:00
jaggernaut%netscape.com
9dba49d0db
Bug 53057: Fixing up users of implicit |CharT*| conversion operators for nsCString to use |.get()| instead, rr=dbaron, rs=scc
...
git-svn-id: svn://10.0.0.236/trunk@106250 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-25 06:13:52 +00:00
dougt%netscape.com
fa2d0b7e98
99163 - removing nsObserverService.h includes. Also fixing 106090, extra methods on nsObserverService. r=shaver@mozilla.org, sr=jband@netscape.com
...
git-svn-id: svn://10.0.0.236/trunk@105973 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-22 22:01:27 +00:00
dougt%netscape.com
cf60fc042e
nsIObserver and nsIObserverService API freeze. r=rpotts@netscape.com, alecf@netscape.com. bug 99163
...
git-svn-id: svn://10.0.0.236/trunk@105800 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-19 20:52:59 +00:00
jaggernaut%netscape.com
51e0dc7a6c
Bug 100476: Convert uses of member functions ToNewUnicode, ToNewCString and ToNewUTF8String to their global versions and remove support from nsCString and nsString. r=dbaron, rs=scc
...
git-svn-id: svn://10.0.0.236/trunk@104212 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-29 08:28:41 +00:00
idk%eng.sun.com
a420243c8a
fix for 57337 [libjar does not retrieve link information]
...
r = dveditz@netscape.com
sr = brendan@mozilla.org
git-svn-id: svn://10.0.0.236/trunk@103378 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-20 23:33:23 +00:00
gerv%gerv.net
ae1d5501a1
Oops.
...
git-svn-id: svn://10.0.0.236/trunk@103236 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-20 00:02:59 +00:00
scc%mozilla.org
52c8d09e03
bug #98089 : ripped new license
...
git-svn-id: svn://10.0.0.236/trunk@103219 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-19 20:09:47 +00:00
brendan%mozilla.org
6abf5e7f73
Bit checkin for bug 68045, r/sr=waterson&shaver, second attempt. It all works
...
for me on optimized and debug gcc2.96, rh7.1.
- Better failure codes from nsXULPrototypeScript::Deserialize.
- Call nsXULDocument::AbortFastLoads after nsXULPrototypeScript::Serialize
failure, instead of just nulling the FastLoad service's output stream.
- Expose nsXULDocument::AbortFastLoads via nsIXULPrototypeCache, for use from
nsChromeProtocolHandler.cpp. AbortFastLoads flushes the XUL cache now, for
good measure.
- The needless "Current" adjective in nsIFastLoadService attribute and method
names is no more.
- Add a do_GetFastLoadService() helper, to use CID instead of contractid, and
to let the compiler consolidate the static inline CID.
- Add "nglayout.debug.checksum_xul_fastload_file" pref so people can do without
the checksum verification step when reading a FastLoad file.
- Verify the FastLoad file checksum, by default. Also, cache it in the FastLoad
service so we don't recompute it when re-opening the FastLoad file as mailnews
and other top-levels start up. Fill the checksum cache in EndFastLoad, when
the last pseudo-concurrent top-level finishes loading.
My hope to compute the checksum while writing the FastLoad file ran afoul of
misordered writes. The old code to checksum the in-memory nsFastLoadHeader
also was broken on little endian platforms. Now all checksumming is done via
a separate read pass over the complete file, save for the header's checksum
field, which is summed as if it contained zero.
- Track and check FastLoad file dependencies. This required groveling with a
bunch of Necko interfaces in nsChromeProtocolHandler::NewChannel -- read it
and weep. Dependency checking, as well as checksum access and computation,
use better-factored nsIFastLoad{File,Read,Write}Control interfaces.
- nsBufferedStream::Seek wasn't flushing the buffer when seeking backward
within the buffer, but it must, because mCursor bounds the amount to write
if the buffer contains the end of file.
- Add an unbufferedStream readonly attribute to nsIStreamBufferAccess, so we
don't have to screw around with the bufferying layer when checksumming. Also
implement nsIStreamBufferAccess in nsBufferedOutputStream.
- nsISeekableOutputStream was bogus, based on a bad state I had put the
nsBufferedOutputStream code in on its way from being completely broken when
you seek backwards outside of the buffer. Removing this interface required
using nsIFastLoadFileIO in nsFastLoadFileWriter, and it also required careful
ordering of Close calls (the Reader must close after the Writer or Updater,
so that the Reader's underlying, unbuffered input stream can be read by
nsFastLoadFileWriter::Close to compute the checksum.
- Miscellaneous tab/indentation, comment typo, bracing, if( => if ( style,
nsnull vs. 0, useless variable elimination, tortured control flow,
AutoString instead of String, and gratuitous ; after nsISupportsUtils.h
macro call cleanups.
git-svn-id: svn://10.0.0.236/trunk@101544 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-21 20:51:34 +00:00