15 Commits

Author SHA1 Message Date
bzbarsky%mit.edu
dd845f0702 Make ReplaceObjectAt a little safer. Bug 227780, r=timeless, sr=alecf
git-svn-id: svn://10.0.0.236/trunk@183978 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:05:18 +00:00
dbaron%dbaron.org
094062e71f nsCOMArray should not use nsDerivedSafe. b=221525 r=bryner
git-svn-id: svn://10.0.0.236/trunk@183973 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:05:13 +00:00
neil%parkwaycc.co.uk
e1e7049150 Bug 198685 need nsCOMArray function like IndexOf that checks COM object identity p=bsmedberg@covad.net r=alecf (no sr needed)
git-svn-id: svn://10.0.0.236/trunk@183969 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:05:09 +00:00
bzbarsky%mit.edu
5a26f692af fix build bustage
git-svn-id: svn://10.0.0.236/trunk@183968 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:05:08 +00:00
alecf%netscape.com
bc56abe6d2 fix an assertion from nsCOMArray where ReplaceElementAt() wouldn't property extend the array because we were just using ObjectAt()
residual stuff from bug 197827, which caused an assertion browsing frame
patch by keeda@hotpop.com, r/sr=alecf


git-svn-id: svn://10.0.0.236/trunk@183949 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:49 +00:00
sicking%bigfoot.com
c55dec444f Bug 162115: Make nsCOMArray return nsDeriviedSafes to avoid bad addrefs/releases
r=bz sr=alecf


git-svn-id: svn://10.0.0.236/trunk@183948 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:48 +00:00
bzbarsky%mit.edu
e20ae20465 Make the nsCOMArray destructor release all the objects. Bug 178813,
r=bbaetz, sr=rpotts


git-svn-id: svn://10.0.0.236/trunk@183947 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:47 +00:00
bzbarsky%mit.edu
84f58842a9 nsCOMArray_base copy constructor should not assert. Bug 178534,
r=dougt, sr=alecf


git-svn-id: svn://10.0.0.236/trunk@183946 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:46 +00:00
bzbarsky%mit.edu
47d0458544 Add AppendObjects/InsertObjectsAt to nsCOMArray. Bug 175137,
r=timeless, sr=alecf, a=dbaron


git-svn-id: svn://10.0.0.236/trunk@183944 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:44 +00:00
varga%netscape.com
cbf2794035 Fix for bug 174443. nsCOMArray::ApendObject() shouldn't addref
r=dougt, sr=alecf, a=asa


git-svn-id: svn://10.0.0.236/trunk@183942 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:42 +00:00
mkaply%us.ibm.com
44fb2c6287 OS/2 bustage - need PR_CALLBACK
git-svn-id: svn://10.0.0.236/trunk@183941 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:41 +00:00
alecf%netscape.com
5b0d7a95bf - fix ReplaceObjectAt to properly account for existing null entries
- make nsCOMArray_base accessible from nsCOMArray<T> so that a nsCOMArray<T> can passed to NS_NewArray
for bug 162115, not part of build


git-svn-id: svn://10.0.0.236/trunk@183937 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:37 +00:00
alecf%netscape.com
f3ecff623a not part of build, more for bug 162115:
- fix some spelling, add documentation
- add NS_NewArray(), including one that takes an existing nsCOMArray<T>
- implement copy constructor for nsCOMArray_base, so that NS_NewArray can work
not part of build


git-svn-id: svn://10.0.0.236/trunk@183936 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:36 +00:00
alecf%netscape.com
beeb7ca0be match up some reviewers comments:
- tri-license with MPL, not NPL
- be consistent with policy on null in the array (it is allowed)
- move Clear() into implementation file, and hide static callback there too
- make sure to AddRef() on the way out of nsArray::IndexOf()
- handle failure of ReplaceElementAt more gracefully
bug 162115, not part of build yet


git-svn-id: svn://10.0.0.236/trunk@183935 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:35 +00:00
alecf%netscape.com
903a2ca605 continuing work in progress on nsCOMArray<T> - take darin's suggestion and move all nsISupports-related code into a non-template base class nsCOMArray_base. This allows the generated template to be paper thin (or really, non-existent!)
Then, we move some of the non-trivial methods of this class into a .cpp file


git-svn-id: svn://10.0.0.236/trunk@183934 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-02 16:04:34 +00:00