346 Commits

Author SHA1 Message Date
timeless%mac.com
7b921259da Bugzilla Bug 110080 change !NS_SUCCEEDED(status) to NS_FAILED(status)
s/!NS_SUCCEEDED/NS_FAILED/g;s/!NS_FAILED/NS_SUCCEEDED/g;
r=dougt sr=hewitt


git-svn-id: svn://10.0.0.236/trunk@108471 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-19 06:45:00 +00:00
bzbarsky%mit.edu
068756d821 Use NS_LITERAL_STRING instead of NS_ConvertASCIItoUCS2 where possible
(i.e. where the string is a literal).  Bug 104159, r=jag, sr=alecf


git-svn-id: svn://10.0.0.236/trunk@107987 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-14 01:33:42 +00:00
brade%netscape.com
74f5fa0887 nsIFile->nsIURI in nsIDiskDocument; fix SaveDocument api (bug #104883)
git-svn-id: svn://10.0.0.236/trunk@106965 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-01 15:27:38 +00:00
bernd.mielke%snafu.de
67e3a6751d bug 103443 - remove the return rv?rv: NS_ERROR_FAILURE pattern from the editor files.
the editor/base remain untouched r=cmanske sr=kin


git-svn-id: svn://10.0.0.236/trunk@105623 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-17 14:33:50 +00:00
dbaron%fas.harvard.edu
1382ac90eb Making debugging code be |#ifdef DEBUG|. b=91036 r=harishd sr=jst
git-svn-id: svn://10.0.0.236/trunk@105468 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-16 05:31:36 +00:00
cmanske%netscape.com
221efe8850 Fix memory leak (not using nsCOMPtr) in editor, b=103317, r=rcassin, sr=kin
git-svn-id: svn://10.0.0.236/trunk@105089 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-10 21:29:46 +00:00
gerv%gerv.net
3821428085 License changes, take 2. Bug 98089. mozilla/editor/.
git-svn-id: svn://10.0.0.236/trunk@103757 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-25 22:53:13 +00:00
gerv%gerv.net
ae1d5501a1 Oops.
git-svn-id: svn://10.0.0.236/trunk@103236 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-20 00:02:59 +00:00
scc%mozilla.org
52c8d09e03 bug #98089: ripped new license
git-svn-id: svn://10.0.0.236/trunk@103219 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-19 20:09:47 +00:00
kin%netscape.com
08f0c16feb Fix for bug 98018: Impossible to delete text in textbox
nsEditor::CreateTxnForDeleteInsertionPoint() shouldn't
use count-1 when calculating isLast, in the non-text case.

r=jfrancis@netscape.com  sr=sfraser@netscape.com


git-svn-id: svn://10.0.0.236/trunk@102646 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-10 14:46:57 +00:00
cls%seawood.org
3736408869 Declare nsCOMPtrs outside of do-while loops to avoid gcc 2.x -O2 optimization bug.
Bug #96911 r=jfrancis sr=kin a=blizzard


git-svn-id: svn://10.0.0.236/trunk@102146 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-01 17:24:08 +00:00
kin%netscape.com
6f9f127fbd Fix for bug 83607: too much backspace segfaults mozilla in textbox forms
Prevent GetPriorNode() and GetNextNode() from traversing above root
node when aCurrentNode is the rootNode.

r=brade@netscape.com  sr=sfraser@netscape.com  a=asa@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@101968 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-29 21:33:52 +00:00
kin%netscape.com
e07ae6bcd6 Fix for bug #96604: Deleting characters from some form input controls will allow altering page content
mozilla/editor/base/nsEditor.cpp
  mozilla/editor/base/nsEditor.h

    - Added IsRootNode() method.
    - Added calls to IsRootNode() in GetPriorNode() and GetNextNode()
      to prevent traversing above the root node.

r=jfrancis@netscape.com  sr=sfraser@netscape.com  a=asa@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@101900 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-28 18:21:12 +00:00
jfrancis%netscape.com
dc74067145 fixes:
bug 83918 - Not able to start a list (number or bullets) when using Bold style
bug 62347 - Selecting "Body Text" doesn't change style if in <pre> text that has <br>
bug 86476 - ubercaret appears on multi-line text block
bug 87882 - pasting text from one bullet to another yields extra bullet
---------------
r=sfraser; sr=kin


git-svn-id: svn://10.0.0.236/trunk@101631 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-22 05:32:44 +00:00
jaggernaut%netscape.com
2b3b3b2586 Bug 86734: Remove NS_WITH_SERVICE. r=dbaron, rs=scc, a=asa
git-svn-id: svn://10.0.0.236/trunk@99906 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-25 07:54:28 +00:00
dbaron%fas.harvard.edu
9359000a40 Header include dependency cleanup. b=64023 r=jag rs=brendan
git-svn-id: svn://10.0.0.236/trunk@99299 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-16 02:40:48 +00:00
jfrancis%netscape.com
078688a194 fix for 46209: I overhauled nsEditor::IsEditable() to better grok the state of content for editability. r=kin; sr=sfraser; a=asa
git-svn-id: svn://10.0.0.236/trunk@96980 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-12 22:35:28 +00:00
jfrancis%netscape.com
be3782bde4 bug 76888: plaintext editor deletion can move/lose whitesapce. r=sfraser; sr=kin
git-svn-id: svn://10.0.0.236/trunk@93177 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-26 20:14:26 +00:00
shanjian%netscape.com
656421251c #59405 IME candidate window position is not correct in text field on New card and To field
r = sfraser sr=kin a=blizzard
Handle the difference of cursor coordinate required by different platform.
nsICaret.h
nsCaret.cpp
nsEditor.cpp
nsPlaintextEditor.cpp
nsHTMLEditor.cpp


git-svn-id: svn://10.0.0.236/trunk@92763 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-19 22:46:29 +00:00
jfrancis%netscape.com
9a35a75ae3 fixes for bugs:
75618   CR line breaks not recognized when inserting data in a plain 
76258 	IsEditable() needs to be smarter 
72968 	browser crashes when doing REDO after doing some cut/paste i 
55224 	switching from HTML Source mode to Normal causes dataloss 
71355 	style buttons do not work from 2nd cell onwards inside table 
71362 	empty tables inside (otherwise) empty list item disappears w 
74655 	40% of reply time in mailcompose spent converting linefeeds

r=fm; sr=kin


git-svn-id: svn://10.0.0.236/trunk@92547 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-17 10:15:05 +00:00
cmanske%netscape.com
faba49aa9b Fixed reset selection when inserting under <head>. Also removed compile warning in nsTableEditor.cpp, b=71883, r=jfrancis,kin sr=sfraser
git-svn-id: svn://10.0.0.236/trunk@92060 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-12 03:41:06 +00:00
shaver%mozilla.org
8a65cf3329 75152: Remove GetVersionNumber stub in favour of upcoming, less-invasive
preloader strategy. r=jag, sr=attinasi.


git-svn-id: svn://10.0.0.236/trunk@91976 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-11 14:23:13 +00:00
mjudge%netscape.com
77323a8468 66318 r= kin, sr=kin tested by ducarozz ,phil chofmann approved..changing APIS to be idl so we can use in embedding land... lots of string changes too to nsAStrings
git-svn-id: svn://10.0.0.236/trunk@91610 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-07 00:45:26 +00:00
akkana%netscape.com
02dbe54c0d 66345: Factoring necessary for editor reorganization. sr=kin/sfraser, r=jfrancis
git-svn-id: svn://10.0.0.236/trunk@91511 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-05 23:48:01 +00:00
rickg%netscape.com
75bb2ffbb9 preloader update. r=peterl, sr=attinasi
git-svn-id: svn://10.0.0.236/trunk@91193 18797224-902f-48f8-a5cc-f745e15eee43
2001-04-03 22:58:59 +00:00
anthonyd%netscape.com
9ce7243134 bug fix for 67985 - needed methods for nsEditor impl
r=jfrancis
sr=sfraser


git-svn-id: svn://10.0.0.236/trunk@89436 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-13 02:48:17 +00:00
kin%netscape.com
7365b2cbe5 Fixes for bug #66308 ([embed] XPIDL'ize transaction manager)
sr=sfraser@netscape.com,mscott@netscape.com r=jfrancis@netscape.com

* nsITransaction, nsITransactionListenter, nsITransactionManager have
  been XPIDL'ized and moved into mozilla/editor/txmgr/idl. The versions
  of these interfaces in mozilla/editor/txmgr/public are being CVS removed.

* Renamed Do(), Undo(), and Redo() to DoTransaction(), UndoTransaction(),
  and RedoTransaction() to avoid reserved word problems in languages like
  JS. I did a sweep through editor and mailnews to remove these methods.

* PeekUndoStack() and PeekRedoStack() now return an AddRef'd pointer.

* Removed GetUndoString(), GetRedoString() and Write() from the
  nsITransaction interface. Neither editor or mailnews really made
  use of these methods.

* Removed Write() from the nsITransactionManager.cpp interface.

* The Transaction Manager now supports weak references.

* Added support for nsITransactionList to the TransactionManager
  to allow access to all transactions on the Undo and Redo stacks, as
  well as auto-aggregated transactions.

* Removed all references to nsITransactionDescription from txmgr and editor.

* Added nsPIEditorTransaction and made all Editor internal transactions
  inherit from it so we can distinguish between our transactions and
  ones from 3rd parties.

New files checked in:

  editor/txmgr/idl/nsITransaction.idl
  editor/txmgr/idl/nsITransactionList.idl
  editor/txmgr/idl/nsITransactionListener.idl
  editor/txmgr/idl/nsITransactionManager.idl
  editor/txmgr/src/nsITransactionList.cpp
  editor/txmgr/src/nsITransactionList.h
  editor/idl/nsPIEditorTransaction.idl

Files that were CVS removed:

  editor/txmgr/public/nsITransaction.h
  editor/txmgr/public/nsITransactionListener.h
  editor/txmgr/public/nsITransactionManager.h
  editor/txmgr/idl/nsITransactionDescription.h
  editor/base/IMECommitTxn.cpp
  editor/base/IMECommitTxn.h

Files modified:

  editor/Makefile.in
  editor/makefile.win
  editor/base/ChangeAttributeTxn.cpp
  editor/base/ChangeAttributeTxn.h
  editor/base/CreateElementTxn.cpp
  editor/base/CreateElementTxn.h
  editor/base/DeleteElementTxn.cpp
  editor/base/DeleteElementTxn.h
  editor/base/DeleteRangeTxn.cpp
  editor/base/DeleteRangeTxn.h
  editor/base/DeleteTextTxn.cpp
  editor/base/DeleteTextTxn.h
  editor/base/EditAggregateTxn.cpp
  editor/base/EditAggregateTxn.h
  editor/base/EditTxn.cpp
  editor/base/EditTxn.h
  editor/base/IMECommitTxn.cpp
  editor/base/IMECommitTxn.h
  editor/base/IMETextTxn.cpp
  editor/base/IMETextTxn.h
  editor/base/InsertElementTxn.cpp
  editor/base/InsertElementTxn.h
  editor/base/InsertTextTxn.cpp
  editor/base/InsertTextTxn.h
  editor/base/JoinElementTxn.cpp
  editor/base/JoinElementTxn.h
  editor/base/nsEditor.cpp
  editor/base/nsEditorShell.cpp
  editor/base/nsEditorShell.h
  editor/base/nsEditorTxnLog.cpp
  editor/base/nsStyleSheetTxns.cpp
  editor/base/nsStyleSheetTxns.h
  editor/base/PlaceholderTxn.cpp
  editor/base/PlaceholderTxn.h
  editor/base/SetDocTitleTxn.cpp
  editor/base/SetDocTitleTxn.h
  editor/base/SplitElementTxn.cpp
  editor/base/SplitElementTxn.h
  editor/idl/Makefile.in
  editor/idl/makefile.win
  editor/idl/MANIFEST
  editor/idl/nsIEditorShell.idl
  editor/macbuild/editor.mcp
  editor/macbuild/EditorIDL.mcp
  editor/txmgr/idl/Makefile.in
  editor/txmgr/idl/makefile.win
  editor/txmgr/idl/MANIFEST
  editor/txmgr/idl/nsITransactionManager.idl
  editor/txmgr/macbuild/txmgr.mcp
  editor/txmgr/macbuild/txmgrIDL.mcp
  editor/txmgr/public/Makefile.in
  editor/txmgr/public/makefile.win
  editor/txmgr/public/MANIFEST
  editor/txmgr/src/Makefile.in
  editor/txmgr/src/makefile.win
  editor/txmgr/src/nsTransactionItem.cpp
  editor/txmgr/src/nsTransactionItem.h
  editor/txmgr/src/nsTransactionList.cpp
  editor/txmgr/src/nsTransactionList.h
  editor/txmgr/src/nsTransactionManager.cpp
  editor/txmgr/src/nsTransactionManager.h
  editor/txmgr/src/nsTransactionManagerFactory.cpp
  editor/txmgr/src/nsTransactionStack.cpp
  editor/txmgr/src/nsTransactionStack.h
  editor/txmgr/tests/TestTXMgr.cpp
  editor/ui/composer/content/EditorCommandsDebug.js
  editor/ui/composer/content/editorOverlay.xul
  editor/ui/composer/locale/en-US/editorOverlay.dtd
  mailnews/base/src/nsMessenger.cpp
  mailnews/base/util/nsMsgTxn.cpp
  mailnews/base/util/nsMsgTxn.h
  mailnews/imap/src/nsImapMailFolder.cpp
  mailnews/imap/src/nsImapUndoTxn.cpp
  mailnews/imap/src/nsImapUndoTxn.h
  mailnews/local/src/nsLocalMailFolder.cpp
  mailnews/local/src/nsLocalUndoTxn.cpp
  mailnews/local/src/nsLocalUndoTxn.h


git-svn-id: svn://10.0.0.236/trunk@89126 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-09 14:23:59 +00:00
disttsc%bart.nl
abd8de21e5 Change implicit conversion from
|NS_ConvertUTF8toUCS2|
|NS_ConvertASCIItoUCS2|
|NS_ConvertUCS2toUTF8|
|ns[C]LiteralString|
|ns[C]PromiseFlatString|

to explicit |get()|.

Add |get()| to |nsString|, remove implicit conversion operators where possible, add NS_WARNING where not (yet!).

Bug=53057, r=alecf, sr=scc


git-svn-id: svn://10.0.0.236/trunk@88947 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-08 08:05:05 +00:00
jfrancis%netscape.com
b9f86f8b98 fix for 70602: selection not properly reset when joining nodes. {r,sr}={kin,sfraser}
git-svn-id: svn://10.0.0.236/trunk@88681 18797224-902f-48f8-a5cc-f745e15eee43
2001-03-06 20:16:38 +00:00
cmanske%netscape.com
a6c3260a9b Make setting doc title undoable (add SetDocumentTitle transaction) b=60129, add export to text file, b=51798, some interface param changes to table editing methods as part of embedding work (b=66300). r=brade, sr=sfraser
git-svn-id: svn://10.0.0.236/trunk@88017 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-26 22:02:58 +00:00
brade%netscape.com
644f57503b caret method renamed to GetCaretCoordinates; r=kin; sr=sfraser
git-svn-id: svn://10.0.0.236/trunk@86233 18797224-902f-48f8-a5cc-f745e15eee43
2001-02-05 15:44:38 +00:00
jfrancis%netscape.com
7cde2dddd5 bug 66290: embedding work: refactor editor to allow smaller plaintext only library. Embedding clients may be interested inthis library if they want to embed a browser but not composer/mail-compose. Reduces library footprint for plaintext-only library by over 50% on all three platforms. r=fm; sr=kin
git-svn-id: svn://10.0.0.236/trunk@85666 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-28 20:13:07 +00:00
akkana%netscape.com
0792fa11db 64665: don't hardwire wrap width to 72. Also fix some warnings. r=jfrancis, sr=kin
git-svn-id: svn://10.0.0.236/trunk@85529 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-25 23:12:16 +00:00
sfraser%netscape.com
4e7e05789b Convert nsIDiskDocument to xpidl, and change it from using nsFileSpecs to nsIFiles. Bug 62567, r= buster, ducarroz, adamlock, sr=kin
git-svn-id: svn://10.0.0.236/trunk@84675 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-09 22:47:02 +00:00
akkana%netscape.com
13ae4ba935 33088: restructure editor output routines. r=kin,buster,adamlock sr=sfraser
git-svn-id: svn://10.0.0.236/trunk@84590 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-08 21:01:29 +00:00
valeski%netscape.com
e4aa16de1a r=kin, sr=sfraser. 47207. removal of extraneous (and noisy in embedding builds) printf.
git-svn-id: svn://10.0.0.236/trunk@84276 18797224-902f-48f8-a5cc-f745e15eee43
2001-01-02 23:20:56 +00:00
dbaron%fas.harvard.edu
fc1d2a9cd5 Convert correct usage of |nsCOMPtr<T>::operator&| to use |address_of| since the operator& will soon become private. b=59414 r=disttsc@bart.nl sr=waterson@netscape.com
git-svn-id: svn://10.0.0.236/trunk@83446 18797224-902f-48f8-a5cc-f745e15eee43
2000-12-09 04:46:08 +00:00
kin%netscape.com
02a2a9a6b6 Misc fixes for pedantic build warnings.
r=jfrancis@netscape.com a=sfraser@netscape.com


git-svn-id: svn://10.0.0.236/trunk@83078 18797224-902f-48f8-a5cc-f745e15eee43
2000-11-29 22:06:02 +00:00
warren%netscape.com
a8b9664a8c Bug 47207. Backing out logging/PRINTF changes until we can fix stopwatch.h, introduce double parens, etc.
git-svn-id: svn://10.0.0.236/trunk@81967 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-28 22:17:53 +00:00
warren%netscape.com
c6b67eceeb Bug 47207. Changing printf to PRINTF to use new logging facility. r=valeski,sr=waterson
git-svn-id: svn://10.0.0.236/trunk@81885 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-27 22:43:51 +00:00
jst%netscape.com
9870b6af65 Fixing rtm++ bug 56212. The new serializers were a bit too eager about what characters to encode as entities, this caused bad things when sending email that contained double quotes and also when writing a message containing quotes in AIM. sr=vidur, r=nisheeth.
git-svn-id: svn://10.0.0.236/trunk@81129 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-13 11:06:05 +00:00
sfraser%netscape.com
8379325c00 Fix for 52808 -- standardized nsEditorShell creation and destruction across components, to fix editor observer notification timing. r=kin,ducarroz,jelwell, sr=hyatt.
git-svn-id: svn://10.0.0.236/trunk@80787 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-10 01:45:46 +00:00
anthonyd%netscape.com
462d2a6e10 fix for bug#54222
The "noshade" attribute on Horizontal rule not set at all
sr=kin
r=mjudge
a=mjudge


git-svn-id: svn://10.0.0.236/trunk@80707 18797224-902f-48f8-a5cc-f745e15eee43
2000-10-08 06:14:21 +00:00
mjudge%netscape.com
2fc6190bef small but pervasive change to make nsIDOMSelection an xpidl interface. also broke it into 2 interfaces, nsISelection and nsISelectionPrivate. moved nsIDOMSelectionListener also to xpidl. these new idl files live in layout/base/public. r=sfraser, r=anthonyd bug 48575
git-svn-id: svn://10.0.0.236/trunk@79118 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-14 11:45:01 +00:00
rayw%netscape.com
d9228441a4 Bug 37275, Changing value of all progids, and changing everywhere a progid
is mentioned to mention a contractid, including in identifiers.

r=warren


git-svn-id: svn://10.0.0.236/trunk@79036 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-13 23:57:52 +00:00
heikki%netscape.com
648ff744fc Forgot to check that we fire the select event with Select All. Also fix event.target. Part of bug 46085. r=mjudge.
git-svn-id: svn://10.0.0.236/trunk@78900 18797224-902f-48f8-a5cc-f745e15eee43
2000-09-12 20:54:41 +00:00
jfrancis%netscape.com
84db5fa624 fixes bugs 46782,50161,48643,49266,49265,46395;
groundwork for bugs 47931,49952;
r=fm


git-svn-id: svn://10.0.0.236/trunk@77257 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-26 04:03:50 +00:00
anthonyd%netscape.com
f4c17f81ff fix for bug 48624 (hidden selection issues with plain text widgets)
fix for bug 45662 (updating range impl to dom spec)
fix for some edge case selection issues invloving multiple windows, no bug #
but saari knows about this.
r: sfraser, jfrancis, mjudge, saari
a: beppe


git-svn-id: svn://10.0.0.236/trunk@77040 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-24 03:54:30 +00:00
sfraser%netscape.com
53a5ee47bc Fixes for 48474 (JS errors typing in plain text compose), 44684 (make align buttons reflect state), 49155 (UMR in editor code). r=anthonyd
git-svn-id: svn://10.0.0.236/trunk@77021 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-24 01:20:29 +00:00
jst%netscape.com
7e0575bfee DOM string changes. All nsString& in DOM interfaces (and interfaces needed by DOM implementations) have been changed to nsAReadableString& and nsAWritableString&. String implementation additions (sanctioned by scc) to support DOM needs. Bug 49091. r=vidur,jst,scc
git-svn-id: svn://10.0.0.236/trunk@76967 18797224-902f-48f8-a5cc-f745e15eee43
2000-08-23 17:27:06 +00:00