106 Commits

Author SHA1 Message Date
jocuri%softhome.net
e4d428bc7e Patch for bug 287325: we should use scalar instead of length for finding out how many elements an array has; patch by me, r=justdave on IRC, fixing tree.
git-svn-id: svn://10.0.0.236/trunk@190676 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-21 14:36:42 +00:00
lpsolit%gmail.com
9c04670d27 Bug 287325: Ability to add custom plain-text fields to a Bug - Patch by Myk Melez <myk@mozilla.org> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@190671 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-21 13:08:24 +00:00
lpsolit%gmail.com
2ca8ffbe4d Bug 316096: 'everconfirmed' is not included in the DTD and XML files - Patch by Greg Hendricks <ghendricks@novell.com> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@187272 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-10 23:30:34 +00:00
myk%mozilla.org
3a06652264 Backing out fix for bug 287325 (initial implementation of custom fields): turns out the tree is not yet open for 2.24 checkins after all. I'll check this back in once the tree opens for 2.24 checkins, which lpsolit says will be in about a month.
git-svn-id: svn://10.0.0.236/trunk@187069 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-06 14:38:43 +00:00
myk%mozilla.org
f724729f95 Bug 287325: an initial implementation of custom fields, including the ability to add text custom fields via the command-line script customfield.pl, search them via the boolean charts, display and edit them on the show bug page, and see changes to them in bug activity; r=mkanat, glob
git-svn-id: svn://10.0.0.236/trunk@187068 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-06 14:23:05 +00:00
bugreport%peshkin.net
95847b0526 Bug 315332 fix several bugs in process_bug.cgi when 'strict_isolation' is on
Patch by Joel Peshkin <bugreport@peshkin.net>
r=lpsolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@184997 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-19 23:47:26 +00:00
lpsolit%gmail.com
228e7d12be Bug 314547: [PostgreSQL] cannot check/uncheck the "Private" checkbox for comments in show_bug.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@184548 18797224-902f-48f8-a5cc-f745e15eee43
2005-11-13 18:16:33 +00:00
mkanat%kerio.com
90039a6142 Bug 313209: Oracle requires "CASE WHEN" around boolean expressions in the SELECT column list
Patch By Lance Larsh <lance.larsh@oracle.com> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@182906 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-24 19:21:05 +00:00
bugreport%peshkin.net
1d06485337 Bug 309681 Prevent users from adding another user who shouldn't have access to a bug as assignee or CC member
Patch by Gabriel Sales de Oliveira <gabriel@async.com.br>
r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@182410 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-17 21:19:09 +00:00
lpsolit%gmail.com
d25babd128 Bug 306325: Move CanEnterProduct() and CanEnterProductOrWarn() out of globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@182051 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-12 02:08:57 +00:00
mkanat%kerio.com
39f4923058 Bug 309680: Use SQL "JOIN ... ON ..." syntax instead of "JOIN ... USING(...)"
Patch By Lance Larsh <lance.larsh@oracle.com> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@181717 18797224-902f-48f8-a5cc-f745e15eee43
2005-10-06 18:43:44 +00:00
lpsolit%gmail.com
1b4ec7368e Bug 256135: Parameter 'movers' is handled differently in Bug.pm and buglist.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=myk
git-svn-id: svn://10.0.0.236/trunk@179872 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-08 23:40:10 +00:00
lpsolit%gmail.com
56985e1098 Bug 304745: Move GetFieldID() out of globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@179668 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-05 20:41:21 +00:00
myk%mozilla.org
ff7b44d6d9 Partial fix for bug 302669: rewrites Attachment.pm to provide a real Attachment class; r=lpsolit
git-svn-id: svn://10.0.0.236/trunk@179468 18797224-902f-48f8-a5cc-f745e15eee43
2005-09-01 14:02:30 +00:00
lpsolit%gmail.com
8b488047d1 Bug 303366: Possible locking tables conflict when voting for bugs - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@178680 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-23 12:17:17 +00:00
bugreport%peshkin.net
205c3f3402 Bug 304583: Remove all remaining need to rederive inherited groups
Patch by Joel Peshkin <bugreport@peshkin.net>
r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@178200 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-18 20:09:37 +00:00
lpsolit%gmail.com
62245bccd9 Bug 304660: PerformSubsts() should be in Util.pm instead of BugMail.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@177762 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-15 17:58:19 +00:00
justdave%bugzilla.org
60d2b0604a Bug 303413: Remove "use Bugzilla" from all of the pm files. All of the cgi files already have it loaded, and it causes circular dependencies.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org>
r=justdave a=justdave


git-svn-id: svn://10.0.0.236/trunk@177733 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-14 22:34:32 +00:00
lpsolit%gmail.com
34acdeea1b Bug 303914: legal_bugs_status should be spelled legal_bug_status in Bug.pm - Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@177710 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 18:46:35 +00:00
mkanat%kerio.com
0cbbdcfee7 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177695 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-13 12:27:04 +00:00
bugreport%peshkin.net
9778732be8 Backout of bug 303669 which broke AppendComment and possibly a number
of other items.


git-svn-id: svn://10.0.0.236/trunk@177419 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 11:23:43 +00:00
mkanat%kerio.com
7bbde62ad3 Bug 303669: Bugzilla mis-uses perl subroutine prototypes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@177413 18797224-902f-48f8-a5cc-f745e15eee43
2005-08-09 05:59:02 +00:00
lpsolit%gmail.com
7d9ef54063 Bug 301440: Move LogActivityEntry out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@176334 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 15:58:45 +00:00
lpsolit%gmail.com
3fc1ffb7ff Bug 285112: Move ValidateBugID out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=joel,wicked a=justdave
git-svn-id: svn://10.0.0.236/trunk@176316 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-20 11:29:33 +00:00
lpsolit%gmail.com
eeb8727424 Bug 300501: Move GetBugActivity() into Bug.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@176064 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-14 00:02:17 +00:00
lpsolit%gmail.com
bd81a6f03e Bug 240251: Bug::AppendComment() should receive the user ID as a 2nd parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@175772 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-07 18:42:09 +00:00
lpsolit%gmail.com
8dddac85e5 Bug 242318: "blocked" field is ignored in post_bug.cgi if the "dependson" field isn't present - Patch by Frédéric Buclin <LpSolit@gmail.com> r=kiko a=justdave
git-svn-id: svn://10.0.0.236/trunk@175744 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-07 14:17:18 +00:00
mkanat%kerio.com
561bb9c551 Bug 289042: Implicit joins should be replaced by explicit joins - installment B
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175517 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-02 05:23:28 +00:00
lpsolit%gmail.com
74b5dfcf2b Bug 297794: initBug's verification of user_id being an email is bogus - Patch by Tiago R. Mello <timello@async.com.br> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@174872 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 20:16:32 +00:00
mkanat%kerio.com
5c30640687 Bug 293501: Add me to files where I belong and fix kerio.com emails
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=colin, a=myk


git-svn-id: svn://10.0.0.236/trunk@174620 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-15 03:55:00 +00:00
lpsolit%gmail.com
e70ec4c9bc Bug 248386: Add support for Alias to post_bug.cgi - Patch by Albert Ting <altlst@sonic.net> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@172998 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-03 18:44:54 +00:00
lpsolit%gmail.com
d1fa0293a2 Bug 290513: Move CheckIfVotedConfirmed() out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@172461 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-19 23:43:00 +00:00
lpsolit%gmail.com
559a76b023 Bug 290511: Move RemoveVotes() out of globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@172352 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-16 17:17:06 +00:00
lpsolit%gmail.com
2b2e8cf907 Bug 199048: Preference option to reverse sort the comments stack - Patch by Shane H. W. Travis <shane.h.w.travis@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@171903 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-09 00:37:52 +00:00
lpsolit%gmail.com
9e4a52fdf0 Bug 86328: Deleting bugs doesn't delete dependent records properly - Patch by Frederic Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@171752 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-06 00:19:56 +00:00
mkanat%kerio.com
effcb842e2 Bug 287880: [SECURITY] Comments on secure bugs still available to templates... show_bug leaks
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@171385 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-30 14:30:43 +00:00
mkanat%kerio.com
2fa9c9d7cc Bug 286501: Summarize time fails with "Can't bind reference" error
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170833 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-17 06:56:16 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
mkanat%kerio.com
abc539470f Bug 285534: bugs.qa_contact should allow NULL
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170685 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 05:20:48 +00:00
travis%sedsystems.ca
5fa193cfee Bug 187658 : Group checkboxes are not sorted consistently
Patch by Shane H. W. Travis <travis@sedsystems.ca>   r=wurblzap  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170541 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-10 22:34:06 +00:00
mkanat%kerio.com
30b6f7b80f Bug 283561: Move AppendComment out of globals.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=vladd, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170509 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-10 08:20:41 +00:00
mkanat%kerio.com
298e9502a5 Bug 285541: QA Contacts No Longer Appear in show_bug
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=justdave, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170500 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-10 04:53:51 +00:00
mkanat%kerio.com
17ed4b1727 Bug 282145: Bug.pm is too slow for general use
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=gerv, a=myk


git-svn-id: svn://10.0.0.236/trunk@170412 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-08 23:57:32 +00:00
mkanat%kerio.com
d29ebec588 Bug 283919: Move BugAliasToID out of CGI.pl into Bugzilla::Bug
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170404 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-08 23:03:57 +00:00
mkanat%kerio.com
3236120a9a Bug 283924: Move ValidateComment out of CGI.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170281 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 13:55:34 +00:00
mkanat%kerio.com
7f1a179da7 Bug 277782: _throw_error should unlock tables when tables are locked, automatically
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=travis, r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170180 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 00:18:48 +00:00
travis%sedsystems.ca
54b66ed77a Bug 283567 : Toggling a comment's privacy does nothing (regression from bug 279700)
Patch by : Frederic Buclin <LpSolit@gmail.com>  r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170010 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-28 21:33:16 +00:00
mkanat%kerio.com
3d946538f6 Bug (None): Fix for checkin from Bug 280493, fix a trailing comma in Bug.pm
Thanks to glob for pointing it out.


git-svn-id: svn://10.0.0.236/trunk@169809 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-25 02:01:45 +00:00
mkanat%kerio.com
f7471cbb97 Bug 283237: Move DBname_to_id out of globals.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@169799 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:42:48 +00:00
mkanat%kerio.com
2e945fe489 Bug 280500: Replace "DATE_FORMAT()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@169798 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:37:48 +00:00