750 Commits

Author SHA1 Message Date
sspitzer%mozilla.org
93ed82e623 fix for bug #383840: problems when manually importing bookmarks exported from places based bookmark builds
fix for bug #381225:  on import, places bookmarks builds attempt to merge in bookmarks.html, where firefox 2 appends bookmarks

fix for bug #380449:  potential data loss on export of LAST_MODIFIED, DATE_ADDED and ICON_URI attributes

r=dietrich


git-svn-id: svn://10.0.0.236/trunk@228736 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-26 02:38:34 +00:00
mozilla.mano%sent.com
43981c671e Bug 385614 - Assert like mad when deleting Livemarks from left pane in the BM. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@228661 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-25 00:00:17 +00:00
sspitzer%mozilla.org
d04c4b306a fix for bug #384731: "Bookmark This Page" throws exception on close in bookmarkProperties.js if you have "bookmarkPropertiesDialog/lastUsed" annotations that point to itemIds for folder that don't exist
fix for bug #384733:  "Add Bookmark" dialog truncated if you have "bookmarkPropertiesDialog/lastUsed" annotations that point to itemIds for folder that don't exist

r=mano


git-svn-id: svn://10.0.0.236/trunk@228607 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-22 23:19:47 +00:00
sspitzer%mozilla.org
d5a744e94f backing out fix for bug #373944 as it causes a performance regression, see bug #385208
git-svn-id: svn://10.0.0.236/trunk@228407 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-20 22:46:54 +00:00
sspitzer%mozilla.org
64541928dd fix for bug #373944: revert the workarounds for bug #373719, bug #373721, bug #374150 and bug #374166 caused by bug #267833.
Now that bug #373756, it is safe to do this.  But note, even when I revert the fix for bug #373756, I am not seeing the problems we saw after bug #267833 first landed.

r=mano


git-svn-id: svn://10.0.0.236/trunk@228371 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-20 07:43:51 +00:00
mozilla.mano%sent.com
96bd073983 Fix typo.
git-svn-id: svn://10.0.0.236/trunk@228370 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-20 07:27:41 +00:00
sspitzer%mozilla.org
d9484fdbed fix for bug #380735: Persist open state of the "age in days" and "site" containers in the history sidebar
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@228362 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-20 05:19:06 +00:00
sspitzer%mozilla.org
7837e039b5 fix for bug #383572: changes made to bookmarks don't show in bookmark searches / Crash [@ nsCOMArray_base::InsertObjectAt nsNavHistoryFolderResultNode::OnItemChanged] deleting "ghost" bookmark
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@228324 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-19 16:25:11 +00:00
sspitzer%mozilla.org
303c7075de supplimental checkin for bug #383681: While BM is in a sorted view, adding a new separator is added below the position index, not the bookmark.
r=mano


git-svn-id: svn://10.0.0.236/trunk@228323 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-19 16:13:19 +00:00
sspitzer%mozilla.org
efc1e69d55 fix for bug #383681: While BM is in a sorted view, adding a new separator is added below the position index, not the bookmark.
disable the "insert separator" from a sorted view and from views that are excluding items.

patch=Christine Yen <cyen@mozilla.com>

r=sspitzer


git-svn-id: svn://10.0.0.236/trunk@228296 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-19 04:19:39 +00:00
mozilla.mano%sent.com
2a0348cc7c Bug 384936 - Folders in bookmarks menu are inaccessible after moving a bookmark to/in the menu. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@228286 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-19 02:25:41 +00:00
sspitzer%mozilla.org
9bbfbbab63 fix for bug #384671: when resetting the history sidebar view, don't use applyFilter()
this is needed for bug #380735, for when we persist day and host container
open state in the history sidebar.

additionally, call load() instead of using .place directly to avoid doing queriesToQueryString() only to call queryStringToQueries().

r=mano


git-svn-id: svn://10.0.0.236/trunk@228284 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-19 01:31:51 +00:00
mozilla.mano%sent.com
ae33d6f7ba Bug 384763 - left click broken in bookmarks menu. r=ssptizer.
git-svn-id: svn://10.0.0.236/trunk@228279 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-19 00:16:09 +00:00
sspitzer%mozilla.org
2d82d1c51d fix for bug #384677: for history sidebar and history menu, don't specify begin / end times
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@228278 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-19 00:08:18 +00:00
kherron%fmailbox.com
a1d95683c0 Backing out patch for bug 376991.
git-svn-id: svn://10.0.0.236/trunk@228202 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-17 15:09:44 +00:00
kherron%fmailbox.com
f74f510c0c Bug 367991 - Remove the places-specific calendar widget. Patch by Asaf Romano <mano@mozilla.com>, r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@228198 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-17 12:52:56 +00:00
mozilla.mano%sent.com
36c80f9488 Bug 384690 - bookmarks menu is broken. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@228188 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-17 03:14:08 +00:00
kherron%fmailbox.com
c7d02330db Bug 381329 - Build fails with GCC-4.3 due to extra semi-colons and '-pedantic' flag. Patch by Art Haas <ahaas@airmail.net>. r+sr=roc.
git-svn-id: svn://10.0.0.236/trunk@228174 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-16 19:54:02 +00:00
sspitzer%mozilla.org
b1a9950498 fix for bug #382136: in Bookmarks Menu - delete separator at bottom position, deletes bookmark
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@228159 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-16 05:07:42 +00:00
sspitzer%mozilla.org
aa6366095d fix for bug #384670: current collection searches in bookmark organizer window search all of bookmarks
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@228158 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-16 05:03:40 +00:00
mozilla.mano%sent.com
3e2310151b Bug 384515 - ASSERT: null node when moving the root node in a places tree. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@228155 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-16 01:55:15 +00:00
mozilla.mano%sent.com
e2bea88aa1 Bug 337855 - Don't rebuild places menus on each open. patch by seth, dietrich & me, r=dietrich/me.
git-svn-id: svn://10.0.0.236/trunk@228154 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-16 01:53:06 +00:00
sspitzer%mozilla.org
b08f1a2b68 fix for bug #381416: Sort order is not remembered by Bookmarks Manager when the View menu is used
patch=Christine Yen <cyen@mozilla.com>
r=sspitzer


git-svn-id: svn://10.0.0.236/trunk@227869 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-12 15:40:07 +00:00
sspitzer%mozilla.org
d2f6b1dc2a fix for bug #383762: "Sort by Name" doesn't work properly with non-ascii characters.
patch=Pavel Cvrcek <bugs@jasnapaka.com>

r=sspitzer


git-svn-id: svn://10.0.0.236/trunk@227865 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-12 15:24:44 +00:00
mozilla.mano%sent.com
b9dad4de38 Bug 381878 - click on a folder in the bookmarks toolbar and then hover over the overflow arrow it doesn't expand. r=ssptizer.
git-svn-id: svn://10.0.0.236/trunk@227846 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-12 05:28:20 +00:00
mozilla.mano%sent.com
729e8cd6fe Bug 382888 - BM menu not working when DM is focused. r=gavin.
git-svn-id: svn://10.0.0.236/trunk@227845 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-12 05:24:58 +00:00
sspitzer%mozilla.org
01a69b0c70 fix for regression bug #383529: after rebuilding the toolbar, "Open <feed name>" loads bogus address.
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@227622 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-07 02:00:05 +00:00
mozilla.mano%sent.com
ae6668ac37 Bug 383328 - no 'open in tabs' menu item for folders / livemarks in bookmark toolbar overflow chevron. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@227566 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-05 23:26:27 +00:00
mozilla.mano%sent.com
57b8e2ccb4 Bug 381534 - cannot drag and drop url from location bar to bookmarks toolbar. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@227565 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-05 23:24:39 +00:00
mozilla.mano%sent.com
4c97d0966c Bug 382073 - Bookmarks Service batch update API is a footgun. r=sayrer/mrbkap, a=mconnor.
git-svn-id: svn://10.0.0.236/trunk@227359 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-01 00:44:43 +00:00
mozilla.mano%sent.com
ae0c91963c Bug 374613 - the context menu of places bookmarks with live titles is missing the 'reload' option. patch from Steve Won <swon@mozilla.com>, r=me, a=mconnor.
git-svn-id: svn://10.0.0.236/trunk@227358 18797224-902f-48f8-a5cc-f745e15eee43
2007-06-01 00:39:10 +00:00
dietrich%mozilla.com
0f12467f54 Bug 380232 occasionally not able to open the bookmarks dialog or subscribe to a feed url (using live bookmarks) [Remote chrome not allowed] (r=mano)
git-svn-id: svn://10.0.0.236/trunk@227343 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-31 19:13:15 +00:00
mozilla.mano%sent.com
0e871606e4 Bug 382101 - Cannot move bookmark folder to the 'root'. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@227304 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-31 00:34:13 +00:00
sspitzer%mozilla.org
708f5a7ef5 fix for bug #379591: places toolbar.xml should just change existing button itemChanged()
r=mano


git-svn-id: svn://10.0.0.236/trunk@227259 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-30 16:17:35 +00:00
sspitzer%mozilla.org
b92b433260 fix for bug #382195: clicking the "show all bookmark folders" button is slow when we're opening to the bookmarks root.
r=mano/dietrich


git-svn-id: svn://10.0.0.236/trunk@227258 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-30 16:08:11 +00:00
mozilla.mano%sent.com
fce348c8fe Bug 382261 - Cannot move bookmarks toolbar folder. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@227198 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-30 00:29:54 +00:00
sspitzer%mozilla.org
827abb0b51 fix for bug #381750: with lots of bookmarks, opening up the bookmark manager dialog is slow
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@227098 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-28 03:57:20 +00:00
sspitzer%mozilla.org
31522c519a fix for bug #381894: Some Live Bookmarks only show in the places organizer.
also, there was a crash lurking in the export code when we didn't have a feed uri.

r=sayrer


git-svn-id: svn://10.0.0.236/trunk@227097 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-28 03:50:34 +00:00
sspitzer%mozilla.org
4798013716 fix for bug #382178: unable to clear a livemark's "site location" in the bookmark properties dialog
r=mano


git-svn-id: svn://10.0.0.236/trunk@227091 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-27 23:36:57 +00:00
sspitzer%mozilla.org
c2bf935bb9 fix for bug #380702: right click, "Reload live Bookmark" of livemark on personal toolbar adds blank items to the personal toolbar.
r=mano


git-svn-id: svn://10.0.0.236/trunk@227083 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-27 19:28:40 +00:00
sspitzer%mozilla.org
605dfc0ad0 fix for bug #381624: history sidebar slower the first time you open it (or on startup), then when you switch history views.
fix for regression bug #381896:  history sidebar not sorted properly the first time you open it

r=dietrich, mano


git-svn-id: svn://10.0.0.236/trunk@227046 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-25 23:50:21 +00:00
rflint%ryanflint.com
85e51c3ef4 Bug 381903 - WARNING: Components.reportError deprecated, use Components.utils.reportError in treeView.js. Patch by Ryan Jones <sciguyryan@gmail.com>, r=mano
git-svn-id: svn://10.0.0.236/trunk@227002 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-25 09:45:19 +00:00
sspitzer%mozilla.org
a65a8ef42f fix for bug #380230: personal toolbar overflow chevron not updating
r=dietrich


git-svn-id: svn://10.0.0.236/trunk@226994 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-25 06:11:02 +00:00
dietrich%mozilla.com
0fe74dc4da Bug 381378 export is unacceptably slow for large bookmarks collections (r=mano)
git-svn-id: svn://10.0.0.236/trunk@226992 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-25 05:41:49 +00:00
sspitzer%mozilla.org
348fe31519 fix for bug #381624: history sidebar slower the first time you open it (or on startup), then when you switch history views
r=mano


git-svn-id: svn://10.0.0.236/trunk@226931 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-24 02:27:32 +00:00
jminta%gmail.com
bc098b3e7c Bug 381485 [Mac] Rename 'Get Info' back to 'Properties', r=mano
git-svn-id: svn://10.0.0.236/trunk@226874 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-23 13:19:41 +00:00
sspitzer%mozilla.org
40feb36d54 fix for bug #381624: history sidebar slower the first time you open it (or on startup), then when you switch history views
r=mano


git-svn-id: svn://10.0.0.236/trunk@226838 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-23 01:44:36 +00:00
mozilla.mano%sent.com
21fa1e93ba Bug 372508 - rename insertItem to insertBookmark and add a title parameter. r=dietrich.
git-svn-id: svn://10.0.0.236/trunk@226834 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-23 01:06:32 +00:00
mozilla.mano%sent.com
4fcfcb5ee1 Bug 371823 - Optimize item moves. r=sspitzer.
git-svn-id: svn://10.0.0.236/trunk@226818 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-22 22:03:55 +00:00
sspitzer%mozilla.org
736bfdbfed fix for bug #368240: A link on the bottom of the history list takes long to load
r=mano


git-svn-id: svn://10.0.0.236/trunk@226808 18797224-902f-48f8-a5cc-f745e15eee43
2007-05-22 20:36:43 +00:00