969 Commits

Author SHA1 Message Date
jake%acutex.net
b65bd37c2f Fix for bug 92713, show_activity.pl displays zeros as non-breaking spaces.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@100005 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-30 12:52:21 +00:00
justdave%syndicomm.com
7d5d7c0224 fix for bug 91903: insecure dependency in require in importxml.pl under taint mode only in Perl 5.005.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99917 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-25 20:12:00 +00:00
justdave%syndicomm.com
4e949a3f8c Fix for bug 90933: inconsistant field types for profiles.disabledtext
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99911 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-25 17:55:29 +00:00
justdave%syndicomm.com
5457c9aeca re-fix bug 76154: permissions weren't being set correctly on the .htaccess files when checksetup.pl was run again. Also adding .htaccess to .cvsignore so it won't show up as ? in cvs diffs and updates.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99905 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-25 07:26:42 +00:00
jake%acutex.net
6fac503401 Remove the code for rejecting the version of MySQL with broken encryption (as bugzilla no longer uses MySQL's encrypt routine). Also, point to mysql.com for downloading newer versions.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99751 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-23 14:33:04 +00:00
justdave%syndicomm.com
af96e738e6 re-fix for bug 55161: buglist works again if you search for change history on a bug
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99743 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-23 02:34:08 +00:00
justdave%syndicomm.com
0f8273ef0c Fix for bug 76154: Bugzilla can now optionally provide .htaccess files for Apache to help restrict viewing of private data
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99729 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-22 05:23:33 +00:00
justdave%syndicomm.com
cb4b02bf43 fix "used only once" error reported by tinderbox
git-svn-id: svn://10.0.0.236/trunk@99725 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-22 00:43:34 +00:00
justdave%syndicomm.com
ad1725e23f Fix for bug 84714 and bug 88797: You can now change bug groups from the "change several bugs" form even if the bugs aren't all in the same groups. Also, the groups are no longer cleared when you make a change from the "change several bugs" form (unless you tell it to)
Patch by Joe Robins <jmrobins@tgix.com> and Dave Miller <justdave@syndicomm.com>
r= zach@zachlipton.com
a= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99724 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-22 00:29:45 +00:00
justdave%syndicomm.com
3071210c34 Fix for bug 84714 and bug 88797: You can now change bug groups from the "change several bugs" form even if the bugs aren't all in the same groups. Also, the groups are no longer cleared when you make a change from the "change several bugs" form (unless you tell it to)
Patch by Joe Robins <jmrobins@tgix.com> and Dave Miller <justdave@syndicomm.com>
r= zach@zachlipton.com
a= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99723 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-22 00:22:36 +00:00
jake%acutex.net
559c643f79 Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99648 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-20 15:18:30 +00:00
justdave%syndicomm.com
7e08c5375e Re-fix for bug 77699: the undefined error affected other browsers than just IE5, so work around it for all browsers.
Patch by Stephen Lee <slee@uk.bnsmc.com>
r= afranke@ags.uni-sb.de


git-svn-id: svn://10.0.0.236/trunk@99638 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-20 08:25:30 +00:00
jake%acutex.net
3366c0e0c1 Correcting the URL for MySQL's web page. Bug 90553.
Patch by Myk Melez <myk@mozilla.org>


git-svn-id: svn://10.0.0.236/trunk@99328 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-16 19:50:17 +00:00
justdave%syndicomm.com
b578f52ce7 Fixing minor problem caused by the original bug 77473 checkin where an SQL error was being produced if you tried to log in
with an invalid username.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99326 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-16 19:38:34 +00:00
justdave%syndicomm.com
a32206490b Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99057 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-11 05:29:21 +00:00
justdave%syndicomm.com
18d9089fcc Fix for bug 87701: Invalid username in bug changes echoed back without escaping HTML data
Patch by Gervase Markham <gervase.markham@univ.ox.ac.uk>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@98634 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-04 07:06:00 +00:00
justdave%syndicomm.com
7c38a345b1 Killing the "used only once" error that suddenly popped up out of nowhere on tinderbox.
git-svn-id: svn://10.0.0.236/trunk@98627 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-04 05:33:37 +00:00
justdave%syndicomm.com
0bbe42a94b removing "Use Carp" and "sub die_with_dignity" that I was supposed to remove from the previous patch before checking it in.
git-svn-id: svn://10.0.0.236/trunk@98626 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-04 05:28:39 +00:00
justdave%syndicomm.com
b9186e3735 Fix for bug 59349: Processmail now runs in taint (perl -T and $db->{Taint}=1) mode. Hooks also added to globals.pl to make converting other files in Bugzilla to run in Taint mode easier.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@98622 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-04 04:41:27 +00:00
gerv%gerv.net
cc60bb0e89 Add strikethrough to resolved bug numbers. Bug 79816. r=jake.
git-svn-id: svn://10.0.0.236/trunk@98411 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-01 20:17:28 +00:00
gerv%gerv.net
d9e5951e98 Make bug chart filenames other-OS friendly by removing colons. Bug 88179. r=jake.
git-svn-id: svn://10.0.0.236/trunk@98408 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-01 19:09:29 +00:00
justdave%syndicomm.com
2dcb6d399f Fix for bug 87596: improper definition of $::components in globals.pl
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@98393 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-01 02:00:56 +00:00
justdave%syndicomm.com
3f68a6abd2 Fix for bug 76183 and bug 71555: consolidates chmod activity in one place in checksetup.pl and also provides permission setting for bugzilla installations installed in a personal user directory as opposed to the server's main web space. (makes the files world-readable so the webserver can see them, since you can't set the group)
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@98242 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-29 03:47:56 +00:00
justdave%syndicomm.com
3e7a5d8794 Fix for but 76073: - and + didn't work in quicksearch in IE and Opera
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@98187 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-28 16:27:37 +00:00
jake%acutex.net
0ed0dcd331 Refix bug 80289. Don't print header for groups if there aren't any groups to display (was printing a header without groups in rare instances).
Patch by Joe Robins <jmrobins@tgix.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@98186 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-28 15:42:30 +00:00
justdave%syndicomm.com
65d93e8ed3 Fix for bug 87983: backdoor.cgi is Netscape-specific, and not part of the bugzilla package. Removing from CVS.
git-svn-id: svn://10.0.0.236/trunk@98148 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-28 06:49:06 +00:00
justdave%syndicomm.com
99e643f07b Fixing "used only once" errors flagged by tinderbox on the last checkin.
git-svn-id: svn://10.0.0.236/trunk@98022 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-27 02:31:55 +00:00
justdave%syndicomm.com
9993af1ff9 Fix for bug 80289: Group restrictions are now identified with checkboxes instead of select widgets. Also, product groups are now only offered if they are either already set, or match the current product (i.e. the option to set a product bit for a product other than the one the bug is in is no longer available) This results in much less clutter for the admin folks on sites with lots of products.
Patch by Joe Robbins <jmrobins@tgix.com>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@98014 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-27 01:44:34 +00:00
justdave%syndicomm.com
199142da3c Re-fix for bug 28458: AddFDef always replaces the fielddefs every time you run checksetup.pl, so the change to them during doeditparams was nullified if you updated. Other recent changes have nullified the reason for changing it in editparams anyway, so just backing that part out.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@97681 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-21 15:03:11 +00:00
justdave%syndicomm.com
8456959368 Fix for "used only once" error reported by tinderbox after the last checkin. (Aaargh!)
git-svn-id: svn://10.0.0.236/trunk@97656 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-21 02:42:41 +00:00
justdave%syndicomm.com
83388dc5ed Fix for bug 47914: buglist.cgi always had a not-logged-in footer if you were unlucky enough to have a login cookie that got corrupted in the shadow database. This patch makes buglist.cgi switch back to the primary database before looking up your login cookie for the footer.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@97650 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-21 02:02:30 +00:00
jake%acutex.net
72d5e88b97 Fix for bug 86447 - ChangeFieldType() wasn't dealing with 'not null' properly.
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@97526 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-20 01:37:19 +00:00
justdave%syndicomm.com
11c1fc0d98 Fix for bug 85833: show_bug.cgi (and probably others) now allow leading or trailing spaces in the bug id, to allow for user input error. This used to work, and recent bug validation changes broke it.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@97469 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-19 22:48:21 +00:00
justdave%syndicomm.com
107bf6572e Fix for bug 45918: the old password field on the userprefs page is now used to log you back in if you try to change your password with cookies turned off, which avoids the confusing login screen after entering your new password in which you used to have to enter your old password one more time in order to let it set your new password (yes, it used to be as confusing as that just sounded :)
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@97448 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-19 22:02:53 +00:00
jake%acutex.net
3d6379f41c Running a query using the Added Comment option was very slow (bug 57350).
Patch by Myk Melez <myk@mozilla.org> and Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97396 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-19 02:05:08 +00:00
jake%acutex.net
9307fd5a8a Refixing bug 71396. Each PushGlobalSQLState() needs a PopGlobalSQLState() and this file instead had two "pushes".
git-svn-id: svn://10.0.0.236/trunk@97393 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-19 01:37:02 +00:00
jake%acutex.net
5743b31229 Allow '\' as a path delimiter (bug 29064)
Patch Concept by <timeless@mac.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97370 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-18 23:13:18 +00:00
jake%acutex.net
73d667cb49 Fix for bug 85832 - QuickSearch should strip leading and trailing spaces.
Patch by Andreas Franke <afranke@ags.uni-sb.de>


git-svn-id: svn://10.0.0.236/trunk@97331 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-18 19:24:17 +00:00
tara%tequilarista.org
176266cd1f applying handy patch to refix version table to be 64 instead of 16--partial fix of bug 9352
git-svn-id: svn://10.0.0.236/trunk@97283 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-16 23:01:12 +00:00
jake%acutex.net
c88b002e96 Fix for bug 71396 - $::db->do isn't needed anymore
Patch by Christian Reis <kiko@async.com.br>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97282 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-16 14:51:16 +00:00
jake%acutex.net
0c19e11337 Fix for bug 83619 - QuickSearch was crashing Netscape 4.76 and 4.77 on Unix
Patch by Andreas Franke <afranke@ags.uni-sb.de>


git-svn-id: svn://10.0.0.236/trunk@97238 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-15 20:16:59 +00:00
jake%acutex.net
0e2e8615a5 Checking in the cleaner version of the fix for "No Available Products". This was attached to bug 65311.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97164 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-14 20:02:31 +00:00
jake%acutex.net
3f301421a8 Backing out previous changes as there was a better patch already attached to a different bug
git-svn-id: svn://10.0.0.236/trunk@97163 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-14 20:00:03 +00:00
jake%acutex.net
6125f97685 Bugzilla shouldn't display empty header in the New: email notifications (bug 85734)
r=timeless


git-svn-id: svn://10.0.0.236/trunk@97146 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-14 14:16:27 +00:00
justdave%syndicomm.com
35ab8d3d93 Fix for bug 84596: Syncshadowdb wasn't using the db_user and db_pass from localconfig, which meant that it previously wouldn't run unless it was running under a user that had access to the bugs and shadowbugs dbs and didn't have a password. It now looks for db_user and db_pass and specifies them on the command line to mysqldump and mysql if they're in use.
r= tara


git-svn-id: svn://10.0.0.236/trunk@96822 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-10 17:38:15 +00:00
justdave%syndicomm.com
64139789dc Re-fix for bug 21253: fix calling conventions for syncshadowdb so that a phony parameter to get past the multi-param system() test in tinderbox actually works.
r= tara


git-svn-id: svn://10.0.0.236/trunk@96819 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-10 17:15:56 +00:00
jake%acutex.net
8e42d674c4 Give a logical error message if no products are available to a user for bug entry (bug 84285).
Patch by Paul Thomas <paul.thomas@sse.ie>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96712 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-08 13:12:13 +00:00
justdave%syndicomm.com
2a73def3a6 Hopefully the fix for bug 77778: component lists, etc stuttering due to corruption in data/versioncache.
Patch design by Terry Weissman <terry@mozilla.org>
Patch implemented by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96651 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 21:26:49 +00:00
justdave%syndicomm.com
62f8abbb9a Fix for bug 15980: Password is no longer shown in the location bar on the first page you load after logging in.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@96648 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 20:26:40 +00:00
justdave%syndicomm.com
5c9e4da69d fix typo
git-svn-id: svn://10.0.0.236/trunk@96598 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-07 01:31:51 +00:00