Commit Graph

49 Commits

Author SHA1 Message Date
beng%bengoodger.com
d53727f74e 329367 -cannot return to bookmarks after a search r=annie.sullivan@gmail.com and 334401 - assorted places organizer fixes including new debug panel r=brettw@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@194665 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-19 03:34:26 +00:00
joe%retrovirus.com
de05616979 Removes the history item mode for the (Bookmark) Properties dialog, which
just showed disabled title and URI fields.  The "Properties" context menu
item is now disabled for URI nodes which are not bookmarked.

bug=330876
r/sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@194576 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-18 01:56:42 +00:00
beng%bengoodger.com
13b759f243 332495 - grouping by site is not preserved when searching + various other search/sort fixes. r=annie.sullivan@gmail.com, brettw@gmail.com (history pieces)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@194357 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 22:51:36 +00:00
joe%retrovirus.com
699aed3a0a Resubmitting this patch, which adds a editing for livemark URIs as well
as fixing a few small livemark bugs, now that I've fixed a couple reference
leaks in nsLivemarkService (see bugs 333764 and 333784).

NOTE: I expect this to cause an increase in allocations on branch balsa,
since it causes nsLivemarkService to be instantiated to set up the menus.
(nsLivemarkService previously wasn't used in the balsa bloat test)

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@194326 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 17:20:31 +00:00
brettw%gmail.com
ef9648f989 Bug 332144 r=brettw sr=beng (checkin for pamg) Subscriptions context menu should have "reload all livemarks"
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@194323 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-13 16:40:12 +00:00
gavin%gavinsharp.com
745d7a2348 Bug 332888: JS warning: variable folderId hides argument, r=ben
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@194238 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-12 18:23:33 +00:00
roc+%cs.cmu.edu
b0f818e526 Bug 331522. Make URI keyword fixup (e.g. doing a Google 'I feel lucky' search) off by default, chrome has to ask specifically to turn it on for a page load. r+sr=darin,r=mconnor,a=darin
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@194206 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-12 03:24:08 +00:00
beng%bengoodger.com
6285f9abf1 329733 - problems with drag & drop to bookmarks menus. ensure that we properly close up bookmarks menus after they have been opened. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@194025 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-10 19:26:01 +00:00
joe%retrovirus.com
f0f9c4e718 Backing out patch from bug 330063 to see if it's responsible for the
branch balsa allocation increases, and if so, fix before resubmitting.


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@193946 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-08 17:58:56 +00:00
joe%retrovirus.com
8f0b91e537 * Added ability to edit Live Bookmark feed & site URIs in Bookmark Properties dialog
* Fixed a setFeedURI bug in the LivemarkService
* Fixed problems that broke the toolbar when a live bookmark had no site URI
* Converted some browser UI code to use LivemarkService methods rather than manipulating the annotations directly

bug=330063
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@193764 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-06 23:29:46 +00:00
joe%retrovirus.com
647416c14e Implements "Bookmark All Tabs..." for Places. (Also fixes a small error
when undoing aggregate transactions.)

bug=330929
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@193476 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 01:26:58 +00:00
darin%meer.net
70c6dd52d7 fixes bug 329634 "No apparent way to Reload Live Bookmark (or update livemarks)" patch by pamg, r=annie, sr=beng
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@193471 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 00:42:44 +00:00
beng%bengoodger.com
ab54521c6e 331755 - Use Bookmark option for setting home page is broken. add a new home page selection dialog that uses places. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@193467 18797224-902f-48f8-a5cc-f745e15eee43
2006-04-04 00:13:58 +00:00
beng%bengoodger.com
67664644bb 331905 - pasted folders/items are inserted at the wrong level in the bookmarks hierarchy. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@193353 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-31 22:42:21 +00:00
joe%retrovirus.com
1e15bea627 Convert all the DB-modifying operations in the Bookmark Properties to use
transactions so that they can be undone.  ("change URI" is the only one
that's not transactionized yet, because it needs deeper work, cf. bug 331655)

bug=326321
r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@193289 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-31 00:35:13 +00:00
beng%bengoodger.com
a978041c69 328191, cannot delete history entries + a few other fixes r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@193145 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-28 19:59:26 +00:00
beng%bengoodger.com
018173b716 323812 - fix bogus copy-paste behavior and assorted other issues (insertion bugs, command updating) r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@193093 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-28 00:54:10 +00:00
beng%bengoodger.com
cc359d57b3 324958 - folder undo delete back to previous folder id. Implement folder removal transaction in bookmarks service itself, using private methods to restore folders back to previous ids. Adjust fe to use new api. r=brettw (C++), annie.sullivan (JS)
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192968 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-25 00:46:28 +00:00
annie.sullivan%gmail.com
21469cfaf3 Bug 329743: fixes dropmarker icons not showing up on places toolbar folders on mac.
Patch by Pam Greene <pamg.bugs@gmail.com>
r=annie.sullivan@gmail.com sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192852 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-23 16:55:25 +00:00
joe%retrovirus.com
b36f66be0b * Moved changeBookmarkURI functionality from controller.js into
nsINavBookmarksService
* Added annotation and favicon handling to changeBookmarkURI
* Added brettw's copyAnnotations patch to nsIAnnotationService
* Added a GetAnnotationService() to the annotation service for faster
  intra-component access
* Added a getBookmarkFoldersTArray() to nsINavBookmarksService for easier
  intra-component memory management; updated getBookmarkFolders() to use it
* Added stub for tagRoot to nsINavBookmarksService; DO NOT USE until 329961
  has been resolved
* Quick fix for Add Bookmarks breakage caused by 329546

bug=330192
r=brettw@gmail.com
sr=bryner@bryanryner.com


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192839 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-23 06:26:23 +00:00
beng%bengoodger.com
656188255a 329269, more command handling cleanup for places views. make sure the right commands are enabled for items in the readonly area of the places list, and generally. make sure reload commands are enabled appropriately. also, some spit and polish for the organizer window r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192826 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-23 00:54:35 +00:00
joe%retrovirus.com
7f4c26fe14 This submission is a roll-up of three patches developed & approved during
the branch freeze:
330052 add bookmark dialog should have a default folder selected
329792 remove dead code for old tag-style folder selector in bookmark properties
330023 allow for editing of folder names

r=annie.sullivan@gmail.com
sr=ben@mozilla.org


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192751 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-22 03:29:57 +00:00
beng%bengoodger.com
65d488c5fc 329269 various improvements to view initialization r=annie.sullivan@gmail.com 330736 - bug in query serialization r=brettw@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192511 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-17 02:02:36 +00:00
annie.sullivan%gmail.com
acaaa94cf4 Fixes several bugs with open in tabs: makes menus set selection in command events in case DOMMenuItemActive doesn't get sent, only shows Open in Tabs menuitem if there are two or more items in the menu, and respects browser.tabs.loadFolderAndReplace and browser.tabs.loadBookmarksInBackground prefs. Also moves #include of debug.js to browser.js as this was causing JavaScript errors on the mac. r=ben@mozilla.org sr=darin@meer.net bug=330130
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192438 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-15 19:59:09 +00:00
joe%retrovirus.com
a9421754f2 Moved Ben's JavaScript ASSERT function to be NS_ASSERT in
toolkit/content/debug.js

debug.js is now included by globalOverlay.js, but if that's not in your
scope you can just #include debug.js directly.

NS_ASSERT() shows a dialog box containing a stack trace when it's called
with a condition that isn't true.  The dialog box will be suppressed in
final builds, but in nightlies and alphas, it's useful for encouraging
bug submissions.  To disable the dialogs, set XUL_ASSERT_PROMPT=0 in
your environment.

bug=327349
r=darin@meer.net, gavin.sharp@gmail.com


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192291 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-14 01:57:26 +00:00
beng%bengoodger.com
311611223e 329269 - more work on places organizer. menus, accessible sorting and grouping options, etc. still a work in progress. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192184 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-10 23:48:40 +00:00
joe%retrovirus.com
ba77f45207 Changes to bookmark properties dialog:
* Customized bookmark properties dialog for add vs. edit cases
* Added support for changing URI of bookmark (annotations not carried over yet)
* Add support for viewing properties of history entries
* Changed from tag-style control to folder tree for folder selection,
  yielding layout and accessibility improvements
* Switched to using standard dialog buttons

bug=329272
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192153 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-10 17:37:22 +00:00
beng%bengoodger.com
2e9288988d 329956 - add bookmark button on toolbar no longer works. r=joe@retrovirus.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192112 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-09 22:03:26 +00:00
beng%bengoodger.com
1f4107e506 329586 - browser shim cleanup, tidies up some UI update notification in the browser, fixes a few menu items here and there, removes unnecessary initialization, moves places to its own window, removes all code to do with maintaining places as a tab, renames osme objects and member variables, formatting issues, creates a browser controller for updating commands. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@192043 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-09 02:09:28 +00:00
annie.sullivan%gmail.com
fe3c49fd71 Fixes JavaScript warnings about trailing commas and redefined variables. bug=329171 r=ben@mozilla.org
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@191937 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-07 23:20:46 +00:00
beng%bengoodger.com
6a4854868c 329587 - controllers registered after places controller cannot execute any commands due to places controller consuming all. r=fritz@google.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@191903 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-07 18:25:43 +00:00
joe%retrovirus.com
a33b7d3a5a * Allows the user to access Bookmark Properties dialog from context menus.
* Adds support for editing the bookmark shortcut (formerly keyword) in the Bookmark Properties dialog.
* Improves the appearance of the Bookmark Properties dialog.
* Removes dead code from PlacesBrowserShim in browser.js

NOTE: This doesn't reflect the final UI for this functionality; rather,
this change is intended to add functionality for users of the nightlies.

bug=322988
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@191866 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-07 00:52:35 +00:00
annie.sullivan%gmail.com
98caa00f4b Added "Open in Tabs" menuitem to bookmarks menus.
Refactored code so that command and click handlers don't reside directly in the XBL bindings for toolbar and
menu.
r=ben@mozilla.org bug=327034


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@191752 18797224-902f-48f8-a5cc-f745e15eee43
2006-03-04 01:19:56 +00:00
annie.sullivan%gmail.com
322a2e93a4 Fixes problems with bookmark menus and toolbarbuttons not working correctly on mac. bug=327036 r=ben@mozilla.org
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@191046 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-23 18:30:40 +00:00
bryner%brianryner.com
c02af4febd Sync up branch and trunk
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@190422 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-17 23:44:21 +00:00
annie.sullivan%gmail.com
6c6a1e5663 Checking in patch by mossop@blueprintit.co.uk to allow middle click to open links in tabs. bug=325781 sr=beng
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@190409 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-17 22:58:41 +00:00
annie.sullivan%gmail.com
4a3d5485b0 Fixed drag and drop support for toolbars and menus.
Added lots more visual feedback when dragging and dropping.
bug=318052 r=beng


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@190321 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-17 00:50:51 +00:00
beng%bengoodger.com
39c9f2418f 326598 - fix a bunch of D&D, paste and insertion issues. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@189594 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-10 22:43:54 +00:00
beng%bengoodger.com
1a72e95485 324948 - should not be able to do edit operations on immutable containers (delete, paste, cut). Make sure we check if a container has readonly children, or the folder itself (if it is a bookmark folder) is readonly before enabling commands for cut, copy and paste. Also assert that activeView is non-null, for safety. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@189515 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-09 21:32:59 +00:00
beng%bengoodger.com
65dec44bb5 320655 - changing the history view displayed should also update the sorting r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@189496 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-09 19:29:40 +00:00
beng%bengoodger.com
de2674b926 326346 - javascript error when selecting text on a page. r=annie.sullivan@gmail.com
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@189385 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-08 01:53:22 +00:00
bryner%brianryner.com
19f36b2aa0 Add support for bookmark separators (bug 320261). r=brettw, ben.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@189381 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-08 01:10:57 +00:00
brettw%gmail.com
f55cf11272 Bug 325161 r=annie.sullivan Make all nsINavHistoryResultNodes support URI attribute, remove nsINavHistoryURIResultNode.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@189277 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-07 01:57:53 +00:00
annie.sullivan%gmail.com
2ebac7087c bug=325169 r=brettw@gmail.com keywords=fixed1.8.1 Fix Livemark icons
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@188636 18797224-902f-48f8-a5cc-f745e15eee43
2006-02-01 02:14:42 +00:00
beng%bengoodger.com
788fdd40db 317633 - undo/redo for Places. Make sure the various transactions work better - e.g. folder undo should save a list of its child nodes for restoration. Also ensure that bookmark edits done in the places tab aren't undone when another tab is selected and Ctrl+Z hit by implementing a transaction manager in the browser window that filters out places-tab transactions if the places tab isn't selected. Make the goDo*Command utility functions in globalOverlay.js consult the window looking for applicable controllers, not just the focused element. r=sullivan. Also 320085 - search menu keybindings for places: allow find bar to be turned off using a state variable, which prevents the opening of the strip but fires an event which other applications like places can listen to: 'find-activated'.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@188580 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-31 18:00:06 +00:00
brettw%gmail.com
a019e27463 [for joe@retrovirus.com] Bug 324743, r=brettw. Result roots are closed by default.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@188540 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-31 03:05:07 +00:00
annie.sullivan%gmail.com
6808f51d2d Fixes to menu and toolbar to work with new history backend.
r=brettw sr=beng bug=209804


git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@188352 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-27 18:30:13 +00:00
brettw%gmail.com
46c0fad9d2 *** empty log message ***
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@188102 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-24 18:45:10 +00:00
bryner%brianryner.com
082ac64a39 Remainder of the Places merge (bug 324370). This adds all of the places files to the branch, along with the build system changes. Places is still disabled by default.
git-svn-id: svn://10.0.0.236/branches/MOZILLA_1_8_BRANCH@188067 18797224-902f-48f8-a5cc-f745e15eee43
2006-01-23 23:19:02 +00:00