82 Commits

Author SHA1 Message Date
lpsolit%gmail.com
eeb8727424 Bug 300501: Move GetBugActivity() into Bug.pm - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@176064 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-14 00:02:17 +00:00
lpsolit%gmail.com
bd81a6f03e Bug 240251: Bug::AppendComment() should receive the user ID as a 2nd parameter - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@175772 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-07 18:42:09 +00:00
lpsolit%gmail.com
8dddac85e5 Bug 242318: "blocked" field is ignored in post_bug.cgi if the "dependson" field isn't present - Patch by Frédéric Buclin <LpSolit@gmail.com> r=kiko a=justdave
git-svn-id: svn://10.0.0.236/trunk@175744 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-07 14:17:18 +00:00
mkanat%kerio.com
561bb9c551 Bug 289042: Implicit joins should be replaced by explicit joins - installment B
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@175517 18797224-902f-48f8-a5cc-f745e15eee43
2005-07-02 05:23:28 +00:00
lpsolit%gmail.com
74b5dfcf2b Bug 297794: initBug's verification of user_id being an email is bogus - Patch by Tiago R. Mello <timello@async.com.br> r=LpSolit a=myk
git-svn-id: svn://10.0.0.236/trunk@174872 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-20 20:16:32 +00:00
mkanat%kerio.com
5c30640687 Bug 293501: Add me to files where I belong and fix kerio.com emails
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=colin, a=myk


git-svn-id: svn://10.0.0.236/trunk@174620 18797224-902f-48f8-a5cc-f745e15eee43
2005-06-15 03:55:00 +00:00
lpsolit%gmail.com
e70ec4c9bc Bug 248386: Add support for Alias to post_bug.cgi - Patch by Albert Ting <altlst@sonic.net> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@172998 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-03 18:44:54 +00:00
lpsolit%gmail.com
d1fa0293a2 Bug 290513: Move CheckIfVotedConfirmed() out of CGI.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=myk
git-svn-id: svn://10.0.0.236/trunk@172461 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-19 23:43:00 +00:00
lpsolit%gmail.com
559a76b023 Bug 290511: Move RemoveVotes() out of globals.pl - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
git-svn-id: svn://10.0.0.236/trunk@172352 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-16 17:17:06 +00:00
lpsolit%gmail.com
2b2e8cf907 Bug 199048: Preference option to reverse sort the comments stack - Patch by Shane H. W. Travis <shane.h.w.travis@gmail.com> r=mkanat a=myk
git-svn-id: svn://10.0.0.236/trunk@171903 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-09 00:37:52 +00:00
lpsolit%gmail.com
9e4a52fdf0 Bug 86328: Deleting bugs doesn't delete dependent records properly - Patch by Frederic Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@171752 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-06 00:19:56 +00:00
mkanat%kerio.com
effcb842e2 Bug 287880: [SECURITY] Comments on secure bugs still available to templates... show_bug leaks
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@171385 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-30 14:30:43 +00:00
mkanat%kerio.com
2fa9c9d7cc Bug 286501: Summarize time fails with "Can't bind reference" error
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170833 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-17 06:56:16 +00:00
mkanat%kerio.com
fda3b0dd8f Bug 174295: ANSI SQL requires all columns in SELECT to be in GROUP BY, unless they are in "aggregate" functions
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk


git-svn-id: svn://10.0.0.236/trunk@170751 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-16 00:27:15 +00:00
mkanat%kerio.com
abc539470f Bug 285534: bugs.qa_contact should allow NULL
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=joel, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170685 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 05:20:48 +00:00
travis%sedsystems.ca
5fa193cfee Bug 187658 : Group checkboxes are not sorted consistently
Patch by Shane H. W. Travis <travis@sedsystems.ca>   r=wurblzap  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170541 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-10 22:34:06 +00:00
mkanat%kerio.com
30b6f7b80f Bug 283561: Move AppendComment out of globals.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=vladd, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170509 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-10 08:20:41 +00:00
mkanat%kerio.com
298e9502a5 Bug 285541: QA Contacts No Longer Appear in show_bug
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=justdave, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170500 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-10 04:53:51 +00:00
mkanat%kerio.com
17ed4b1727 Bug 282145: Bug.pm is too slow for general use
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=gerv, a=myk


git-svn-id: svn://10.0.0.236/trunk@170412 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-08 23:57:32 +00:00
mkanat%kerio.com
d29ebec588 Bug 283919: Move BugAliasToID out of CGI.pl into Bugzilla::Bug
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@170404 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-08 23:03:57 +00:00
mkanat%kerio.com
3236120a9a Bug 283924: Move ValidateComment out of CGI.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170281 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-07 13:55:34 +00:00
mkanat%kerio.com
7f1a179da7 Bug 277782: _throw_error should unlock tables when tables are locked, automatically
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=travis, r=LpSolit, a=justdave


git-svn-id: svn://10.0.0.236/trunk@170180 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 00:18:48 +00:00
travis%sedsystems.ca
54b66ed77a Bug 283567 : Toggling a comment's privacy does nothing (regression from bug 279700)
Patch by : Frederic Buclin <LpSolit@gmail.com>  r=mkanat  a=justdave


git-svn-id: svn://10.0.0.236/trunk@170010 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-28 21:33:16 +00:00
mkanat%kerio.com
3d946538f6 Bug (None): Fix for checkin from Bug 280493, fix a trailing comma in Bug.pm
Thanks to glob for pointing it out.


git-svn-id: svn://10.0.0.236/trunk@169809 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-25 02:01:45 +00:00
mkanat%kerio.com
f7471cbb97 Bug 283237: Move DBname_to_id out of globals.pl
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap, a=myk


git-svn-id: svn://10.0.0.236/trunk@169799 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:42:48 +00:00
mkanat%kerio.com
2e945fe489 Bug 280500: Replace "DATE_FORMAT()" with Bugzilla::DB function call
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, a=myk


git-svn-id: svn://10.0.0.236/trunk@169798 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-24 23:37:48 +00:00
mkanat%kerio.com
6156f99e69 Bug 281596: Remove RelationSet from Bugzilla::Bug
Patch by Max Kanat-Alexander <mkanat@kerio.com> r=LpSolit, a=myk


git-svn-id: svn://10.0.0.236/trunk@169275 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 18:48:59 +00:00
travis%sedsystems.ca
b1d19a6237 Bug 282331 : Old comments get wrapped even if already_wrapped=1
Patch by Jussi Sirpoma <jussi@comlink.fi>  r=mkanat  a=myk


git-svn-id: svn://10.0.0.236/trunk@169261 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 17:00:20 +00:00
travis%sedsystems.ca
4f92c4d66c Bug 271276 : Cannot enter negative time for 'Hours Worked'
Patch by Shane H. W. Travis <travis@sedsystems.ca>   r=LpSolit  a=justdave


git-svn-id: svn://10.0.0.236/trunk@169253 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 16:16:38 +00:00
travis%sedsystems.ca
8a81a01901 Bug 276838 : Eliminate use of $::unconfirmedstate
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=wurblzap  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168979 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:22:26 +00:00
travis%sedsystems.ca
726c6527c6 Bug 279544: Bug.pm: Eliminate deprecated Bugzilla::DB routines
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=wurblzap  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168793 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-04 16:04:57 +00:00
travis%sedsystems.ca
64284ff52f Bug 279740 : Move CountOpenDependencies out of globals.pl
Patch by Max Kanat-Alexander <mkanat@kerio.com>  r=wurblzap  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168643 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-01 17:43:26 +00:00
travis%sedsystems.ca
92492b41de Bug 279700 : Move GetComments from globals.pl into Bugzilla::Bug
Patch by Max Kanat-Alexander <mkanat@kerio.com>   r=vladd  a=justdave


git-svn-id: svn://10.0.0.236/trunk@168550 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 16:32:57 +00:00
travis%sedsystems.ca
0170d97491 Bug 266579 : Users without privs can confirm bugs by assigning to themselves first, without having canconfirm privs
Patch by LpSolit@gmail.com    r=myk    a=justdave


git-svn-id: svn://10.0.0.236/trunk@168095 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-20 23:22:10 +00:00
jocuri%softhome.net
297b1c2147 Patch for bug 103636: Support specifying a date on which a bug is expected to be resolved; patch by Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>, r=jouni, a=myk.
git-svn-id: svn://10.0.0.236/trunk@167817 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:36:05 +00:00
bugreport%peshkin.net
967204e8ec Bug 224208 Add a higher level of categorization (.ie departments, locations, etc.)
patch by Albert Ting
r=joel, glob
a=myk


git-svn-id: svn://10.0.0.236/trunk@161078 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-20 21:49:20 +00:00
kiko%async.com.br
c176924dd6 More whitespace fixes. r=ssdbot. I've already talked to Alexandre
about this, won't happen again.


git-svn-id: svn://10.0.0.236/trunk@160440 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-06 13:47:25 +00:00
kiko%async.com.br
65618d4b65 Whitespace fixes. r=ssdbot
git-svn-id: svn://10.0.0.236/trunk@160402 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-05 13:51:23 +00:00
kiko%async.com.br
77e2765fbe Fix for bug 253562: Hours Worked (actual_time) is being listed as 1.
Cleans up Bugzilla::Bug::actual_time to do things the right way (dbi,
Bugzilla->user) and apparently fixes a problem limited to some
platforms. r=joel, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@160399 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-05 13:43:48 +00:00
bugreport%peshkin.net
cd65dc04d7 Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 16:17:10 +00:00
jocuri%softhome.net
ac35b43d57 Patch for bug 253357: replace IFNULL with COALESCE for increased database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160169 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 08:59:16 +00:00
bugreport%peshkin.net
9f826706c4 Bug 253588: Change Bugzilla->user to be usable even for a logged-out user
patch by erik,joel
r=kiko
a=justdave


git-svn-id: svn://10.0.0.236/trunk@160163 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 02:27:26 +00:00
kiko%async.com.br
f5b1cdca19 Fix for bug 236678: Clean up access to COOKIE global. Murder the last
remaining places in the tree where COOKIE is used; includes a rather
thorough cleanup of Bugzilla::Bug->user and a minor doc update. r=joel, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@160015 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 02:45:38 +00:00
kiko%async.com.br
f670ca783b Using "abort" instead of 1 to make the unlock_tables request consistent
with the rest of Bugzilla.


git-svn-id: svn://10.0.0.236/trunk@159667 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-22 17:51:19 +00:00
kiko%async.com.br
ce412f90e2 Fix for bug 252159: centralize time validation. Adds a ValidateTime
function to Bugzilla::Bug and uses it in relevant callsites. Patch by
Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>. r=kiko, a=justdave.


git-svn-id: svn://10.0.0.236/trunk@159666 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-22 17:48:37 +00:00
jouni%heikniemi.net
7fd5078c36 Bug 223878: Flag system dies when changing a deleted flag.
r=joel, justdave
a=justdave


git-svn-id: svn://10.0.0.236/trunk@158788 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-06 07:08:02 +00:00
jocuri%softhome.net
227f7186fb Patch for bug 248001: Conversion of boolean conditions in SQL statements for better DB independence; patch by David Lawrence <dkl@redhat.com>; r=joel, vladd; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@158711 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-03 00:26:29 +00:00
jocuri%softhome.net
5a0765d00b Patch for bug 217627: fix Bugzilla internal error message that appears if bug alias starts with zero; patch by Alexey Gladkov <legion@altlinux.org>; r=justdave; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@156600 18797224-902f-48f8-a5cc-f745e15eee43
2004-05-19 19:48:11 +00:00
justdave%syndicomm.com
e099454c93 Bug 192516: Moving the loose .pm files into the Bugzilla directory, where they belong. These files pre-date the Bugzilla directory, and would have gone there had it existed at the time. The four files in question were copied on the CVS server to preserve CVS history in the files. This checkin deletes them from the old location and modifies everything else to know where they are now.
r= myk, gerv
a= justdave


git-svn-id: svn://10.0.0.236/trunk@154078 18797224-902f-48f8-a5cc-f745e15eee43
2004-03-18 03:57:05 +00:00
justdave%syndicomm.com
910a4cf80d Bug 217422: "0" was missing in "votes: 0" (MySQL 4 compatibility)
r= bbaetz, a= justdave


git-svn-id: svn://10.0.0.236/trunk@146510 18797224-902f-48f8-a5cc-f745e15eee43
2003-09-02 06:54:58 +00:00