Bommels05/Mozilla
Bommels05/Mozilla
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
218,123 Commits 3,986 Branches 0 Tags
Commit Graph

196 Commits

Author SHA1 Message Date
bzrmirror%bugzilla.org
7e6c565c4c Bug 913904: (CVE-2013-1734) [SECURITY] CSRF when updating attachments 
r=dkl a=sgreen


git-svn-id: svn://10.0.0.236/trunk@265060 18797224-902f-48f8-a5cc-f745e15eee43
 2013-10-16 17:29:09 +00:00
mkanat%bugzilla.org
b6f905fa00 Bug 811280: Adds a caching mechanism to Bugzilla::Object to avoid querying the database repeatedly for the same information 
r=dkl,a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264478 18797224-902f-48f8-a5cc-f745e15eee43
 2012-11-22 14:45:44 +00:00
mkanat%bugzilla.org
58cef36f10 Bug 803600: Clean up the comment generated when deleting attachments 
r=justdave a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264356 18797224-902f-48f8-a5cc-f745e15eee43
 2012-10-19 19:00:52 +00:00
mkanat%bugzilla.org
8e47ba629a Bug 787529: Use |use 5.10.1| everywhere 
r=wicked a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264195 18797224-902f-48f8-a5cc-f745e15eee43
 2012-09-01 21:45:59 +00:00
mkanat%bugzilla.org
7c9d5aa91e Bug 771107 - List of attachments in attachment details screen does not distinguish obsolete attachments 
r=glob, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@264053 18797224-902f-48f8-a5cc-f745e15eee43
 2012-07-23 22:15:49 +00:00
mkanat%bugzilla.org
ce80d498cb Bug 138546: Add a checkbox to add himself to the CC list when creating or editing an attachment 
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263982 18797224-902f-48f8-a5cc-f745e15eee43
 2012-06-26 15:30:46 +00:00
mkanat%bugzilla.org
049206fa69 Bug 671612: Send "X-Content-Type-Options: nosniff" with every response 
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263870 18797224-902f-48f8-a5cc-f745e15eee43
 2012-05-29 15:16:07 +00:00
mkanat%bugzilla.org
0b693cde00 2nd part of bug 731559: fix get_attachments_by_bug() everywhere 
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263527 18797224-902f-48f8-a5cc-f745e15eee43
 2012-03-06 21:01:31 +00:00
mkanat%bugzilla.org
3b5e8524aa Bug 680131: Replace the MPL 1.1 license by the MPL 2.0 one in all files, and add it to files which miss one 
r=kiko r=mkanat r=mrbball a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263258 18797224-902f-48f8-a5cc-f745e15eee43
 2012-01-11 22:48:45 +00:00
mkanat%bugzilla.org
b49caf910d Bug 169752: Activity log should fuse data fields split because they didn't fit 
r=glob a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263162 18797224-902f-48f8-a5cc-f745e15eee43
 2011-12-14 13:31:39 +00:00
mkanat%bugzilla.org
7acf883f6a Bug 684225: The removal of locally stored attachments should be done from Bugzilla::Attachment->remove_from_db 
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@263142 18797224-902f-48f8-a5cc-f745e15eee43
 2011-12-07 23:16:18 +00:00
mkanat%bugzilla.org
6d82a471be Bug 703983 - CSRF vulnerability in attachment.cgi allows possible unauthorized attachment creation 
[r=LpSolit a=LpSolit]


git-svn-id: svn://10.0.0.236/trunk@263092 18797224-902f-48f8-a5cc-f745e15eee43
 2011-11-21 22:16:29 +00:00
mkanat%bugzilla.org
a98571dff6 Bug 682822: Hide 'obsolete attachments' section when there are none to display 
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262794 18797224-902f-48f8-a5cc-f745e15eee43
 2011-09-02 05:01:24 +00:00
mkanat%bugzilla.org
4e6c5e0ad5 Bug 637981: (CVE-2011-2379) [SECURITY] "Raw Unified" patch diffs can cause XSS on this domain in IE 6-8 and Safari 
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262585 18797224-902f-48f8-a5cc-f745e15eee43
 2011-08-04 20:49:57 +00:00
mkanat%bugzilla.org
52ed8b54ae Bug 653404: Misleading error message when file to be attached is not readable by browser 
r/a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@262266 18797224-902f-48f8-a5cc-f745e15eee43
 2011-04-28 15:02:31 +00:00
mkanat%bugzilla.org
eeda9a8f58 Bug 633776: Automatic charset detection for text attachments 
r=mkanat, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@262027 18797224-902f-48f8-a5cc-f745e15eee43
 2011-03-09 10:01:49 +00:00
mkanat%bugzilla.org
6453a5f6b5 Bug 607361: Creating an attachment without a "comment" param in the URL causes an internal error 
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@261461 18797224-902f-48f8-a5cc-f745e15eee43
 2010-10-26 18:35:08 +00:00
mkanat%bugzilla.org
a835e1e88c Bug 414509: offer View All (non obsolete) attachments 
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@261327 18797224-902f-48f8-a5cc-f745e15eee43
 2010-10-03 00:01:42 +00:00
mkanat%bugzilla.org
72363488c1 Bug 584110: Don't name attachment files "attachment.txt" by default, because this confuses IE 
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260959 18797224-902f-48f8-a5cc-f745e15eee43
 2010-08-03 23:31:39 +00:00
mkanat%bugzilla.org
4b084bf2f3 Bug 453425 - Send "X-Content-Type-Options: nosniff" header when displaying attachments so IE8 doesn't try to sniff the content type. 
[r=LpSolit a=LpSolit]


git-svn-id: svn://10.0.0.236/trunk@260948 18797224-902f-48f8-a5cc-f745e15eee43
 2010-08-03 18:03:12 +00:00
mkanat%bugzilla.org
a77eb64833 Bug 119703: Create an attachment by pasting it into a text field 
r/a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260809 18797224-902f-48f8-a5cc-f745e15eee43
 2010-07-18 17:31:54 +00:00
mkanat%bugzilla.org
f7fcd61887 Bug 490930: Always store attachments locally if they are over X size (and below some threshold!), don't ever display "Big File" checkbox 
r=mkanat a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260674 18797224-902f-48f8-a5cc-f745e15eee43
 2010-07-08 17:03:37 +00:00
mkanat%bugzilla.org
05f390461e Bug 567846: Modify set_status, set_resolution, and set_dup_id to use 
VALIDATOR_DEPENDENCIES, so that they don't need custom code in set_all.


git-svn-id: svn://10.0.0.236/trunk@260420 18797224-902f-48f8-a5cc-f745e15eee43
 2010-06-03 19:31:22 +00:00
mkanat%bugzilla.org
ecf0f13ce8 Bug 565879: Merge ThrowCodeError("action_unrecognized"), ThrowUserError("no_valid_action") and ThrowCodeError("unknown_action") 
r=ghendricks a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260347 18797224-902f-48f8-a5cc-f745e15eee43
 2010-05-20 15:46:29 +00:00
mkanat%bugzilla.org
e8a9c14a6f Bug 560281: Do not display deleted attachments in "View All" 
a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260327 18797224-902f-48f8-a5cc-f745e15eee43
 2010-05-17 16:47:29 +00:00
mkanat%bugzilla.org
ee678ea1c7 Bug 395451 - "Bugzilla::BugMail needs to use Bug objects internally instead of direct SQL" 
[r=mkanat a=mkanat]


git-svn-id: svn://10.0.0.236/trunk@260272 18797224-902f-48f8-a5cc-f745e15eee43
 2010-05-07 03:47:31 +00:00
mkanat%bugzilla.org
f7e990146a Bug 560009: Use firstidx from List::MoreUtils instead of lsearch 
r=timello, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@260217 18797224-902f-48f8-a5cc-f745e15eee43
 2010-04-22 18:16:55 +00:00
mkanat%bugzilla.org
ea01bb9b51 Bug 556429: Stop sending bugmail from inside the template 
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260155 18797224-902f-48f8-a5cc-f745e15eee43
 2010-04-05 23:32:33 +00:00
mkanat%bugzilla.org
460f5b7053 Bug 365926: Serve attachments without an explicit charset, and let the browser 
decide which charset to use
r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@260066 18797224-902f-48f8-a5cc-f745e15eee43
 2010-03-28 21:18:57 +00:00
lpsolit%gmail.com
5314135502 Bug 532518: Credentials are not checked correctly when viewing one attachment from another bug's alternate host - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@259313 18797224-902f-48f8-a5cc-f745e15eee43
 2009-12-30 14:54:28 +00:00
mkanat%bugzilla.org
7ec4e12560 Bug 162060: Remove the relationship between "votestoconfirm" and whether or not the UNCONFIRMED status is available, by adding a checkbox to enable the UNCONFIRMED status in editproducts.cgi. 
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259248 18797224-902f-48f8-a5cc-f745e15eee43
 2009-12-17 23:31:56 +00:00
mkanat%bugzilla.org
ae8a434e67 Bug 526734: Allow localization of the "From update of attachment" string in comments 
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259210 18797224-902f-48f8-a5cc-f745e15eee43
 2009-12-13 20:56:45 +00:00
mkanat%bugzilla.org
4af90d4d96 Bug 452919: Allow the "created an attachment" message in comments to be localized 
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@259167 18797224-902f-48f8-a5cc-f745e15eee43
 2009-12-04 14:28:49 +00:00
mkanat%bugzilla.org
a200d47ff2 Bug 523495: Re-work attachment.cgi and the general attachment_base-checking code to prevent an infinite redirect loop when ssl_redirect is on and Bugzilla has an attachment_base set. 
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258772 18797224-902f-48f8-a5cc-f745e15eee43
 2009-10-24 05:22:46 +00:00
mkanat%bugzilla.org
4f5ccb8607 Bug 509053: Implement Bugzilla->feature (feature_enabled in the templates), and use it to detect when PatchReader is available. 
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258543 18797224-902f-48f8-a5cc-f745e15eee43
 2009-09-30 22:39:32 +00:00
mkanat%bugzilla.org
5401e2915d Bug 328628: When attachments have UTF-8 characters in their name, they will now be downloaded with the correct name. 
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=Wurblzap, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@258530 18797224-902f-48f8-a5cc-f745e15eee43
 2009-09-30 08:53:25 +00:00
lpsolit%gmail.com
c8326196b1 Bug 140999: Users without edit permissions for an attachment should still be able to make comments - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@258513 18797224-902f-48f8-a5cc-f745e15eee43
 2009-09-28 17:24:41 +00:00
mkanat%bugzilla.org
992afafa72 Bug 509045: Make "use_keywords" a global template variable instead of having to pass it to templates all the time 
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit


git-svn-id: svn://10.0.0.236/trunk@258054 18797224-902f-48f8-a5cc-f745e15eee43
 2009-08-11 04:34:22 +00:00
lpsolit%gmail.com
300f2f05d6 Bug 305993: The requestee field may be omitted even when a requestee is already set - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@257955 18797224-902f-48f8-a5cc-f745e15eee43
 2009-08-06 02:18:51 +00:00
lpsolit%gmail.com
8872215623 Bug 415541: Implement $bug->set_flags() and $attachment->set_flags() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@257948 18797224-902f-48f8-a5cc-f745e15eee43
 2009-08-05 12:36:22 +00:00
lpsolit%gmail.com
d4333b5e80 Bug 486685: MIME type override for attachments lost in HTTP redirect - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wicked a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@256923 18797224-902f-48f8-a5cc-f745e15eee43
 2009-04-15 09:49:44 +00:00
lpsolit%gmail.com
843d034307 Bug 454251: Implement Bugzilla::Attachment->create() and $attachment->update() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit (module owner) 
git-svn-id: svn://10.0.0.236/trunk@256870 18797224-902f-48f8-a5cc-f745e15eee43
 2009-04-09 11:38:01 +00:00
reed%reedloden.com
8260f06e70 Bug 477420 - "Rename some of the token names used in attachment.cgi" [p=reed r=LpSolit a=LpSolit] 
git-svn-id: svn://10.0.0.236/trunk@256775 18797224-902f-48f8-a5cc-f745e15eee43
 2009-03-31 19:59:27 +00:00
reed%reedloden.com
8cd83e6fd7 Bug 476603 - "[SECURITY] Editing attachments doesn't have any CSRF protection" [p=reed r=LpSolit a=LpSolit] 
git-svn-id: svn://10.0.0.236/trunk@256756 18797224-902f-48f8-a5cc-f745e15eee43
 2009-03-30 21:03:50 +00:00
lpsolit%gmail.com
054bb4fdd3 Bug 472206: [SECURITY] Bugzilla should optionally not allow the user to view possibly harmful attachments - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat r=justdave a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@256027 18797224-902f-48f8-a5cc-f745e15eee43
 2009-02-02 19:12:26 +00:00
lpsolit%gmail.com
0c29cf31b2 Bug 38862: [SECURITY] attachments should be at a different hostname - Patch by Byron Jones <bugzilla@glob.com.au> and Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@256018 18797224-902f-48f8-a5cc-f745e15eee43
 2009-02-02 18:26:26 +00:00
lpsolit%gmail.com
edb686a4a0 Bug 467171: Editing attachments doesn't update the Last-Modified bug timestamp - Patch by A.A. Shimono <shimono@mozilla.gr.jp> r/a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@255552 18797224-902f-48f8-a5cc-f745e15eee43
 2008-12-17 15:07:28 +00:00
mkanat%bugzilla.org
1d59fd5f61 Bug 452734: Remove the keyword chooser, because it's a usability regression 
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=mkanat


git-svn-id: svn://10.0.0.236/trunk@254284 18797224-902f-48f8-a5cc-f745e15eee43
 2008-09-17 23:49:08 +00:00
lpsolit%gmail.com
4b7fde17a0 Bug 388251: Implement 'new Bugzilla::Attachment' - Patch by Frédéric Buclin <LpSolit@gmail.com> a=LpSolit 
git-svn-id: svn://10.0.0.236/trunk@254105 18797224-902f-48f8-a5cc-f745e15eee43
 2008-09-08 17:13:37 +00:00
lpsolit%gmail.com
8a584b1d0c Bug 453743: Decrease the number of calls to the DB about flags when viewing a bug - Patch by Frédéric Buclin <LpSolit@gmail.com> r/a=mkanat 
git-svn-id: svn://10.0.0.236/trunk@254102 18797224-902f-48f8-a5cc-f745e15eee43
 2008-09-08 16:23:46 +00:00