148 Commits

Author SHA1 Message Date
myk%mozilla.org
8382a27dc5 Fix for bug 103778: Rewrites and templatizes buglist.cgi.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv


git-svn-id: svn://10.0.0.236/trunk@116392 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-12 13:55:07 +00:00
bbaetz%student.usyd.edu.au
88e73ded84 Backing out a bit I didn't mean to check in as part of bug 119657. Oops.
git-svn-id: svn://10.0.0.236/trunk@115633 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-02 02:44:51 +00:00
bbaetz%student.usyd.edu.au
a0bfcec93b Bug 127318 - push UserInGroup to templates
r=jake x 2


git-svn-id: svn://10.0.0.236/trunk@115557 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-01 06:01:12 +00:00
bbaetz%student.usyd.edu.au
64e009df7b Bug 119657 - template error checking
r=gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@115556 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-01 05:57:43 +00:00
gerv%gerv.net
c777c794ee Bug 115369 - templatise long_list.cgi.
git-svn-id: svn://10.0.0.236/trunk@114974 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-19 23:22:24 +00:00
justdave%syndicomm.com
b74c77bfa4 Fix for bug 125516: the recent fix for emails truncating when a period occurred on a line by itself broke Exim because it
needs the -t and -i as separate parameters instead of stacked (the original patch had -ti)
Patch by Tobias Burnus <burnus@gmx.de>
r= justdave, gerv


git-svn-id: svn://10.0.0.236/trunk@114723 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-17 08:22:31 +00:00
bbaetz%student.usyd.edu.au
1edd210910 Bug 110013 - templatize describecomponents.cgi
r=gerv, afranke


git-svn-id: svn://10.0.0.236/trunk@114463 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-14 01:25:25 +00:00
justdave%syndicomm.com
0981d9555c Backing out checkin for bug 115369, it's busted on Perl 5.00503.
git-svn-id: svn://10.0.0.236/trunk@114403 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 17:25:02 +00:00
justdave%syndicomm.com
551166c6d8 Fix for bug 115369: Templatization of long_list.cgi
Patch by Gervase Markham <gerv@mozilla.org>
r= bbaetz, dkl


git-svn-id: svn://10.0.0.236/trunk@114395 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 15:34:36 +00:00
bbaetz%student.usyd.edu.au
5bd31d7e20 Bug 97471 - The assignee and qa contact should always be able to see their
bugs
r=justdave, afranke


git-svn-id: svn://10.0.0.236/trunk@114371 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 03:05:15 +00:00
bbaetz%student.usyd.edu.au
8018723bcc Bug 100094 - use generic template handling code
r=mattyt, afranke


git-svn-id: svn://10.0.0.236/trunk@114368 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 02:27:24 +00:00
justdave%syndicomm.com
686d81fb26 Fix for bug 117055: Emails were being truncated if they contained a line with nothing but a period on them. We now pass -i to
sendmail and its clones to tell it to ignore periods (since we close the pipe when we're done, rather than signalling it with
a period).  Has been tested with sendmail and postfix.
Patch by Dave Miller <justdave@syndicomm.com>
r= afranke, bugzilla@bkor.dhs.org, jake


git-svn-id: svn://10.0.0.236/trunk@113739 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-06 02:47:00 +00:00
bbaetz%student.usyd.edu.au
e20fe58870 Bug 95732 - remove logincookies.cryptpassword, and invalidate cookies from
the db when required instead.
(Also fixes bug 58242 as a side effect)

r=myk, kiko


git-svn-id: svn://10.0.0.236/trunk@113598 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 12:23:05 +00:00
myk%mozilla.org
f89a91a9e4 Fix for bug 121747: Stops every script before it does anything else if Bugzilla is currently shut down. Also adds global template
instantiation code to globals.pl.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv,kiko


git-svn-id: svn://10.0.0.236/trunk@113573 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-03 09:28:48 +00:00
myk%mozilla.org
3bad919c98 Fix for bug 104521: Removes old attachment interface in favor of new attachment tracker.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,kiko


git-svn-id: svn://10.0.0.236/trunk@113204 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-30 14:14:12 +00:00
bbaetz%student.usyd.edu.au
7f8c1e8eec Bug 121074 - taint error after changing bug
r=daa@distributed.net,jake


git-svn-id: svn://10.0.0.236/trunk@112518 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-22 15:12:11 +00:00
bbaetz%student.usyd.edu.au
34d34e045d Bug 98368 - dbi connect doesn't use db_port option.
Patch by gene.stuckey@tellabs.com, r=bbaetz,justdave


git-svn-id: svn://10.0.0.236/trunk@112517 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-22 06:49:22 +00:00
justdave%syndicomm.com
c148fadef8 Fix for bug 108982: enable taint mode for all user-facing CGI files.
Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave


git-svn-id: svn://10.0.0.236/trunk@112490 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-20 01:44:52 +00:00
zach%zachlipton.com
78c6d67164 Fix for bug 113646, midair when changing assignee gives error. Fix changes sub trim() in globals.pl not to use $_ so as not to conflict with $_ values allready
set.

Patch by myk@mozilla.org, r1=bbaetz, r2=dave.


git-svn-id: svn://10.0.0.236/trunk@110600 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-17 01:29:52 +00:00
matty%chariot.net.au
2ddf8be3ca Bug 104677 : Votes field (text style) on showvotes.cgi defaults to size 5, not natural size and doesn't include a maxlength attribute.
Patch by Christoper Aillon <caillon@returnzero.com>.


git-svn-id: svn://10.0.0.236/trunk@108373 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 10:29:55 +00:00
bbaetz%cs.mcgill.ca
eb246d5306 Bug 101560, pt 2. Perl 5.00503 gives a (bogus?) warning which 5.6 doesn't.
Quote manually rather than using qw to get arround this


git-svn-id: svn://10.0.0.236/trunk@108365 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 07:57:25 +00:00
bbaetz%cs.mcgill.ca
3bc2957b7a Bug 101560 - clear some more env vars so that system calls will run in
taint mode. The perforce integration stuff needs this.

r=gerv,mattyt


git-svn-id: svn://10.0.0.236/trunk@108362 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-17 07:19:46 +00:00
jake%acutex.net
9b3a845780 Fix for bug 86300 - If a bug didn't exist and GetBugLink() tried to create a tooltip for it, you'd get uninitialized variables warnings in your error log. This path also introduces a cache so if the same bug # is mentioned more than once during the same running of the script, it only has to query the database once.
r= mattyt, gerv


git-svn-id: svn://10.0.0.236/trunk@107921 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-12 13:43:59 +00:00
bbaetz%cs.mcgill.ca
59af65fd2f Fixed "used only once" warning coming from my patch for bug 97469. The
warning was hidden from the tests by bug 106424.

r=Jake, no 2nd review needed.


git-svn-id: svn://10.0.0.236/trunk@106195 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-24 20:33:49 +00:00
bbaetz%cs.mcgill.ca
cced8d8047 Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.

Also fxed bug 101560, by clearing BASH_ENV

r=myk,justdave


git-svn-id: svn://10.0.0.236/trunk@106051 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-23 15:44:53 +00:00
jake%acutex.net
6556ad04b0 Bug 71840 - Make comments referenceable using a #c4 to get the fourth comment.
Patch by Gerv <gerv@mozilla.org> and Myself.
r= jake@acutex.net, gerv@mozilla.org, justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@105883 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-20 13:03:14 +00:00
jake%acutex.net
5fcb9d6a75 Backing out previous change, the wrong patch got checked in.
git-svn-id: svn://10.0.0.236/trunk@105882 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-20 12:59:57 +00:00
gerv%gerv.net
ffb874519d Bug 71840 - make comments referenceable. Patch by gerv/jake. r=justdave, jake/gerv.
git-svn-id: svn://10.0.0.236/trunk@105863 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-20 01:06:59 +00:00
jake%acutex.net
692e3604f8 Bug 73180 - We now put a notice at the top of the versioncache file saying that it should not be edited.
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@105856 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-19 23:49:37 +00:00
gerv%gerv.net
028982971c Bug 57819 - change the size of the bit we print in the large error case. r=justdave.
git-svn-id: svn://10.0.0.236/trunk@105379 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-14 01:34:08 +00:00
justdave%syndicomm.com
d27f46ad1e Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@105335 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 01:36:17 +00:00
justdave%syndicomm.com
f9578f1b9e Backing out Gerv's checkin for bug 71840. Per the bug report, it did not have proper review first, and myk objected to what
got landed on irc.


git-svn-id: svn://10.0.0.236/trunk@105249 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-12 03:03:00 +00:00
gerv%gerv.net
c73af2e1df Bug 71840 - Make comments referenceable. Patch by gerv; r=myk, jake (ish :-).
git-svn-id: svn://10.0.0.236/trunk@105220 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-11 23:07:54 +00:00
gerv%gerv.net
1c91e195e0 Bug 57819 - cut down large mysql error strings. Patch by n_hibma@qubesoft.com, r=gerv.
git-svn-id: svn://10.0.0.236/trunk@105209 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-11 21:58:07 +00:00
justdave%syndicomm.com
972f8cb409 Fix for bug 82809: comments in bugs no longer have &#013; where the linefeeds should be.
Patch by Dave Miller <justdave@syndicomm.com>
r= timeless@mac.com (no 2nd review needed)


git-svn-id: svn://10.0.0.236/trunk@104532 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-03 07:49:19 +00:00
jake%acutex.net
b176facdc0 Fix for bug 30731 - Reassigning closed bugs from the mass change page caused their status to be set to new.
r= myk@mozilla.org, zach@zachlipton.com


git-svn-id: svn://10.0.0.236/trunk@102955 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-14 21:50:08 +00:00
jake%acutex.net
67916924a4 Fix for bug 42810 - Bugzilla would choke if your product name contained a ' mark.
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com, caillon@returnzero.com


git-svn-id: svn://10.0.0.236/trunk@102132 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-31 23:51:35 +00:00
justdave%syndicomm.com
9ad00e307b Bumping version to 2.15 for development
git-svn-id: svn://10.0.0.236/trunk@101972 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-29 21:41:50 +00:00
justdave%syndicomm.com
3c6be8b594 moving version to 2.14 (golden) to roll the tarball.
git-svn-id: svn://10.0.0.236/trunk@101962 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-29 19:52:13 +00:00
justdave%syndicomm.com
064b8f00e6 All code patches targetted for 2.14 have been checked in. Bumping version
number to 2.14rc to indicate release candidate status.


git-svn-id: svn://10.0.0.236/trunk@101816 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-26 23:06:45 +00:00
jake%acutex.net
a4afec26d3 Fix for bug 95634 - Improvements to Param('voteremovedmail')
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@101782 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-25 00:12:12 +00:00
myk%mozilla.org
9d8541adf1 Fix for bug 95890: Correctly convert/record keyword changes in the bugs_activity table for keywords containing a plus sign or other
regular expression meta-characters.  Myk's first ever Bugzilla checkin!
Patch by Dave Miller <justdave@syndicomm.com> and Myk Melez <myk@mozilla.org>.
r=myk@mozilla.org,justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@101424 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-19 18:26:21 +00:00
justdave%syndicomm.com
b777352072 Fix for bug 92593: Changing a bugs product will no longer remove the votes from that bug unless the number of votes for a given user is beyond what is allowed per-bug on the new product. Only the per-bug vote count is checked. If the user is beyond the per-product vote limit for the new product, it is left alone, on the theory that it's better to preserve the votes on the bug. The user will be forced to reduce their votes to fit the product limit the next time they try to vote on something.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@101167 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-16 02:46:15 +00:00
justdave%syndicomm.com
ee2d742219 Re-fix for bug 95082: allow syncshadowdb to continue to make queries while Bugzilla is shut down.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@101066 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-15 02:38:02 +00:00
jake%acutex.net
8d75bc0860 Fix for bug 95082 - Param('shutdownhtml') doesn't completely shut down bugzilla.
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100921 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-13 19:11:35 +00:00
justdave%syndicomm.com
740ffa66b6 Fix for bug 94618: remove restrictions on valid characters in passwords. If crypt() takes it, why shouldn't we?
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100861 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-11 01:51:05 +00:00
zach%zachlipton.com
c8d61a878f fix for bug 66235: process_bug.cgi: multiple product change misses the groupset bit. Patch by Myk <myk@mozilla.org> r=Jake, oh, and it's my first checkin, yahoo!
git-svn-id: svn://10.0.0.236/trunk@100858 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-11 01:18:24 +00:00
jake%acutex.net
559c643f79 Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99648 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-20 15:18:30 +00:00
justdave%syndicomm.com
a32206490b Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99057 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-11 05:29:21 +00:00
justdave%syndicomm.com
18d9089fcc Fix for bug 87701: Invalid username in bug changes echoed back without escaping HTML data
Patch by Gervase Markham <gervase.markham@univ.ox.ac.uk>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@98634 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-04 07:06:00 +00:00