307 Commits

Author SHA1 Message Date
sfraser%netscape.com
a65a684b15 WIP for 18395, various editor command handling and updating changes. r=akkana
git-svn-id: svn://10.0.0.236/trunk@58123 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-18 21:50:15 +00:00
jfrancis%netscape.com
de4c509f39 fix for 21412 - backspace wouldn't remove list items in html editor.
In addition some improvements were made to the adjustment of selection after an edit action (example: backspacing through a list item now pops you up to the previous item)


git-svn-id: svn://10.0.0.236/trunk@58013 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-17 12:41:34 +00:00
jfrancis%netscape.com
3384856d4f * fixed 19596;
* fixed 23597;
* fixed deletion bug that could cause to breaks to be deleted instead of one, when backspacing once. (no #)
* partial fix for current paragraph style not being properly reported in the composer toolbar.  (no #)


git-svn-id: svn://10.0.0.236/trunk@57934 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-15 14:29:29 +00:00
mjudge%netscape.com
c252b5c37a small fix for bug23833 r= jfrancis
git-svn-id: svn://10.0.0.236/trunk@57744 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-13 23:56:34 +00:00
kin%netscape.com
394fb406dc We now cut the correct number of characters from the styleValue string.
Fixed bug that prevented us from removing properties starting at the
zeroth position in the string.
r=sfraser@netscape.com


git-svn-id: svn://10.0.0.236/trunk@57736 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-13 23:50:28 +00:00
cmanske%netscape.com
d4e1176a34 Table editing work and fixed bug 21389, r=buster. Added detecting table, row, or cell for setting background color, bug 7992, r=kin. Renamed overloaded GetDocumentTitle to GetDocumentTitleString and set new URL of saved page in webshell, bug 23726, r=mjudge
git-svn-id: svn://10.0.0.236/trunk@57722 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-13 23:33:00 +00:00
jfrancis%netscape.com
861057611a fixed bug 20613 & 21121: both invloved newlines in preformatted text. Layout gives no frames for blanklines caused by newlines, so you cant click or arrow to them. I replace such newlines with breaks now.
fixed 21196: select all no longer selects the special break we use in empty documents (this would cause an invisible selection).

fixed 21430: choosing a new alignment in an empty doc used to do nothing.  Now it works but I've exposed a selection bug inthe process...

fixed 22225: a little unintended re-entrancy caused multiple breaks to be inserted in empty table cells when doc read in.


git-svn-id: svn://10.0.0.236/trunk@57668 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-13 10:17:35 +00:00
jfrancis%netscape.com
e7ca3cd894 fix for bug 23595: lines permuted by forward delete of a break. one line fix - some misordered parameters.
git-svn-id: svn://10.0.0.236/trunk@57495 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-12 02:20:24 +00:00
pp%ludusdesign.com
b5787cf895 Converting usage of ::GetIID() to NS_GET_IID().
Bug #20232, r=scc@netscape.com


git-svn-id: svn://10.0.0.236/trunk@57423 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-11 20:49:15 +00:00
jfrancis%netscape.com
a1fc60d62e fixing VC5 build (missing return value)
git-svn-id: svn://10.0.0.236/trunk@57325 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-11 01:25:00 +00:00
jfrancis%netscape.com
fdee474e64 fix for 11994, an IME bug. (accidentally left out of prior checkin)
git-svn-id: svn://10.0.0.236/trunk@57273 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-10 10:20:51 +00:00
jfrancis%netscape.com
8f19524dca added in some rules code for mail quoting. This
fixes bug: 19979   (extra blank line showing up in
mail that has quotes)

partial progress on block transformation work:
unlisting a list now works mostly correctly again,
instead of merging all the former list items into
one run of text (no bug number).

Moz-br's are now added in one more circumstance:
when you have a br at the end of some inline
content that is followed by a new block (like a
list, table, etc.).  This is needed for the same
reason that the other moz-br's are: to generate a
blank line that the user expects after hitting
return. (no bug number)

DTD-related work to enable the editor to check if
you should be able to type given the current
selection.

fixed bug 22944: inserting an <A> in a table
splits the table.

Made some progress on text paste performance, but
it's still too slow.  That's 19273, which I'm
leaving open

fixed bug 15258:  selection capable of getting out
of the body element.

fixed a bug where code that merged adjacent text
nodes would merge the non-editable "formatting"
textnodes, (no bug number).  Added code to prevent
selection from ending up inside a non-editable
text node.

fix for 11994, an IME bug.


git-svn-id: svn://10.0.0.236/trunk@57272 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-10 10:13:58 +00:00
akkana%netscape.com
740c96ed62 23169: Fix uninitialized variables, including one which was disallowing splitting lines by hitting return. r=jfrancis
git-svn-id: svn://10.0.0.236/trunk@57018 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-06 22:35:04 +00:00
jfrancis%netscape.com
c6690138e4 fixing warnings
git-svn-id: svn://10.0.0.236/trunk@56868 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-06 00:16:18 +00:00
jfrancis%netscape.com
150dc1a9ce continuing the war on the Case Of The Happy Caret
git-svn-id: svn://10.0.0.236/trunk@56838 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-05 12:24:10 +00:00
akkana%netscape.com
5bf44a084f 22655: add API to allow specifying charset when inserting/quoting html. r=rhp
16015: Add API and implementation for delete-to-beginning (^U). r=slamm,rhp
490: Insert formatting newlines when inserting new nodes. r=rhp


git-svn-id: svn://10.0.0.236/trunk@56743 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-04 20:38:12 +00:00
jfrancis%netscape.com
11faed23b2 Fix for bug 21346.
This is actually a major reworking of how the low level editor txns perturb selection.  There is a mode now for telling the txns not to disturb the selection.  There is also a fix for unlisting lists (sometimes list items got merged unintentionally when unlisting).


git-svn-id: svn://10.0.0.236/trunk@56714 18797224-902f-48f8-a5cc-f745e15eee43
2000-01-04 03:09:41 +00:00
bryner%uiuc.edu
47ec5d971a Changing a char array to a PRUnichar array, to fix a build
warning. r=sspitzer.


git-svn-id: svn://10.0.0.236/trunk@56593 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-29 03:45:26 +00:00
cmanske%netscape.com
74a5d53339 Fixed bug 22072, loading style sheet in editor. a=jar, r=brade
git-svn-id: svn://10.0.0.236/trunk@56459 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-22 23:57:04 +00:00
kin%netscape.com
c36783f984 Changed write string for "paragraphFormat" to "SetParagraphFormat()"
to get log playback working again.
r=buster@netscape.com,cmanske@netscape.com  a=don@netscape.com


git-svn-id: svn://10.0.0.236/trunk@56393 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-22 19:44:00 +00:00
kin%netscape.com
eeeeaca1e6 Fix for bug #21683: [dogfood] Can't set focus to end of reply message to type
Added beginRulesSniffing local variable.
r=jfrancis@netscape.com a=chofmann@netscape.com


git-svn-id: svn://10.0.0.236/trunk@56073 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-16 00:59:08 +00:00
akkana%netscape.com
130dea903e 21534 (part of 18033 and 18046): handle delete word and to-end functionality
outside of any selection batching (didn't work when inside a batch).
r=jfrancis; part of Mike's 18046 fixes which are a=chofmann.


git-svn-id: svn://10.0.0.236/trunk@55995 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-14 23:07:12 +00:00
jfrancis%netscape.com
af51a3ae47 fixes for bug 21030. again. really.
21030: html mail reply won't quote original message
r=kin; a=brendan


git-svn-id: svn://10.0.0.236/trunk@55870 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-10 23:16:02 +00:00
ftang%netscape.com
236069891b fix bug 19358 r=jfrancis add IME force commit for Undo,SelectAll and Paste
git-svn-id: svn://10.0.0.236/trunk@55818 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-09 22:37:36 +00:00
jfrancis%netscape.com
26e8a2307e fixes for bug 21158 and 21030.
21158: aplying text style deletes text
21030: html mail reply won't quote original message
r=kin; a=chofmann


git-svn-id: svn://10.0.0.236/trunk@55808 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-09 21:12:16 +00:00
ftang%netscape.com
c02259352d fix bug 12090 19358. Implement ForceCompositionEnd and add it in the beginning of AddInlineProperty/RemoveInlineProperty/InsertElement/InsertHTML
git-svn-id: svn://10.0.0.236/trunk@55702 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-08 03:39:36 +00:00
jfrancis%netscape.com
edba5add24 fix for 20457: deletion in editor pretty darn screwy. Lots of changes to improve this. Document modifying entry points in editor now go thru a standard sandwich, which allows tracking of what changed in the doc, which allows proper post-processing of what changed. Also, all deletions now go thru the rules code, if applicable. Also some bugs in tracking the changed document portion have been fixed. Finally selection setting after a delete is improved.
git-svn-id: svn://10.0.0.236/trunk@55568 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-07 08:30:19 +00:00
cmanske%netscape.com
d0dbb9cc6d Finished basic table editing (bug 6256) r=mjudge. Fixed XUL so debug-only plain text editor works. r=akkana
git-svn-id: svn://10.0.0.236/trunk@55498 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-07 01:12:10 +00:00
jfrancis%netscape.com
c211707ae9 fix for bug 19130 - hitting escape during ime entry can leave editor without a caret. r=kin
git-svn-id: svn://10.0.0.236/trunk@55324 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-05 00:29:34 +00:00
cmanske%netscape.com
9ee1970a3d Finished fix for 13695 (r=danm), basic table editing (bug 6256): cpp r=mjudge, related UI work r=brade
git-svn-id: svn://10.0.0.236/trunk@55260 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-04 01:46:23 +00:00
vidur%netscape.com
a68ed6e2a5 For bug 17325. Changed signature of css loader methods. R=nisheeth.
git-svn-id: svn://10.0.0.236/trunk@55253 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-04 01:29:18 +00:00
cmanske%netscape.com
145c2179d6 Fixed bugs 18529, 20289; lots of progress on table editing (bug 6256). Other UI fixes: New color picker UI, added more missing menu items such as align, increase/decrease indent; moved 'Choose File' button to overlay to share by Image, Link, etc. dialogs. r=sfraser,akkana
git-svn-id: svn://10.0.0.236/trunk@54937 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-01 22:20:50 +00:00
jfrancis%netscape.com
145139b012 * fix for PDT+ 16481: need rules for deleting in tables
* fix for 19395: protect against zero length text inserts
r = floppy moose


git-svn-id: svn://10.0.0.236/trunk@54907 18797224-902f-48f8-a5cc-f745e15eee43
1999-12-01 14:32:55 +00:00
jfrancis%netscape.com
c3b10ef137 fix for bug 20205: selection was getting jerked around by whitespace conversion code.
git-svn-id: svn://10.0.0.236/trunk@54765 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-30 21:58:37 +00:00
warren%netscape.com
51881fbcea Landing no_neckoutil2_branch. Bug #11159. Removes neckoutil_s.lib from build which helps beos and openvms.
git-svn-id: svn://10.0.0.236/trunk@54722 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-30 04:50:42 +00:00
akkana%netscape.com
9da43ace6b 18714: make InsertAsQuotation methods leave the insert point after, and outside, the node that was inserted. r=rhp
git-svn-id: svn://10.0.0.236/trunk@54592 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-29 21:15:57 +00:00
jfrancis%netscape.com
ed38a43f75 * ported the html editor work for the "caret doesn't move when i hit return" bug (16715) back to the plaintext editor.
* fixed a paste/rules interaction problem (19367)
* introduced an init time pass over html documents to populate empty list items and table cells with special breaks so that the user can click in them and actually get a caret
* fixed some warnings
r = floppy moose


git-svn-id: svn://10.0.0.236/trunk@54561 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-29 08:28:46 +00:00
jfrancis%netscape.com
ba25bda682 cool! i cant believe it's not butter! (how did the mac ever compile this?)
fixing bizarre cut/paste error.


git-svn-id: svn://10.0.0.236/trunk@54470 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-25 01:34:42 +00:00
jfrancis%netscape.com
bd6345ff1b fixing bad comptr usage (also not caught by mac compiler)
git-svn-id: svn://10.0.0.236/trunk@54468 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-25 00:39:55 +00:00
jfrancis%netscape.com
efe6e42352 fixing bad const in interface (not caught by mac compiler)
git-svn-id: svn://10.0.0.236/trunk@54466 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-25 00:36:34 +00:00
jfrancis%netscape.com
5020ab053b implemented a system to track what portion of a document is affect by an editor action. Used that system to help solve extensive whitespace handling problems, ans also problems with caret placement in response to returns (this lattter fix for html editors only - plaintext coming later). Fixed numerous list bugs involving outdenting, unlisting, and splitting lists.
Checkin addressees these bugzilla bugs:
2073 & 12337 - whitespace trouble when typing (you can end up with all nbsp's instead of spaces)


git-svn-id: svn://10.0.0.236/trunk@54463 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-25 00:19:45 +00:00
akkana%netscape.com
bcb564f007 19610: Change InsertAsQuotation API to return inserted node r=rhp
git-svn-id: svn://10.0.0.236/trunk@54423 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-24 20:48:59 +00:00
nisheeth%netscape.com
f03cdb6370 Fix for bug 17937. nsHTMLEditor::DeleteSelectionAndCreateNode() wasn't addref'ing an out parameter. r=sfraser.
git-svn-id: svn://10.0.0.236/trunk@54121 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-22 00:01:18 +00:00
akkana%netscape.com
f524df3661 Improve the problem of excessive whitespace around <pre> quotes in
plaintext mail (r=mcafee).
Also, 19237: an initial fix for html quoting (html source being
inserted outside the blockquote).


git-svn-id: svn://10.0.0.236/trunk@53894 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-18 19:43:14 +00:00
sspitzer%netscape.com
7fe343ca94 fix for blocker bug #19083, compose html message causes a crash.
r=sfraser.


git-svn-id: svn://10.0.0.236/trunk@53789 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-17 22:34:41 +00:00
brade%netscape.com
44627def1e fix bug 18892 (r=kin@netscape.com); change constant to PRUnichar
git-svn-id: svn://10.0.0.236/trunk@53651 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-16 14:40:11 +00:00
cmanske%netscape.com
fc50750177 Partial fix for 14344(Page Properties) and 18774(Increase/Decrease Font Size). Fixed 18234 (move Advanced Edit button), 18485 (don't prompt for title with Save As), 16714 (undefined value for para. property combobox) and 18494 (add filename to window caption). Improved Image Properties dialog and CSS style for toolbars. Added new Composer icons. r=sfraser
git-svn-id: svn://10.0.0.236/trunk@53428 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-13 16:37:58 +00:00
akkana%netscape.com
9d3b32781e 18576: Enclose plaintext replies in a <pre> so they don't get wrapped,
and add appropriate edit rules to split pre tags when editing plaintext.
r=sfraser


git-svn-id: svn://10.0.0.236/trunk@53381 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-13 00:26:45 +00:00
kin%netscape.com
e17664b119 TransactionManager fix for bug #11590: eliminate NS_COMFALSE
Modified all nsITransactionListener::Will* methods and implementations
to use an aInterrupt argument.

    mozilla/editor/base/nsEditorTxnLog.cpp
    mozilla/editor/base/nsEditorTxnLog.h
    mozilla/editor/txmgr/public/nsITransactionListener.h
    mozilla/editor/txmgr/src/nsTransactionItem.cpp
    mozilla/editor/txmgr/src/nsTransactionManager.cpp
    mozilla/editor/txmgr/src/nsTransactionManager.h

r=brade@netscape.com


git-svn-id: svn://10.0.0.236/trunk@53220 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-11 19:35:40 +00:00
buster%netscape.com
5765c7e4da partial fix for bug 14599. We no longer crash. The frameset loads in the editor window,
but no editor is actually attached, so no editing is possible.  Next step is
to detect the error case and stop the document load altogether.


git-svn-id: svn://10.0.0.236/trunk@53219 18797224-902f-48f8-a5cc-f745e15eee43
1999-11-11 19:22:30 +00:00