mkanat%kerio.com
0830f4190a
Bug 287109: [SECURITY] Names of private products/components can be exposed on certain CGIs
...
Patch By Frederic Buclin <LpSolit@gmail.com> r=myk, r=joel, a=justdave
git-svn-id: svn://10.0.0.236/trunk@173309 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-12 02:07:10 +00:00
lpsolit%gmail.com
c816b055f0
Bug 287487: User with no privs can not add comments to bugs that have a deadline field set - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
...
git-svn-id: svn://10.0.0.236/trunk@173265 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-10 20:30:13 +00:00
lpsolit%gmail.com
63a5361ea2
Bug 286160: possible invalid flag types when moving a bug to a different product - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
...
git-svn-id: svn://10.0.0.236/trunk@173142 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-06 21:43:33 +00:00
lpsolit%gmail.com
e70ec4c9bc
Bug 248386: Add support for Alias to post_bug.cgi - Patch by Albert Ting <altlst@sonic.net> r=LpSolit a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@172998 18797224-902f-48f8-a5cc-f745e15eee43
2005-05-03 18:44:54 +00:00
lpsolit%gmail.com
b03d86aeac
Bug 272623: FindWrapPoint is misplaced in process_bug.cgi - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
...
git-svn-id: svn://10.0.0.236/trunk@172442 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-19 17:55:10 +00:00
lpsolit%gmail.com
a58231e5fb
Bug 225818: %FORM, %MFORM, and %COOKIE need to go away, in favor of the CGI methods - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=myk
...
git-svn-id: svn://10.0.0.236/trunk@171914 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-09 23:18:18 +00:00
lpsolit%gmail.com
2b2e8cf907
Bug 199048: Preference option to reverse sort the comments stack - Patch by Shane H. W. Travis <shane.h.w.travis@gmail.com> r=mkanat a=myk
...
git-svn-id: svn://10.0.0.236/trunk@171903 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-09 00:37:52 +00:00
lpsolit%gmail.com
9ae2e5d0a4
Bug 238876: remove %FORM from process_bug.cgi - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@171880 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-08 00:45:47 +00:00
lpsolit%gmail.com
5251cf02ed
Bug 287947: Change CheckFormField/CheckFormFieldDefined subs in CGI.pl to use CGI object instead FORM hash - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=myk
...
git-svn-id: svn://10.0.0.236/trunk@171874 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-07 23:52:20 +00:00
lpsolit%gmail.com
6d78cc1d1b
Bug 238878: Make hidden-fields template, User Matching and Flags use direct CGI instead of [% form.foo %] - Patch by Teemu Mannermaa <wicked@etlicon.fi> r=LpSolit a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@171870 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-07 23:37:56 +00:00
mkanat%kerio.com
833b2e61f6
Bug 286235: Implicit joins should be replaced by explicit joins - installment A
...
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=joel, a=myk
git-svn-id: svn://10.0.0.236/trunk@171610 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 21:52:06 +00:00
lpsolit%gmail.com
1dd5f8d38c
Bug 288883: SQL crash when granting/denying a request - Patch by Frederic Buclin <LpSolit@gmail.com> r=joel a=justdave
...
git-svn-id: svn://10.0.0.236/trunk@171579 18797224-902f-48f8-a5cc-f745e15eee43
2005-04-04 18:40:59 +00:00
lpsolit%gmail.com
79a712368c
Bug 178157: Dependency emails don't get sent for status change during mass change - Patch by Frederic Buclin <LpSolit@gmail.com> r=myk, a=myk
...
git-svn-id: svn://10.0.0.236/trunk@170887 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-18 08:29:47 +00:00
mkanat%kerio.com
abc539470f
Bug 285534: bugs.qa_contact should allow NULL
...
Patch By Max Kanat-Alexander <mkanat@kerio.com> r=joel, a=justdave
git-svn-id: svn://10.0.0.236/trunk@170685 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-15 05:20:48 +00:00
travis%sedsystems.ca
4ed94e13b7
Bug 284896 : QA contact never receives mail when removed from a bug
...
Patch by Olav Vitters <bugzilla-mozilla@bkor.dhs.org> r=justdave, a=justdave
git-svn-id: svn://10.0.0.236/trunk@170532 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-10 19:35:18 +00:00
mkanat%kerio.com
7f1a179da7
Bug 277782: _throw_error should unlock tables when tables are locked, automatically
...
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=travis, r=LpSolit, a=justdave
git-svn-id: svn://10.0.0.236/trunk@170180 18797224-902f-48f8-a5cc-f745e15eee43
2005-03-05 00:18:48 +00:00
travis%sedsystems.ca
3bfdd4d4f2
Bug 283139 : Zero out 'hours remaining' field on certain state transitions r.t. throwing an error saying it's not zeroed out.
...
Patch by Shane H. W. Travis <travis@sedsystems.ca> r=LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@169998 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-28 18:55:07 +00:00
mkanat%kerio.com
de89702d36
Bug 282748: uninitialized value in localtime in Format.pm
...
Patch By Frederic Buclin <LpSolit@gmail.com> r=wurblzap, a=myk
git-svn-id: svn://10.0.0.236/trunk@169818 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-25 03:28:02 +00:00
travis%sedsystems.ca
691455c5d9
Bug 212940 : Can't use an undefined value as an ARRAY reference at /http/bugzilla/process_bug.cgi line 866.
...
Patch by Frederic Buclin <LpSolit@gmail.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@169646 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-23 16:53:24 +00:00
mkanat%kerio.com
fe14d8a2d1
Bug 280497: Replace "LIMIT" with Bugzilla::DB function call
...
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=justdave
git-svn-id: svn://10.0.0.236/trunk@169390 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-18 16:14:27 +00:00
mkanat%kerio.com
a88c76e484
Bug 280503: Replace "LOCK/UNLOCK TABLES" with Bugzilla::DB function call
...
Patch By Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat,a=myk
git-svn-id: svn://10.0.0.236/trunk@169333 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-17 21:57:27 +00:00
mkanat%kerio.com
98056cd489
Bug 281592: "use Bugzilla::RelationSet" in globals.pl and process_bug.cgi is dead code r=vladd, a=myk
...
git-svn-id: svn://10.0.0.236/trunk@169252 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-16 16:14:36 +00:00
travis%sedsystems.ca
81f64817cf
Bug 257315 : type of delta_ts in bugs table should not be timestamp
...
Patch by Tomas Kopal <Tomas.Kopal@altap.cz> r=mkanat, LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@168981 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:51:03 +00:00
travis%sedsystems.ca
8a81a01901
Bug 276838 : Eliminate use of $::unconfirmedstate
...
Patch by Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@168979 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-08 16:22:26 +00:00
travis%sedsystems.ca
64284ff52f
Bug 279740 : Move CountOpenDependencies out of globals.pl
...
Patch by Max Kanat-Alexander <mkanat@kerio.com> r=wurblzap a=justdave
git-svn-id: svn://10.0.0.236/trunk@168643 18797224-902f-48f8-a5cc-f745e15eee43
2005-02-01 17:43:26 +00:00
travis%sedsystems.ca
92492b41de
Bug 279700 : Move GetComments from globals.pl into Bugzilla::Bug
...
Patch by Max Kanat-Alexander <mkanat@kerio.com> r=vladd a=justdave
git-svn-id: svn://10.0.0.236/trunk@168550 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-31 16:32:57 +00:00
justdave%bugzilla.org
2541fed321
Backing out the checking from bug 257315 until it gets corrected. It prevents new bugs from being filed.
...
a=justdave
git-svn-id: svn://10.0.0.236/trunk@168520 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-30 04:22:28 +00:00
travis%sedsystems.ca
e652a2da94
Bug 257315 : type of delta_ts in bugs table should not be timestamp
...
Patch by Tomas Kopal <Tomas.Kopal@altap.cz> r=vladd, LpSolit a=justdave
git-svn-id: svn://10.0.0.236/trunk@168456 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-28 19:01:28 +00:00
travis%sedsystems.ca
cd62d4adef
Bug 218771 : The error message should be more accurate on who can change fields
...
Patch by Frederic Buclin <LpSolit@gmail.com> r=myk a=myk
git-svn-id: svn://10.0.0.236/trunk@168401 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-27 19:17:10 +00:00
travis%sedsystems.ca
b413ed388e
Bug 34488: Add a checkbox to add self to CC list
...
Patch by GavinS <bugzilla@chimpychompy.org> r=vladd, myk a=myk
git-svn-id: svn://10.0.0.236/trunk@168225 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-24 05:26:56 +00:00
travis%sedsystems.ca
0170d97491
Bug 266579 : Users without privs can confirm bugs by assigning to themselves first, without having canconfirm privs
...
Patch by LpSolit@gmail.com r=myk a=justdave
git-svn-id: svn://10.0.0.236/trunk@168095 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-20 23:22:10 +00:00
jocuri%softhome.net
297b1c2147
Patch for bug 103636: Support specifying a date on which a bug is expected to be resolved; patch by Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>, r=jouni, a=myk.
...
git-svn-id: svn://10.0.0.236/trunk@167817 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:36:05 +00:00
jocuri%softhome.net
d11f7f6055
Patch for bug 277622: Move DiffStrings() out of globals.pl into Bugzilla/Util.pm; patch by Max K-A <mkanat@kerio.com>, r=vladd, a=myk.
...
git-svn-id: svn://10.0.0.236/trunk@167812 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-16 13:02:35 +00:00
travis%sedsystems.ca
32d3e62f85
Bug 277621 : Uninitialized value message when changing timetracking fields
...
Patch by Marc Schumann <wurblzap@gmail.com> r=justdave a=justdave
git-svn-id: svn://10.0.0.236/trunk@167734 18797224-902f-48f8-a5cc-f745e15eee43
2005-01-14 16:32:15 +00:00
jake%bugzilla.org
a3ab1de813
Bug 264601 - Bugzilla will now tell a user which field contained an "invalid bug number or alias."
...
Patch by Frédéric Buclin <LpSolit@netscape.net>
r=myk, a=justdave
git-svn-id: svn://10.0.0.236/trunk@166909 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-21 09:04:01 +00:00
jocuri%softhome.net
22e4b3570a
Patch for bug 274236: Variable component overlaps in ThrowCodeError; patch by me, r=wurblzap (Marc), a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@166689 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-14 01:59:59 +00:00
jocuri%softhome.net
aecbadf98b
Patch for bug 271797: avoid making target_milestone empty if usetargetmilestone=1; patch by Frédéric Buclin <LpSolit@netscape.net>, r=justdave, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@166484 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-09 10:49:53 +00:00
jocuri%softhome.net
930f674f5e
Patch for bug 258711: move.pl should honour emailsuffix; patch by Marc Schumann <wurblzap@gmail.com>, r=justdave, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@166321 18797224-902f-48f8-a5cc-f745e15eee43
2004-12-06 17:08:20 +00:00
jocuri%softhome.net
3be7f3bfa1
Patch for bug 267560: CheckCanChangeField in process_bug.cgi shouldn't request the bug owner, QA contact and reporter too many times; patch by Frédéric Buclin <LpSolit@netscape.net>, r=justdave, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@165543 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-20 12:31:04 +00:00
jocuri%softhome.net
8610d5bf4e
Patch for bug 267774: Remove unused variable in process_bug.cgi; patch by Frédéric Buclin <LpSolit@netscape.net>; r=kiko, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@164995 18797224-902f-48f8-a5cc-f745e15eee43
2004-11-05 08:58:03 +00:00
justdave%bugzilla.org
4da516c042
[SECURITY] Bug 252638: It is possible to send a carefully crafted HTTP POST message to process_bug.cgi which will remove keywords from a bug even if you don't have permissions to edit all bug fields (the "editbugs" permission). Such changes are reported in "bug changed" email notifications, so they are easily detected and reversed if someone abuses it.
...
Patch by Myk Melez <myk@mozilla.org>
r=gerv, a=justdave
git-svn-id: svn://10.0.0.236/trunk@164336 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-25 07:20:59 +00:00
justdave%bugzilla.org
46e9d71358
Bug 254498: Check for comment required for time validation was too late.
...
Patch by Tiago R. Mello <tiago@async.com.br>
r=kiko, a=justdave
git-svn-id: svn://10.0.0.236/trunk@164324 18797224-902f-48f8-a5cc-f745e15eee43
2004-10-25 04:49:32 +00:00
bugreport%peshkin.net
cd65dc04d7
Bug 186093: Move CanSeeBug to User.pm and make User.pm usable by templates
...
r=kiko
a=justdave
git-svn-id: svn://10.0.0.236/trunk@160350 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-04 16:17:10 +00:00
jocuri%softhome.net
2336c8c696
Patch for bug 253604: When commit a bug, validate timetracking before user match; patch by Tiago R. Mello <tiago@async.com.br>; r=kiko, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@160268 18797224-902f-48f8-a5cc-f745e15eee43
2004-08-03 06:23:25 +00:00
jocuri%softhome.net
23204eca2d
Patch for bug 253360: replace IF() with CASE WHEN for database compatibility; patch by Tomas Kopal <Tomas.Kopal@altap.cz>; r=vladd, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@160170 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-31 09:36:18 +00:00
kiko%async.com.br
e3ff662f81
Fix for bug 216008: Time Tracking: default values cause change bug
...
errors. Check if the time values haven't actually changed by using integer comparison (instead of string comparison). r=jouni, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160020 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 03:09:10 +00:00
kiko%async.com.br
a89fa3803a
Fix for bug 252789: Empty timetrackinggroup causes error "hours worked
...
needs to be positive" when changing bug. Sanitizing the AddComment bits
in process_bug.cgi to only touch work_time if user is in
timetrackinggroup. Fixes regression introduced in bug 252159.
r=jouni,joel; a=justdave.
git-svn-id: svn://10.0.0.236/trunk@160017 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-29 02:59:11 +00:00
kiko%async.com.br
ce412f90e2
Fix for bug 252159: centralize time validation. Adds a ValidateTime
...
function to Bugzilla::Bug and uses it in relevant callsites. Patch by
Alexandre Michetti Manduca <michetti@grad.icmc.usp.br>. r=kiko, a=justdave.
git-svn-id: svn://10.0.0.236/trunk@159666 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-22 17:48:37 +00:00
kiko%async.com.br
f1789c492a
Fix for bug 251935: Remove $COOKIE from process_bug.cgi. r=joel, a=myk.
...
git-svn-id: svn://10.0.0.236/trunk@159553 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-20 21:25:33 +00:00
gerv%gerv.net
76b9955c30
Bug 240093 - get canconfirm working again. Patch by gerv; r=joel, a=justdave.
...
git-svn-id: svn://10.0.0.236/trunk@159396 18797224-902f-48f8-a5cc-f745e15eee43
2004-07-17 16:09:28 +00:00