129 Commits

Author SHA1 Message Date
bbaetz%student.usyd.edu.au
9ab11b68e6 Bug 118953 - incorrect message from checksetup.pl
patch by bugzilla@ali.as r=bbaetz, justdave


git-svn-id: svn://10.0.0.236/trunk@116785 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-18 06:06:30 +00:00
bbaetz%student.usyd.edu.au
cb033cc810 Bug 129466 - use IP addr (not hostname) in logincookies table
r=gerv, justdave


git-svn-id: svn://10.0.0.236/trunk@116706 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-16 06:03:09 +00:00
myk%mozilla.org
8382a27dc5 Fix for bug 103778: Rewrites and templatizes buglist.cgi.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv


git-svn-id: svn://10.0.0.236/trunk@116392 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-12 13:55:07 +00:00
zach%zachlipton.com
9d9d7f0421 Fix for bug 127524: checksetup.pl fails with XML::Parser error
Patch by Zach Lipton (zach@zachlipton.com) and by Tobias Burnus
(burnus@gmx.de). r=justdave, r2=zach


git-svn-id: svn://10.0.0.236/trunk@115589 18797224-902f-48f8-a5cc-f745e15eee43
2002-03-01 22:40:48 +00:00
justdave%syndicomm.com
18d1efd0f7 Fixing typo in previous checkin.
git-svn-id: svn://10.0.0.236/trunk@114657 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-16 03:04:36 +00:00
justdave%syndicomm.com
8e87b38c01 Fix for bug 125835: Removing an old sarcastic comment from the localconfig generation routine so that it doesn't imply that
using a password is bad.
Patch by James Cox <james@awpimajes.com>
r= justdave x 2


git-svn-id: svn://10.0.0.236/trunk@114656 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-16 02:59:25 +00:00
zach%zachlipton.com
5ab1d5892a Fixing tinderbox bustage. Maybe I need to get more sleep before I commit.
git-svn-id: svn://10.0.0.236/trunk@114481 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-14 04:37:30 +00:00
zach%zachlipton.com
11f8961b68 Was missing an indent from my last fix, fixing it. No r= needed
git-svn-id: svn://10.0.0.236/trunk@114480 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-14 04:34:56 +00:00
zach%zachlipton.com
52eb4e183d Fix for bug 97290: checksetup.pl should report about errors in localconfig
r=kiko x2


git-svn-id: svn://10.0.0.236/trunk@114477 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-14 04:27:50 +00:00
bbaetz%student.usyd.edu.au
5bd31d7e20 Bug 97471 - The assignee and qa contact should always be able to see their
bugs
r=justdave, afranke


git-svn-id: svn://10.0.0.236/trunk@114371 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 03:05:15 +00:00
justdave%syndicomm.com
92bd7a7a44 Fix for bug 99024: checksetup was not giving proper permissions to the contents of the template directory. This patch also
adds an .htaccess file that blocks access to the template folder by the web server.
Patch by Dave Miller <justdave@syndicomm.com>
r= zach x 2


git-svn-id: svn://10.0.0.236/trunk@114357 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-13 01:35:28 +00:00
bbaetz%student.usyd.edu.au
76c31e4bbd Correct date on logincookies schema change.
git-svn-id: svn://10.0.0.236/trunk@114020 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-08 11:16:05 +00:00
zach%zachlipton.com
137895e51f Fix for bug 87398: checksetup.pl should warn if not run as root. Patch
adds a warning if the user has webservergroup set but does not run
checksetup.pl as root.

r1=kiko, r2=justdave


git-svn-id: svn://10.0.0.236/trunk@113610 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 16:38:33 +00:00
bbaetz%student.usyd.edu.au
e20fe58870 Bug 95732 - remove logincookies.cryptpassword, and invalidate cookies from
the db when required instead.
(Also fixes bug 58242 as a side effect)

r=myk, kiko


git-svn-id: svn://10.0.0.236/trunk@113598 18797224-902f-48f8-a5cc-f745e15eee43
2002-02-04 12:23:05 +00:00
myk%mozilla.org
3bad919c98 Fix for bug 104521: Removes old attachment interface in favor of new attachment tracker.
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,kiko


git-svn-id: svn://10.0.0.236/trunk@113204 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-30 14:14:12 +00:00
zach%zachlipton.com
063a9d3b5e Fix for bug 121735: Perl warning running checksetup.pl if a module has a
non-numeric version number. Patch sets checksetup.pl to use a string
compare instead of a numeric one.

Patch by Dave Miller. r1=Bradley Baetz and r2=Gerv


git-svn-id: svn://10.0.0.236/trunk@113002 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-27 18:59:38 +00:00
jake%acutex.net
069219670c Bug 120081 - Bugzilla now requires version 2.06 of the Template Toolkit.
r= bbaetz, justdave


git-svn-id: svn://10.0.0.236/trunk@112371 18797224-902f-48f8-a5cc-f745e15eee43
2002-01-17 01:57:24 +00:00
jake%acutex.net
640a455469 Bug 37339 and Bug 80183 - Adding a sidebar.cgi and index.cgi. The sidebar.cgi can currently be used in Mozilla/Netscape 6 and uses XUL that was originally written by Scott Collins <scc@mozilla.org>. The index.cgi displays both the proper header and footer in the appropriate places. It also changes the links accoding to if you are logged in or not.
r= ddk, kiko


git-svn-id: svn://10.0.0.236/trunk@110402 18797224-902f-48f8-a5cc-f745e15eee43
2001-12-12 22:41:19 +00:00
myk%mozilla.org
81302cc7d8 Fix for bug 109802: Make it clear how to enter mysql passwords with special characters into localconfig.
Patch by Dave Miller <justdave@syndicomm.com>.
r=ddkilzer,louie.


git-svn-id: svn://10.0.0.236/trunk@108949 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-27 00:49:26 +00:00
bbaetz%cs.mcgill.ca
9ca8a3c375 Bug 107718 pt 2 - use subtraction instead of the ~ operator, which older
mysql versions don't support. Remove the checksetup.pl restriction, too.

r=jake x2


git-svn-id: svn://10.0.0.236/trunk@108061 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-14 15:12:23 +00:00
bbaetz%cs.mcgill.ca
8904a09db5 Require (temporarily) mysql >= 3.23.5 for the ~ operator, needed for the
fix to bug 107718. This should be removed when the group stuff lands (bug
60822).

r=justdave x 2


git-svn-id: svn://10.0.0.236/trunk@107624 18797224-902f-48f8-a5cc-f745e15eee43
2001-11-07 22:42:32 +00:00
myk%mozilla.org
dc4c583cd4 Fix for bug 98602: re-implementation of "create attachment" page.
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org,jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@106739 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-30 23:42:22 +00:00
zach%zachlipton.com
87b667ee3b Fix for bug 96675: checksetup should require admin e-mail address satisfy emailregexp. This fix has
checksetup.pl use the emailregexp set in params if the params file exists, or ensures that it matches the
default emailregexp from defparams.pl.

r1=justdave, r2=bbaetz.


git-svn-id: svn://10.0.0.236/trunk@106499 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-28 03:40:59 +00:00
justdave%syndicomm.com
d27f46ad1e Fix for bug 104516: No code changes in this patch, all this checkin does is remove all tabs from the bugzilla source and replace it with the appropriate number of spaces (in most cases 8) to line up with existing code. This is part of the effort to bring the existing codebase up to par with our style guidelines.
Patch by Jake Steehagen <jake@acutex.net>
r= justdave x2


git-svn-id: svn://10.0.0.236/trunk@105335 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-13 01:36:17 +00:00
gerv%gerv.net
918cf95369 Add MacOS X. Bug 52577. Patch by afranke. r=gerv.
git-svn-id: svn://10.0.0.236/trunk@105207 18797224-902f-48f8-a5cc-f745e15eee43
2001-10-11 21:52:28 +00:00
zach%zachlipton.com
041ee9f94b Fix for bug 97588: localconfig should mention access.conf as well as
httpd.conf (for old apache). Simple 2line comment addition to localconfig
to inform the user they may need to look at access.conf in addition to
httpd.conf if they are using an older version of apache.

Patch by Gavin Shelley <gavins@iplbath.com> r=Zach Lipton
<zach@zachlipton.com> no 2nd review needed for this patch.


git-svn-id: svn://10.0.0.236/trunk@103586 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-23 17:07:55 +00:00
zach%zachlipton.com
158508051a Have checksetup.pl block web-access to runtests.sh (by .htaccess) and
chmod +x runtests.sh so that it can be run with ./

r=bbaetz on irc, no 2nd review needed. No bug filed.


git-svn-id: svn://10.0.0.236/trunk@103571 18797224-902f-48f8-a5cc-f745e15eee43
2001-09-23 04:28:17 +00:00
justdave%syndicomm.com
0a54592e93 Fix for bug 97721: Bugzilla now requires Perl 5.005 (previous requirement was Perl 5.004). This is due to the use of Template Toolkit for templatizing the pages for easier local customization. The new attachment tracker that was checked in earlier tonight uses the templates. Also included on this patch is a check for AppConfig, which is a prerequisite for Template Toolkit, because the Makefile.PL for Template Toolkit won't run without it, and it doesn't tell CPAN that it has prereqs, which causes confusion if you're installing from CPAN.
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org


git-svn-id: svn://10.0.0.236/trunk@102075 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-31 06:08:43 +00:00
justdave%syndicomm.com
4aaf91f5f6 Fix for bug 75840: syncshadowdb -syncall now properly shuts down Bugzilla during the sync process so mysql doesn't get overloaded while the tables are locked. This patch also adds some funtionality to the script to allow you to specify an alternate temp directory on the command line, in case you have a large database and need it made to a different filesystem for space reasons.
Patch by Dawn Endico <endico@mozilla.org> and Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@102074 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-31 05:49:01 +00:00
myk%mozilla.org
9f3ec3f125 Fix for bug 84338: initial implementation of attachment tracker, which lets users flag attachments with statuses.
Patch by Myk Melez <myk@mozilla.org>
r=justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@102065 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-31 03:54:37 +00:00
myk%mozilla.org
9d8541adf1 Fix for bug 95890: Correctly convert/record keyword changes in the bugs_activity table for keywords containing a plus sign or other
regular expression meta-characters.  Myk's first ever Bugzilla checkin!
Patch by Dave Miller <justdave@syndicomm.com> and Myk Melez <myk@mozilla.org>.
r=myk@mozilla.org,justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@101424 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-19 18:26:21 +00:00
justdave%syndicomm.com
929927863c Fix for bug 39816: Anyone in CC, Reporter, QA Contact, or Asigned To fields can now be given access to view a bug even if the permissions on that bug are set to a group that would normally exclude those people.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100906 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-13 00:46:20 +00:00
justdave%syndicomm.com
740ffa66b6 Fix for bug 94618: remove restrictions on valid characters in passwords. If crypt() takes it, why shouldn't we?
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100861 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-11 01:51:05 +00:00
justdave%syndicomm.com
19a161bd38 Re-fix for bug 55161 - if data is partial in activity table, prepend a ? to indicate that we don't know for sure what got dropped.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@100645 18797224-902f-48f8-a5cc-f745e15eee43
2001-08-09 06:12:18 +00:00
justdave%syndicomm.com
4e949a3f8c Fix for bug 90933: inconsistant field types for profiles.disabledtext
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99911 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-25 17:55:29 +00:00
justdave%syndicomm.com
5457c9aeca re-fix bug 76154: permissions weren't being set correctly on the .htaccess files when checksetup.pl was run again. Also adding .htaccess to .cvsignore so it won't show up as ? in cvs diffs and updates.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99905 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-25 07:26:42 +00:00
jake%acutex.net
6fac503401 Remove the code for rejecting the version of MySQL with broken encryption (as bugzilla no longer uses MySQL's encrypt routine). Also, point to mysql.com for downloading newer versions.
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99751 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-23 14:33:04 +00:00
justdave%syndicomm.com
0f8273ef0c Fix for bug 76154: Bugzilla can now optionally provide .htaccess files for Apache to help restrict viewing of private data
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99729 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-22 05:23:33 +00:00
jake%acutex.net
559c643f79 Fix for bugs 55161 and 12819. The activity log now stores only what's changed in multi-value fields.
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@99648 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-20 15:18:30 +00:00
jake%acutex.net
3366c0e0c1 Correcting the URL for MySQL's web page. Bug 90553.
Patch by Myk Melez <myk@mozilla.org>


git-svn-id: svn://10.0.0.236/trunk@99328 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-16 19:50:17 +00:00
justdave%syndicomm.com
a32206490b Fix for bug 77473, bug 74032, and bug 85472: Passwords are no longer stored in plaintext in the database. Passwords are no longer encrypted with MySQL's ENCRYPT() function (because it doesn't work on some installs), but with Perl's crypt() function. The crypt-related routines now properly deal with salts so that they work on systems that use methods other than UNIX crypt to crypt the passwords (such as MD5). Checksetup.pl will walk through your database and re-crypt everyone's passwords based on the plaintext password entry, then drop the plaintext password column. As a consequence of no longer having a plaintext password, it is no longer possible to email someone their password, so the login screen has been changed to request a password reset instead. The user is emailed a temporary identifying token, with a link back to Bugzilla. They click on the link or paste it into their browser and Bugzilla allows them to change their password.
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com, jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@99057 18797224-902f-48f8-a5cc-f745e15eee43
2001-07-11 05:29:21 +00:00
justdave%syndicomm.com
3f68a6abd2 Fix for bug 76183 and bug 71555: consolidates chmod activity in one place in checksetup.pl and also provides permission setting for bugzilla installations installed in a personal user directory as opposed to the server's main web space. (makes the files world-readable so the webserver can see them, since you can't set the group)
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@98242 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-29 03:47:56 +00:00
justdave%syndicomm.com
199142da3c Re-fix for bug 28458: AddFDef always replaces the fielddefs every time you run checksetup.pl, so the change to them during doeditparams was nullified if you updated. Other recent changes have nullified the reason for changing it in editparams anyway, so just backing that part out.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@97681 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-21 15:03:11 +00:00
jake%acutex.net
72d5e88b97 Fix for bug 86447 - ChangeFieldType() wasn't dealing with 'not null' properly.
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@97526 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-20 01:37:19 +00:00
jake%acutex.net
3d6379f41c Running a query using the Added Comment option was very slow (bug 57350).
Patch by Myk Melez <myk@mozilla.org> and Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net


git-svn-id: svn://10.0.0.236/trunk@97396 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-19 02:05:08 +00:00
tara%tequilarista.org
176266cd1f applying handy patch to refix version table to be 64 instead of 16--partial fix of bug 9352
git-svn-id: svn://10.0.0.236/trunk@97283 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-16 23:01:12 +00:00
justdave%syndicomm.com
0d88c2a487 Fix for bug 21253: removing all single-parameter system() calls from Bugzilla
Patch by Dave Miller <justdave@syndicomm.com>
r= tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96556 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 21:17:42 +00:00
justdave%syndicomm.com
ca7f7346ea Fix for bug 83872: Bugzilla no longer requires the Mysql Perl module, but the DBD::mysql Perl module, and has been this way for a while. Fixing the version checks in checksetup.pl to check the correct module. Also eliminates a DBD::mysql-specific database function call that is depricated in the current version of DBD_mysql.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net, tara@tequilarista.org


git-svn-id: svn://10.0.0.236/trunk@96555 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 21:10:47 +00:00
justdave%syndicomm.com
ebc34ab007 Fix for bug 28458: "NEW" bugs were not getting CC or QA Contact information displayed.
Patch by Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96491 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 04:28:52 +00:00
justdave%syndicomm.com
8928aa2555 Fix for bug 75482: adding the capability to deactivate a group without deleting it (prevent new bugs from being placed into that group, but don't remove the group restriction from bugs already in it).
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com


git-svn-id: svn://10.0.0.236/trunk@96488 18797224-902f-48f8-a5cc-f745e15eee43
2001-06-06 03:16:52 +00:00